lalph 0.3.26 → 0.3.28

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lalph",
   "type": "module",
-  "version": "0.3.26",
+  "version": "0.3.28",
   "publishConfig": {
     "access": "public"
   },
@@ -22,17 +22,17 @@
   "devDependencies": {
     "@changesets/changelog-github": "^0.5.2",
     "@changesets/cli": "^2.29.8",
-    "@effect/language-service": "^0.73.1",
-    "@effect/platform-node": "https://pkg.pr.new/Effect-TS/effect-smol/@effect/platform-node@0a6d33c",
+    "@effect/language-service": "^0.75.1",
+    "@effect/platform-node": "4.0.0-beta.6",
     "@linear/sdk": "^75.0.0",
     "@octokit/plugin-rest-endpoint-methods": "^17.0.0",
     "@octokit/types": "^16.0.0",
     "concurrently": "^9.2.1",
-    "effect": "https://pkg.pr.new/Effect-TS/effect-smol/effect@0a6d33c",
+    "effect": "4.0.0-beta.6",
     "husky": "^9.1.7",
     "lint-staged": "^16.2.7",
     "octokit": "^5.0.5",
-    "oxlint": "^1.47.0",
+    "oxlint": "^1.49.0",
     "prettier": "^3.8.1",
     "tsdown": "^0.20.3",
     "typescript": "^5.9.3",

package/src/Github/Cli.ts

@@ -45,7 +45,7 @@ export class GithubCli extends ServiceMap.Service<GithubCli>()(
           Effect.map((data) => {
             const comments =
               data.data.repository.pullRequest.comments.nodes.filter(
-                (c) => !c.author.login.startsWith("github"),
+                (c) => !c.isBot,
               )
             const reviews =
               data.data.repository.pullRequest.reviews.nodes.filter(

package/src/Github/TokenManager.ts

@@ -5,6 +5,7 @@ import {
   Option,
   Schedule,
   Schema,
+  Semaphore,
   ServiceMap,
 } from "effect"
 import {
@@ -64,7 +65,7 @@ export class TokenManager extends ServiceMap.Service<TokenManager>()(
         }
         return currentToken.value
       })
-      const get = Effect.makeSemaphoreUnsafe(1).withPermit(getNoLock)
+      const get = Semaphore.makeUnsafe(1).withPermit(getNoLock)
 
       const deviceCode = Effect.gen(function* () {
         const code = yield* HttpClientRequest.post(

package/src/Linear/TokenManager.ts

@@ -2,10 +2,12 @@ import {
   DateTime,
   Deferred,
   Effect,
+  Encoding,
   Layer,
   Option,
   Schedule,
   Schema,
+  Semaphore,
   ServiceMap,
 } from "effect"
 import {
@@ -18,7 +20,6 @@ import {
   HttpServerRequest,
   HttpServerResponse,
 } from "effect/unstable/http"
-import { Base64Url } from "effect/encoding"
 import { NodeHttpServer } from "@effect/platform-node"
 import { createServer } from "node:http"
 import { KeyValueStore } from "effect/unstable/persistence"
@@ -80,7 +81,7 @@ export class TokenManager extends ServiceMap.Service<TokenManager>()(
           return currentToken.value
         }),
       )
-      const get = Effect.makeSemaphoreUnsafe(1).withPermit(getNoLock)
+      const get = Semaphore.makeUnsafe(1).withPermit(getNoLock)
 
       const pkce = Effect.gen(function* () {
         const deferred = yield* Deferred.make<typeof CallbackParams.Type>()
@@ -116,7 +117,9 @@ export class TokenManager extends ServiceMap.Service<TokenManager>()(
         const verifierSha256 = yield* Effect.promise(() =>
           crypto.subtle.digest("SHA-256", new TextEncoder().encode(verifier)),
         )
-        const challenge = Base64Url.encode(new Uint8Array(verifierSha256))
+        const challenge = Encoding.encodeBase64Url(
+          new Uint8Array(verifierSha256),
+        )
 
         const url = `https://linear.app/oauth/authorize?client_id=${clientId}&redirect_uri=${encodeURIComponent(redirectUri)}&response_type=code&scope=read,write&code_challenge=${challenge}&code_challenge_method=S256`
 

package/src/Prd.ts

@@ -7,6 +7,7 @@ import {
   Path,
   PlatformError,
   Schedule,
+  Semaphore,
   ServiceMap,
   Stream,
 } from "effect"
@@ -65,7 +66,7 @@ export class Prd extends ServiceMap.Service<
       { suspendOnWaiting: true },
     )
 
-    const syncSemaphore = Effect.makeSemaphoreUnsafe(1)
+    const syncSemaphore = Semaphore.makeUnsafe(1)
 
     const maybeRevertIssue = Effect.fnUntraced(function* (options: {
       readonly issueId: string

package/src/Tracing.ts

@@ -41,21 +41,16 @@ const TracerLogger = Effect.gen(function* () {
   }
 
   return Tracer.make({
-    span(name, parent, annotations, links, startTime, kind, options) {
-      const span = tracer.span(
-        name,
-        parent,
-        annotations,
-        links,
-        startTime,
-        kind,
-        options,
-      )
-      log(`${name}: started`, startTime)
+    span(options) {
+      const span = tracer.span(options)
+      log(`${options.name}: started`, options.startTime)
       const oldEnd = span.end
       span.end = (endTime, cause) => {
         const duration = Duration.nanos(endTime - span.status.startTime)
-        log(`${name}: completed. Took ${Duration.format(duration)}`, endTime)
+        log(
+          `${options.name}: completed. Took ${Duration.format(duration)}`,
+          endTime,
+        )
         return oldEnd.call(span, endTime, cause)
       }
       return span

package/src/Workers.ts

@@ -103,6 +103,7 @@ export const withWorkerState =
           unmountState()
           unmountOutput()
           registry.update(activeWorkersAtom, HashMap.remove(workerId))
+          return Effect.void
         }),
         Effect.provideService(CurrentWorkerState, { state, output }),
       )

package/src/commands/root.ts

@@ -8,6 +8,7 @@ import {
   Iterable,
   Option,
   Path,
+  Semaphore,
   Stream,
 } from "effect"
 import { PromptGen } from "../PromptGen.ts"
@@ -248,7 +249,7 @@ const runProject = Effect.fnUntraced(
   }) {
     const isFinite = Number.isFinite(options.iterations)
     const iterationsDisplay = isFinite ? options.iterations : "unlimited"
-    const semaphore = Effect.makeSemaphoreUnsafe(options.project.concurrency)
+    const semaphore = Semaphore.makeUnsafe(options.project.concurrency)
     const fibers = yield* FiberSet.make()
 
     yield* resetInProgress.pipe(Effect.withSpan("Main.resetInProgress"))

package/src/domain/GithubComment.ts

@@ -4,12 +4,29 @@ export class Author extends S.Class<Author>("Author")({
   login: S.String,
 }) {}
 
+// Prefixes of bot users that we want to ignore when determining if a comment is
+// from a bot or not. This is not an exhaustive list, but covers some common
+// cases.
+const commonBotUserPrefixes = [
+  "dependabot",
+  "github",
+  "changeset",
+  "renovate",
+  "snyk",
+  "coderabbit",
+]
+
 export class Comment extends S.Class<Comment>("Comment")({
   id: S.String,
   body: S.String,
   author: Author,
   createdAt: S.String,
-}) {}
+}) {
+  get isBot() {
+    const login = this.author.login.toLowerCase()
+    return commonBotUserPrefixes.some((prefix) => login.startsWith(prefix))
+  }
+}
 
 export class PullRequestComments extends S.Class<PullRequestComments>(
   "PullRequestComments",

package/src/shared/stream.ts

@@ -1,12 +1,10 @@
-import { Effect, Filter, flow, Schema, Stream } from "effect"
+import { Effect, flow, Schema, Stream } from "effect"
 
 export const streamFilterJson = <S extends Schema.Top>(schema: S) => {
   const fromString = Schema.fromJsonString(schema)
   const decode = Schema.decodeEffect(fromString)
   return flow(
     Stream.splitLines,
-    Stream.filterMapEffect((line) =>
-      decode(line).pipe(Effect.catch(() => Effect.succeed(Filter.failVoid))),
-    ),
+    Stream.filterEffect((line) => decode(line).pipe(Effect.result)),
   )
 }