lalph 0.3.2 → 0.3.4

package/dist/cli.mjs

@@ -151201,7 +151201,9 @@ If you need to add a research task, mention in the description that it needs to:
 - add a specification file in the \`${options.specsDirectory}\` directory with
   an implementation plan based on the research findings.
 - once the specification file is added, turn the implementation plan into tasks
-  in the prd.yml file.
+  in the prd.yml file. Each task should reference the specification file in its
+  description, and be small, atomic and independently shippable without failing
+  validation checks (typechecks, linting, tests).
 - make sure the follow up tasks include a dependency on the research task.` : ""}
 
 ### Removing tasks
@@ -151363,7 +151365,10 @@ ${options.plan}
 3. Start two subagents with a copy of this prompt.
    - The first subagent will review the plan and provide feedback or improvements.
    - The second subagent will look over the implementation plan, and ensure each task is
-     small, atomic and independently shippable without failing validation checks (typechecks, linting, tests).
+     small, atomic and independently shippable. It also **NEEDS TO** make sure task
+     can be completed without failing validation checks (typechecks, linting, tests).
+     If a task will only pass validations when combined with another, the subagent should
+     combine the work into one task.
 4. Write the specification details to a \`.lalph/plan.json\` file using the following format:
    \`\`\`json
    {
@@ -151591,7 +151596,7 @@ const addOrUpdateProject = fnUntraced(function* (existing) {
 			title: "Commit",
 			description: "Tasks are committed directly to the target branch",
 			value: "commit",
-			selected: existing ? existing.gitFlow === "pr" : false
+			selected: existing ? existing.gitFlow === "commit" : false
 		}]
 	});
 	const reviewAgent = yield* toggle({
@@ -151924,7 +151929,8 @@ var Prd = class extends Service$1()("lalph/Prd", { make: gen(function* () {
 	static layerProvided = this.layer.pipe(provide$3([
 		layer,
 		layer$17,
-		CurrentIssueSource.layer
+		CurrentIssueSource.layer,
+		Settings.layer
 	]));
 	static layerLocal = this.layerNoWorktree.pipe(provideMerge(Worktree.layerLocal));
 	static layerLocalProvided = this.layerLocal.pipe(provide$3([
@@ -152347,8 +152353,7 @@ const commandPlanTasks = make$35("tasks", { specificationPath }).pipe(withDescri
 	Settings.layer,
 	PromptGen.layer,
 	Prd.layerProvided.pipe(provide$3(layerProjectIdPrompt)),
-	CurrentIssueSource.layer,
-	Settings.layer
+	CurrentIssueSource.layer
 ]))));
 
 //#endregion
@@ -152396,19 +152401,17 @@ const commandPlan = make$35("plan", {
 }).pipe(withDescription("Iterate on an issue plan and create PRD tasks"), withHandler(fnUntraced(function* ({ dangerous, withNewProject }) {
 	const thePlan = yield* (yield* Editor).editTemp({ suffix: ".md" });
 	if (isNone(thePlan)) return;
-	const project = withNewProject ? yield* addOrUpdateProject() : yield* selectProject;
-	const { specsDirectory } = yield* commandRoot;
-	yield* plan({
-		plan: thePlan.value,
-		specsDirectory,
-		targetBranch: project.targetBranch,
-		dangerous
-	}).pipe(provideService(CurrentProjectId, project.id));
-}, provide$1([
-	Settings.layer,
-	CurrentIssueSource.layer,
-	Editor.layer
-]))), withSubcommands([commandPlanTasks]));
+	yield* gen(function* () {
+		const project = withNewProject ? yield* addOrUpdateProject() : yield* selectProject;
+		const { specsDirectory } = yield* commandRoot;
+		yield* plan({
+			plan: thePlan.value,
+			specsDirectory,
+			targetBranch: project.targetBranch,
+			dangerous
+		}).pipe(provideService(CurrentProjectId, project.id));
+	}).pipe(provide$1([Settings.layer, CurrentIssueSource.layer]));
+}, provide$1(Editor.layer))), withSubcommands([commandPlanTasks]));
 const plan = fnUntraced(function* (options) {
 	const fs = yield* FileSystem;
 	const pathService = yield* Path$1;
@@ -152510,7 +152513,7 @@ const commandSource = make$35("source").pipe(withDescription("Select the issue s
 
 //#endregion
 //#region package.json
-var version = "0.3.2";
+var version = "0.3.4";
 
 //#endregion
 //#region src/commands/projects/ls.ts

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lalph",
   "type": "module",
-  "version": "0.3.2",
+  "version": "0.3.4",
   "publishConfig": {
     "access": "public"
   },
@@ -27,6 +27,7 @@
     "@linear/sdk": "^72.0.0",
     "@octokit/plugin-rest-endpoint-methods": "^17.0.0",
     "@octokit/types": "^16.0.0",
+    "concurrently": "^9.2.1",
     "effect": "https://pkg.pr.new/Effect-TS/effect-smol/effect@39ecde9",
     "husky": "^9.1.7",
     "lint-staged": "^16.2.7",
@@ -47,7 +48,7 @@
     ]
   },
   "scripts": {
-    "check": "tsc --noEmit && oxlint -c .oxlintrc.json",
+    "check": "concurrently \"tsc --noEmit\" \"oxlint -c .oxlintrc.json\" \"pnpm build\"",
     "build": "tsdown"
   }
 }

package/src/Prd.ts

@@ -15,7 +15,7 @@ import { PrdIssue } from "./domain/PrdIssue.ts"
 import { IssueSource, IssueSourceError } from "./IssueSource.ts"
 import { AtomRegistry, Reactivity } from "effect/unstable/reactivity"
 import { CurrentIssueSource, currentIssuesAtom } from "./CurrentIssueSource.ts"
-import { CurrentProjectId } from "./Settings.ts"
+import { CurrentProjectId, Settings } from "./Settings.ts"
 
 export class Prd extends ServiceMap.Service<
   Prd,
@@ -282,6 +282,7 @@ export class Prd extends ServiceMap.Service<
       AtomRegistry.layer,
       Reactivity.layer,
       CurrentIssueSource.layer,
+      Settings.layer,
     ]),
   )
   static layerLocal = this.layerNoWorktree.pipe(

package/src/Projects.ts

@@ -188,7 +188,7 @@ export const addOrUpdateProject = Effect.fnUntraced(function* (
         title: "Commit",
         description: "Tasks are committed directly to the target branch",
         value: "commit",
-        selected: existing ? existing.gitFlow === "pr" : false,
+        selected: existing ? existing.gitFlow === "commit" : false,
       },
     ] as const,
   })

package/src/PromptGen.ts

@@ -55,7 +55,9 @@ If you need to add a research task, mention in the description that it needs to:
 - add a specification file in the \`${options.specsDirectory}\` directory with
   an implementation plan based on the research findings.
 - once the specification file is added, turn the implementation plan into tasks
-  in the prd.yml file.
+  in the prd.yml file. Each task should reference the specification file in its
+  description, and be small, atomic and independently shippable without failing
+  validation checks (typechecks, linting, tests).
 - make sure the follow up tasks include a dependency on the research task.`
           : ""
       }
@@ -256,7 +258,10 @@ ${options.plan}
 3. Start two subagents with a copy of this prompt.
    - The first subagent will review the plan and provide feedback or improvements.
    - The second subagent will look over the implementation plan, and ensure each task is
-     small, atomic and independently shippable without failing validation checks (typechecks, linting, tests).
+     small, atomic and independently shippable. It also **NEEDS TO** make sure task
+     can be completed without failing validation checks (typechecks, linting, tests).
+     If a task will only pass validations when combined with another, the subagent should
+     combine the work into one task.
 4. Write the specification details to a \`.lalph/plan.json\` file using the following format:
    \`\`\`json
    {

package/src/commands/plan/tasks.ts

@@ -54,7 +54,6 @@ export const commandPlanTasks = Command.make("tasks", {
         PromptGen.layer,
         Prd.layerProvided.pipe(Layer.provide(layerProjectIdPrompt)),
         CurrentIssueSource.layer,
-        Settings.layer,
       ]),
     ),
   ),

package/src/commands/plan.ts

@@ -31,15 +31,17 @@ export const commandPlan = Command.make("plan", {
 }).pipe(
   Command.withDescription("Iterate on an issue plan and create PRD tasks"),
   Command.withHandler(
-    Effect.fnUntraced(
-      function* ({ dangerous, withNewProject }) {
-        const editor = yield* Editor
+    Effect.fnUntraced(function* ({ dangerous, withNewProject }) {
+      const editor = yield* Editor
 
-        const thePlan = yield* editor.editTemp({
-          suffix: ".md",
-        })
-        if (Option.isNone(thePlan)) return
+      const thePlan = yield* editor.editTemp({
+        suffix: ".md",
+      })
+      if (Option.isNone(thePlan)) return
 
+      // We nest this effect, so we can launch the editor first as fast as
+      // possible
+      yield* Effect.gen(function* () {
         const project = withNewProject
           ? yield* addOrUpdateProject()
           : yield* selectProject
@@ -51,9 +53,8 @@ export const commandPlan = Command.make("plan", {
           targetBranch: project.targetBranch,
           dangerous,
         }).pipe(Effect.provideService(CurrentProjectId, project.id))
-      },
-      Effect.provide([Settings.layer, CurrentIssueSource.layer, Editor.layer]),
-    ),
+      }).pipe(Effect.provide([Settings.layer, CurrentIssueSource.layer]))
+    }, Effect.provide(Editor.layer)),
   ),
   Command.withSubcommands([commandPlanTasks]),
 )