lalph 0.1.44 → 0.1.45

package/dist/cli.mjs

@@ -133825,10 +133825,6 @@ const TokenResponse$1 = Struct({
 
 //#endregion
 //#region src/IssueSource.ts
-/**
-* Current unused, but eventually will represent a source of issues so we can
-* support more than just Linear
-*/
 var IssueSource = class extends Service()("lalph/IssueSource") {};
 var IssueSourceError = class extends ErrorClass("lalph/IssueSourceError")({
 	_tag: tag("IssueSourceError"),
@@ -140460,9 +140456,10 @@ The following instructions should be done without interaction or asking for perm
 ${prdNotes}`;
 	const prompt = (options) => `The following instructions should be done without interaction or asking for permission.
 
-1. Your job is to complete the task with id \`${options.taskId}\` from the prd.yml file.
+1. Study the ${options.specsDirectory}/README.md file (if available).
+   Then your job is to complete the task with id \`${options.taskId}\` from the prd.yml file.
    Read the entire prd.yml file to understand the context of the task and any
-   key learnings from previous work. Study the .specs/README.md file.
+   key learnings from previous work.
 2. Check if there is an existing Github PR for the task, otherwise create a new
    branch for the task.${options.targetBranch ? ` The target branch for the PR should be \`${options.targetBranch}\`. If the target branch does not exist, create it first.` : ""}
    - If there is an existing PR, checkout the branch for that PR.
@@ -140474,6 +140471,10 @@ ${prdNotes}`;
    - When checking for PR reviews, make sure to check the "reviews" field and read ALL unresolved comments.
      Also read the normal comments to see if there are any additional requests.
 3. Implement the task.
+   - **If at any point** you discover something that needs fixing, or another task
+     that needs doing, immediately add it to the prd.yml file as a new task.
+   - Add important discoveries about the codebase, or challenges faced to the task's
+     \`description\`. More details below.
 4. Run any checks / feedback loops, such as type checks, unit tests, or linting.
 5. Create or update the pull request with your progress.
    ${sourceMeta.githubPrInstructions}
@@ -140511,9 +140512,6 @@ If for any reason you get stuck on a task, mark the task back as "todo" by updat
 \`state\` and leaving some notes in the task's \`description\` field about the
 challenges faced.
 
-If it feels like you are brute forcing your way through a task, STOP and move the
-task back to "todo" state with notes on why in the description.
-
 ${prdNotes}`;
 	const promptTimeout = (options) => `Your earlier attempt to complete the task with id \`${options.taskId}\` took too
 long and has timed out. You can find the task details in the prd.yml file.
@@ -140522,19 +140520,20 @@ The following instructions should be done without interaction or asking for
 permission.
 
 1. Investigate why you think the task took too long. Research the codebase
-   further if needed.
-2. Break down the task into smaller tasks and add them to the prd.yml file.
-3. Mark the original task as "done" by updating its \`state\` in the prd.yml file.
-4. Each new task should have an id of \`null\`, a title, and a concise description that
+   further to understand what is needed to complete the task.
+2. Mark the original task as "done" by updating its \`state\` in the prd.yml file.
+3. Break down the task into smaller tasks and add them to the prd.yml file.
+   Each new task should have an id of \`null\`, a title, and a concise description that
    includes a short summary of the task and a brief list of steps to complete it.
    - Include where to find the plan specification in the description (if applicable).
    - The tasks should start in the "todo" state.
    - Each task should be an atomic, committable piece of work.
      Instead of creating tasks like "Refactor the authentication system", create
      smaller tasks like "Implement OAuth2 login endpoint", "Add JWT token refresh mechanism", etc.
-5. Setup task dependencies using the \`blockedBy\` field as needed. You will need
+4. Setup task dependencies using the \`blockedBy\` field as needed. You will need
    to wait 5 seconds after adding tasks to the prd.yml file to allow the system
    to assign ids to the new tasks before you can setup dependencies.
+5. If any specifications need updating based on your new understanding, update them.
 
 ${prdNotes}`;
 	const planPrompt = (options) => `1. Ask the user for the idea / request, then your job is to create a detailed
@@ -140792,7 +140791,8 @@ const run = fnUntraced(function* (options) {
 		const exitCode$1 = yield* execWithStallTimeout(cliAgent.command({
 			prompt: promptGen.prompt({
 				taskId: task.id,
-				targetBranch: getOrUndefined(options.targetBranch)
+				targetBranch: getOrUndefined(options.targetBranch),
+				specsDirectory: options.specsDirectory
 			}),
 			prdFilePath: pathService.join(".lalph", "prd.yml")
 		})).pipe(timeout(options.runTimeout), catchTag("TimeoutError", fnUntraced(function* (error$1) {
@@ -140945,8 +140945,9 @@ const root = make$25("lalph", {
 	targetBranch,
 	maxIterationMinutes,
 	stallMinutes,
-	reset
-}).pipe(withHandler(fnUntraced(function* ({ iterations: iterations$1, concurrency: concurrency$1, autoMerge: autoMerge$1, targetBranch: targetBranch$1, maxIterationMinutes: maxIterationMinutes$1, stallMinutes: stallMinutes$1, reset: reset$2 }) {
+	reset,
+	specsDirectory
+}).pipe(withHandler(fnUntraced(function* ({ iterations: iterations$1, concurrency: concurrency$1, autoMerge: autoMerge$1, targetBranch: targetBranch$1, maxIterationMinutes: maxIterationMinutes$1, stallMinutes: stallMinutes$1, reset: reset$2, specsDirectory: specsDirectory$1 }) {
 	if (reset$2) yield* resetCurrentIssueSource;
 	const source = yield* build(CurrentIssueSource.layer);
 	yield* getOrSelectCliAgent;
@@ -140967,6 +140968,7 @@ const root = make$25("lalph", {
 			startedDeferred,
 			autoMerge: autoMerge$1,
 			targetBranch: targetBranch$1,
+			specsDirectory: specsDirectory$1,
 			stallTimeout: minutes(stallMinutes$1),
 			runTimeout: minutes(maxIterationMinutes$1)
 		})), catchFilter((e) => e._tag === "NoMoreWork" || e._tag === "QuitError" ? fail$8(e) : e, (e) => logWarning(fail$5(e))), catchTags({
@@ -140989,10 +140991,10 @@ const root = make$25("lalph", {
 }, scoped$1)));
 const selectAgent = make$25("agent").pipe(withDescription("Select the CLI agent to use"), withHandler(() => selectCliAgent));
 const selectSource = make$25("source").pipe(withDescription("Select the issue source to use"), withHandler(() => selectIssueSource));
-const planMode = make$25("plan", { specsDirectory }).pipe(withDescription("Iterate on an issue plan and create PRD tasks"), withHandler(fnUntraced(function* (options) {
-	const { reset: reset$2 } = yield* root;
+const planMode = make$25("plan").pipe(withDescription("Iterate on an issue plan and create PRD tasks"), withHandler(fnUntraced(function* () {
+	const { reset: reset$2, specsDirectory: specsDirectory$1 } = yield* root;
 	if (reset$2) yield* resetCurrentIssueSource;
-	yield* plan(options).pipe(provide$1(CurrentIssueSource.layer));
+	yield* plan({ specsDirectory: specsDirectory$1 }).pipe(provide$1(CurrentIssueSource.layer));
 })));
 root.pipe(withSubcommands([
 	planMode,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lalph",
   "type": "module",
-  "version": "0.1.44",
+  "version": "0.1.45",
   "publishConfig": {
     "access": "public"
   },

package/src/IssueSource.ts

@@ -1,10 +1,6 @@
 import { Effect, Schema, ServiceMap } from "effect"
 import type { PrdIssue } from "./domain/PrdIssue.ts"
 
-/**
- * Current unused, but eventually will represent a source of issues so we can
- * support more than just Linear
- */
 export class IssueSource extends ServiceMap.Service<
   IssueSource,
   {

package/src/PromptGen.ts

@@ -73,11 +73,13 @@ ${prdNotes}`
       const prompt = (options: {
         readonly taskId: string
         readonly targetBranch: string | undefined
+        readonly specsDirectory: string
       }) => `The following instructions should be done without interaction or asking for permission.
 
-1. Your job is to complete the task with id \`${options.taskId}\` from the prd.yml file.
+1. Study the ${options.specsDirectory}/README.md file (if available).
+   Then your job is to complete the task with id \`${options.taskId}\` from the prd.yml file.
    Read the entire prd.yml file to understand the context of the task and any
-   key learnings from previous work. Study the .specs/README.md file.
+   key learnings from previous work.
 2. Check if there is an existing Github PR for the task, otherwise create a new
    branch for the task.${options.targetBranch ? ` The target branch for the PR should be \`${options.targetBranch}\`. If the target branch does not exist, create it first.` : ""}
    - If there is an existing PR, checkout the branch for that PR.
@@ -89,6 +91,10 @@ ${prdNotes}`
    - When checking for PR reviews, make sure to check the "reviews" field and read ALL unresolved comments.
      Also read the normal comments to see if there are any additional requests.
 3. Implement the task.
+   - **If at any point** you discover something that needs fixing, or another task
+     that needs doing, immediately add it to the prd.yml file as a new task.
+   - Add important discoveries about the codebase, or challenges faced to the task's
+     \`description\`. More details below.
 4. Run any checks / feedback loops, such as type checks, unit tests, or linting.
 5. Create or update the pull request with your progress.
    ${sourceMeta.githubPrInstructions}
@@ -126,9 +132,6 @@ If for any reason you get stuck on a task, mark the task back as "todo" by updat
 \`state\` and leaving some notes in the task's \`description\` field about the
 challenges faced.
 
-If it feels like you are brute forcing your way through a task, STOP and move the
-task back to "todo" state with notes on why in the description.
-
 ${prdNotes}`
 
       const promptTimeout = (options: {
@@ -140,19 +143,20 @@ The following instructions should be done without interaction or asking for
 permission.
 
 1. Investigate why you think the task took too long. Research the codebase
-   further if needed.
-2. Break down the task into smaller tasks and add them to the prd.yml file.
-3. Mark the original task as "done" by updating its \`state\` in the prd.yml file.
-4. Each new task should have an id of \`null\`, a title, and a concise description that
+   further to understand what is needed to complete the task.
+2. Mark the original task as "done" by updating its \`state\` in the prd.yml file.
+3. Break down the task into smaller tasks and add them to the prd.yml file.
+   Each new task should have an id of \`null\`, a title, and a concise description that
    includes a short summary of the task and a brief list of steps to complete it.
    - Include where to find the plan specification in the description (if applicable).
    - The tasks should start in the "todo" state.
    - Each task should be an atomic, committable piece of work.
      Instead of creating tasks like "Refactor the authentication system", create
      smaller tasks like "Implement OAuth2 login endpoint", "Add JWT token refresh mechanism", etc.
-5. Setup task dependencies using the \`blockedBy\` field as needed. You will need
+4. Setup task dependencies using the \`blockedBy\` field as needed. You will need
    to wait 5 seconds after adding tasks to the prd.yml file to allow the system
    to assign ids to the new tasks before you can setup dependencies.
+5. If any specifications need updating based on your new understanding, update them.
 
 ${prdNotes}`
 

package/src/Runner.ts

@@ -21,6 +21,7 @@ export const run = Effect.fnUntraced(
     readonly startedDeferred: Deferred.Deferred<void>
     readonly autoMerge: boolean
     readonly targetBranch: Option.Option<string>
+    readonly specsDirectory: string
     readonly stallTimeout: Duration.Duration
     readonly runTimeout: Duration.Duration
   }) {
@@ -140,6 +141,7 @@ export const run = Effect.fnUntraced(
         prompt: promptGen.prompt({
           taskId: task.id,
           targetBranch: Option.getOrUndefined(options.targetBranch),
+          specsDirectory: options.specsDirectory,
         }),
         prdFilePath: pathService.join(".lalph", "prd.yml"),
       })

package/src/cli.ts

@@ -80,6 +80,7 @@ const root = Command.make("lalph", {
   maxIterationMinutes,
   stallMinutes,
   reset,
+  specsDirectory,
 }).pipe(
   Command.withHandler(
     Effect.fnUntraced(function* ({
@@ -90,6 +91,7 @@ const root = Command.make("lalph", {
       maxIterationMinutes,
       stallMinutes,
       reset,
+      specsDirectory,
     }) {
       if (reset) {
         yield* resetCurrentIssueSource
@@ -126,6 +128,7 @@ const root = Command.make("lalph", {
               startedDeferred,
               autoMerge,
               targetBranch,
+              specsDirectory,
               stallTimeout: Duration.minutes(stallMinutes),
               runTimeout: Duration.minutes(maxIterationMinutes),
             }),
@@ -185,15 +188,17 @@ const selectSource = Command.make("source").pipe(
   Command.withHandler(() => selectIssueSource),
 )
 
-const planMode = Command.make("plan", { specsDirectory }).pipe(
+const planMode = Command.make("plan").pipe(
   Command.withDescription("Iterate on an issue plan and create PRD tasks"),
   Command.withHandler(
-    Effect.fnUntraced(function* (options) {
-      const { reset } = yield* root
+    Effect.fnUntraced(function* () {
+      const { reset, specsDirectory } = yield* root
       if (reset) {
         yield* resetCurrentIssueSource
       }
-      yield* plan(options).pipe(Effect.provide(CurrentIssueSource.layer))
+      yield* plan({ specsDirectory }).pipe(
+        Effect.provide(CurrentIssueSource.layer),
+      )
     }),
   ),
 )