lace-mcp 0.0.2-alpha.29 → 0.0.2-alpha.30

package/dist/cli.js

@@ -633,10 +633,10 @@ var init_uninstall = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpReviewLoader.ts
+// ../../libs/shared/src/mcp/mcpReviewLoader.ts
 var ReviewLoaderError;
 var init_mcpReviewLoader = __esm({
-  "../../libs/shared/src/mcpReviewLoader.ts"() {
+  "../../libs/shared/src/mcp/mcpReviewLoader.ts"() {
     "use strict";
     ReviewLoaderError = class extends Error {
       contentText;
@@ -655,13 +655,13 @@ var init_mcpReviewLoader = __esm({
   }
 });
 
-// ../../libs/shared/src/errorMessages.ts
+// ../../libs/shared/src/errors/errorMessages.ts
 function lookupErrorMessage(code) {
   return code ? ERROR_MESSAGES[code] : void 0;
 }
 var ERROR_MESSAGES;
 var init_errorMessages = __esm({
-  "../../libs/shared/src/errorMessages.ts"() {
+  "../../libs/shared/src/errors/errorMessages.ts"() {
     "use strict";
     ERROR_MESSAGES = {
       // --- Auth / Session ---
@@ -16127,10 +16127,10 @@ var init_mcpAttachments = __esm({
   }
 });
 
-// ../../libs/shared/src/reviewCommentRunBinding.ts
+// ../../libs/shared/src/review/reviewCommentRunBinding.ts
 var reviewCommentRunBindingSchema;
 var init_reviewCommentRunBinding = __esm({
-  "../../libs/shared/src/reviewCommentRunBinding.ts"() {
+  "../../libs/shared/src/review/reviewCommentRunBinding.ts"() {
     "use strict";
     init_zod();
     reviewCommentRunBindingSchema = external_exports.object({
@@ -16953,7 +16953,7 @@ var init_reviewLoaderImages = __esm({
   }
 });
 
-// ../../libs/shared/src/resolvePublishMode.ts
+// ../../libs/shared/src/publishing/resolvePublishMode.ts
 function requireTitle(title, message) {
   if (!title) throw new ReviewLoaderError(message);
   return title;
@@ -17000,7 +17000,7 @@ function resolvePublishMode(input) {
   };
 }
 var init_resolvePublishMode = __esm({
-  "../../libs/shared/src/resolvePublishMode.ts"() {
+  "../../libs/shared/src/publishing/resolvePublishMode.ts"() {
     "use strict";
     init_mcpReviewLoader();
   }
@@ -17365,19 +17365,23 @@ async function fetchReviewElementComments(reviewId, config4, pageId) {
 }
 async function fetchDecisionThreadContext(decision) {
   const config4 = readMcpCredentials();
-  if (!config4) return null;
+  if (!config4) return [];
   const reviewId = decision.review_id;
-  if (!reviewId) return null;
+  if (!reviewId) return [];
   try {
     const res = await fetch(`${config4.apiBase}/lace/reviews/${encodeURIComponent(reviewId)}/thread-context`, {
       headers: jsonAuthHeaders(config4),
       signal: AbortSignal.timeout(API_FETCH_TIMEOUT_MS)
     });
-    if (!res.ok) return null;
+    if (!res.ok) return [];
     const payload = await res.json();
-    return payload.context ?? null;
+    return (payload.messages ?? []).map((message) => ({
+      role: message.role,
+      visibleText: message.visibleText,
+      createdAt: message.createdAt
+    }));
   } catch {
-    return null;
+    return [];
   }
 }
 async function fetchDiscussionThreads(config4, reviewId) {
@@ -17438,8 +17442,7 @@ function createHttpReviewLoader() {
       const detail = await loadReviewCommentDetailFromHttp(decisionId, requireConfig());
       const decision = detail?.decision;
       if (!decision) return [];
-      const context2 = await fetchDecisionThreadContext(decision);
-      return context2 ? [{ text: context2 }] : [];
+      return fetchDecisionThreadContext(decision);
     },
     async resolveDiscussionAccess(reviewId) {
       try {
@@ -34574,7 +34577,7 @@ var init_mcp = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpToolHelpers.ts
+// ../../libs/shared/src/mcp/mcpToolHelpers.ts
 function errorMessage(error54) {
   if (error54 instanceof Error) return error54.message;
   if (typeof error54 === "object" && error54 !== null && "message" in error54 && typeof error54.message === "string") {
@@ -34602,14 +34605,47 @@ function loaderErrorResponse(error54, fallback) {
 function loaderScope(scope) {
   return { orgId: scope.orgId, userId: scope.userId };
 }
+function extractErrorCode(result) {
+  if (!result.isError || !result.structuredContent?.error) return void 0;
+  const error54 = result.structuredContent.error;
+  if (typeof error54 === "string") return error54;
+  if (typeof error54 === "object" && error54 !== null && "code" in error54) return String(error54.code);
+  return void 0;
+}
+function toolCompletedProps(result, toolName, duration_ms) {
+  const error_code = extractErrorCode(result);
+  return {
+    tool: toolName,
+    outcome: result.isError ? "error" : "success",
+    duration_ms,
+    ...error_code === void 0 ? {} : { error_code }
+  };
+}
+function withToolMetrics(toolName, handler, opts) {
+  return async (params) => {
+    opts.onToolInvoked?.(toolName);
+    const start = performance.now();
+    try {
+      const result = await handler(params);
+      opts.onToolCompleted?.(toolCompletedProps(result, toolName, Math.round(performance.now() - start)));
+      return result;
+    } catch (error54) {
+      const duration_ms = Math.round(performance.now() - start);
+      opts.onToolError?.(error54, { toolName });
+      const errorResult = loaderErrorResponse(error54, `Failed to execute ${toolName}. Please try again.`);
+      opts.onToolCompleted?.(toolCompletedProps(errorResult, toolName, duration_ms));
+      return errorResult;
+    }
+  };
+}
 var init_mcpToolHelpers = __esm({
-  "../../libs/shared/src/mcpToolHelpers.ts"() {
+  "../../libs/shared/src/mcp/mcpToolHelpers.ts"() {
     "use strict";
     init_mcpReviewLoader();
   }
 });
 
-// ../../libs/shared/src/mcpPromptRegistration.ts
+// ../../libs/shared/src/mcp/mcpPromptRegistration.ts
 function registerPublishPrototypePrompt(server2) {
   server2.registerPrompt(
     "publish-prototype",
@@ -34715,7 +34751,7 @@ function registerMcpPrompts({ server: server2, loader, getScope }) {
   registerCheckFeedbackPrompt(server2, loader, getScope);
 }
 var init_mcpPromptRegistration = __esm({
-  "../../libs/shared/src/mcpPromptRegistration.ts"() {
+  "../../libs/shared/src/mcp/mcpPromptRegistration.ts"() {
     "use strict";
     init_completable();
     init_zod();
@@ -34723,7 +34759,7 @@ var init_mcpPromptRegistration = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpResourceRegistration.ts
+// ../../libs/shared/src/mcp/mcpResourceRegistration.ts
 function registerMcpResources({ server: server2, loader, getScope }) {
   server2.registerResource(
     "review",
@@ -34773,17 +34809,17 @@ function registerMcpResources({ server: server2, loader, getScope }) {
   );
 }
 var init_mcpResourceRegistration = __esm({
-  "../../libs/shared/src/mcpResourceRegistration.ts"() {
+  "../../libs/shared/src/mcp/mcpResourceRegistration.ts"() {
     "use strict";
     init_mcp();
     init_mcpToolHelpers();
   }
 });
 
-// ../../libs/shared/src/artifactPublishLimits.ts
+// ../../libs/shared/src/publishing/artifactPublishLimits.ts
 var MIB, MAX_INLINE_FILE_BYTES, MAX_INLINE_TOTAL_BYTES, MAX_ASSET_COUNT, MAX_ASSET_FILE_BYTES, MAX_ASSET_TOTAL_BYTES, MAX_ARCHIVE_BYTES, MAX_SOURCE_ARCHIVE_BYTES, MAX_ARCHIVE_FILE_BYTES, MAX_ARCHIVE_UNCOMPRESSED_BYTES, SHA256_HEX_RE;
 var init_artifactPublishLimits = __esm({
-  "../../libs/shared/src/artifactPublishLimits.ts"() {
+  "../../libs/shared/src/publishing/artifactPublishLimits.ts"() {
     "use strict";
     MIB = 1024 * 1024;
     MAX_INLINE_FILE_BYTES = 25 * MIB;
@@ -34799,7 +34835,7 @@ var init_artifactPublishLimits = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpToolPublishReview.ts
+// ../../libs/shared/src/mcp/mcpToolPublishReview.ts
 function isPreparedResult(result) {
   return "phase" in result && result.phase === "awaiting_upload";
 }
@@ -34963,7 +34999,8 @@ function registerPublishReviewTool({
   loader,
   getScope,
   onToolInvoked,
-  onToolError
+  onToolError,
+  onToolCompleted
 }) {
   if (!loader.publishReview) return;
   const publishReview = loader.publishReview;
@@ -34976,15 +35013,18 @@ function registerPublishReviewTool({
       outputSchema: publishReviewOutputSchema,
       annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false }
     },
-    async (params) => {
-      onToolInvoked?.("publish_review");
-      return handlePublishReviewTool({ params, publishReview, getScope, onToolError });
-    }
+    withToolMetrics(
+      "publish_review",
+      async (params) => {
+        return handlePublishReviewTool({ params, publishReview, getScope, onToolError });
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
 var publishReviewOutputSchema, PUBLISH_REVIEW_DESCRIPTION, publishReviewInputSchema;
 var init_mcpToolPublishReview = __esm({
-  "../../libs/shared/src/mcpToolPublishReview.ts"() {
+  "../../libs/shared/src/mcp/mcpToolPublishReview.ts"() {
     "use strict";
     init_zod();
     init_artifactPublishLimits();
@@ -35043,7 +35083,7 @@ var init_mcpToolPublishReview = __esm({
   }
 });
 
-// ../../libs/shared/src/reviewToolHandlers.ts
+// ../../libs/shared/src/mcp/reviewToolHandlers.ts
 function toSummary(view) {
   const summary = {};
   for (const key of SUMMARY_KEYS) summary[key] = view[key];
@@ -35101,6 +35141,7 @@ function decisionBbox(decision) {
 function decisionNotFoundResult(id) {
   return {
     content: [{ type: "text", text: `Decision "${id}" not found. Use search_comments to find valid IDs.` }],
+    structuredContent: { error: "not_found", id },
     isError: true
   };
 }
@@ -35208,6 +35249,7 @@ async function handleSearchDiscussion(loader, params, scope, onError) {
     if (!canAccess) {
       return {
         content: [{ type: "text", text: "Access denied - discussion sharing is not enabled for this review." }],
+        structuredContent: { error: "sharing_disabled", reviewId: params.reviewId },
         isError: true
       };
     }
@@ -35215,17 +35257,26 @@ async function handleSearchDiscussion(loader, params, scope, onError) {
     if (!threadId2) {
       const links = await loader.loadThreadLinks(params.reviewId, scope);
       if (links.length === 0) {
-        return { content: [{ type: "text", text: "No discussion threads linked to this review." }] };
+        return {
+          content: [{ type: "text", text: "No discussion threads linked to this review." }],
+          structuredContent: { error: "no_threads", reviewId: params.reviewId }
+        };
       }
       threadId2 = links[0].thread_id;
     }
     const messages = await loader.loadThreadMessages(threadId2, scope);
     if (messages.length === 0) {
-      return { content: [{ type: "text", text: "No messages in this discussion thread." }] };
+      return {
+        content: [{ type: "text", text: "No messages in this discussion thread." }],
+        structuredContent: { error: "no_messages", reviewId: params.reviewId, threadId: threadId2 }
+      };
     }
     const filtered = params.query ? filterDiscussionMessages(messages, params.query) : messages;
     if (!filtered) {
-      return { content: [{ type: "text", text: "No messages matching the query in this discussion thread." }] };
+      return {
+        content: [{ type: "text", text: "No messages matching the query in this discussion thread." }],
+        structuredContent: { error: "no_matches", reviewId: params.reviewId, threadId: threadId2, query: params.query }
+      };
     }
     return { content: [{ type: "text", text: formatDiscussionThread(threadId2, filtered) }] };
   } catch (e) {
@@ -35265,11 +35316,11 @@ async function handleApplyComment(loader, id, include, scope) {
 }
 var searchCommentsSchema, SUMMARY_KEYS;
 var init_reviewToolHandlers = __esm({
-  "../../libs/shared/src/reviewToolHandlers.ts"() {
+  "../../libs/shared/src/mcp/reviewToolHandlers.ts"() {
     "use strict";
     init_zod();
-    init_mcpToolHelpers();
     init_review();
+    init_mcpToolHelpers();
     searchCommentsSchema = {
       query: external_exports.string().optional().describe("Text search across headline, body, and element text"),
       status: external_exports.enum(["resolved", "suggested", "all"]).default("resolved").optional().describe("Filter by comment status (default: resolved)"),
@@ -35328,13 +35379,14 @@ var init_reviewToolHandlers = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpToolRegistration.ts
+// ../../libs/shared/src/mcp/mcpToolRegistration.ts
 function registerSearchCommentsTool({
   server: server2,
   loader,
   getScope,
   onToolInvoked,
-  onToolError
+  onToolError,
+  onToolCompleted
 }) {
   server2.registerTool(
     "search_comments",
@@ -35344,23 +35396,28 @@ function registerSearchCommentsTool({
       annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
       inputSchema: searchCommentsSchema
     },
-    async (params) => {
-      onToolInvoked?.("search_comments");
-      try {
+    withToolMetrics(
+      "search_comments",
+      async (params) => {
         return await handleSearchComments(
           loader,
           params,
           loaderScope(getScope()),
           (e) => onToolError?.(e, { toolName: "search_comments" })
         );
-      } catch (e) {
-        onToolError?.(e, { toolName: "search_comments" });
-        return loaderErrorResponse(e, "Failed to search comments. Please try again.");
-      }
-    }
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
-function registerApplyDecisionTool({ server: server2, loader, getScope, onToolInvoked, onToolError }) {
+function registerApplyDecisionTool({
+  server: server2,
+  loader,
+  getScope,
+  onToolInvoked,
+  onToolError,
+  onToolCompleted
+}) {
   server2.registerTool(
     "apply_comment",
     {
@@ -35374,18 +35431,23 @@ function registerApplyDecisionTool({ server: server2, loader, getScope, onToolIn
       },
       annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false }
     },
-    async ({ id, include = "instructions" }) => {
-      onToolInvoked?.("apply_comment");
-      try {
+    withToolMetrics(
+      "apply_comment",
+      async ({ id, include = "instructions" }) => {
         return await handleApplyComment(loader, id, include, loaderScope(getScope()));
-      } catch (e) {
-        onToolError?.(e, { toolName: "apply_comment" });
-        return loaderErrorResponse(e, "Failed to apply decision. Please try again.");
-      }
-    }
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
-function registerListReviewsTool({ server: server2, loader, getScope, onToolInvoked, onToolError }) {
+function registerListReviewsTool({
+  server: server2,
+  loader,
+  getScope,
+  onToolInvoked,
+  onToolError,
+  onToolCompleted
+}) {
   server2.registerTool(
     "list_reviews",
     {
@@ -35400,9 +35462,9 @@ function registerListReviewsTool({ server: server2, loader, getScope, onToolInvo
       },
       annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false }
     },
-    async (params) => {
-      onToolInvoked?.("list_reviews");
-      try {
+    withToolMetrics(
+      "list_reviews",
+      async (params) => {
         const result = await loader.listReviews(params, loaderScope(getScope()));
         const text = result.nextCursor ? `Showing ${result.reviews.length} reviews. Pass cursor "${result.nextCursor}" to see more.` : `Showing ${result.reviews.length} reviews.`;
         return {
@@ -35411,14 +35473,19 @@ function registerListReviewsTool({ server: server2, loader, getScope, onToolInvo
             { type: "text", text: JSON.stringify(result) }
           ]
         };
-      } catch (e) {
-        onToolError?.(e, { toolName: "list_reviews" });
-        return loaderErrorResponse(e, "Failed to list reviews. Please try again.");
-      }
-    }
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
-function registerListProjectsTool({ server: server2, loader, getScope, onToolInvoked, onToolError }) {
+function registerListProjectsTool({
+  server: server2,
+  loader,
+  getScope,
+  onToolInvoked,
+  onToolError,
+  onToolCompleted
+}) {
   server2.registerTool(
     "list_projects",
     {
@@ -35430,9 +35497,9 @@ function registerListProjectsTool({ server: server2, loader, getScope, onToolInv
       },
       annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false }
     },
-    async (params) => {
-      onToolInvoked?.("list_projects");
-      try {
+    withToolMetrics(
+      "list_projects",
+      async (params) => {
         const result = await loader.listProjects(params, loaderScope(getScope()));
         const text = result.nextCursor ? `Showing ${result.projects.length} projects. Pass cursor "${result.nextCursor}" to see more.` : `Showing ${result.projects.length} projects.`;
         return {
@@ -35441,11 +35508,9 @@ function registerListProjectsTool({ server: server2, loader, getScope, onToolInv
             { type: "text", text: JSON.stringify(result) }
           ]
         };
-      } catch (e) {
-        onToolError?.(e, { toolName: "list_projects" });
-        return loaderErrorResponse(e, "Failed to list projects. Please try again.");
-      }
-    }
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
 function registerSearchDiscussionTool({
@@ -35453,7 +35518,8 @@ function registerSearchDiscussionTool({
   loader,
   getScope,
   onToolInvoked,
-  onToolError
+  onToolError,
+  onToolCompleted
 }) {
   server2.registerTool(
     "search_discussion",
@@ -35467,20 +35533,18 @@ function registerSearchDiscussionTool({
       },
       annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false }
     },
-    async (params) => {
-      onToolInvoked?.("search_discussion");
-      try {
+    withToolMetrics(
+      "search_discussion",
+      async (params) => {
         return await handleSearchDiscussion(
           loader,
           params,
           loaderScope(getScope()),
           (e) => onToolError?.(e, { toolName: "search_discussion" })
         );
-      } catch (e) {
-        onToolError?.(e, { toolName: "search_discussion" });
-        return loaderErrorResponse(e, "Failed to search discussion. Please try again.");
-      }
-    }
+      },
+      { onToolInvoked, onToolError, onToolCompleted }
+    )
   );
 }
 function registerMcpTools(opts) {
@@ -35492,7 +35556,7 @@ function registerMcpTools(opts) {
   registerSearchDiscussionTool(opts);
 }
 var init_mcpToolRegistration = __esm({
-  "../../libs/shared/src/mcpToolRegistration.ts"() {
+  "../../libs/shared/src/mcp/mcpToolRegistration.ts"() {
     "use strict";
     init_zod();
     init_mcpToolHelpers();
@@ -35501,14 +35565,14 @@ var init_mcpToolRegistration = __esm({
   }
 });
 
-// ../../libs/shared/src/mcpSurface.ts
+// ../../libs/shared/src/mcp/mcpSurface.ts
 function registerMcpSurface(opts) {
   registerMcpTools(opts);
   registerMcpResources(opts);
   registerMcpPrompts(opts);
 }
 var init_mcpSurface = __esm({
-  "../../libs/shared/src/mcpSurface.ts"() {
+  "../../libs/shared/src/mcp/mcpSurface.ts"() {
     "use strict";
     init_mcpPromptRegistration();
     init_mcpResourceRegistration();
@@ -35516,7 +35580,7 @@ var init_mcpSurface = __esm({
   }
 });
 
-// ../../libs/shared/src/observability.ts
+// ../../libs/shared/src/platform/observability.ts
 function normalizeKey(key) {
   return key.replace(/[^a-zA-Z0-9]/g, "").toLowerCase();
 }
@@ -35643,7 +35707,7 @@ function sanitizeObservabilitySentryEvent(event) {
 }
 var OBSERVABILITY_REDACTED, OBSERVABILITY_MAX_ARRAY_ITEMS, DEFAULT_MAX_DEPTH, DATA_URL_PATTERN, LONG_STRING_LIMIT, SECRET_KEYS, CONTENT_KEYS, CONTENT_SUFFIXES, SAFE_METADATA_KEYS, UNSANITIZED;
 var init_observability = __esm({
-  "../../libs/shared/src/observability.ts"() {
+  "../../libs/shared/src/platform/observability.ts"() {
     "use strict";
     OBSERVABILITY_REDACTED = "[redacted]";
     OBSERVABILITY_MAX_ARRAY_ITEMS = 20;
@@ -35753,6 +35817,18 @@ function trackToolInvoked(tool) {
     properties
   });
 }
+function trackToolCompleted(props) {
+  const properties = sanitizeObservabilityProperties({
+    app: "mcp",
+    ...props,
+    identified: distinctId !== null
+  });
+  queue.push({
+    event: MCP_COMPLETED_EVENT,
+    distinct_id: distinctId ?? ANONYMOUS_DISTINCT_ID,
+    properties
+  });
+}
 async function flushAnalytics() {
   if (!POSTHOG_API_KEY || queue.length === 0) return;
   const batch = queue.splice(0);
@@ -35766,7 +35842,7 @@ async function flushAnalytics() {
   } catch {
   }
 }
-var POSTHOG_API_KEY, POSTHOG_HOST, FLUSH_TIMEOUT_MS, ANONYMOUS_DISTINCT_ID, queue, distinctId, MCP_EVENT;
+var POSTHOG_API_KEY, POSTHOG_HOST, FLUSH_TIMEOUT_MS, ANONYMOUS_DISTINCT_ID, queue, distinctId, MCP_EVENT, MCP_COMPLETED_EVENT;
 var init_analytics = __esm({
   "src/analytics.ts"() {
     "use strict";
@@ -35778,6 +35854,7 @@ var init_analytics = __esm({
     queue = [];
     distinctId = null;
     MCP_EVENT = "mcp_tool_invoked";
+    MCP_COMPLETED_EVENT = "mcp_tool_completed";
   }
 });
 
@@ -81808,7 +81885,8 @@ function createLaceServer() {
     loader,
     getScope: getLocalScope,
     onToolInvoked: trackToolInvoked,
-    onToolError: handleToolError
+    onToolError: handleToolError,
+    onToolCompleted: trackToolCompleted
   });
   return server2;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lace-mcp",
-  "version": "0.0.2-alpha.29",
+  "version": "0.0.2-alpha.30",
   "type": "module",
   "files": [
     "dist/cli.js",