kuzzle 2.20.0 → 2.20.1

package/lib/api/controllers/documentController.js

@@ -232,17 +232,15 @@ class DocumentController extends NativeController {
 
   async export(request) {
     const { index, collection } = request.getIndexAndCollection();
-    const { size, scrollTTL, searchBody } = request.getSearchParams();
-    const format = request.getString("format", "jsonl");
-    const fields = request.getBodyArray("fields", []);
+    const { size, scrollTTL } = request.getSearchParams();
     const lang = request.getLangParam();
+    const format = request.getString("format", "jsonl");
     const separator = request.getString("separator", ",");
-    const fieldsName = request.getBodyObject("fieldsName", {});
+    const query = request.getObjectFromBodyOrArgs("query", {});
+    const fields = request.getArrayFromBodyOrArgs("fields", []);
+    const fieldsName = request.getObjectFromBodyOrArgs("fieldsName", {});
 
-    // Remove "fields" and "fieldsName" from searchBody to avoid ES throwing an error
-    // since those properties are not allowed in the searchBody
-    searchBody.fields = undefined;
-    searchBody.fieldsName = undefined;
+    const searchBody = { query };
 
     if (request.context.connection.protocol !== "http") {
       throw kerror.get(

package/lib/api/funnel.js

@@ -50,6 +50,7 @@ const kerror = require("../kerror");
 const debug = require("../util/debug")("kuzzle:funnel");
 const processError = kerror.wrap("api", "process");
 const { has } = require("../util/safeObject");
+const { HttpStream } = require("../types");
 
 // Actions of the auth controller that does not necessite to verify the token
 // when cookie auth is active
@@ -662,7 +663,9 @@ class Funnel {
       ) {
         // check if the plugin response can be serialized
         try {
-          JSON.stringify(responseData);
+          if (!(responseData instanceof HttpStream)) {
+            JSON.stringify(responseData);
+          }
         } catch (e) {
           _request.setResult(null);
           throw kerror.get("plugin", "controller", "unserializable_response");

package/lib/api/request/kuzzleRequest.d.ts

@@ -373,6 +373,8 @@ export declare class KuzzleRequest {
      * Returns the search body query according to the http method
      */
     getSearchBody(): JSONObject;
+    getObjectFromBodyOrArgs(name: string, def?: JSONObject): JSONObject;
+    getArrayFromBodyOrArgs(name: string, def?: any): JSONObject;
     /**
      * Returns the search params.
      */

package/lib/api/request/kuzzleRequest.js

@@ -726,6 +726,38 @@ class KuzzleRequest {
         }
         return this.getObject("searchBody", {});
     }
+    getObjectFromBodyOrArgs(name, def) {
+        if (this.context.connection.protocol !== "http" ||
+            this.context.connection.misc.verb !== "GET") {
+            return this.getBodyObject(name, def);
+        }
+        const rawObject = this.getString(name, JSON.stringify(def));
+        try {
+            return JSON.parse(rawObject);
+        }
+        catch (error) {
+            if (error instanceof SyntaxError) {
+                throw assertionError.get("invalid_type", name, "JSON string");
+            }
+            throw error;
+        }
+    }
+    getArrayFromBodyOrArgs(name, def) {
+        if (this.context.connection.protocol !== "http" ||
+            this.context.connection.misc.verb !== "GET") {
+            return this.getBodyArray(name, def);
+        }
+        const rawObject = this.getString(name, JSON.stringify(def));
+        try {
+            return JSON.parse(rawObject);
+        }
+        catch (error) {
+            if (error instanceof SyntaxError) {
+                throw assertionError.get("invalid_type", name, "JSON string");
+            }
+            throw error;
+        }
+    }
     /**
      * Returns the search params.
      */

package/lib/core/network/protocols/httpwsProtocol.js

@@ -83,14 +83,11 @@ const HTTP_ALLOWED_CONTENT_TYPES = [
 ];
 const HTTP_SKIPPED_HEADERS = ["content-length", "set-cookie"];
 const HTTP_HEADER_CONNECTION = Buffer.from("Connection");
-const HTTP_HEADER_CONTENT_LENGTH = Buffer.from("Content-Length");
 const HTTP_HEADER_ACCESS_CONTROL_ALLOW_ORIGIN = Buffer.from(
   "Access-Control-Allow-Origin"
 );
 const HTTP_HEADER_SET_COOKIE = Buffer.from("Set-Cookie");
 const HTTP_HEADER_VARY = Buffer.from("Vary");
-const HTTP_HEADER_TRANSFER_ENCODING = Buffer.from("Transfer-Encoding");
-const CHUNKED = Buffer.from("chunked");
 const WILDCARD = Buffer.from("*");
 const ORIGIN = Buffer.from("Origin");
 const X_KUZZLE_REQUEST_ID = Buffer.from("X-Kuzzle-Request-Id");
@@ -782,15 +779,6 @@ class HttpWsProtocol extends Protocol {
     // Send Headers in one go
     response.cork(() => {
       this.httpWriteRequestHeaders(request, response, message);
-
-      if (streamSizeFixed) {
-        response.writeHeader(
-          HTTP_HEADER_CONTENT_LENGTH,
-          Buffer.from(httpStream.totalBytes.toString())
-        );
-      } else {
-        response.writeHeader(HTTP_HEADER_TRANSFER_ENCODING, CHUNKED);
-      }
     });
 
     httpStream.stream.on("data", (chunk) => {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "kuzzle",
   "author": "The Kuzzle Team <support@kuzzle.io>",
-  "version": "2.20.0",
+  "version": "2.20.1",
   "description": "Kuzzle is an open-source solution that handles all the data management through a secured API, with a large choice of protocols.",
   "bin": "bin/start-kuzzle-server",
   "scripts": {
@@ -16,15 +16,17 @@
     "dev": "npx ergol docker/scripts/start-kuzzle-dev.ts -c ./config/ergol.config.json",
     "dev:test": "npm run dev -- docker/scripts/start-kuzzle-dev.ts --enable-plugins functional-test-plugin",
     "test": "npm run clean && npm run --silent test:lint && npm run build && npm run test:unit:coverage && npm run test:functional",
+    "test:jest": "jest",
     "test:unit": "DEBUG= npx --node-arg=--trace-warnings mocha --exit",
     "test:unit:coverage": "DEBUG= nyc --reporter=text-summary --reporter=lcov mocha --exit",
-    "test:functional": "npm run test:functional:http && npm run test:functional:websocket",
+    "test:functional": "npm run test:functional:http && npm run test:functional:websocket && npm run test:jest",
     "test:functional:http": "KUZZLE_PROTOCOL=http npx cucumber-js --profile http",
     "test:functional:websocket": "KUZZLE_PROTOCOL=websocket npx cucumber-js --profile websocket",
     "test:functional:legacy": "npm run test:functional:legacy:http && npm run test:functional:legacy:websocket && npm run test:functional:legacy:mqtt",
     "test:functional:legacy:http": "npx cucumber-js --format progress-bar --profile http ./features-legacy",
     "test:functional:legacy:websocket": "npx cucumber-js --format progress-bar --profile websocket ./features-legacy",
     "test:functional:legacy:mqtt": "npx cucumber-js --format progress-bar --profile mqtt ./features-legacy",
+    "test:functional:jest": "npm run test:jest",
     "cucumber": "cucumber.js --fail-fast",
     "codecov": "codecov",
     "prettier": "npx prettier ./lib ./test ./bin ./features ./plugins/available/functional-test-plugin --write",
@@ -62,7 +64,7 @@
     "koncorde": "^4.0.3",
     "kuzzle-plugin-auth-passport-local": "^6.3.6",
     "kuzzle-plugin-logger": "^3.0.3",
-    "kuzzle-sdk": "^7.10.3",
+    "kuzzle-sdk": "^7.10.5",
     "kuzzle-vault": "^2.0.4",
     "lodash": "4.17.21",
     "long": "^5.2.1",
@@ -91,6 +93,8 @@
     "url": "git://github.com/kuzzleio/kuzzle.git"
   },
   "devDependencies": {
+    "@jest/globals": "^29.3.1",
+    "@types/jest": "^29.2.5",
     "@types/js-yaml": "^4.0.5",
     "@types/lodash": "^4.14.190",
     "async": "^3.2.4",
@@ -98,6 +102,7 @@
     "codecov": "^3.8.3",
     "cucumber": "^6.0.5",
     "ergol": "^1.0.2",
+    "jest": "^29.3.1",
     "mocha": "^10.1.0",
     "mock-require": "^3.0.3",
     "mqtt": "^4.3.7",
@@ -109,6 +114,7 @@
     "should-sinon": "0.0.6",
     "sinon": "^14.0.2",
     "strip-json-comments": "https://github.com/sindresorhus/strip-json-comments/archive/refs/tags/v3.1.1.tar.gz",
+    "ts-jest": "^29.0.5",
     "ts-node": "^10.9.1",
     "typescript": "^4.9.3",
     "yaml": "^2.1.3"