kushi-agents 5.5.0 → 5.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kushi-agents",
-  "version": "5.5.0",
+  "version": "5.5.1",
   "description": "Install Kushi — multi-source project evidence agent with Comprehensive Structured Capture (CSC) into weekly-only files across Email, Teams, OneNote, Loop, SharePoint, Meetings, CRM, ADO. Meetings retain a sibling verbatim/ audit folder. WorkIQ-only for M365 sources (Graph / m365_* FORBIDDEN as fallbacks; user-paste is first-class). Host-agnostic.",
   "type": "module",
   "bin": {
@@ -57,4 +57,5 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
+

package/plugin/instructions/llm-vs-runner.instructions.md

@@ -65,3 +65,26 @@ Probes D44–D47 will assert:
 - D45: no SKILL.md contains forbidden phrasings (HTTP verbs, manual path templates, week-math snippets).
 - D46: every runner has integration tests under `plugin/runners/test/integration/`.
 - D47: every runner emits a stdout JSON line on the happy path under fixture mode.
+
+## Legacy probe carve-out (v5.5.1)
+
+The following pre-v5.5.0 probes assumed SKILL.md inlined doctrine cites, validation loops, and orchestrator checklists. In v5.5.0+ those concerns live in the runner + its tests, so the probes **skip thin-pointer skills** (the same nine listed in `D44` `$v550Map`):
+
+| Probe | What it used to require | Where it lives now |
+|-------|------------------------|--------------------|
+| C12 | `evidence-thoroughness` cite in pull-* SKILL.md | runner: thoroughness retry loop |
+| D2  | `snapshot-vs-stream.instructions.md` cite in pull-* SKILL.md | runner JSDoc + integration tests |
+| D3  | "WorkIQ" in pull-* SKILL.md Tools section | runner's discovery code path |
+| D6  | `side-by-side-config` cite in bootstrap/refresh SKILL.md | runner: config-write helper |
+| D11 | `verbatim-by-default` + v3.7.6 contracts cite | runner: `lib/verbatim.mjs` + tests |
+| D12 | `m365-id-registry` tokens in SKILL.md | runner: `lib/id-registry.mjs` |
+| D17 | `fuzzy-disambiguation` cite in name→ID skills | runner: name→ID resolver |
+| D18 | `per-source-verification-gate` cite | runner: gate check before write |
+| D26 | `issue-recovery` cite | runner: error-classification helper |
+| D30.references-layout | `Load references/...` pointer when `references/` exists | runner loads its own packs |
+| D30.checklist-orchestrators | `- [ ]` items in orchestrator SKILL.md | `refresh.mjs` orchestrates |
+| D30.validation-loop | `## Validation loop` in writer SKILL.md | runner integration tests |
+| D34.retrofit-clean | skill-checker `--retrofit` non-additive gaps == 0 | n/a for thin-pointers |
+
+Non-thin-pointer skills (e.g. `pull-loop`, `pull-misc`, `aggregate-project`, `consolidate-evidence`) still get all of these checks.
+

package/plugin/skills/self-check/run.ps1

@@ -279,6 +279,13 @@ $agentFile       = Join-Path $pluginDir 'agents\kushi.agent.md'
 $readmeFile      = Join-Path $Root 'README.md'
 $wtlFile         = Join-Path $Root 'docs\reference\where-things-live.md'
 
+# v5.5.0 thin-pointer skills — see plugin/instructions/llm-vs-runner.instructions.md
+# "Legacy probe carve-out" table for which probes skip these and why.
+$thinPointerSkills = @(
+    'pull-crm','pull-ado','pull-email','pull-teams','pull-meetings',
+    'pull-onenote','pull-sharepoint','bootstrap-project','refresh-project'
+)
+
 if (-not (Test-Path $pluginDir)) {
     Write-Error "plugin/ not found at $pluginDir — run from kushi repo root or pass -Root."
     exit 2
@@ -513,7 +520,8 @@ foreach ($name in $fdeSkills) {
 }
 
 # === C12: pull-* skills must reference evidence-thoroughness (merged thoroughness-detector v4.4.9) ===
-foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' }) {
+# Skip thin-pointers — runner owns thoroughness retry in v5.5.0.
+foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' -and ($thinPointerSkills -notcontains $_.Name) }) {
     $f = Join-Path $d.FullName 'SKILL.md'
     $text = $mdText[$f]
     if (-not $text) { continue }
@@ -545,6 +553,11 @@ if (-not (Test-Path $detectorFile)) {
 
 # === Deep checks ===
 if ($Deep) {
+    # See module-level $thinPointerSkills (line ~282) and
+    # plugin/instructions/llm-vs-runner.instructions.md for the rationale on
+    # why pre-v5.5.0 probes skip thin-pointer SKILL.md files. Coverage for
+    # those skills lives in D44–D47 V550Runners probes lower in this file.
+
     # D1: templates referenced from skills exist
     $templatesDir = Join-Path $pluginDir 'templates'
     foreach ($d in $skillDirs) {
@@ -559,16 +572,16 @@ if ($Deep) {
             }
         }
     }
-    # D2: pull-* skills must reference snapshot-vs-stream
-    foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' }) {
+    # D2: pull-* skills must reference snapshot-vs-stream (skip thin-pointers; runner owns this contract in v5.5.0)
+    foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' -and ($thinPointerSkills -notcontains $_.Name) }) {
         $f = Join-Path $d.FullName 'SKILL.md'
         $text = $mdText[$f]
         if ($text -notmatch 'snapshot-vs-stream\.instructions\.md') {
             Add-Finding D2 'Snapshot/Stream' 'warning' "Skill $($d.Name) doesn't cite snapshot-vs-stream.instructions.md" "Add a reference (e.g. 'per snapshot-vs-stream.instructions.md') in the skill body." $f 0
         }
     }
-    # D3: pull-* must list WorkIQ in Tools section (order is the skill's choice; some skills correctly prefer REST/host first when WorkIQ summarizes — see pull-crm/email/onenote v3.7.x)
-    foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' }) {
+    # D3: pull-* must list WorkIQ in Tools section (skip thin-pointers; runner owns discovery + capture in v5.5.0)
+    foreach ($d in $skillDirs | Where-Object { $_.Name -like 'pull-*' -and ($thinPointerSkills -notcontains $_.Name) }) {
         $f = Join-Path $d.FullName 'SKILL.md'
         $text = $mdText[$f]
         if ($text -notmatch '(?ms)\bWorkIQ\b') {
@@ -642,7 +655,7 @@ if ($Deep) {
         }
     }
     # D6: side-by-side rule cited where user config is touched
-    $configTouchers = @('bootstrap-project','refresh-project')  # heuristic
+    $configTouchers = @('bootstrap-project','refresh-project') | Where-Object { $thinPointerSkills -notcontains $_ }  # v5.5.0: runner owns side-by-side config writes
     foreach ($name in $configTouchers) {
         $f = Join-Path $skillsDir "$name\SKILL.md"
         if (Test-Path $f) {
@@ -740,8 +753,8 @@ if ($Deep) {
         }
     }
 
-    # D11: pull-* skills SKILL.md cite verbatim-by-default contract in front blockquote
-    $pullSkillDirs = Get-ChildItem -Path (Join-Path $pluginDir 'skills') -Directory | Where-Object { $_.Name -like 'pull-*' -or $_.Name -in @('bootstrap-project','refresh-project') }
+    # D11: pull-* skills SKILL.md cite verbatim-by-default contract in front blockquote (skip thin-pointers; runner owns verbatim doctrine in v5.5.0)
+    $pullSkillDirs = Get-ChildItem -Path (Join-Path $pluginDir 'skills') -Directory | Where-Object { ($_.Name -like 'pull-*' -or $_.Name -in @('bootstrap-project','refresh-project')) -and ($thinPointerSkills -notcontains $_.Name) }
     foreach ($sd in $pullSkillDirs) {
         $sf = Join-Path $sd.FullName 'SKILL.md'
         if (Test-Path $sf) {
@@ -765,7 +778,7 @@ if ($Deep) {
         @{ name='refresh-project';   required=@('m365-id-registry','knownSections') },
         @{ name='pull-onenote';      required=@('m365-id-registry','one_pages', 'webPageId', 'auth-required', 'playwright-profile') },
         @{ name='pull-misc';         required=@('m365-id-registry','external-links', 'misc_links', 'placeholder', 'delegated') }
-    )
+    ) | Where-Object { $thinPointerSkills -notcontains $_.name }  # v5.5.0: runner owns these tokens
     foreach ($rc in $registryConsumers) {
         $sf = Join-Path $pluginDir "skills\$($rc.name)\SKILL.md"
         if (Test-Path $sf) {
@@ -966,7 +979,7 @@ if ($Deep) {
         $fuzzyCallers = @(
             'pull-onenote','pull-sharepoint','pull-teams','pull-crm','pull-ado','pull-email',
             'engagement-root-resolution.instructions.md','ask-project'
-        )
+        ) | Where-Object { $thinPointerSkills -notcontains $_ }  # v5.5.0: runner owns name→ID resolution
         foreach ($caller in $fuzzyCallers) {
             $candidate = if ($caller -like '*.instructions.md') {
                 Join-Path $instructionsDir $caller
@@ -988,6 +1001,7 @@ if ($Deep) {
         Add-Finding D18 'Verification gate' 'warning' "plugin/instructions/per-source-verification-gate.instructions.md is missing" "Restore the v4.4.7 verification-gate doctrine." $gateInst 0
     } else {
         $gateCallers = @('bootstrap-project','refresh-project','aggregate-project') + (Get-ChildItem $skillsDir -Directory | Where-Object { $_.Name -like 'pull-*' } | Select-Object -ExpandProperty Name)
+        $gateCallers = $gateCallers | Where-Object { $thinPointerSkills -notcontains $_ }  # v5.5.0: runner enforces the gate
         foreach ($caller in $gateCallers) {
             $sf = Join-Path (Join-Path $skillsDir $caller) 'SKILL.md'
             if (Test-Path $sf) {
@@ -1182,7 +1196,7 @@ if ($Deep) {
             'aggregate-project','consolidate-evidence',
             'bootstrap-project','refresh-project',
             'apply-ado-update','propose-ado-update'
-        )
+        ) | Where-Object { $thinPointerSkills -notcontains $_ }  # v5.5.0: runner cites issue-recovery
         foreach ($skillName in $recoveryRequired) {
             $skillFile = Join-Path $skillsDir "$skillName\SKILL.md"
             if (-not (Test-Path $skillFile)) { continue }
@@ -1664,9 +1678,9 @@ if ($Deep) {
             Add-Finding 'D30.skill-size' 'Spec compliance' 'warning' "$($d.Name)/SKILL.md is ~$skillTokens tokens (cap 5000)" "Split bulk content into plugin/skills/$($d.Name)/references/<topic>.md per agentskills-compliance.instructions.md." $skillFile 0
         }
 
-        # D30.references-layout — if references/ exists, SKILL.md must cite at least one "Load references/..." pointer.
+        # D30.references-layout — if references/ exists, SKILL.md must cite at least one "Load references/..." pointer. (skip thin-pointers; runner owns the reference packs)
         $refsDir = Join-Path $d.FullName 'references'
-        if (Test-Path $refsDir) {
+        if ((Test-Path $refsDir) -and ($thinPointerSkills -notcontains $d.Name)) {
             $hasRefMention = $skillText -match 'references/[A-Za-z0-9_\-]+\.md'
             if (-not $hasRefMention) {
                 Add-Finding 'D30.references-layout' 'Spec compliance' 'warning' "$($d.Name)/ has a references/ folder but SKILL.md never cites any references/<file>.md" "Add explicit load-on-trigger pointers, e.g. 'Load references/canonical-prompts.md when constructing the WorkIQ query.'" $skillFile 0
@@ -1680,15 +1694,15 @@ if ($Deep) {
             }
         }
 
-        # D30.checklist-orchestrators — orchestrators contain at least one `- [ ]` checklist item.
-        if ($orchestratorSkills -contains $d.Name) {
+        # D30.checklist-orchestrators — orchestrators contain at least one `- [ ]` checklist item. (skip thin-pointers; orchestration moved into refresh.mjs in v5.5.0)
+        if (($orchestratorSkills -contains $d.Name) -and ($thinPointerSkills -notcontains $d.Name)) {
             if ($skillText -notmatch '(?m)^\s*-\s+\[ \]') {
                 Add-Finding 'D30.checklist-orchestrators' 'Spec compliance' 'warning' "$($d.Name)/SKILL.md is an orchestrator but contains no '- [ ]' checklist items" "Convert the numbered/prose step list to GitHub checkbox syntax per agentskills-compliance.instructions.md rule 4." $skillFile 0
             }
         }
 
-        # D30.validation-loop — writer skills contain a `## Validation loop` heading.
-        if ($writerSkills -contains $d.Name) {
+        # D30.validation-loop — writer skills contain a `## Validation loop` heading. (skip thin-pointers; runner integration tests are the validation loop in v5.5.0)
+        if (($writerSkills -contains $d.Name) -and ($thinPointerSkills -notcontains $d.Name)) {
             if ($skillText -notmatch '(?m)^##\s+Validation loop\b') {
                 Add-Finding 'D30.validation-loop' 'Spec compliance' 'warning' "$($d.Name)/SKILL.md is a writer skill but is missing a '## Validation loop' section" "Append the standard validation loop (do → self-check -Targeted → fix → repeat → log success) per agentskills-compliance.instructions.md rule 5." $skillFile 0
             }
@@ -1962,6 +1976,8 @@ process.stdout.write(JSON.stringify(out));
             try { $allParsed = $allJson | ConvertFrom-Json } catch {}
             if ($allParsed -and $allParsed.skills) {
                 foreach ($s in $allParsed.skills) {
+                    # v5.5.0: thin-pointer skills are intentionally minimal; retrofit gaps don't apply.
+                    if ($thinPointerSkills -contains $s.name) { continue }
                     if ($s.non_additive_count -gt 0) {
                         Add-Finding 'D34.retrofit-clean' 'Creator conformance' 'warning' "Skill '$($s.name)' has $($s.non_additive_count) non-additive gap(s) that retrofit cannot auto-fix" "Inspect Evidence/_skill-checker/$($s.name)/fix-plan.json and document/fix manually. See docs/audits/v5.0.4-skill-creator-dogfood.md for known exceptions." (Join-Path $Root "plugin/skills/$($s.name)/SKILL.md") 0
                     }