kushi-agents 5.4.3 → 5.4.4

package/src/per-user-files.test.mjs

@@ -0,0 +1,137 @@
+// v5.4.4: per-user truth + auto-consolidated root view.
+// Tests cover (a) bootstrap-project SKILL.md target path, (b) self-check D42
+// probe (positive + negative), and (c) migrate-per-user-files migration
+// script (fresh migration, idempotent no-op, defensive needs-merge).
+
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { spawnSync } from 'node:child_process';
+import fs from 'node:fs';
+import path from 'node:path';
+import url from 'node:url';
+
+const here = path.dirname(url.fileURLToPath(import.meta.url));
+const repoRoot = path.resolve(here, '..');
+const migrate  = path.join(repoRoot, 'plugin', 'skills', 'migrate-per-user-files', 'migrate.ps1');
+const selfCheck = path.join(repoRoot, 'plugin', 'skills', 'self-check', 'run.ps1');
+
+function pwsh(args) {
+  return spawnSync('pwsh', ['-NoProfile', '-File', ...args], { encoding: 'utf8' });
+}
+
+function tmpProject(label) {
+  const root = path.join(repoRoot, '.testtmp', `per-user-files-${label}-${Date.now()}`);
+  fs.mkdirSync(root, { recursive: true });
+  fs.mkdirSync(path.join(root, '.kushi', 'config', 'user'), { recursive: true });
+  fs.writeFileSync(
+    path.join(root, '.kushi', 'config', 'user', 'project-evidence.yml'),
+    'alias: ushak\n'
+  );
+  return root;
+}
+
+test('bootstrap-project SKILL.md targets per-user bootstrap-status path', () => {
+  const skillMd = fs.readFileSync(
+    path.join(repoRoot, 'plugin', 'skills', 'bootstrap-project', 'SKILL.md'),
+    'utf8'
+  );
+  assert.ok(
+    /Evidence\/<alias>\/bootstrap-status\.md/.test(skillMd),
+    'bootstrap-project SKILL.md must reference Evidence/<alias>/bootstrap-status.md'
+  );
+  // No bare root mention of the three per-user files outside of the v5.4.4
+  // migration callout. We enforce by requiring 'Evidence/<alias>/' on every
+  // line that mentions bootstrap-status.md.
+  const lines = skillMd.split(/\r?\n/);
+  for (let i = 0; i < lines.length; i++) {
+    if (/bootstrap-status\.md/.test(lines[i])) {
+      const window = lines.slice(Math.max(0, i - 5), Math.min(lines.length, i + 6)).join('\n');
+      assert.ok(
+        /Evidence[\\/][^\s)`]+[\\/]|_Consolidated[\\/]/.test(window),
+        `bootstrap-project SKILL.md line ${i + 1} mentions bootstrap-status.md but is not per-user scoped within 5 lines`
+      );
+    }
+  }
+});
+
+test('self-check D42 probe catches a bare root mention in a synthetic skill', () => {
+  // Create a temporary skill that violates D42 and run self-check -Targeted D42 on it.
+  const stageRoot = path.join(repoRoot, '.testtmp', `d42-probe-${Date.now()}`);
+  // Mirror the minimum file shape self-check expects.
+  fs.mkdirSync(path.join(stageRoot, 'plugin', 'skills', 'sample-bad'), { recursive: true });
+  fs.mkdirSync(path.join(stageRoot, 'plugin', 'instructions'), { recursive: true });
+  fs.mkdirSync(path.join(stageRoot, 'plugin', 'prompts'), { recursive: true });
+  fs.mkdirSync(path.join(stageRoot, 'plugin', 'agents'), { recursive: true });
+  fs.writeFileSync(
+    path.join(stageRoot, 'plugin', 'skills', 'sample-bad', 'SKILL.md'),
+    `---\nname: "sample-bad"\nversion: "1.0.0"\ndescription: "USE WHEN testing."\n---\n\n# Sample bad\n\nThis skill writes FOLLOW-UPS.md at the project root.\n`
+  );
+  fs.writeFileSync(
+    path.join(stageRoot, 'plugin', 'agents', 'kushi.agent.md'),
+    `---\nname: "kushi"\nversion: "5.4.4"\n---\n`
+  );
+  try {
+    const r = pwsh([selfCheck, '-Root', stageRoot, '-Deep', '-Targeted', 'D42', '-Json']);
+    const findings = JSON.parse(r.stdout || '[]');
+    const d42 = findings.filter((f) => f.code && f.code.startsWith('D42'));
+    assert.ok(d42.length >= 1, `expected at least one D42 finding, got ${d42.length}`);
+    assert.match(d42[0].message, /FOLLOW-UPS\.md/);
+  } finally {
+    fs.rmSync(stageRoot, { recursive: true, force: true });
+  }
+});
+
+test('migrate-per-user-files: fresh migration moves all three root files', () => {
+  const root = tmpProject('fresh');
+  try {
+    fs.writeFileSync(path.join(root, 'bootstrap-status.md'), 'BS-1\n');
+    fs.writeFileSync(path.join(root, 'FOLLOW-UPS.md'), 'FU-1\n');
+    fs.writeFileSync(path.join(root, 'OPEN-QUESTIONS-DRAFT.md'), 'OQ-1\n');
+    const r = pwsh([migrate, '-ProjectRoot', root, '-Apply']);
+    assert.equal(r.status, 0, `migrate exited ${r.status}: ${r.stdout} :: ${r.stderr}`);
+    assert.ok(fs.existsSync(path.join(root, 'Evidence', 'ushak', 'bootstrap-status.md')));
+    assert.ok(fs.existsSync(path.join(root, 'Evidence', 'ushak', 'FOLLOW-UPS.md')));
+    assert.ok(fs.existsSync(path.join(root, 'Evidence', 'ushak', 'OPEN-QUESTIONS-DRAFT.md')));
+    assert.ok(!fs.existsSync(path.join(root, 'bootstrap-status.md')));
+    assert.ok(!fs.existsSync(path.join(root, 'FOLLOW-UPS.md')));
+    assert.ok(!fs.existsSync(path.join(root, 'OPEN-QUESTIONS-DRAFT.md')));
+    const runLog = fs.readFileSync(path.join(root, 'Evidence', 'run-log.yml'), 'utf8');
+    assert.match(runLog, /migrations:/);
+    assert.match(runLog, /alias: ushak/);
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test('migrate-per-user-files: re-running --apply on migrated repo is a no-op', () => {
+  const root = tmpProject('idem');
+  try {
+    fs.writeFileSync(path.join(root, 'bootstrap-status.md'), 'X\n');
+    fs.writeFileSync(path.join(root, 'FOLLOW-UPS.md'), 'Y\n');
+    fs.writeFileSync(path.join(root, 'OPEN-QUESTIONS-DRAFT.md'), 'Z\n');
+    const r1 = pwsh([migrate, '-ProjectRoot', root, '-Apply']);
+    assert.equal(r1.status, 0);
+    const r2 = pwsh([migrate, '-ProjectRoot', root, '-Apply']);
+    assert.equal(r2.status, 0);
+    assert.match(r2.stdout, /nothing-to-do/);
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test('migrate-per-user-files: refuses to overwrite when per-user copy differs', () => {
+  const root = tmpProject('merge');
+  try {
+    fs.mkdirSync(path.join(root, 'Evidence', 'ushak'), { recursive: true });
+    fs.writeFileSync(path.join(root, 'Evidence', 'ushak', 'bootstrap-status.md'), 'A\n');
+    fs.writeFileSync(path.join(root, 'bootstrap-status.md'), 'B\n');
+    const r = pwsh([migrate, '-ProjectRoot', root, '-Apply']);
+    assert.equal(r.status, 1, `expected exit 1 on needs-merge, got ${r.status}`);
+    assert.match(r.stdout, /needs-merge/);
+    // Per-user file must NOT have been overwritten.
+    assert.equal(fs.readFileSync(path.join(root, 'Evidence', 'ushak', 'bootstrap-status.md'), 'utf8'), 'A\n');
+    assert.equal(fs.readFileSync(path.join(root, 'bootstrap-status.md'), 'utf8'), 'B\n');
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});