kushi-agents 4.2.0 → 4.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kushi-agents",
-  "version": "4.2.0",
+  "version": "4.2.2",
   "description": "Install Kushi — multi-source project evidence agent with snapshot+stream capture across Email, Teams, OneNote, SharePoint, Meetings, CRM, ADO. WorkIQ-only for M365 sources (Graph / m365_* FORBIDDEN as fallbacks; user-paste is first-class). Host-agnostic.",
   "type": "module",
   "bin": {
@@ -42,6 +42,11 @@
     "url": "https://github.com/gim-home/kushi/issues"
   },
   "license": "MIT",
+  "scripts": {
+    "test": "node --test src/check-workiq.test.mjs",
+    "smoke": "node scripts/smoke.mjs",
+    "prepublishOnly": "npm test && npm run smoke"
+  },
   "publishConfig": {
     "access": "public"
   }

package/src/check-workiq.mjs

@@ -61,12 +61,32 @@ function findOnPath(name) {
   const args = isWin ? [name] : ['-v', name];
   const res = spawnSync(cmd, args, { encoding: 'utf-8', shell: !isWin });
   if (res.status !== 0) return null;
-  const first = (res.stdout || '').split(/\r?\n/).map((s) => s.trim()).find(Boolean);
-  return first || null;
+  const all = (res.stdout || '')
+    .split(/\r?\n/)
+    .map((s) => s.trim())
+    .filter(Boolean);
+  if (!isWin) return all[0] || null;
+  // Windows `where` may return multiple matches (e.g. npm shims produce both
+  // `workiq` (bash script, no extension) and `workiq.cmd`). Prefer
+  // executable extensions in priority order; fall back to the first match.
+  const priority = ['.cmd', '.exe', '.bat', '.ps1'];
+  for (const ext of priority) {
+    const hit = all.find((p) => p.toLowerCase().endsWith(ext));
+    if (hit) return hit;
+  }
+  return all[0] || null;
 }
 
 function runVersion(binPath) {
-  const res = spawnSync(binPath, ['--version'], { encoding: 'utf-8', timeout: 10_000 });
+  // Windows requires shell:true to spawn .cmd / .bat / shim files. The DEP0190
+  // warning is harmless here because we control both binPath (resolved via
+  // `where` / explicit --workiq-path) and args (literal ['--version']).
+  const isWin = process.platform === 'win32';
+  const res = spawnSync(binPath, ['--version'], {
+    encoding: 'utf-8',
+    timeout: 10_000,
+    shell: isWin,
+  });
   if (res.status !== 0) {
     return {
       ok: false,

package/src/check-workiq.test.mjs

@@ -0,0 +1,93 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { spawnSync } from 'node:child_process';
+import { fileURLToPath } from 'node:url';
+import path from 'node:path';
+import os from 'node:os';
+import fs from 'node:fs';
+
+import { checkWorkIQ } from './check-workiq.mjs';
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+const isWin = process.platform === 'win32';
+
+function makeTempBin(name, body) {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'kushi-test-'));
+  const full = path.join(dir, name);
+  fs.writeFileSync(full, body);
+  if (!isWin) fs.chmodSync(full, 0o755);
+  return { dir, full };
+}
+
+test('checkWorkIQ: --workiq-path pointing at non-existent file returns path-invalid', () => {
+  const r = checkWorkIQ({ workiqPath: '/definitely/does/not/exist/workiq' });
+  assert.equal(r.ok, false);
+  assert.equal(r.reason, 'path-invalid');
+  assert.match(r.hint, /does not point at an existing file/i);
+});
+
+test('checkWorkIQ: --workiq-path pointing at a runnable script returns ok with version', () => {
+  // Build a tiny fake that prints a version string and exits 0.
+  const name = isWin ? 'fake-workiq.cmd' : 'fake-workiq';
+  const body = isWin
+    ? '@echo off\r\necho 9.9.9-fake\r\nexit /b 0\r\n'
+    : '#!/usr/bin/env bash\necho 9.9.9-fake\nexit 0\n';
+  const { full, dir } = makeTempBin(name, body);
+  try {
+    const r = checkWorkIQ({ workiqPath: full });
+    assert.equal(r.ok, true, `expected ok, got ${JSON.stringify(r)}`);
+    assert.equal(r.path, full);
+    assert.match(r.version, /9\.9\.9-fake/);
+  } finally {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test('checkWorkIQ: --workiq-path pointing at a failing binary returns not-executable', () => {
+  const name = isWin ? 'broken-workiq.cmd' : 'broken-workiq';
+  const body = isWin
+    ? '@echo off\r\nexit /b 17\r\n'
+    : '#!/usr/bin/env bash\nexit 17\n';
+  const { full, dir } = makeTempBin(name, body);
+  try {
+    const r = checkWorkIQ({ workiqPath: full });
+    assert.equal(r.ok, false);
+    assert.equal(r.reason, 'not-executable');
+    assert.match(r.hint, /failed/i);
+  } finally {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+test('checkWorkIQ: with no PATH match and no override returns not-found with platform hint', () => {
+  const savedPath = process.env.PATH;
+  const savedPathCap = process.env.Path;
+  const savedHome = process.env.HOME;
+  const savedProfile = process.env.USERPROFILE;
+  try {
+    const fakeRoot = path.join(os.tmpdir(), `kushi-empty-${Date.now()}`);
+    process.env.PATH = fakeRoot;
+    if (isWin) process.env.Path = fakeRoot;
+    process.env.HOME = fakeRoot;
+    if (isWin) process.env.USERPROFILE = fakeRoot;
+
+    const r = checkWorkIQ();
+    assert.equal(r.ok, false);
+    assert.equal(r.reason, 'not-found');
+    if (isWin) {
+      assert.match(r.hint, /winget install Microsoft\.WorkIQ/);
+    } else if (process.platform === 'darwin') {
+      assert.match(r.hint, /brew install --cask microsoft-workiq/);
+    } else {
+      assert.match(r.hint, /install-workiq/);
+    }
+  } finally {
+    process.env.PATH = savedPath;
+    if (savedPathCap !== undefined) process.env.Path = savedPathCap;
+    else delete process.env.Path;
+    if (savedHome !== undefined) process.env.HOME = savedHome;
+    else delete process.env.HOME;
+    if (savedProfile !== undefined) process.env.USERPROFILE = savedProfile;
+    else delete process.env.USERPROFILE;
+  }
+});