kupos-ui-components-lib 10.4.71 → 10.4.73

package/dist/ui/DiscountBanners/discountUtils.js

@@ -107,24 +107,37 @@ function addOperatorLogo(card, service) {
         { url, name: service.operator_name || ((_f = service.operator_details) === null || _f === void 0 ? void 0 : _f[2]) },
     ];
 }
+// savings_percent may be missing or sent as a string; fall back to the deal's prices so
+// Remate still sorts by its real discount instead of dropping to 0%
+function getWowDealPercent(wowDealData) {
+    const savings = Number(wowDealData.savings_percent);
+    if (savings > 0)
+        return savings;
+    const original = Number(wowDealData.original_price);
+    const final = Number(wowDealData.final_price);
+    return original > 0 && final >= 0 && final < original
+        ? ((original - final) / original) * 100
+        : 0;
+}
 function toDiscountLabel(discount, currencySign) {
     if (discount.type === "fixed") {
         return `${CommonService.currencyRounded(discount.amount, currencySign)} de dcto`;
     }
     return `${Math.round(discount.amount)}% de dcto`;
 }
-// Groups services into one card per discount category. Remate/wow-deal is always the first card.
+// Groups services into one card per discount category, ordered from highest to lowest discount.
 export function deriveDiscountCards(services = [], wowDealData, currencySign = "$") {
     var _a, _b, _c, _d, _e;
     const cards = new Map();
     const wowServices = wowDealData === null || wowDealData === void 0 ? void 0 : wowDealData.services;
+    const wowDealPercent = wowDealData ? getWowDealPercent(wowDealData) : 0;
     const hasWowDeal = !!wowDealData &&
         ((Array.isArray(wowServices) && wowServices.length > 0) ||
-            !!wowDealData.savings_percent);
+            wowDealPercent > 0);
     if (hasWowDeal) {
         const remateDiscount = {
             type: "percentage",
-            amount: Math.round(wowDealData.savings_percent || 0),
+            amount: Math.round(wowDealPercent),
         };
         cards.set(REMATE_KEY, {
             key: REMATE_KEY,
@@ -217,5 +230,13 @@ export function deriveDiscountCards(services = [], wowDealData, currencySign = "
             return a.name.localeCompare(b.name, "es", { sensitivity: "base" });
         });
     }
-    return Array.from(cards.values());
+    // Highest discount first, Remate included — it takes its place by its percent rather than
+    // always leading. Percentages and fixed amounts can't be compared, so percentages lead.
+    // The sort is stable, so on a tie Remate stays ahead and the rest keep service order.
+    return Array.from(cards.values()).sort((a, b) => {
+        if (a.discountType !== b.discountType) {
+            return a.discountType === "percentage" ? -1 : 1;
+        }
+        return b.amount - a.amount;
+    });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kupos-ui-components-lib",
-  "version": "10.4.71",
+  "version": "10.4.73",
   "description": "A reusable UI components package",
   "publishConfig": {
     "access": "public"

package/src/ui/DiscountBanners/discountUtils.ts

@@ -148,6 +148,18 @@ function addOperatorLogo(
   ];
 }
 
+// savings_percent may be missing or sent as a string; fall back to the deal's prices so
+// Remate still sorts by its real discount instead of dropping to 0%
+function getWowDealPercent(wowDealData: WowDealData): number {
+  const savings = Number(wowDealData.savings_percent);
+  if (savings > 0) return savings;
+  const original = Number(wowDealData.original_price);
+  const final = Number(wowDealData.final_price);
+  return original > 0 && final >= 0 && final < original
+    ? ((original - final) / original) * 100
+    : 0;
+}
+
 function toDiscountLabel(
   discount: ServiceDiscount,
   currencySign: string,
@@ -158,7 +170,7 @@ function toDiscountLabel(
   return `${Math.round(discount.amount)}% de dcto`;
 }
 
-// Groups services into one card per discount category. Remate/wow-deal is always the first card.
+// Groups services into one card per discount category, ordered from highest to lowest discount.
 export function deriveDiscountCards(
   services: DiscountBannerServiceItem[] = [],
   wowDealData?: WowDealData,
@@ -167,15 +179,16 @@ export function deriveDiscountCards(
   const cards = new Map<string, DiscountBannerCard>();
 
   const wowServices = wowDealData?.services;
+  const wowDealPercent = wowDealData ? getWowDealPercent(wowDealData) : 0;
   const hasWowDeal =
     !!wowDealData &&
     ((Array.isArray(wowServices) && wowServices.length > 0) ||
-      !!wowDealData.savings_percent);
+      wowDealPercent > 0);
 
   if (hasWowDeal) {
     const remateDiscount: ServiceDiscount = {
       type: "percentage",
-      amount: Math.round(wowDealData!.savings_percent || 0),
+      amount: Math.round(wowDealPercent),
     };
     cards.set(REMATE_KEY, {
       key: REMATE_KEY,
@@ -276,5 +289,13 @@ export function deriveDiscountCards(
     });
   }
 
-  return Array.from(cards.values());
+  // Highest discount first, Remate included — it takes its place by its percent rather than
+  // always leading. Percentages and fixed amounts can't be compared, so percentages lead.
+  // The sort is stable, so on a tie Remate stays ahead and the rest keep service order.
+  return Array.from(cards.values()).sort((a, b) => {
+    if (a.discountType !== b.discountType) {
+      return a.discountType === "percentage" ? -1 : 1;
+    }
+    return b.amount - a.amount;
+  });
 }