kryptheon 0.1.64 → 0.1.66

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -92,6 +92,163 @@ function handlerAt(parser, ast, line) {
92
92
  return { path: found.path, reqName: first && first.type === 'Identifier' ? first.name : null };
93
93
  }
94
94
 
95
+ const isFnNode = (n) => !!n && /^(FunctionDeclaration|FunctionExpression|ArrowFunctionExpression)$/.test(n.type);
96
+ // a helper module followed from the handler's file, and from that one (round 30: the router requires
97
+ // ../services/signatures.js, whose verifySignature signs JSON.stringify(body) with createHmac)
98
+ const MAX_MODULE_HOPS = 2;
99
+
100
+ /** The parsed files of the project a handler's helpers live in: abs -> ast (or null), read once per readSigning. */
101
+ function moduleReader(parser) {
102
+ const cache = new Map();
103
+ return (abs) => {
104
+ if (cache.has(abs)) return cache.get(abs);
105
+ let ast = null;
106
+ try {
107
+ const text = fs.readFileSync(abs, 'utf8');
108
+ try {
109
+ ast = parser.babelParse(text, abs, true);
110
+ } catch (err) {
111
+ ast = parser.babelParse(text, abs, false);
112
+ }
113
+ } catch (err) {
114
+ ast = null;
115
+ }
116
+ cache.set(abs, ast);
117
+ return ast;
118
+ };
119
+ }
120
+
121
+ /** A relative module a file names, as a file of the project - or null (a package, or not there). */
122
+ function localModule(fromAbs, spec) {
123
+ if (typeof spec !== 'string' || !/^\.{1,2}(\/|$)/.test(spec)) return null;
124
+ const base = path.resolve(path.dirname(fromAbs), spec);
125
+ const stem = base.replace(/\.(js|mjs|cjs|jsx|ts)$/i, '');
126
+ for (const f of [base, stem + '.js', stem + '.cjs', stem + '.mjs', stem + '.ts', stem + '.jsx', path.join(base, 'index.js'), path.join(base, 'index.ts')]) {
127
+ try {
128
+ if (fs.statSync(f).isFile()) return f;
129
+ } catch (err) {
130
+ /* next */
131
+ }
132
+ }
133
+ return null;
134
+ }
135
+
136
+ /** require('./x') / require('./x').name / await import('./x') as { spec, name } (name null for the whole module), or null. */
137
+ function requiredOf(node) {
138
+ let n = node;
139
+ if (n && n.type === 'AwaitExpression') n = n.argument;
140
+ if (n && n.type === 'MemberExpression' && !n.computed && n.property.type === 'Identifier') {
141
+ const inner = requiredOf(n.object);
142
+ return inner && inner.name === null ? { spec: inner.spec, name: n.property.name === 'default' ? 'default' : n.property.name } : null;
143
+ }
144
+ if (n && n.type === 'CallExpression' && ((n.callee.type === 'Identifier' && n.callee.name === 'require') || n.callee.type === 'Import') && n.arguments[0] && n.arguments[0].type === 'StringLiteral') return { spec: n.arguments[0].value, name: null };
145
+ return null;
146
+ }
147
+
148
+ /**
149
+ * Where a name of a file comes from when it is another file's: { spec, name } - `name` the exported name, 'default'
150
+ * for the module's own value, null for the whole module (a namespace: sigs.verify). Null for anything else.
151
+ */
152
+ function importOf(binding, localName) {
153
+ const bp = binding && binding.path;
154
+ const n = bp && bp.node;
155
+ if (!n) return null;
156
+ if (n.type === 'ImportSpecifier' && bp.parent.source) return { spec: bp.parent.source.value, name: n.imported.type === 'Identifier' ? n.imported.name : n.imported.value };
157
+ if (n.type === 'ImportDefaultSpecifier' && bp.parent.source) return { spec: bp.parent.source.value, name: 'default' };
158
+ if (n.type === 'ImportNamespaceSpecifier' && bp.parent.source) return { spec: bp.parent.source.value, name: null };
159
+ if (n.type !== 'VariableDeclarator') return null;
160
+ const req = requiredOf(n.init);
161
+ if (!req) return null;
162
+ // const verify = require('./sigs') - the module's own value; const sigs = require('./sigs') used as sigs.verify
163
+ if (n.id.type === 'Identifier') return { spec: req.spec, name: req.name === null ? 'default' : req.name, whole: req.name === null };
164
+ if (n.id.type === 'ObjectPattern' && req.name === null) {
165
+ for (const prop of n.id.properties) {
166
+ if (prop.type !== 'ObjectProperty' || prop.computed) continue;
167
+ const v = prop.value.type === 'AssignmentPattern' ? prop.value.left : prop.value;
168
+ if (v.type === 'Identifier' && v.name === localName) return { spec: req.spec, name: prop.key.type === 'Identifier' ? prop.key.name : prop.key.value };
169
+ }
170
+ }
171
+ return null;
172
+ }
173
+
174
+ /**
175
+ * The function a module exports under a name ('default' for module.exports = fn / export default): its path, or a
176
+ * re-export of another module ({ spec, name }) - or null.
177
+ */
178
+ function exportedFunction(parser, ast, name) {
179
+ let found = null;
180
+ let again = null;
181
+ const fnOf = (valuePath) => {
182
+ const v = valuePath && valuePath.node;
183
+ if (isFnNode(v)) return valuePath;
184
+ if (v && v.type === 'Identifier') {
185
+ const b = valuePath.scope.getBinding(v.name);
186
+ const bn = b && b.path && b.path.node;
187
+ if (bn && bn.type === 'FunctionDeclaration') return b.path;
188
+ if (bn && bn.type === 'VariableDeclarator' && isFnNode(bn.init)) return b.path.get('init');
189
+ if (bn && bn.type === 'VariableDeclarator' && requiredOf(bn.init)) {
190
+ const r = requiredOf(bn.init);
191
+ again = { spec: r.spec, name: r.name === null ? name : r.name };
192
+ }
193
+ const imp = b && importOf(b, v.name);
194
+ if (imp && !again) again = { spec: imp.spec, name: imp.name === null ? name : imp.name };
195
+ }
196
+ const r = v && requiredOf(v);
197
+ if (r && !again) again = { spec: r.spec, name: r.name === null ? name : r.name };
198
+ return null;
199
+ };
200
+ parser.traverse(ast, {
201
+ AssignmentExpression(p) {
202
+ if (found) return;
203
+ const chain = chainOf(p.node.left);
204
+ if (!chain) return;
205
+ const right = p.get('right');
206
+ // module.exports = { verifySignature, sign: signBody } / module.exports = fn
207
+ if (chain.join('.') === 'module.exports') {
208
+ if (right.node.type === 'ObjectExpression') {
209
+ right.get('properties').forEach((prop) => {
210
+ if (found || prop.node.type !== 'ObjectProperty' && prop.node.type !== 'ObjectMethod') return;
211
+ const key = prop.node.key && (prop.node.key.type === 'Identifier' ? prop.node.key.name : prop.node.key.value);
212
+ if (key !== name) return;
213
+ found = prop.node.type === 'ObjectMethod' ? prop : fnOf(prop.get('value'));
214
+ });
215
+ } else if (name === 'default') found = fnOf(right);
216
+ else if (requiredOf(right.node) && requiredOf(right.node).name === null) again = again || { spec: requiredOf(right.node).spec, name: name };
217
+ return;
218
+ }
219
+ // module.exports.verify = ... / exports.verify = ...
220
+ if ((chain.length === 3 && chain[0] === 'module' && chain[1] === 'exports' && chain[2] === name) || (chain.length === 2 && chain[0] === 'exports' && chain[1] === name)) found = fnOf(right);
221
+ },
222
+ ExportNamedDeclaration(p) {
223
+ if (found) return;
224
+ const d = p.node.declaration;
225
+ if (d && d.type === 'FunctionDeclaration' && d.id && d.id.name === name) found = p.get('declaration');
226
+ else if (d && d.type === 'VariableDeclaration') {
227
+ p.get('declaration.declarations').forEach((dp) => {
228
+ if (!found && dp.node.id.type === 'Identifier' && dp.node.id.name === name && isFnNode(dp.node.init)) found = dp.get('init');
229
+ });
230
+ } else if (!d) {
231
+ for (const sp of p.node.specifiers || []) {
232
+ const exported = sp.exported && (sp.exported.type === 'Identifier' ? sp.exported.name : sp.exported.value);
233
+ if (exported !== name || !sp.local) continue;
234
+ if (p.node.source) again = again || { spec: p.node.source.value, name: sp.local.name };
235
+ else {
236
+ const b = p.scope.getBinding(sp.local.name);
237
+ const bn = b && b.path && b.path.node;
238
+ if (bn && bn.type === 'FunctionDeclaration') found = b.path;
239
+ else if (bn && bn.type === 'VariableDeclarator' && isFnNode(bn.init)) found = b.path.get('init');
240
+ }
241
+ }
242
+ }
243
+ },
244
+ ExportDefaultDeclaration(p) {
245
+ if (found || name !== 'default') return;
246
+ found = isFnNode(p.node.declaration) ? p.get('declaration') : fnOf(p.get('declaration'));
247
+ },
248
+ });
249
+ return found || (again ? { reexport: again } : null);
250
+ }
251
+
95
252
  /**
96
253
  * How the handler signs: { ok, header, algorithm, encoding, secret: { env, fallback }, fields, types, why }.
97
254
  * Reading code only. `fields` are the body fields the map saw the route read.
@@ -167,6 +324,8 @@ function readSigning(parser, root, route, fields) {
167
324
  // the helper call being read now: a call found inside it is that call's child, so a secret can be followed back
168
325
  // through each of them to the handler (round 28: hmac(secret, raw) -> signBody(secret, body) -> createHmac)
169
326
  let reading = null;
327
+ // the file the function being read is in: a helper's own requires are that file's
328
+ let readingFile = abs;
170
329
  const readFrom = (fnPath) => fnPath.traverse({
171
330
  CallExpression(p) {
172
331
  const n = p.node;
@@ -186,7 +345,12 @@ function readSigning(parser, root, route, fields) {
186
345
  if (n.callee && n.callee.type === 'Identifier') {
187
346
  // handed the body, or the body's bytes: sign(raw, key) where raw = JSON.stringify(req.body || {})
188
347
  const at = n.arguments.findIndex((a) => isBody(a) || isPayload(resolve(a, 3, p)));
189
- if (at >= 0) helpers.push({ name: n.callee.name, at, scope: p.scope, callPath: p, parent: reading });
348
+ if (at >= 0) helpers.push({ name: n.callee.name, at, scope: p.scope, callPath: p, parent: reading, file: readingFile, hops: reading ? reading.hops : 0 });
349
+ }
350
+ // sigs.verifySignature(req.body, ...): a function of another file of the project, through its module (round 30)
351
+ if (n.callee && n.callee.type === 'MemberExpression' && !n.callee.computed && n.callee.object.type === 'Identifier' && n.callee.property.type === 'Identifier') {
352
+ const at = n.arguments.findIndex((a) => isBody(a) || isPayload(resolve(a, 3, p)));
353
+ if (at >= 0) helpers.push({ name: n.callee.object.name, member: n.callee.property.name, at, scope: p.scope, callPath: p, parent: reading, file: readingFile, hops: reading ? reading.hops : 0 });
190
354
  }
191
355
  // ['payment.captured', 'refund.processed'].includes(payload.type), or TYPES.includes(event.type): every kind in
192
356
  // the list (round 27)
@@ -231,23 +395,54 @@ function readSigning(parser, root, route, fields) {
231
395
  if (p.node.id.type === 'ObjectPattern' && isBody(p.node.init)) for (const prop of p.node.id.properties) if (prop.key && prop.key.type === 'Identifier') destructured.push(prop.key.name);
232
396
  },
233
397
  });
398
+ // the function a helper call names: one of the same file, or one another file of the project exports (a relative
399
+ // require or import, followed at most MAX_MODULE_HOPS files away from the handler's)
400
+ const parsed = moduleReader(parser);
401
+ const fnOfCall = (call) => {
402
+ const b = call.scope.getBinding(call.name);
403
+ if (!b || !b.path) return null;
404
+ if (!call.member) {
405
+ const own = b.path.node.type === 'FunctionDeclaration' ? b.path : b.path.node.type === 'VariableDeclarator' && b.path.node.init && /Function/.test(b.path.node.init.type) ? b.path.get('init') : null;
406
+ if (own) return { fnPath: own, file: call.file };
407
+ }
408
+ const imp = importOf(b, call.name);
409
+ if (!imp) return null;
410
+ // sigs.verify needs the whole module; verify(...) needs a function, not a module's namespace
411
+ if (call.member && !(imp.name === null || imp.whole)) return null;
412
+ if (!call.member && imp.name === null) return null;
413
+ let want = { spec: imp.spec, name: call.member || imp.name };
414
+ let from = call.file;
415
+ for (let hop = call.hops; hop < MAX_MODULE_HOPS; hop++) {
416
+ const abs = localModule(from, want.spec);
417
+ const ast = abs && parsed(abs);
418
+ if (!ast) return null;
419
+ const got = exportedFunction(parser, ast, want.name);
420
+ if (!got) return null;
421
+ if (!got.reexport) return { fnPath: got, file: abs, hops: hop + 1 };
422
+ want = got.reexport;
423
+ from = abs;
424
+ }
425
+ return null;
426
+ };
234
427
  readFrom(h.path);
235
428
  let via = null;
236
429
  if (!hmac) {
237
430
  for (const call of helpers) {
238
- const b = call.scope.getBinding(call.name);
239
- if (!b || !b.path) continue;
240
- const fnPath = b.path.node.type === 'FunctionDeclaration' ? b.path : b.path.node.type === 'VariableDeclarator' && b.path.node.init && /Function/.test(b.path.node.init.type) ? b.path.get('init') : null;
431
+ const target = fnOfCall(call);
432
+ const fnPath = target && target.fnPath;
241
433
  const param = fnPath && fnPath.node.params[call.at];
242
434
  if (!param || param.type !== 'Identifier') continue;
243
435
  bodyNames.add(param.name);
244
436
  scopePath = fnPath;
245
437
  call.fnPath = fnPath;
438
+ if (target.hops !== undefined) call.hops = target.hops;
246
439
  reading = call;
440
+ readingFile = target.file;
247
441
  readFrom(fnPath);
248
442
  reading = null;
443
+ readingFile = abs;
249
444
  if (hmac) {
250
- via = call.name;
445
+ via = call.member ? call.name + '.' + call.member : call.name;
251
446
  // the helper's own parameters are this call's arguments: hmac(secret, body) called as
252
447
  // hmac(process.env.PAYMENT_WEBHOOK_SECRET || '', raw) signs with that secret (round 27)
253
448
  hmac.via = call;
@@ -261,15 +456,17 @@ function readSigning(parser, root, route, fields) {
261
456
  // the other functions handed the body: what they read and the kinds they branch on are the webhook's too, even
262
457
  // once the HMAC is found (round 27: hmac(...) signs, applyPaymentEvent(payload) acts on payload.type)
263
458
  for (const call of helpers) {
264
- if (call.read || call.name === via) continue;
265
- const b = call.scope.getBinding(call.name);
266
- if (!b || !b.path) continue;
267
- const fnPath = b.path.node.type === 'FunctionDeclaration' ? b.path : b.path.node.type === 'VariableDeclarator' && b.path.node.init && /Function/.test(b.path.node.init.type) ? b.path.get('init') : null;
459
+ if (call.read || (call.member ? call.name + '.' + call.member : call.name) === via) continue;
460
+ const target = fnOfCall(call);
461
+ const fnPath = target && target.fnPath;
268
462
  const param = fnPath && fnPath.node.params[call.at];
269
463
  if (!param || param.type !== 'Identifier') continue;
270
464
  call.read = true;
465
+ if (target.hops !== undefined) call.hops = target.hops;
271
466
  bodyNames.add(param.name);
467
+ readingFile = target.file;
272
468
  readFrom(fnPath);
469
+ readingFile = abs;
273
470
  }
274
471
  const known = new Set((fields || []).map((f) => f.name));
275
472
  const allFields = (fields || []).slice().concat(destructured.filter((n) => !known.has(n) && (known.add(n), true)).map((n) => ({ name: n, from: 'body' })));
@@ -277,7 +474,7 @@ function readSigning(parser, root, route, fields) {
277
474
  // inventory). Not "not tried" - its events are sent with no signature, which is the very thing to find out
278
475
  if (!header && !hmac) return { ok: true, open: true, fields: allFields, types: kindsOf(), typeField, why: 'no signature header is read and no HMAC is made in the handler' };
279
476
  if (!header) return { ok: false, why: 'the handler makes an HMAC but reads no signature header (looked for a header with sig, hmac or token in its name)' };
280
- if (!hmac) return { ok: false, why: 'the handler reads ' + header + ' but does not compute an HMAC the way this check knows (createHmac(alg, secret).update(body).digest(encoding)), in itself or in a function of the same file it hands the body to' };
477
+ if (!hmac) return { ok: false, why: 'the handler reads ' + header + ' but does not compute an HMAC the way this check knows (createHmac(alg, secret).update(body).digest(encoding)), in itself, in a function of the same file it hands the body to, or in one a file of the project it requires exports' };
281
478
  const alg = hmac.alg && hmac.alg.type === 'StringLiteral' ? hmac.alg.value.toLowerCase() : null;
282
479
  const enc = hmac.enc && hmac.enc.type === 'StringLiteral' ? hmac.enc.value.toLowerCase() : null;
283
480
  if (!alg || !ALGORITHMS.test(alg)) return { ok: false, why: 'the HMAC algorithm is not a plain name written in the code' };
@@ -502,9 +699,12 @@ async function run(root, options) {
502
699
  if (shape.amount) b[shape.amount] = amount !== undefined ? amount : amountKey ? Number(rec[amountKey]) : 1;
503
700
  return b;
504
701
  };
702
+ // who sends: nobody signed in, as a provider does - or, for a route the app keeps behind its own sign-in (blind
703
+ // round 33: every address under /api needed a session, the webhooks too), the signed-in account
704
+ let via = null;
505
705
  const post = async (mode, body) => {
506
706
  const text = JSON.stringify(body);
507
- const session = authz.makeSession(ctx, null, '(nobody signed in)', null);
707
+ const session = via || authz.makeSession(ctx, null, '(nobody signed in)', null);
508
708
  const headers = {};
509
709
  if (mode === 'signed') headers[signing.header] = sign(signing, secret, text);
510
710
  if (mode === 'wrong') headers[signing.header] = wrongSignature(signing, secret, text);
@@ -544,29 +744,52 @@ async function run(root, options) {
544
744
  say('Sending ' + (open ? 'an unsigned' : 'a correctly signed') + ' ' + ctypes[0] + ' to ' + name + ' first...');
545
745
  const first = nextRecord(unpaidFor(ctypes[0])) || nextRecord();
546
746
  if (!first) { hook.notTried = 'no record left to aim an event at'; continue; }
547
- let control = await attempt(S, ctypes[0], first, undefined, open ? 'unsigned' : 'signed');
548
- // a refusal can be the record's state, not the signature (round 26: "captured" sent to a failed payment is 409):
549
- // the same type at the other records, then the next type, three sends at most - a refusal changes nothing
550
- const refusals = [control];
551
- // a plain control refused (round 26 refuses payment.created for the record's state): the usual order then, with the
552
- // usual three sends besides it
553
- const order = plain && !control.took ? types : ctypes;
554
- const budget = plain && !control.took ? 4 : 3;
555
- for (const type of order) {
556
- for (const rec of records) {
557
- if (control.took || refusals.length >= budget) break;
558
- if (refusals.some((t) => t.type === type && t.record === rec.id) || (statusKey && REFUNDED.test(String(rec[statusKey])))) continue;
559
- control = await attempt(S, type, rec, undefined, open ? 'unsigned' : 'signed');
560
- refusals.push(control);
747
+ const controlPhase = async () => {
748
+ let control = await attempt(S, ctypes[0], first, undefined, open ? 'unsigned' : 'signed');
749
+ // a refusal can be the record's state, not the signature (round 26: "captured" sent to a failed payment is 409):
750
+ // the same type at the other records, then the next type, three sends at most - a refusal changes nothing
751
+ const refusals = [control];
752
+ // a plain control refused (round 26 refuses payment.created for the record's state): the usual order then, with the
753
+ // usual three sends besides it
754
+ const order = plain && !control.took ? types : ctypes;
755
+ const budget = plain && !control.took ? 4 : 3;
756
+ for (const type of order) {
757
+ for (const rec of records) {
758
+ if (control.took || refusals.length >= budget) break;
759
+ if (refusals.some((t) => t.type === type && t.record === rec.id) || (statusKey && REFUNDED.test(String(rec[statusKey])))) continue;
760
+ control = await attempt(S, type, rec, undefined, open ? 'unsigned' : 'signed');
761
+ refusals.push(control);
762
+ }
561
763
  }
562
- }
563
- // every real event refused, or none could be built (round 22: Razorpay's nested body): a signed event of a type
564
- // no handler acts on. Taken, it shows the signature is made right - and the same event unsigned or wrongly
565
- // signed then shows whether the app checks it before anything else (round 22 checked the length only)
566
- if (!control.took && !open && ctypes[0] !== NEUTRAL) {
567
- const neutral = await attempt('signed', NEUTRAL, first, undefined, 'signed');
568
- refusals.push(neutral);
569
- if (neutral.took) control = neutral;
764
+ // every real event refused, or none could be built (round 22: Razorpay's nested body): a signed event of a type
765
+ // no handler acts on. Taken, it shows the signature is made right - and the same event unsigned or wrongly
766
+ // signed then shows whether the app checks it before anything else (round 22 checked the length only)
767
+ if (!control.took && !open && ctypes[0] !== NEUTRAL) {
768
+ const neutral = await attempt('signed', NEUTRAL, first, undefined, 'signed');
769
+ refusals.push(neutral);
770
+ if (neutral.took) control = neutral;
771
+ }
772
+ return { control, refusals };
773
+ };
774
+ let { control, refusals } = await controlPhase();
775
+ // Every correctly signed event answered 401 with nobody signed in: the app keeps this route behind its own sign-in.
776
+ // A provider never signs in, so its events cannot arrive - said as a thing to check. The same tries are then made as
777
+ // the signed-in account, and everything found after that says so: any account of the app can send these events.
778
+ if (!control.took && !open && refusals.every((t) => t.status === 401)) {
779
+ const gated = refusals;
780
+ via = reader;
781
+ hook.signedIn = who.email;
782
+ say('Every correctly signed event to ' + name + ' was answered 401 with nobody signed in - sending them again as ' + who.email + '...');
783
+ ({ control, refusals } = await controlPhase());
784
+ hook.loginGate = { refusals: gated.map((t) => t.type + ': ' + t.status), tookSignedIn: control.took };
785
+ const headline = name + ' answers 401 to a correctly signed event when nobody is signed in' + (control.took ? ', and takes it from a signed-in account' : '') + ': a provider never signs in to your app, so its events cannot arrive.';
786
+ const gate = { kind: 'webhook-login-gate', where: name, from: route.file + ':' + route.line, status: 'verification required', severity: 'MEDIUM', headline,
787
+ proof: ['Correctly signed with ' + (signing.secret.env || 'the secret in the code') + ', nobody signed in: ' + gated.map((t) => t.type + (t.record !== null ? ' for ' + resource + ' ' + t.record : '') + ' answered ' + t.status).join('; '),
788
+ control.took ? 'The same event as ' + who.email + ': answered ' + control.status : 'As ' + who.email + ' too: ' + refusals.map((t) => t.status).join(', ')],
789
+ fixPrompt: ['Kryptheon sent my running app a correctly signed webhook event, and it was refused because nobody was signed in:', '', headline, '', 'Where: ' + route.file + ':' + route.line, '',
790
+ 'Mount the webhook route before the sign-in middleware (or exclude it from it), so that only the signature decides whether an event is taken - and keep the signature check strict: answer 401 when it is missing or wrong.', '', 'Afterwards I will run: npx kryptheon api'].join(String.fromCharCode(10)) };
791
+ hook.findings.push(gate);
792
+ out.findings.push(gate);
570
793
  }
571
794
  hook.control = control;
572
795
  hook.neutral = control.type === NEUTRAL && !open;
@@ -587,14 +810,30 @@ async function run(root, options) {
587
810
  // (round 26: the next record was a failed payment, which refuses any capture for its state, not its amount)
588
811
  // a capture-kind event, even when the control was another kind (round 27: payment.created took the control); at the
589
812
  // control's record first, then the others, until one takes a capture at all - a refusal for its state says nothing
590
- const captureType = shape.amount && amountKey ? (!REFUNDED.test(control.type) && CAPTURE.test(control.type) ? control.type : signing.types.find((t) => !REFUNDED.test(t) && CAPTURE.test(t))) : null;
813
+ // A handler that compares no event type acts on every event it is sent (blind round 32: the type defaulted to
814
+ // 'payment.captured', so the check's own neutral event was a capture): the event it took is then the capture.
815
+ const actsOnAny = !types.length && !(signing.types || []).length;
816
+ const captureType = shape.amount && amountKey ? (!REFUNDED.test(control.type) && CAPTURE.test(control.type) ? control.type : signing.types.find((t) => !REFUNDED.test(t) && CAPTURE.test(t)) || (actsOnAny ? control.type : null)) : null;
591
817
  const payControl = !!captureType;
818
+ // a record a capture can still land on first, so what changed is the capture and not a record already settled
819
+ const captureOrder = [...capturable, controlRec].concat(records).filter((r, i, all) => r && r.id !== null && all.indexOf(r) === i).slice(0, 3);
592
820
  if (captureType) {
593
- for (const rec of [controlRec].concat(records.filter((r) => r !== controlRec)).slice(0, 3)) {
821
+ for (const rec of captureOrder) {
594
822
  const t = await attempt(S, captureType, rec, (Number(rec[amountKey]) || 0) + 100, 'signed, wrong amount');
595
823
  if (t.took) break;
596
824
  }
597
825
  }
826
+ // the same capture in another currency than the record's (blind round 32: EUR was taken for a USD payment)
827
+ const currencyKey = records[0] && Object.keys(records[0]).find((k) => /^currency(_code)?$/i.test(k));
828
+ if (captureType && shape.currency && currencyKey) {
829
+ for (const rec of captureOrder) {
830
+ const own = String(rec[currencyKey] || '').toUpperCase();
831
+ const other = own === 'EUR' ? 'USD' : 'EUR';
832
+ const body = Object.assign(bodyFor(captureType, rec, amountKey ? Number(rec[amountKey]) || 1 : undefined), { [shape.currency]: /^[a-z]+$/.test(String(rec[currencyKey] || '')) ? other.toLowerCase() : other });
833
+ const t = await attempt(S, captureType, rec, undefined, 'signed, wrong currency', body);
834
+ if (t.took) break;
835
+ }
836
+ }
598
837
  // a refund on a record that was paid: sent twice as the same event, then for more than was paid
599
838
  const refundType = types.find((t) => REFUNDED.test(t)) || signing.types.find((t) => REFUNDED.test(t));
600
839
  const paidRec = refundType && statusKey && records.find((r) => PAID.test(String(r[statusKey])) && !REFUNDED.test(String(r[statusKey])));
@@ -622,7 +861,10 @@ async function run(root, options) {
622
861
 
623
862
  // judged
624
863
  const at = hook.from;
625
- const finding = (kind, severity, status, headline, proof, fix) => {
864
+ const finding = (kind, severity, status, headline0, proof0, fix) => {
865
+ // sent while signed in: the app answers only signed-in people here, so it is any account of the app that can do it
866
+ const headline = via ? headline0.replace(/\.$/, '') + ' - sent while signed in as ' + who.email + ', since this route answers 401 to anyone not signed in: any account of your app can do it.' : headline0;
867
+ const proof = via ? ['Sent with ' + who.email + '\'s sign-in (with nobody signed in, every correctly signed event was answered 401).'].concat(proof0) : proof0;
626
868
  const f = { kind, where: name, from: at, status, severity, headline, proof, fixPrompt: ['Kryptheon sent my running app an event it signs itself, and it was taken when it should not have been:', '', headline, '', 'Where: ' + at, '', fix, '', 'Afterwards I will run: npx kryptheon api'].join(String.fromCharCode(10)) };
627
869
  hook.findings.push(f);
628
870
  out.findings.push(f);
@@ -645,12 +887,16 @@ async function run(root, options) {
645
887
  if (t.mode === 'none' && t.took) {
646
888
  finding('webhook-unsigned', t.changed ? 'CRITICAL' : 'HIGH', t.changed ? 'confirmed' : 'verification required',
647
889
  t.changed ? name + ' took ' + shown(t) + ' with no signature at all and changed ' + resource + ' ' + t.record + (t.from !== null && t.from !== t.to ? ' (' + statusKey + ' ' + t.from + ' -> ' + t.to + ')' : ' (' + t.fields.join(', ') + ')') + ': anyone who can reach it can send one.' : name + ' answered ' + t.status + ' to ' + shown(t) + ' with no signature, though no change was seen' + seen + '.',
648
- [(open ? 'With nobody signed in, and no signature - the handler reads none: ' : 'With nobody signed in and no ' + signing.header + ' header: ') + lineOf(t)],
890
+ [(open ? (via ? 'With' : 'With nobody signed in, and') + ' no signature - the handler reads none: ' : (via ? 'With' : 'With nobody signed in and') + ' no ' + signing.header + ' header: ') + lineOf(t)],
649
891
  open ? 'This webhook checks no signature at all. Have the sender sign each event (an HMAC of the exact raw body with a shared secret, in a header) and answer 401 before anything is saved when the signature is missing or wrong, using a timing-safe compare.' : 'Treat a request with no signature as invalid: answer 401 before anything is saved, the same as a wrong signature. The check that reads "if the header is there and it is wrong" lets every request without the header through.');
650
892
  } else if (t.mode === 'wrong' && t.took) {
651
893
  finding('webhook-forged', t.changed ? 'CRITICAL' : 'HIGH', t.changed ? 'confirmed' : 'verification required',
652
894
  name + ' took ' + t.type + ' with a wrong signature' + (t.changed ? ' and changed ' + resource + ' ' + t.record : '') + '.',
653
895
  ['A signature of the right length, one character wrong: ' + lineOf(t)], 'Compare the signature with a timing-safe compare (crypto.timingSafeEqual) over the exact raw body, and answer 401 when it does not match, before anything is saved.');
896
+ } else if (t.label === 'signed, wrong currency' && t.took && t.changed) {
897
+ finding('webhook-currency', 'HIGH', 'confirmed',
898
+ name + ' applied ' + shown(t) + ' in another currency than ' + resource + ' ' + t.record + '\'s, and it changed all the same (' + (t.from !== t.to ? statusKey + ' ' + t.from + ' -> ' + t.to : t.fields.join(', ')) + ').',
899
+ ['Correctly signed, with the record\'s amount but another currency: ' + lineOf(t)], 'Compare the currency in the event with the currency the ' + resource + ' was created in, and ignore or flag the event when they differ - never store the event\'s currency over the record\'s.');
654
900
  } else if (t.label === 'signed, wrong amount' && t.took && t.changed) {
655
901
  finding('webhook-amount', 'HIGH', 'confirmed',
656
902
  name + ' applied ' + t.type + ' for an amount that is not ' + resource + ' ' + t.record + '\'s, and it changed all the same (' + (t.from !== t.to ? statusKey + ' ' + t.from + ' -> ' + t.to : t.fields.join(', ')) + ').',
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "kryptheon",
3
- "version": "0.1.64",
3
+ "version": "0.1.66",
4
4
  "description": "Record what you do in your app and get plain-language reports when it breaks.",
5
5
  "license": "SEE LICENSE IN LICENSE",
6
6
  "type": "commonjs",
@@ -38,6 +38,7 @@
38
38
  "kryptheon-dashboard.js",
39
39
  "kryptheon-dashboard.html",
40
40
  "kryptheon-dashboard-page.js",
41
+ "kryptheon-account.js",
41
42
  "kryptheon-logo.png",
42
43
  "kryptheon-fonts-OFL.txt",
43
44
  "kryptheon-spacemono.woff2",
@@ -58,7 +59,8 @@
58
59
  "kryptheon-map.js",
59
60
  "kryptheon-api.js",
60
61
  "kryptheon-webhook.js",
61
- "kryptheon-csv.js"
62
+ "kryptheon-csv.js",
63
+ "kryptheon-newer.js"
62
64
  ],
63
65
  "engines": {
64
66
  "node": ">=20.6.0"
@@ -68,7 +70,7 @@
68
70
  "pg": "^8.23.0"
69
71
  },
70
72
  "scripts": {
71
- "check": "node kryptheon-store.check.js && node kryptheon-code.check.js && node kryptheon-constdata.check.js && node kryptheon-listitems.check.js && node kryptheon-accept.check.js && node kryptheon-keys.check.js && node kryptheon-dashboard.check.js && node kryptheon-edge.check.js && node kryptheon-reliability.check.js && node kryptheon-fresh.check.js && node kryptheon-payments-dash.check.js && node kryptheon-embedded.check.js && node kryptheon-autostart.check.js && node kryptheon-changes.check.js && node kryptheon-look.check.js && node kryptheon-verify.check.js && node kryptheon-recheck.check.js && node kryptheon-reporter.check.js && node kryptheon-signature.check.js && node kryptheon-signature.stream.check.js && node kryptheon-signature.baseline.check.js && node kryptheon-signature.settle.check.js && node kryptheon-signature.number.check.js && node kryptheon-signature.rows.check.js && node kryptheon-env.check.js && node kryptheon-watchdog.check.js && node kryptheon-phone.check.js && node kryptheon-homedash.check.js && node kryptheon-record.check.js && node kryptheon-selectors.check.js && node kryptheon-recordings.check.js && node kryptheon-testfiles.check.js && node kryptheon-cleanup.check.js && node kryptheon-orphan.check.js && node kryptheon-project.check.js && node kryptheon-setup.check.js && node kryptheon-browser.check.js && node kryptheon-heal.check.js && node kryptheon-load.check.js && node kryptheon-authz.check.js && node kryptheon-roles.check.js && node kryptheon-map.check.js && node kryptheon-api.check.js && node kryptheon-webhook.check.js && node kryptheon-csv.check.js && node kryptheon-package.check.js",
73
+ "check": "node kryptheon-store.check.js && node kryptheon-code.check.js && node kryptheon-constdata.check.js && node kryptheon-listitems.check.js && node kryptheon-accept.check.js && node kryptheon-keys.check.js && node kryptheon-dashboard.check.js && node kryptheon-edge.check.js && node kryptheon-reliability.check.js && node kryptheon-fresh.check.js && node kryptheon-payments-dash.check.js && node kryptheon-embedded.check.js && node kryptheon-autostart.check.js && node kryptheon-changes.check.js && node kryptheon-look.check.js && node kryptheon-verify.check.js && node kryptheon-recheck.check.js && node kryptheon-reporter.check.js && node kryptheon-signature.check.js && node kryptheon-signature.stream.check.js && node kryptheon-signature.baseline.check.js && node kryptheon-signature.settle.check.js && node kryptheon-signature.number.check.js && node kryptheon-signature.rows.check.js && node kryptheon-env.check.js && node kryptheon-watchdog.check.js && node kryptheon-phone.check.js && node kryptheon-homedash.check.js && node kryptheon-record.check.js && node kryptheon-selectors.check.js && node kryptheon-recordings.check.js && node kryptheon-testfiles.check.js && node kryptheon-cleanup.check.js && node kryptheon-orphan.check.js && node kryptheon-project.check.js && node kryptheon-setup.check.js && node kryptheon-browser.check.js && node kryptheon-heal.check.js && node kryptheon-load.check.js && node kryptheon-authz.check.js && node kryptheon-roles.check.js && node kryptheon-map.check.js && node kryptheon-api.check.js && node kryptheon-webhook.check.js && node kryptheon-csv.check.js && node kryptheon-package.check.js && node kryptheon-newer.check.js",
72
74
  "check:store": "node kryptheon-store.check.js",
73
75
  "check:code": "node kryptheon-code.check.js",
74
76
  "check:constdata": "node kryptheon-constdata.check.js",
@@ -113,7 +115,9 @@
113
115
  "check:map": "node kryptheon-map.check.js",
114
116
  "check:api": "node kryptheon-api.check.js",
115
117
  "check:webhook": "node kryptheon-webhook.check.js",
116
- "check:csv": "node kryptheon-csv.check.js"
118
+ "check:csv": "node kryptheon-csv.check.js",
119
+ "check:newer": "node kryptheon-newer.check.js",
120
+ "check:account": "node kryptheon-account.check.js"
117
121
  },
118
122
  "keywords": [
119
123
  "playwright",