korekt-cli 0.8.3 → 0.8.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "korekt-cli",
-  "version": "0.8.3",
+  "version": "0.8.5",
   "description": "AI-powered code review CLI - Keep your kode korekt",
   "main": "src/index.js",
   "bin": {

package/src/formatter.js

@@ -29,6 +29,8 @@ const CATEGORY_ICONS = {
   documentation: '📝',
   test_coverage: '🧪',
   readability: '📖',
+  architectural: '🏗️',
+  file_structure: '📁',
   default: '⚙️', // Default icon
 };
 

package/src/git-logic.js

@@ -1,5 +1,6 @@
 import { execa } from 'execa';
 import chalk from 'chalk';
+import { detectCIProvider } from './utils.js';
 
 /**
  * Truncate content to a maximum number of lines using "head and tail".
@@ -98,6 +99,30 @@ export function shouldIgnoreFile(filePath, patterns) {
   return false;
 }
 
+/**
+ * Calculate total changed lines (additions + deletions) from changed files
+ * @param {Array} changedFiles - Array of file objects with diff property
+ * @returns {number} - Total number of changed lines
+ */
+export function calculateChangedLines(changedFiles) {
+  let changedLines = 0;
+  for (const file of changedFiles) {
+    if (file.diff) {
+      const lines = file.diff.split('\n');
+      for (const line of lines) {
+        if (
+          (line.startsWith('+') || line.startsWith('-')) &&
+          !line.startsWith('+++') &&
+          !line.startsWith('---')
+        ) {
+          changedLines++;
+        }
+      }
+    }
+  }
+  return changedLines;
+}
+
 /**
  * Helper function to parse the complex output of git diff --name-status
  */
@@ -219,6 +244,8 @@ export async function runUncommittedReview(mode = 'unstaged') {
       commit_messages: [], // No commits for uncommitted changes
       changed_files: changedFiles,
       source_branch: branchName,
+      changed_lines: calculateChangedLines(changedFiles),
+      is_ci: detectCIProvider() !== null,
     };
   } catch (error) {
     console.error(chalk.red('Failed to analyze uncommitted changes:'), error.message);
@@ -498,6 +525,8 @@ export async function runLocalReview(targetBranch = null, ignorePatterns = null)
       author_email,
       author_name,
       contributors,
+      changed_lines: calculateChangedLines(changedFiles),
+      is_ci: detectCIProvider() !== null,
     };
   } catch (error) {
     console.error(chalk.red('Failed to run local review analysis:'), error.message);

package/src/git-logic.test.js

@@ -9,6 +9,7 @@ import {
   getContributors,
 } from './git-logic.js';
 import { execa } from 'execa';
+import { detectCIProvider } from './utils.js';
 
 describe('parseNameStatus', () => {
   it('should correctly parse M, A, and D statuses', () => {
@@ -667,3 +668,345 @@ describe('getContributors', () => {
     expect(result.contributors[2].commits).toBe(1);
   });
 });
+
+describe('changed_lines calculation', () => {
+  beforeEach(() => {
+    vi.mock('execa');
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it('should calculate changed_lines for uncommitted changes', async () => {
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/fake/repo/path' };
+      }
+      if (command.includes('diff --cached --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff --cached -U15 -- file.js')) {
+        // Simulate a diff with 5 additions and 3 deletions (8 total changed lines)
+        return {
+          stdout:
+            'diff --git a/file.js b/file.js\n' +
+            '--- a/file.js\n' +
+            '+++ b/file.js\n' +
+            '@@ -1,5 +1,10 @@\n' +
+            '+new line 1\n' +
+            '+new line 2\n' +
+            ' existing line\n' +
+            '-old line 1\n' +
+            '-old line 2\n' +
+            '-old line 3\n' +
+            '+new line 3\n' +
+            '+new line 4\n' +
+            '+new line 5\n',
+        };
+      }
+      if (command.includes('show HEAD:file.js')) {
+        return { stdout: 'old content' };
+      }
+
+      throw new Error(`Unmocked command: ${command}`);
+    });
+
+    const result = await runUncommittedReview('staged');
+
+    expect(result).toBeDefined();
+    expect(result.changed_lines).toBe(8); // 5 additions + 3 deletions
+  });
+
+  it('should calculate changed_lines for local review', async () => {
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/path/to/repo' };
+      }
+      if (command.includes('rev-parse --verify main')) {
+        return { stdout: 'commit-hash' };
+      }
+      if (command === 'git fetch origin main') {
+        return { stdout: '' };
+      }
+      if (command.includes('merge-base origin/main HEAD')) {
+        return { stdout: 'abc123' };
+      }
+      if (command.includes('log --no-merges --pretty=%B---EOC---')) {
+        return { stdout: 'feat: add feature---EOC---' };
+      }
+      if (command.includes('diff --name-status')) {
+        return { stdout: 'M\tfile1.js\nA\tfile2.js' };
+      }
+      if (command.includes('diff -U15') && command.includes('file1.js')) {
+        // 10 lines changed in file1.js
+        return {
+          stdout:
+            'diff --git a/file1.js b/file1.js\n' +
+            '+line1\n' +
+            '+line2\n' +
+            '-line3\n' +
+            '-line4\n' +
+            '+line5\n' +
+            '+line6\n' +
+            '+line7\n' +
+            '-line8\n' +
+            '+line9\n' +
+            '+line10\n',
+        };
+      }
+      if (command.includes('diff -U15') && command.includes('file2.js')) {
+        // 5 lines added in file2.js (new file)
+        return {
+          stdout:
+            'diff --git a/file2.js b/file2.js\n' +
+            '+line1\n' +
+            '+line2\n' +
+            '+line3\n' +
+            '+line4\n' +
+            '+line5\n',
+        };
+      }
+      if (command.includes('show abc123:file1.js')) {
+        return { stdout: 'original content' };
+      }
+
+      return { stdout: '' };
+    });
+
+    const result = await runLocalReview('main');
+
+    expect(result).toBeDefined();
+    expect(result.changed_lines).toBe(15); // 10 from file1.js + 5 from file2.js
+  });
+
+  it('should handle diffs with no changes', async () => {
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/fake/repo/path' };
+      }
+      if (command.includes('diff --cached --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff --cached -U15 -- file.js')) {
+        // Empty diff (no actual changes, just headers)
+        return {
+          stdout: 'diff --git a/file.js b/file.js\n--- a/file.js\n+++ b/file.js\n',
+        };
+      }
+      if (command.includes('show HEAD:file.js')) {
+        return { stdout: 'content' };
+      }
+
+      throw new Error(`Unmocked command: ${command}`);
+    });
+
+    const result = await runUncommittedReview('staged');
+
+    expect(result).toBeDefined();
+    expect(result.changed_lines).toBe(0);
+  });
+});
+
+describe('is_ci flag in payload', () => {
+  beforeEach(() => {
+    vi.mock('execa');
+    vi.mock('./utils.js', () => ({
+      detectCIProvider: vi.fn(),
+    }));
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it('should set is_ci to true when detectCIProvider returns a provider', async () => {
+    vi.mocked(detectCIProvider).mockReturnValue('github');
+
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/fake/repo/path' };
+      }
+      if (command.includes('diff --cached --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff --cached -U15 -- file.js')) {
+        return { stdout: 'diff --git a/file.js b/file.js\n+new line' };
+      }
+      if (command.includes('show HEAD:file.js')) {
+        return { stdout: 'old content' };
+      }
+
+      throw new Error(`Unmocked command: ${command}`);
+    });
+
+    const result = await runUncommittedReview('staged');
+
+    expect(result).toBeDefined();
+    expect(result.is_ci).toBe(true);
+  });
+
+  it('should set is_ci to false when detectCIProvider returns null', async () => {
+    vi.mocked(detectCIProvider).mockReturnValue(null);
+
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/fake/repo/path' };
+      }
+      if (command.includes('diff --cached --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff --cached -U15 -- file.js')) {
+        return { stdout: 'diff --git a/file.js b/file.js\n+new line' };
+      }
+      if (command.includes('show HEAD:file.js')) {
+        return { stdout: 'old content' };
+      }
+
+      throw new Error(`Unmocked command: ${command}`);
+    });
+
+    const result = await runUncommittedReview('staged');
+
+    expect(result).toBeDefined();
+    expect(result.is_ci).toBe(false);
+  });
+
+  it('should include is_ci in runLocalReview payload', async () => {
+    vi.mocked(detectCIProvider).mockReturnValue('azure');
+
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/path/to/repo' };
+      }
+      if (command.includes('rev-parse --verify main')) {
+        return { stdout: 'commit-hash' };
+      }
+      if (command === 'git fetch origin main') {
+        return { stdout: '' };
+      }
+      if (command.includes('merge-base origin/main HEAD')) {
+        return { stdout: 'abc123' };
+      }
+      if (command.includes('log --no-merges --pretty=%B---EOC---')) {
+        return { stdout: 'feat: add feature---EOC---' };
+      }
+      if (command.includes('log --no-merges --format=%ae|%an')) {
+        return { stdout: 'user@example.com|User Name' };
+      }
+      if (command.includes('diff --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff -U15')) {
+        return { stdout: 'diff content' };
+      }
+      if (command.includes('show abc123:file.js')) {
+        return { stdout: 'original content' };
+      }
+
+      return { stdout: '' };
+    });
+
+    const result = await runLocalReview('main');
+
+    expect(result).toBeDefined();
+    expect(result.is_ci).toBe(true);
+  });
+
+  it('should set is_ci to false in runLocalReview when not in CI', async () => {
+    vi.mocked(detectCIProvider).mockReturnValue(null);
+
+    vi.mocked(execa).mockImplementation(async (cmd, args) => {
+      const command = [cmd, ...args].join(' ');
+
+      if (command.includes('remote get-url origin')) {
+        return { stdout: 'https://github.com/user/repo.git' };
+      }
+      if (command.includes('rev-parse --abbrev-ref HEAD')) {
+        return { stdout: 'feature-branch' };
+      }
+      if (command.includes('rev-parse --show-toplevel')) {
+        return { stdout: '/path/to/repo' };
+      }
+      if (command.includes('rev-parse --verify main')) {
+        return { stdout: 'commit-hash' };
+      }
+      if (command === 'git fetch origin main') {
+        return { stdout: '' };
+      }
+      if (command.includes('merge-base origin/main HEAD')) {
+        return { stdout: 'abc123' };
+      }
+      if (command.includes('log --no-merges --pretty=%B---EOC---')) {
+        return { stdout: 'feat: add feature---EOC---' };
+      }
+      if (command.includes('log --no-merges --format=%ae|%an')) {
+        return { stdout: 'user@example.com|User Name' };
+      }
+      if (command.includes('diff --name-status')) {
+        return { stdout: 'M\tfile.js' };
+      }
+      if (command.includes('diff -U15')) {
+        return { stdout: 'diff content' };
+      }
+      if (command.includes('show abc123:file.js')) {
+        return { stdout: 'original content' };
+      }
+
+      return { stdout: '' };
+    });
+
+    const result = await runLocalReview('main');
+
+    expect(result).toBeDefined();
+    expect(result.is_ci).toBe(false);
+  });
+});

package/src/index.js

@@ -14,6 +14,10 @@ import { tmpdir } from 'os';
 import { runLocalReview } from './git-logic.js';
 import { getApiKey, setApiKey, getApiEndpoint, setApiEndpoint } from './config.js';
 import { formatReviewOutput } from './formatter.js';
+import { detectCIProvider, truncateFileData, formatErrorOutput } from './utils.js';
+
+// Re-export utilities for backward compatibility
+export { detectCIProvider, truncateFileData, formatErrorOutput } from './utils.js';
 
 const require = createRequire(import.meta.url);
 const { version } = require('../package.json');
@@ -26,44 +30,6 @@ const { version } = require('../package.json');
 const log = (msg) => process.stderr.write(msg + '\n');
 const output = (msg) => process.stdout.write(msg + '\n');
 
-/**
- * Truncates file data (diff and content) for display purposes
- * @param {Object} file - File object with path, status, diff, content, etc.
- * @param {number} maxLength - Maximum length before truncation (default: 500)
- * @returns {Object} File object with truncated diff and content
- */
-export function truncateFileData(file, maxLength = 500) {
-  return {
-    path: file.path,
-    status: file.status,
-    ...(file.old_path && { old_path: file.old_path }),
-    diff:
-      file.diff.length > maxLength
-        ? `${file.diff.substring(0, maxLength)}... [truncated ${file.diff.length - maxLength} chars]`
-        : file.diff,
-    content:
-      file.content.length > maxLength
-        ? `${file.content.substring(0, maxLength)}... [truncated ${file.content.length - maxLength} chars]`
-        : file.content,
-  };
-}
-
-/**
- * Formats error object for JSON output
- * @param {Error} error - Error object from axios or other source
- * @returns {Object} Formatted error output with success: false
- */
-export function formatErrorOutput(error) {
-  return {
-    success: false,
-    error: error.message,
-    ...(error.response && {
-      status: error.response.status,
-      data: error.response.data,
-    }),
-  };
-}
-
 /**
  * Ask for user confirmation before proceeding
  */
@@ -84,23 +50,6 @@ async function confirmAction(message) {
   });
 }
 
-/**
- * Detect CI provider from environment variables
- * @returns {string|null} Provider name or null if not detected
- */
-export function detectCIProvider() {
-  if (process.env.GITHUB_TOKEN && process.env.GITHUB_REPOSITORY) {
-    return 'github';
-  }
-  if (process.env.SYSTEM_ACCESSTOKEN && process.env.SYSTEM_PULLREQUEST_PULLREQUESTID) {
-    return 'azure';
-  }
-  if (process.env.BITBUCKET_REPO_SLUG && process.env.BITBUCKET_PR_ID) {
-    return 'bitbucket';
-  }
-  return null;
-}
-
 /**
  * Run the CI integration script to post comments
  * @param {string} provider - CI provider (github, azure, bitbucket)

package/src/utils.js

@@ -0,0 +1,54 @@
+/**
+ * Detect CI provider from environment variables
+ * @returns {string|null} Provider name or null if not detected
+ */
+export function detectCIProvider() {
+  if (process.env.GITHUB_TOKEN && process.env.GITHUB_REPOSITORY) {
+    return 'github';
+  }
+  if (process.env.SYSTEM_ACCESSTOKEN && process.env.SYSTEM_PULLREQUEST_PULLREQUESTID) {
+    return 'azure';
+  }
+  if (process.env.BITBUCKET_REPO_SLUG && process.env.BITBUCKET_PR_ID) {
+    return 'bitbucket';
+  }
+  return null;
+}
+
+/**
+ * Truncates file data (diff and content) for display purposes
+ * @param {Object} file - File object with path, status, diff, content, etc.
+ * @param {number} maxLength - Maximum length before truncation (default: 500)
+ * @returns {Object} File object with truncated diff and content
+ */
+export function truncateFileData(file, maxLength = 500) {
+  return {
+    path: file.path,
+    status: file.status,
+    ...(file.old_path && { old_path: file.old_path }),
+    diff:
+      file.diff.length > maxLength
+        ? `${file.diff.substring(0, maxLength)}... [truncated ${file.diff.length - maxLength} chars]`
+        : file.diff,
+    content:
+      file.content.length > maxLength
+        ? `${file.content.substring(0, maxLength)}... [truncated ${file.content.length - maxLength} chars]`
+        : file.content,
+  };
+}
+
+/**
+ * Formats error object for JSON output
+ * @param {Error} error - Error object from axios or other source
+ * @returns {Object} Formatted error output with success: false
+ */
+export function formatErrorOutput(error) {
+  return {
+    success: false,
+    error: error.message,
+    ...(error.response && {
+      status: error.response.status,
+      data: error.response.data,
+    }),
+  };
+}