komplian 0.3.4 → 0.3.6

package/komplian-onboard.mjs

@@ -18,6 +18,13 @@ import { homedir } from "node:os";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 
+/** Windows: sin esto, CreateProcess no resuelve gh.cmd / git.exe / npm.cmd como la consola. */
+const IS_WIN = process.platform === "win32";
+
+function spawnWin(extra = {}) {
+  return IS_WIN ? { ...extra, shell: true } : extra;
+}
+
 const c = {
   reset: "\x1b[0m",
   dim: "\x1b[2m",
@@ -51,10 +58,14 @@ function banner() {
 }
 
 function ghOk() {
-  const r = spawnSync("gh", ["auth", "status", "-h", "github.com"], {
-    encoding: "utf8",
-    stdio: ["ignore", "pipe", "pipe"],
-  });
+  const r = spawnSync(
+    "gh",
+    ["auth", "status", "-h", "github.com"],
+    spawnWin({
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "pipe"],
+    })
+  );
   return r.status === 0;
 }
 
@@ -65,23 +76,28 @@ function runGhAuth() {
   const r = spawnSync(
     "gh",
     ["auth", "login", "-h", "github.com", "-s", "repo", "-s", "read:org", "-w"],
-    { stdio: "inherit" }
+    spawnWin({ stdio: "inherit" })
   );
   return r.status === 0;
 }
 
 function ghApiJson(path) {
-  const r = spawnSync("gh", ["api", path], {
-    encoding: "utf8",
-    stdio: ["ignore", "pipe", "pipe"],
-  });
+  const r = spawnSync(
+    "gh",
+    ["api", path],
+    spawnWin({
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "pipe"],
+    })
+  );
   return { status: r.status, stdout: r.stdout || "", stderr: r.stderr || "" };
 }
 
 function verifyOrgMembership(org) {
   const enc = encodeURIComponent(org);
   const mem = ghApiJson(`user/memberships/orgs/${enc}`);
-  if (mem.status === 200) {
+  /** spawnSync().status = código de salida de `gh` (0 = éxito), no código HTTP. */
+  if (mem.status === 0) {
     try {
       const j = JSON.parse(mem.stdout);
       if (j.state === "active") return;
@@ -94,7 +110,8 @@ function verifyOrgMembership(org) {
       process.exit(1);
     }
   }
-  if (mem.status === 404) {
+  const hint = (mem.stderr + mem.stdout).toLowerCase();
+  if (hint.includes("404") || hint.includes("not found")) {
     log(
       `${c.red}✗${c.reset} Esta cuenta ${c.bold}no es miembro${c.reset} de la org ${c.bold}${org}${c.reset}.`
     );
@@ -103,21 +120,20 @@ function verifyOrgMembership(org) {
     );
     process.exit(1);
   }
-  const hint = (mem.stderr + mem.stdout).toLowerCase();
-  if (mem.status === 403 || hint.includes("read:org") || hint.includes("scope")) {
+  if (hint.includes("403") || hint.includes("read:org") || hint.includes("scope")) {
     log(`${c.red}✗${c.reset} Falta scope ${c.bold}read:org${c.reset} en gh.`);
     log(`${c.dim}  gh auth refresh -h github.com -s repo -s read:org${c.reset}`);
     process.exit(1);
   }
   log(
-    `${c.red}✗${c.reset} No se pudo verificar la org (${mem.status}):\n${c.dim}${(mem.stderr || mem.stdout).trim()}${c.reset}`
+    `${c.red}✗${c.reset} No se pudo verificar la org (código ${mem.status}):\n${c.dim}${(mem.stderr || mem.stdout).trim()}${c.reset}`
   );
   process.exit(1);
 }
 
 function logGhIdentity() {
   const u = ghApiJson("user");
-  if (u.status !== 200) return;
+  if (u.status !== 0) return;
   try {
     const j = JSON.parse(u.stdout);
     if (j.login) {
@@ -128,30 +144,26 @@ function logGhIdentity() {
   }
 }
 
-function cmdExists(name) {
-  const pathEnv = process.env.PATH || process.env.Path || "";
-  const isWin = process.platform === "win32";
-  const sep = isWin ? ";" : ":";
-  const dirs = pathEnv.split(sep).filter(Boolean);
-  const exts = isWin
-    ? ["", ...(process.env.PATHEXT || ".COM;.EXE;.BAT;.CMD").split(";")]
-    : [""];
-  for (const dir of dirs) {
-    for (const ext of exts) {
-      try {
-        const full = join(dir, name + ext);
-        if (existsSync(full) && statSync(full).isFile()) return true;
-      } catch {
-        continue;
-      }
-    }
-  }
-  return false;
+/** Misma resolución que los clones: en Windows hace falta shell para gh.cmd / git / npm. */
+function canRun(cmd, args) {
+  const r = spawnSync(cmd, args, spawnWin({ stdio: "ignore" }));
+  return r.status === 0 && !r.error;
 }
 
 function needCmd(name, hint = "") {
-  if (!cmdExists(name)) {
-    log(`${c.red}✗${c.reset} Falta ${c.bold}${name}${c.reset} en el PATH.${hint ? ` ${hint}` : ""}`);
+  const ok =
+    name === "gh"
+      ? canRun("gh", ["version"])
+      : name === "git"
+        ? canRun("git", ["--version"])
+        : canRun(name, ["--version"]);
+  if (!ok) {
+    log(`${c.red}✗${c.reset} No se puede ejecutar ${c.bold}${name}${c.reset} (¿PATH o instalación?).${hint ? ` ${hint}` : ""}`);
+    if (IS_WIN) {
+      log(
+        `${c.dim}  Windows: cierra y abre la terminal tras instalar gh/git, o reinicia para refrescar PATH.${c.reset}`
+      );
+    }
     process.exit(1);
   }
 }
@@ -164,7 +176,7 @@ function ghRepoList(org) {
   const r = spawnSync(
     "gh",
     ["repo", "list", org, "--limit", "1000", "--json", "name,isArchived,isFork"],
-    { encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] }
+    spawnWin({ encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] })
   );
   if (r.status !== 0) {
     log(`${c.red}✗${c.reset} gh repo list falló:\n${r.stderr || r.stdout}`);
@@ -246,9 +258,11 @@ function cloneOne(org, name, workspace, useSsh) {
     : ["repo", "clone", `${org}/${name}`, name];
   const cmd = useSsh ? "git" : "gh";
   const r = spawnSync(cmd, args, {
-    cwd: workspace,
-    encoding: "utf8",
-    stdio: ["ignore", "pipe", "pipe"],
+    ...spawnWin({
+      cwd: workspace,
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "pipe"],
+    }),
   });
   process.stdout.write("\r\x1b[K");
   if (r.status === 0) {
@@ -266,11 +280,15 @@ function copyCursorPack(workspace, cursorRepoUrl) {
     const tmp = join(workspace, ".cursor-bootstrap-tmp");
     rmSync(tmp, { recursive: true, force: true });
     log(`${c.dim}→${c.reset} Cursor pack (clone superficial)…`);
-    const r = spawnSync("git", ["clone", "--depth", "1", String(cursorRepoUrl).trim(), tmp], {
-      cwd: workspace,
-      stdio: ["ignore", "pipe", "pipe"],
-      encoding: "utf8",
-    });
+    const r = spawnSync(
+      "git",
+      ["clone", "--depth", "1", String(cursorRepoUrl).trim(), tmp],
+      spawnWin({
+        cwd: workspace,
+        stdio: ["ignore", "pipe", "pipe"],
+        encoding: "utf8",
+      })
+    );
     if (r.status === 0 && existsSync(join(tmp, ".cursor"))) {
       rmSync(rootCursor, { recursive: true, force: true });
       cpSync(join(tmp, ".cursor"), rootCursor, { recursive: true });
@@ -289,7 +307,7 @@ function copyCursorPack(workspace, cursorRepoUrl) {
 function npmInstallEach(workspace) {
   log("");
   log(`${c.cyan}━━ npm install por repo ━━${c.reset}`);
-  if (!cmdExists("npm")) {
+  if (!canRun("npm", ["--version"])) {
     log(`${c.yellow}○${c.reset} npm no está en PATH — omito installs`);
     return;
   }
@@ -299,7 +317,7 @@ function npmInstallEach(workspace) {
     const pkg = join(d, "package.json");
     if (!existsSync(pkg)) continue;
     log(`${c.dim}→${c.reset} ${ent}`);
-    const ir = spawnSync("npm", ["install"], { cwd: d, stdio: "inherit" });
+    const ir = spawnSync("npm", ["install"], spawnWin({ cwd: d, stdio: "inherit" }));
     if (ir.status !== 0) {
       log(`${c.yellow}○${c.reset} npm install con avisos en ${ent}`);
     } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "komplian",
-  "version": "0.3.4",
+  "version": "0.3.6",
   "description": "Komplian developer workspace setup: GitHub CLI (browser login) + git clone by team. Node 18+, git, gh — no OAuth App to register.",
   "type": "module",
   "engines": {