koffi 2.3.0-beta.1 → 2.3.0-beta.2

package/doc/callbacks.md

@@ -173,6 +173,10 @@ There is also an optional ending `length` argument that you can use in two cases
 - Use it to give the number of bytes to decode in non-NUL terminated strings: `koffi.decode(value, 'char *', 5)`
 - Decode consecutive values into an array. For example, here is how you can decode an array with 3 float values: `koffi.decode(value, 'float', 3)`. This is equivalent to `koffi.decode(value, koffi.array('float', 3))`.
 
+```{note}
+In Koffi 2.2 and earlier versions, the length argument is only used to decode strings and is ignored otherwise.
+```
+
 ## Asynchronous callbacks
 
 *New in Koffi 2.2.2*

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "koffi",
-    "version": "2.3.0-beta.1",
+    "version": "2.3.0-beta.2",
     "stable": "2.2.5",
     "description": "Fast and simple C FFI (foreign function interface) for Node.js",
     "keywords": [

package/src/koffi/src/call.cc

@@ -923,15 +923,17 @@ bool CallData::PushPointer(Napi::Value value, const TypeInfo *type, int directio
                     memset_safe(ptr, 0, size);
                 }
             } else if (IsRawBuffer(value)) {
-                Span<const uint8_t> buffer = GetRawBuffer(value);
+                Span<uint8_t> buffer = GetRawBuffer(value);
 
-                ptr = AllocHeap(buffer.len, 16);
+                if (directions == 1) {
+                    ptr = AllocHeap(buffer.len, 16);
 
-                if (directions & 1) {
                     if (!PushBuffer(buffer, buffer.len, type, ptr))
                         return false;
                 } else {
-                    memset_safe(ptr, 0, (size_t)buffer.len);
+                    // Fast no-copy path
+                    ptr = buffer.ptr;
+                    directions = 1;
                 }
             } else if (RG_LIKELY(type->ref.type->primitive == PrimitiveKind::Record)) {
                 Napi::Object obj = value.As<Napi::Object>();