koffi 2.16.0-beta.2 → 2.16.0

package/src/koffi/src/{abi/riscv64_asm.S → abi_riscv64_asm.S}

@@ -129,7 +129,9 @@ ForwardCallXDD:
 # ----------------------------
 
 .global RelayCallback
-.global CallSwitchStack
+.global SwitchAndRelay
+.global RelayDirect
+.global TrampolineEnd
 
 # First, make a copy of argument registers.
 # Then call the C function RelayCallback with the following arguments:
@@ -137,6 +139,12 @@ ForwardCallXDD:
 # arguments of this call, and a pointer to a struct that will contain the result registers.
 # After the call, simply load these registers from the output struct.
 .macro trampoline id
+    li t0, \id
+    j RelayTrampoline
+    .align 4
+.endm
+
+RelayTrampoline:
     addi sp, sp, -176
     sd ra, 0(sp)
     sd a0, 8(sp)
@@ -155,10 +163,8 @@ ForwardCallXDD:
     fsd fa5, 112(sp)
     fsd fa6, 120(sp)
     fsd fa7, 128(sp)
-    li a0, \id
+    mv a0, t0
     addi a1, sp, 8
-    addi a2, sp, 176
-    addi a3, sp, 136
     call RelayCallback
     ld ra, 0(sp)
     ld a0, 136(sp)
@@ -167,14 +173,13 @@ ForwardCallXDD:
     fld fa1, 160(sp)
     addi sp, sp, 176
     ret
-.endm
 
 # When a callback is relayed, Koffi will call into Node.js and V8 to execute Javascript.
 # The problem is that we're still running on the separate Koffi stack, and V8 will
 # probably misdetect this as a "stack overflow". We have to restore the old
 # stack pointer, call Node.js/V8 and go back to ours.
 # The first three parameters (a0, a1, a2) are passed through untouched.
-CallSwitchStack:
+SwitchAndRelay:
     addi sp, sp, -16
     sd ra, 0(sp)
     sd s1, 8(sp)
@@ -184,14 +189,15 @@ CallSwitchStack:
     andi t0, t0, -16
     sd t0, 8(a4)
     mv sp, a3
-    jalr a5
+    call RelayDirect
     mv sp, s1
     ld ra, 0(sp)
     ld s1, 8(sp)
     addi sp, sp, 16
     ret
 
-# Trampolines
-# ----------------------------
+.align 4
+#include "gnu.inc"
 
-#include "../trampolines/gnu.inc"
+TrampolineEnd:
+    ret

package/src/koffi/src/{abi/x64_sysv.cc → abi_x64_sysv.cc}

@@ -4,9 +4,9 @@
 #if defined(__x86_64__) && !defined(_WIN32)
 
 #include "lib/native/base/base.hh"
-#include "../ffi.hh"
-#include "../call.hh"
-#include "../util.hh"
+#include "ffi.hh"
+#include "call.hh"
+#include "util.hh"
 
 #include <napi.h>
 
@@ -55,9 +55,10 @@ extern "C" Xmm0RaxRet ForwardCallXDG(const void *func, uint8_t *sp, uint8_t **ou
 extern "C" RaxXmm0Ret ForwardCallXGD(const void *func, uint8_t *sp, uint8_t **out_old_sp);
 extern "C" Xmm0Xmm1Ret ForwardCallXDD(const void *func, uint8_t *sp, uint8_t **out_old_sp);
 
-extern "C" napi_value CallSwitchStack(Napi::Function *func, size_t argc, napi_value *argv,
-                                      uint8_t *old_sp, Span<uint8_t> *new_stack,
-                                      napi_value (*call)(Napi::Function *func, size_t argc, napi_value *argv));
+extern "C" uint8_t Trampoline0;
+extern "C" uint8_t TrampolineEnd;
+extern "C" void *FindTrampolineStart();
+extern "C" void *FindTrampolineEnd();
 
 static inline RegisterClass MergeClasses(RegisterClass cls1, RegisterClass cls2)
 {
@@ -223,226 +224,179 @@ bool AnalyseFunction(Napi::Env, InstanceData *, FunctionInfo *func)
 
 bool CallData::Prepare(const FunctionInfo *func, const Napi::CallbackInfo &info)
 {
-    uint64_t *gpr_ptr = AllocStack<uint64_t>(14 * 8 + func->args_size);
-    uint64_t *xmm_ptr = gpr_ptr + 6;
-    uint64_t *args_ptr = gpr_ptr + 14;
+    uint64_t *args_ptr = nullptr;
+    uint64_t *gpr_ptr = nullptr;
+    uint64_t *xmm_ptr = nullptr;
 
-    if (!gpr_ptr) [[unlikely]]
+    // Return through registers unless it's too big
+    if (!AllocStack(func->args_size, 16, &args_ptr)) [[unlikely]]
+        return false;
+    if (!AllocStack(8 * 8, 8, &xmm_ptr)) [[unlikely]]
+        return false;
+    if (!AllocStack(6 * 8, 8, &gpr_ptr)) [[unlikely]]
         return false;
     if (func->ret.use_memory) {
         return_ptr = AllocHeap(func->ret.type->size, 16);
         *(uint8_t **)(gpr_ptr++) = return_ptr;
     }
 
-    Size i = -1;
-
-    static const void *const DispatchTable[] = {
-        #define PRIMITIVE(Name) && Name,
-        #include "../primitives.inc"
-    };
-
-#define LOOP
-#define CASE(Primitive) \
-        do { \
-            PrimitiveKind next = func->primitives[++i]; \
-            goto *DispatchTable[(int)next]; \
-        } while (false); \
-        Primitive:
-#define OR(Primitive) \
-        Primitive:
-
 #define PUSH_INTEGER(CType) \
         do { \
-            const ParameterInfo &param = func->parameters[i]; \
-            Napi::Value value = info[param.offset]; \
-             \
-            CType v; \
-            if (!TryNumber(value, &v)) [[unlikely]] { \
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return false; \
             } \
              \
+            CType v = GetNumber<CType>(value); \
             *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)v; \
         } while (false)
 #define PUSH_INTEGER_SWAP(CType) \
         do { \
-            const ParameterInfo &param = func->parameters[i]; \
-            Napi::Value value = info[param.offset]; \
-             \
-            CType v; \
-            if (!TryNumber(value, &v)) [[unlikely]] { \
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return false; \
             } \
              \
+            CType v = GetNumber<CType>(value); \
             *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)ReverseBytes(v); \
         } while (false)
 
     // Push arguments
-    LOOP {
-        CASE(Void) { K_UNREACHABLE(); };
-
-        CASE(Bool) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
-
-            bool b;
-            if (napi_get_value_bool(env, value, &b) != napi_ok) [[unlikely]] {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected boolean", GetValueType(instance, value));
-                return false;
-            }
-
-            *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)b;
-        };
-
-        CASE(Int8) { PUSH_INTEGER(int8_t); };
-        CASE(UInt8) { PUSH_INTEGER(uint8_t); };
-        CASE(Int16) { PUSH_INTEGER(int16_t); };
-        CASE(Int16S) { PUSH_INTEGER_SWAP(int16_t); };
-        CASE(UInt16) { PUSH_INTEGER(uint16_t); };
-        CASE(UInt16S) { PUSH_INTEGER_SWAP(uint16_t); };
-        CASE(Int32) { PUSH_INTEGER(int32_t); };
-        CASE(Int32S) { PUSH_INTEGER_SWAP(int32_t); };
-        CASE(UInt32) { PUSH_INTEGER(uint32_t); };
-        CASE(UInt32S) { PUSH_INTEGER_SWAP(uint32_t); };
-        CASE(Int64) { PUSH_INTEGER(int64_t); };
-        CASE(Int64S) { PUSH_INTEGER_SWAP(int64_t); };
-        CASE(UInt64) { PUSH_INTEGER(int64_t); };
-        CASE(UInt64S) { PUSH_INTEGER_SWAP(int64_t); };
-
-        CASE(String) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
-
-            const char *str;
-            if (!PushString(value, param.directions, &str)) [[unlikely]]
-                return false;
-
-            *(const char **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str;
-        };
-        CASE(String16) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
-
-            const char16_t *str16;
-            if (!PushString16(value, param.directions, &str16)) [[unlikely]]
-                return false;
+    for (Size i = 0; i < func->parameters.len; i++) {
+        const ParameterInfo &param = func->parameters[i];
+        K_ASSERT(param.directions >= 1 && param.directions <= 3);
 
-            *(const char16_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str16;
-        };
-        CASE(String32) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
+        Napi::Value value = info[param.offset];
 
-            const char32_t *str32;
-            if (!PushString32(value, param.directions, &str32)) [[unlikely]]
-                return false;
+        switch (param.type->primitive) {
+            case PrimitiveKind::Void: { K_UNREACHABLE(); } break;
 
-            *(const char32_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str32;
-        };
+            case PrimitiveKind::Bool: {
+                if (!value.IsBoolean()) [[unlikely]] {
+                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value for argmument %2, expected boolean", GetValueType(instance, value));
+                    return false;
+                }
 
-        CASE(Pointer) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
+                bool b = value.As<Napi::Boolean>();
+                *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)b;
+            } break;
+            case PrimitiveKind::Int8: { PUSH_INTEGER(int8_t); } break;
+            case PrimitiveKind::UInt8: { PUSH_INTEGER(uint8_t); } break;
+            case PrimitiveKind::Int16: { PUSH_INTEGER(int16_t); } break;
+            case PrimitiveKind::Int16S: { PUSH_INTEGER_SWAP(int16_t); } break;
+            case PrimitiveKind::UInt16: { PUSH_INTEGER(uint16_t); } break;
+            case PrimitiveKind::UInt16S: { PUSH_INTEGER_SWAP(uint16_t); } break;
+            case PrimitiveKind::Int32: { PUSH_INTEGER(int32_t); } break;
+            case PrimitiveKind::Int32S: { PUSH_INTEGER_SWAP(int32_t); } break;
+            case PrimitiveKind::UInt32: { PUSH_INTEGER(uint32_t); } break;
+            case PrimitiveKind::UInt32S: { PUSH_INTEGER_SWAP(uint32_t); } break;
+            case PrimitiveKind::Int64: { PUSH_INTEGER(int64_t); } break;
+            case PrimitiveKind::Int64S: { PUSH_INTEGER_SWAP(int64_t); } break;
+            case PrimitiveKind::UInt64: { PUSH_INTEGER(uint64_t); } break;
+            case PrimitiveKind::UInt64S: { PUSH_INTEGER_SWAP(uint64_t); } break;
+            case PrimitiveKind::String: {
+                const char *str;
+                if (!PushString(value, param.directions, &str)) [[unlikely]]
+                    return false;
 
-            void *ptr;
-            if (!PushPointer(value, param.type, param.directions, &ptr)) [[unlikely]]
-                return false;
+                *(const char **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str;
+            } break;
+            case PrimitiveKind::String16: {
+                const char16_t *str16;
+                if (!PushString16(value, param.directions, &str16)) [[unlikely]]
+                    return false;
 
-            *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
-        };
+                *(const char16_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str16;
+            } break;
+            case PrimitiveKind::String32: {
+                const char32_t *str32;
+                if (!PushString32(value, param.directions, &str32)) [[unlikely]]
+                    return false;
 
-        CASE(Record) OR(Union) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
+                *(const char32_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str32;
+            } break;
+            case PrimitiveKind::Pointer: {
+                void *ptr;
+                if (!PushPointer(value, param.type, param.directions, &ptr)) [[unlikely]]
+                    return false;
 
-            if (!IsObject(value)) [[unlikely]] {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected object", GetValueType(instance, value));
-                return false;
-            }
+                *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
+            } break;
+            case PrimitiveKind::Record:
+            case PrimitiveKind::Union: {
+                if (!IsObject(value)) [[unlikely]] {
+                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected object", GetValueType(instance, value));
+                    return false;
+                }
 
-            Napi::Object obj = value.As<Napi::Object>();
+                Napi::Object obj = value.As<Napi::Object>();
 
-            if (param.gpr_count || param.xmm_count) {
-                K_ASSERT(param.type->size <= 16);
+                if (param.gpr_count || param.xmm_count) {
+                    K_ASSERT(param.type->size <= 16);
 
-                uint64_t buf[2] = {};
-                if (!PushObject(obj, param.type, (uint8_t *)buf))
-                    return false;
+                    uint64_t buf[2] = {};
+                    if (!PushObject(obj, param.type, (uint8_t *)buf))
+                        return false;
 
-                if (param.gpr_first) {
-                    *(gpr_ptr++) = buf[0];
-                    if (param.gpr_count == 2) {
-                        *(gpr_ptr++) = buf[1];
-                    } else if (param.xmm_count == 1) {
-                        *(xmm_ptr++) = buf[1];
-                    }
-                } else {
-                    *(xmm_ptr++) = buf[0];
-                    if (param.xmm_count == 2) {
-                        *(xmm_ptr++) = buf[1];
-                    } else if (param.gpr_count == 1) {
-                        *(gpr_ptr++) = buf[1];
+                    if (param.gpr_first) {
+                        *(gpr_ptr++) = buf[0];
+                        if (param.gpr_count == 2) {
+                            *(gpr_ptr++) = buf[1];
+                        } else if (param.xmm_count == 1) {
+                            *(xmm_ptr++) = buf[1];
+                        }
+                    } else {
+                        *(xmm_ptr++) = buf[0];
+                        if (param.xmm_count == 2) {
+                            *(xmm_ptr++) = buf[1];
+                        } else if (param.gpr_count == 1) {
+                            *(gpr_ptr++) = buf[1];
+                        }
                     }
+                } else if (param.use_memory) {
+                    args_ptr = AlignUp(args_ptr, param.type->align);
+                    if (!PushObject(obj, param.type, (uint8_t *)args_ptr))
+                        return false;
+                    args_ptr += (param.type->size + 7) / 8;
                 }
-            } else if (param.use_memory) {
-                args_ptr = AlignUp(args_ptr, param.type->align);
-                if (!PushObject(obj, param.type, (uint8_t *)args_ptr))
+            } break;
+            case PrimitiveKind::Array: { K_UNREACHABLE(); } break;
+            case PrimitiveKind::Float32: {
+                if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
+                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
                     return false;
-                args_ptr += (param.type->size + 7) / 8;
-            }
-        };
-        CASE(Array) { K_UNREACHABLE(); };
-
-        CASE(Float32) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
-
-            float f;
-            if (!TryNumber(value, &f)) [[unlikely]] {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
-                return false;
-            }
-
-            uint64_t *ptr = (param.xmm_count ? xmm_ptr : args_ptr)++;
-
-            memset((uint8_t *)ptr + 4, 0, 4);
-            *(float *)ptr = f;
-        };
-        CASE(Float64) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
-
-            double d;
-            if (!TryNumber(value, &d)) [[unlikely]] {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
-                return false;
-            }
+                }
 
-            *(double *)((param.xmm_count ? xmm_ptr : args_ptr)++) = d;
-        };
+                float f = GetNumber<float>(value);
+                uint64_t *ptr = (param.xmm_count ? xmm_ptr : args_ptr)++;
 
-        CASE(Callback) {
-            const ParameterInfo &param = func->parameters[i];
-            Napi::Value value = info[param.offset];
+                memset((uint8_t *)ptr + 4, 0, 4);
+                *(float *)ptr = f;
+            } break;
+            case PrimitiveKind::Float64: {
+                if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
+                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
+                    return false;
+                }
 
-            void *ptr;
-            if (!PushCallback(value, param.type, &ptr)) [[unlikely]]
-                return false;
+                double d = GetNumber<double>(value);
+                *(double *)((param.xmm_count ? xmm_ptr : args_ptr)++) = d;
+            } break;
+            case PrimitiveKind::Callback: {
+                void *ptr;
+                if (!PushCallback(value, param.type, &ptr)) [[unlikely]]
+                    return false;
 
-            *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
-        };
+                *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
+            } break;
 
-        CASE(Prototype) { /* End loop */ };
+            case PrimitiveKind::Prototype: { K_UNREACHABLE(); } break;
+        }
     }
 
 #undef PUSH_INTEGER_SWAP
 #undef PUSH_INTEGER
 
-#undef OR
-#undef CASE
-#undef LOOP
-
     new_sp = mem->stack.end();
 
     return true;
@@ -536,8 +490,17 @@ Napi::Value CallData::Complete(const FunctionInfo *func)
         case PrimitiveKind::String: return result.ptr ? Napi::String::New(env, (const char *)result.ptr) : env.Null();
         case PrimitiveKind::String16: return result.ptr ? Napi::String::New(env, (const char16_t *)result.ptr) : env.Null();
         case PrimitiveKind::String32: return result.ptr ? MakeStringFromUTF32(env, (const char32_t *)result.ptr) : env.Null();
-        case PrimitiveKind::Pointer: return result.ptr ? WrapPointer(env, func->ret.type->ref.type, result.ptr) : env.Null();
-        case PrimitiveKind::Callback: return result.ptr ? WrapCallback(env, func->ret.type->ref.type, result.ptr) : env.Null();
+        case PrimitiveKind::Pointer:
+        case PrimitiveKind::Callback: {
+            if (result.ptr) {
+                Napi::External<void> external = Napi::External<void>::New(env, result.ptr);
+                SetValueTag(external, func->ret.type->ref.marker);
+
+                return external;
+            } else {
+                return env.Null();
+            }
+        } break;
         case PrimitiveKind::Record:
         case PrimitiveKind::Union: {
             const uint8_t *ptr = return_ptr ? (const uint8_t *)return_ptr
@@ -556,8 +519,12 @@ Napi::Value CallData::Complete(const FunctionInfo *func)
     K_UNREACHABLE();
 }
 
-void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_stack, BackRegisters *out_reg)
+void CallData::Relay(Size idx, uint8_t *sp)
 {
+    uint8_t *own_sp = sp;
+    uint8_t *caller_sp = sp + 160;
+    BackRegisters *out_reg = (BackRegisters *)(sp + 112);
+
     if (env.IsExceptionPending()) [[unlikely]]
         return;
 
@@ -712,21 +679,18 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
                 Napi::Value arg = str32 ? MakeStringFromUTF32(env, str32) : env.Null();
                 arguments.Append(arg);
             } break;
-            case PrimitiveKind::Pointer: {
+            case PrimitiveKind::Pointer:
+            case PrimitiveKind::Callback: {
                 void *ptr2 = *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++);
 
-                Napi::Value p = ptr2 ? WrapPointer(env, param.type->ref.type, ptr2) : env.Null();
-                arguments.Append(p);
+                if (ptr2) {
+                    Napi::External<void> external = Napi::External<void>::New(env, ptr2);
+                    SetValueTag(external, param.type->ref.marker);
 
-                if (param.type->dispose) {
-                    param.type->dispose(env, param.type, ptr2);
+                    arguments.Append(external);
+                } else {
+                    arguments.Append(env.Null());
                 }
-            } break;
-            case PrimitiveKind::Callback: {
-                void *ptr2 = *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++);
-
-                Napi::Value p = ptr2 ? WrapCallback(env, param.type->ref.type, ptr2) : env.Null();
-                arguments.Append(p);
 
                 if (param.type->dispose) {
                     param.type->dispose(env, param.type, ptr2);
@@ -786,37 +750,30 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
 
     const TypeInfo *type = proto->ret.type;
 
-    // Make the call
-    napi_value ret;
-    if (switch_stack) {
-        ret = CallSwitchStack(&func, (size_t)arguments.len, arguments.data, old_sp, &mem->stack,
-                              [](Napi::Function *func, size_t argc, napi_value *argv) { return (napi_value)func->Call(argv[0], argc - 1, argv + 1); });
-    } else {
-        ret = (napi_value)func.Call(arguments[0], arguments.len - 1, arguments.data + 1);
-    }
-    Napi::Value value(env, ret);
+    // Make the call!
+    Napi::Value value = func.Call(arguments[0], arguments.len - 1, arguments.data + 1);
 
     if (env.IsExceptionPending()) [[unlikely]]
         return;
 
 #define RETURN_INTEGER(CType) \
         do { \
-            CType v; \
-            if (!TryNumber(value, &v)) [[unlikely]] { \
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return; \
             } \
              \
+            CType v = GetNumber<CType>(value); \
             out_reg->rax = (uint64_t)v; \
         } while (false)
 #define RETURN_INTEGER_SWAP(CType) \
         do { \
-            CType v; \
-            if (!TryNumber(value, &v)) [[unlikely]] { \
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return; \
             } \
              \
+            CType v = GetNumber<CType>(value); \
             out_reg->rax = (uint64_t)ReverseBytes(v); \
         } while (false)
 
@@ -824,12 +781,12 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
     switch (type->primitive) {
         case PrimitiveKind::Void: {} break;
         case PrimitiveKind::Bool: {
-            bool b;
-            if (napi_get_value_bool(env, value, &b) != napi_ok) [[unlikely]] {
+            if (!value.IsBoolean()) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected boolean", GetValueType(instance, value));
                 return;
             }
 
+            bool b = value.As<Napi::Boolean>();
             out_reg->rax = (uint64_t)b;
         } break;
         case PrimitiveKind::Int8: { RETURN_INTEGER(int8_t); } break;
@@ -868,9 +825,24 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
             out_reg->rax = (uint64_t)str32;
         } break;
         case PrimitiveKind::Pointer: {
-            void *ptr;
-            if (!PushPointer(value, type, 1, &ptr)) [[unlikely]]
+            uint8_t *ptr;
+
+            if (CheckValueTag(value, type->ref.marker)) {
+                ptr = value.As<Napi::External<uint8_t>>().Data();
+            } else if (IsObject(value) && (type->ref.type->primitive == PrimitiveKind::Record ||
+                                           type->ref.type->primitive == PrimitiveKind::Union)) {
+                Napi::Object obj = value.As<Napi::Object>();
+
+                ptr = AllocHeap(type->ref.type->size, 16);
+
+                if (!PushObject(obj, type->ref.type, ptr))
+                    return;
+            } else if (IsNullOrUndefined(value)) {
+                ptr = nullptr;
+            } else {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected %2", GetValueType(instance, value), type->name);
                 return;
+            }
 
             out_reg->rax = (uint64_t)ptr;
         } break;
@@ -911,28 +883,42 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
         } break;
         case PrimitiveKind::Array: { K_UNREACHABLE(); } break;
         case PrimitiveKind::Float32: {
-            float f;
-            if (!TryNumber(value, &f)) [[unlikely]] {
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
                 return;
             }
 
+            float f = GetNumber<float>(value);
+
             memset((uint8_t *)&out_reg->xmm0 + 4, 0, 4);
             memcpy(&out_reg->xmm0, &f, 4);
         } break;
         case PrimitiveKind::Float64: {
-            double d;
-            if (!TryNumber(value, &d)) [[unlikely]] {
+            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
                 return;
             }
 
+            double d = GetNumber<double>(value);
             out_reg->xmm0 = d;
         } break;
         case PrimitiveKind::Callback: {
             void *ptr;
-            if (!PushCallback(value, type, &ptr)) [[unlikely]]
+
+            if (value.IsFunction()) {
+                Napi::Function func2 = value.As<Napi::Function>();
+
+                ptr = ReserveTrampoline(type->ref.proto, func2);
+                if (!ptr) [[unlikely]]
+                    return;
+            } else if (CheckValueTag(value, type->ref.marker)) {
+                ptr = value.As<Napi::External<void>>().Data();
+            } else if (IsNullOrUndefined(value)) {
+                ptr = nullptr;
+            } else {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected %2", GetValueType(instance, value), type->name);
                 return;
+            }
 
             out_reg->rax = (uint64_t)ptr;
         } break;
@@ -946,6 +932,16 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
     err_guard.Disable();
 }
 
+void *FindTrampolineStart()
+{
+    return &Trampoline0;
+}
+
+void *FindTrampolineEnd()
+{
+    return &TrampolineEnd;
+}
+
 }
 
 #endif