koffi 2.15.1 → 2.16.0-beta.1

package/src/koffi/src/abi_riscv64.cc

@@ -52,8 +52,6 @@ extern "C" napi_value CallSwitchStack(Napi::Function *func, size_t argc, napi_va
                                       uint8_t *old_sp, Span<uint8_t> *new_stack,
                                       napi_value (*call)(Napi::Function *func, size_t argc, napi_value *argv));
 
-#include "trampolines/prototypes.inc"
-
 static inline void ExpandPair(const uint8_t raw[16], int size1, int size2, uint64_t out_regs[2])
 {
     memcpy(out_regs + 0, raw, size1);
@@ -150,213 +148,258 @@ bool AnalyseFunction(Napi::Env, InstanceData *, FunctionInfo *func)
 
 bool CallData::Prepare(const FunctionInfo *func, const Napi::CallbackInfo &info)
 {
-    uint64_t *args_ptr = nullptr;
-    uint64_t *gpr_ptr = nullptr;
-    uint64_t *vec_ptr = nullptr;
+    uint64_t *vec_ptr = AllocStack<uint64_t>(16 * 8 + func->args_size);
+    uint64_t *gpr_ptr = vec_ptr + 8;
+    uint64_t *args_ptr = vec_ptr + 16;
 
-    // Return through registers unless it's too big
-    if (!AllocStack(func->args_size, 16, &args_ptr)) [[unlikely]]
-        return false;
-    if (!AllocStack(8 * 8, 8, &gpr_ptr)) [[unlikely]]
-        return false;
-    if (!AllocStack(8 * 8, 8, &vec_ptr)) [[unlikely]]
+    if (!vec_ptr) [[unlikely]]
         return false;
     if (func->ret.use_memory) {
         return_ptr = AllocHeap(func->ret.type->size, 16);
         *(uint8_t **)(gpr_ptr++) = return_ptr;
     }
 
+    Size i = -1;
+
+    static const void *const DispatchTable[] = {
+        #define PRIMITIVE(Name) && Name,
+        #include "primitives.inc"
+    };
+
+#define LOOP
+#define CASE(Primitive) \
+        do { \
+            PrimitiveKind next = func->primitives[++i]; \
+            goto *DispatchTable[(int)next]; \
+        } while (false); \
+        Primitive:
+#define OR(Primitive) \
+        Primitive:
+
 #define PUSH_INTEGER(CType) \
         do { \
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
+            const ParameterInfo &param = func->parameters[i]; \
+            Napi::Value value = info[param.offset]; \
+             \
+            CType v; \
+            if (!TryNumber(value, &v)) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return false; \
             } \
              \
-            CType v = GetNumber<CType>(value); \
             *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)v; \
         } while (false)
 #define PUSH_INTEGER_SWAP(CType) \
         do { \
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
+            const ParameterInfo &param = func->parameters[i]; \
+            Napi::Value value = info[param.offset]; \
+             \
+            CType v; \
+            if (!TryNumber(value, &v)) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return false; \
             } \
              \
-            CType v = GetNumber<CType>(value); \
             *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)ReverseBytes(v); \
         } while (false)
 
     // Push arguments
-    for (Size i = 0; i < func->parameters.len; i++) {
-        const ParameterInfo &param = func->parameters[i];
-        K_ASSERT(param.directions >= 1 && param.directions <= 3);
+    LOOP {
+        CASE(Void) { K_UNREACHABLE(); };
 
-        Napi::Value value = info[param.offset];
+        CASE(Bool) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-        switch (param.type->primitive) {
-            case PrimitiveKind::Void: { K_UNREACHABLE(); } break;
+            bool b;
+            if (napi_get_value_bool(env, value, &b) != napi_ok) [[unlikely]] {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected boolean", GetValueType(instance, value));
+                return false;
+            }
 
-            case PrimitiveKind::Bool: {
-                if (!value.IsBoolean()) [[unlikely]] {
-                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected boolean", GetValueType(instance, value));
-                    return false;
-                }
+            *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)b;
+        };
+
+        CASE(Int8) { PUSH_INTEGER(int8_t); };
+        CASE(UInt8) { PUSH_INTEGER(uint8_t); };
+        CASE(Int16) { PUSH_INTEGER(int16_t); };
+        CASE(Int16S) { PUSH_INTEGER_SWAP(int16_t); };
+        CASE(UInt16) { PUSH_INTEGER(uint16_t); };
+        CASE(UInt16S) { PUSH_INTEGER_SWAP(uint16_t); };
+        CASE(Int32) { PUSH_INTEGER(int32_t); };
+        CASE(Int32S) { PUSH_INTEGER_SWAP(int32_t); };
+        CASE(UInt32) { PUSH_INTEGER(uint32_t); };
+        CASE(UInt32S) { PUSH_INTEGER_SWAP(uint32_t); };
+        CASE(Int64) { PUSH_INTEGER(int64_t); };
+        CASE(Int64S) { PUSH_INTEGER_SWAP(int64_t); };
+        CASE(UInt64) { PUSH_INTEGER(uint64_t); };
+        CASE(UInt64S) { PUSH_INTEGER_SWAP(uint64_t); };
+
+        CASE(String) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-                bool b = value.As<Napi::Boolean>();
-                *((param.gpr_count ? gpr_ptr : args_ptr)++) = (uint64_t)b;
-            } break;
-            case PrimitiveKind::Int8: { PUSH_INTEGER(int8_t); } break;
-            case PrimitiveKind::UInt8: { PUSH_INTEGER(uint8_t); } break;
-            case PrimitiveKind::Int16: { PUSH_INTEGER(int16_t); } break;
-            case PrimitiveKind::Int16S: { PUSH_INTEGER_SWAP(int16_t); } break;
-            case PrimitiveKind::UInt16: { PUSH_INTEGER(uint16_t); } break;
-            case PrimitiveKind::UInt16S: { PUSH_INTEGER_SWAP(uint16_t); } break;
-            case PrimitiveKind::Int32: { PUSH_INTEGER(int32_t); } break;
-            case PrimitiveKind::Int32S: { PUSH_INTEGER_SWAP(int32_t); } break;
-            case PrimitiveKind::UInt32: { PUSH_INTEGER(uint32_t); } break;
-            case PrimitiveKind::UInt32S: { PUSH_INTEGER_SWAP(uint32_t); } break;
-            case PrimitiveKind::Int64: { PUSH_INTEGER(int64_t); } break;
-            case PrimitiveKind::Int64S: { PUSH_INTEGER_SWAP(int64_t); } break;
-            case PrimitiveKind::UInt64: { PUSH_INTEGER(uint64_t); } break;
-            case PrimitiveKind::UInt64S: { PUSH_INTEGER_SWAP(uint64_t); } break;
-            case PrimitiveKind::String: {
-                const char *str;
-                if (!PushString(value, param.directions, &str)) [[unlikely]]
-                    return false;
+            const char *str;
+            if (!PushString(value, param.directions, &str)) [[unlikely]]
+                return false;
 
-                *(const char **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str;
-            } break;
-            case PrimitiveKind::String16: {
-                const char16_t *str16;
-                if (!PushString16(value, param.directions, &str16)) [[unlikely]]
-                    return false;
+            *(const char **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str;
+        };
+        CASE(String16) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-                *(const char16_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str16;
-            } break;
-            case PrimitiveKind::String32: {
-                const char32_t *str32;
-                if (!PushString32(value, param.directions, &str32)) [[unlikely]]
-                    return false;
+            const char16_t *str16;
+            if (!PushString16(value, param.directions, &str16)) [[unlikely]]
+                return false;
 
-                *(const char32_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str32;
-            } break;
-            case PrimitiveKind::Pointer: {
-                void *ptr;
-                if (!PushPointer(value, param.type, param.directions, &ptr)) [[unlikely]]
-                    return false;
+            *(const char16_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str16;
+        };
+        CASE(String32) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-                *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
-            } break;
-            case PrimitiveKind::Record:
-            case PrimitiveKind::Union: {
-                if (!IsObject(value)) [[unlikely]] {
-                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected object", GetValueType(instance, value));
-                    return false;
-                }
+            const char32_t *str32;
+            if (!PushString32(value, param.directions, &str32)) [[unlikely]]
+                return false;
 
-                Napi::Object obj = value.As<Napi::Object>();
+            *(const char32_t **)((param.gpr_count ? gpr_ptr : args_ptr)++) = str32;
+        };
 
-                if (!param.use_memory) {
-                    K_ASSERT(param.type->size <= 16);
-
-                    uint64_t regs[2] = { 0xFFFFFFFFFFFFFFFFull, 0xFFFFFFFFFFFFFFFFull };
-                    {
-                        uint8_t buf[16] = {};
-                        if (!PushObject(obj, param.type, buf))
-                            return false;
-                        ExpandPair(buf, param.reg_size[0], param.reg_size[1], regs);
-                    }
+        CASE(Pointer) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-                    if (param.gpr_first) {
-                        *(gpr_ptr++) = regs[0];
-                        if (param.gpr_count == 2) {
-                            *(gpr_ptr++) = regs[1];
-                        } else if (param.vec_count == 1) {
-                            *(vec_ptr++) = regs[1];
-                        }
-
-                        args_ptr = std::max(gpr_ptr, args_ptr);
-                    } else if (param.vec_count) {
-                        *(vec_ptr++) = regs[0];
-                        if (param.vec_count == 2) {
-                            *(vec_ptr++) = regs[1];
-                        } else if (param.gpr_count == 1) {
-                            *(gpr_ptr++) = regs[1];
-                        }
-                    } else {
-                        K_ASSERT(param.type->align <= 8);
+            void *ptr;
+            if (!PushPointer(value, param.type, param.directions, &ptr)) [[unlikely]]
+                return false;
 
-                        MemCpy(args_ptr, regs, param.type->size);
-                        args_ptr += (param.type->size + 7) / 8;
-                    }
-                } else {
-                    uint8_t *ptr = AllocHeap(param.type->size, 16);
+            *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
+        };
 
-                    if (param.gpr_count) {
-                        K_ASSERT(param.gpr_count == 1);
-                        K_ASSERT(param.vec_count == 0);
+        CASE(Record) OR(Union) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-                        *(uint8_t **)(gpr_ptr++) = ptr;
-                    } else {
-                        *(uint8_t **)(args_ptr++) = ptr;
-                    }
+            if (!IsObject(value)) [[unlikely]] {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected object", GetValueType(instance, value));
+                return false;
+            }
 
-                    if (!PushObject(obj, param.type, ptr))
+            Napi::Object obj = value.As<Napi::Object>();
+
+            if (!param.use_memory) {
+                K_ASSERT(param.type->size <= 16);
+
+                uint64_t regs[2] = { 0xFFFFFFFFFFFFFFFFull, 0xFFFFFFFFFFFFFFFFull };
+                {
+                    uint8_t buf[16] = {};
+                    if (!PushObject(obj, param.type, buf))
                         return false;
-                }
-            } break;
-            case PrimitiveKind::Array: { K_UNREACHABLE(); } break;
-            case PrimitiveKind::Float32: {
-                if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
-                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
-                    return false;
+                    ExpandPair(buf, param.reg_size[0], param.reg_size[1], regs);
                 }
 
-                float f = GetNumber<float>(value);
+                if (param.gpr_first) {
+                    *(gpr_ptr++) = regs[0];
+                    if (param.gpr_count == 2) {
+                        *(gpr_ptr++) = regs[1];
+                    } else if (param.vec_count == 1) {
+                        *(vec_ptr++) = regs[1];
+                    }
 
-                if (param.vec_count) [[likely]] {
-                    memset((uint8_t *)vec_ptr + 4, 0xFF, 4);
-                    *(float *)(vec_ptr++) = f;
-                } else if (param.gpr_count) {
-                    memset((uint8_t *)gpr_ptr + 4, 0xFF, 4);
-                    *(float *)(gpr_ptr++) = f;
+                    args_ptr = std::max(gpr_ptr, args_ptr);
+                } else if (param.vec_count) {
+                    *(vec_ptr++) = regs[0];
+                    if (param.vec_count == 2) {
+                        *(vec_ptr++) = regs[1];
+                    } else if (param.gpr_count == 1) {
+                        *(gpr_ptr++) = regs[1];
+                    }
                 } else {
-                    memset(args_ptr, 0xFF, 8);
-                    *(float *)(args_ptr++) = f;
-                }
-            } break;
-            case PrimitiveKind::Float64: {
-                if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
-                    ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
-                    return false;
+                    K_ASSERT(param.type->align <= 8);
+
+                    MemCpy(args_ptr, regs, param.type->size);
+                    args_ptr += (param.type->size + 7) / 8;
                 }
+            } else {
+                uint8_t *ptr = AllocHeap(param.type->size, 16);
 
-                double d = GetNumber<double>(value);
+                if (param.gpr_count) {
+                    K_ASSERT(param.gpr_count == 1);
+                    K_ASSERT(param.vec_count == 0);
 
-                if (param.vec_count) [[likely]] {
-                    *(double *)(vec_ptr++) = d;
-                } else if (param.gpr_count) {
-                    *(double *)(gpr_ptr++) = d;
+                    *(uint8_t **)(gpr_ptr++) = ptr;
                 } else {
-                    *(double *)(args_ptr++) = d;
+                    *(uint8_t **)(args_ptr++) = ptr;
                 }
-            } break;
-            case PrimitiveKind::Callback: {
-                void *ptr;
-                if (!PushCallback(value, param.type, &ptr)) [[unlikely]]
+
+                if (!PushObject(obj, param.type, ptr))
                     return false;
+            }
+        };
+        CASE(Array) { K_UNREACHABLE(); };
 
-                *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
-            } break;
+        CASE(Float32) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
 
-            case PrimitiveKind::Prototype: { K_UNREACHABLE(); } break;
-        }
+            float f;
+            if (!TryNumber(value, &f)) [[unlikely]] {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
+                return false;
+            }
+
+            if (param.vec_count) [[likely]] {
+                memset((uint8_t *)vec_ptr + 4, 0xFF, 4);
+                *(float *)(vec_ptr++) = f;
+            } else if (param.gpr_count) {
+                memset((uint8_t *)gpr_ptr + 4, 0xFF, 4);
+                *(float *)(gpr_ptr++) = f;
+            } else {
+                memset(args_ptr, 0xFF, 8);
+                *(float *)(args_ptr++) = f;
+            }
+        };
+        CASE(Float64) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
+
+            double d;
+            if (!TryNumber(value, &d)) [[unlikely]] {
+                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
+                return false;
+            }
+
+            if (param.vec_count) [[likely]] {
+                *(double *)(vec_ptr++) = d;
+            } else if (param.gpr_count) {
+                *(double *)(gpr_ptr++) = d;
+            } else {
+                *(double *)(args_ptr++) = d;
+            }
+        };
+
+        CASE(Callback) {
+            const ParameterInfo &param = func->parameters[i];
+            Napi::Value value = info[param.offset];
+
+            void *ptr;
+            if (!PushCallback(value, param.type, &ptr)) [[unlikely]]
+                return false;
+
+            *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++) = ptr;
+        };
+
+        CASE(Prototype) { /* End loop */ };
     }
 
 #undef PUSH_INTEGER_SWAP
 #undef PUSH_INTEGER
 
+#undef OR
+#undef CASE
+#undef LOOP
+
     new_sp = mem->stack.end();
 
     return true;
@@ -450,17 +493,8 @@ Napi::Value CallData::Complete(const FunctionInfo *func)
         case PrimitiveKind::String: return result.ptr ? Napi::String::New(env, (const char *)result.ptr) : env.Null();
         case PrimitiveKind::String16: return result.ptr ? Napi::String::New(env, (const char16_t *)result.ptr) : env.Null();
         case PrimitiveKind::String32: return result.ptr ? MakeStringFromUTF32(env, (const char32_t *)result.ptr) : env.Null();
-        case PrimitiveKind::Pointer:
-        case PrimitiveKind::Callback: {
-            if (result.ptr) {
-                Napi::External<void> external = Napi::External<void>::New(env, result.ptr);
-                SetValueTag(external, func->ret.type->ref.marker);
-
-                return external;
-            } else {
-                return env.Null();
-            }
-        } break;
+        case PrimitiveKind::Pointer: return result.ptr ? WrapPointer(env, func->ret.type->ref.type, result.ptr) : env.Null();
+        case PrimitiveKind::Callback: return result.ptr ? WrapCallback(env, func->ret.type->ref.type, result.ptr) : env.Null();
         case PrimitiveKind::Record:
         case PrimitiveKind::Union: {
             if (return_ptr) {
@@ -640,18 +674,21 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
                 Napi::Value arg = str32 ? MakeStringFromUTF32(env, str32) : env.Null();
                 arguments.Append(arg);
             } break;
-            case PrimitiveKind::Pointer:
-            case PrimitiveKind::Callback: {
+            case PrimitiveKind::Pointer: {
                 void *ptr2 = *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++);
 
-                if (ptr2) {
-                    Napi::External<void> external = Napi::External<void>::New(env, ptr2);
-                    SetValueTag(external, param.type->ref.marker);
+                Napi::Value p = ptr2 ? WrapPointer(env, param.type->ref.type, ptr2) : env.Null();
+                arguments.Append(p);
 
-                    arguments.Append(external);
-                } else {
-                    arguments.Append(env.Null());
+                if (param.type->dispose) {
+                    param.type->dispose(env, param.type, ptr2);
                 }
+            } break;
+            case PrimitiveKind::Callback: {
+                void *ptr2 = *(void **)((param.gpr_count ? gpr_ptr : args_ptr)++);
+
+                Napi::Value p = ptr2 ? WrapCallback(env, param.type->ref.type, ptr2) : env.Null();
+                arguments.Append(p);
 
                 if (param.type->dispose) {
                     param.type->dispose(env, param.type, ptr2);
@@ -737,22 +774,22 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
 
 #define RETURN_INTEGER(CType) \
         do { \
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
+            CType v; \
+            if (!TryNumber(value, &v)) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return; \
             } \
              \
-            CType v = GetNumber<CType>(value); \
             out_reg->a0 = (uint64_t)v; \
         } while (false)
 #define RETURN_INTEGER_SWAP(CType) \
         do { \
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] { \
+            CType v; \
+            if (!TryNumber(value, &v)) [[unlikely]] { \
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value)); \
                 return; \
             } \
              \
-            CType v = GetNumber<CType>(value); \
             out_reg->a0 = (uint64_t)ReverseBytes(v); \
         } while (false)
 
@@ -760,12 +797,12 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
     switch (type->primitive) {
         case PrimitiveKind::Void: {} break;
         case PrimitiveKind::Bool: {
-            if (!value.IsBoolean()) [[unlikely]] {
+            bool b;
+            if (napi_get_value_bool(env, value, &b) != napi_ok) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected boolean", GetValueType(instance, value));
                 return;
             }
 
-            bool b = value.As<Napi::Boolean>();
             out_reg->a0 = (uint64_t)b;
         } break;
         case PrimitiveKind::Int8: { RETURN_INTEGER(int8_t); } break;
@@ -804,24 +841,9 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
             out_reg->a0 = (uint64_t)str32;
         } break;
         case PrimitiveKind::Pointer: {
-            uint8_t *ptr;
-
-            if (CheckValueTag(value, type->ref.marker)) {
-                ptr = value.As<Napi::External<uint8_t>>().Data();
-            } else if (IsObject(value) && (type->ref.type->primitive == PrimitiveKind::Record ||
-                                           type->ref.type->primitive == PrimitiveKind::Union)) {
-                Napi::Object obj = value.As<Napi::Object>();
-
-                ptr = AllocHeap(type->ref.type->size, 16);
-
-                if (!PushObject(obj, type->ref.type, ptr))
-                    return;
-            } else if (IsNullOrUndefined(value)) {
-                ptr = nullptr;
-            } else {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected %2", GetValueType(instance, value), type->name);
+            void *ptr;
+            if (!PushPointer(value, type, 1, &ptr)) [[unlikely]]
                 return;
-            }
 
             out_reg->a0 = (uint64_t)ptr;
         } break;
@@ -864,41 +886,28 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
         } break;
         case PrimitiveKind::Array: { K_UNREACHABLE(); } break;
         case PrimitiveKind::Float32: {
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
+            float f;
+            if (!TryNumber(value, &f)) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
                 return;
             }
 
-            float f = GetNumber<float>(value);
             memset((uint8_t *)&out_reg->fa0 + 4, 0xFF, 4);
             memcpy(&out_reg->fa0, &f, 4);
         } break;
         case PrimitiveKind::Float64: {
-            if (!value.IsNumber() && !value.IsBigInt()) [[unlikely]] {
+            double d;
+            if (!TryNumber(value, &d)) [[unlikely]] {
                 ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected number", GetValueType(instance, value));
                 return;
             }
 
-            double d = GetNumber<double>(value);
             out_reg->fa0 = d;
         } break;
         case PrimitiveKind::Callback: {
             void *ptr;
-
-            if (value.IsFunction()) {
-                Napi::Function func2 = value.As<Napi::Function>();
-
-                ptr = ReserveTrampoline(type->ref.proto, func2);
-                if (!ptr) [[unlikely]]
-                    return;
-            } else if (CheckValueTag(value, type->ref.marker)) {
-                ptr = value.As<Napi::External<void>>().Data();
-            } else if (IsNullOrUndefined(value)) {
-                ptr = nullptr;
-            } else {
-                ThrowError<Napi::TypeError>(env, "Unexpected %1 value, expected %2", GetValueType(instance, value), type->name);
+            if (!PushCallback(value, type, &ptr)) [[unlikely]]
                 return;
-            }
 
             out_reg->a0 = (uint64_t)ptr;
         } break;
@@ -912,12 +921,6 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, bool switch_
     err_guard.Disable();
 }
 
-void *GetTrampoline(int16_t idx, const FunctionInfo *proto)
-{
-    bool fp = proto->forward_fp || proto->ret.vec_count;
-    return Trampolines[idx][fp];
-}
-
 }
 
 #endif

package/src/koffi/src/abi_riscv64_asm.S

@@ -131,36 +131,12 @@ ForwardCallXDD:
 .global RelayCallback
 .global CallSwitchStack
 
-# First, make a copy of the GPR argument registers (a0 to a7).
+# First, make a copy of argument registers.
 # Then call the C function RelayCallback with the following arguments:
 # static trampoline ID, a pointer to the saved GPR array, a pointer to the stack
 # arguments of this call, and a pointer to a struct that will contain the result registers.
 # After the call, simply load these registers from the output struct.
 .macro trampoline id
-    addi sp, sp, -176
-    sd ra, 0(sp)
-    sd a0, 8(sp)
-    sd a1, 16(sp)
-    sd a2, 24(sp)
-    sd a3, 32(sp)
-    sd a4, 40(sp)
-    sd a5, 48(sp)
-    sd a6, 56(sp)
-    sd a7, 64(sp)
-    li a0, \id
-    addi a1, sp, 8
-    addi a2, sp, 176
-    addi a3, sp, 136
-    call RelayCallback
-    ld ra, 0(sp)
-    ld a0, 136(sp)
-    ld a1, 144(sp)
-    addi sp, sp, 176
-    ret
-.endm
-
-# Same thing, but also forwards the floating-point argument registers and loads them at the end.
-.macro trampoline_vec id
     addi sp, sp, -176
     sd ra, 0(sp)
     sd a0, 8(sp)