koffi 1.3.10 → 2.0.0

package/src/abi_x64_sysv_fwd.S

@@ -171,6 +171,22 @@ SYMBOL(ForwardCallXDD):
 .global SYMBOL(Trampoline13)
 .global SYMBOL(Trampoline14)
 .global SYMBOL(Trampoline15)
+.global SYMBOL(Trampoline16)
+.global SYMBOL(Trampoline17)
+.global SYMBOL(Trampoline18)
+.global SYMBOL(Trampoline19)
+.global SYMBOL(Trampoline20)
+.global SYMBOL(Trampoline21)
+.global SYMBOL(Trampoline22)
+.global SYMBOL(Trampoline23)
+.global SYMBOL(Trampoline24)
+.global SYMBOL(Trampoline25)
+.global SYMBOL(Trampoline26)
+.global SYMBOL(Trampoline27)
+.global SYMBOL(Trampoline28)
+.global SYMBOL(Trampoline29)
+.global SYMBOL(Trampoline30)
+.global SYMBOL(Trampoline31)
 .global SYMBOL(TrampolineX0)
 .global SYMBOL(TrampolineX1)
 .global SYMBOL(TrampolineX2)
@@ -187,6 +203,22 @@ SYMBOL(ForwardCallXDD):
 .global SYMBOL(TrampolineX13)
 .global SYMBOL(TrampolineX14)
 .global SYMBOL(TrampolineX15)
+.global SYMBOL(TrampolineX16)
+.global SYMBOL(TrampolineX17)
+.global SYMBOL(TrampolineX18)
+.global SYMBOL(TrampolineX19)
+.global SYMBOL(TrampolineX20)
+.global SYMBOL(TrampolineX21)
+.global SYMBOL(TrampolineX22)
+.global SYMBOL(TrampolineX23)
+.global SYMBOL(TrampolineX24)
+.global SYMBOL(TrampolineX25)
+.global SYMBOL(TrampolineX26)
+.global SYMBOL(TrampolineX27)
+.global SYMBOL(TrampolineX28)
+.global SYMBOL(TrampolineX29)
+.global SYMBOL(TrampolineX30)
+.global SYMBOL(TrampolineX31)
 .global SYMBOL(RelayCallback)
 .global SYMBOL(CallSwitchStack)
 
@@ -296,6 +328,38 @@ SYMBOL(Trampoline14):
     trampoline 14
 SYMBOL(Trampoline15):
     trampoline 15
+SYMBOL(Trampoline16):
+    trampoline 16
+SYMBOL(Trampoline17):
+    trampoline 17
+SYMBOL(Trampoline18):
+    trampoline 18
+SYMBOL(Trampoline19):
+    trampoline 19
+SYMBOL(Trampoline20):
+    trampoline 20
+SYMBOL(Trampoline21):
+    trampoline 21
+SYMBOL(Trampoline22):
+    trampoline 22
+SYMBOL(Trampoline23):
+    trampoline 23
+SYMBOL(Trampoline24):
+    trampoline 24
+SYMBOL(Trampoline25):
+    trampoline 25
+SYMBOL(Trampoline26):
+    trampoline 26
+SYMBOL(Trampoline27):
+    trampoline 27
+SYMBOL(Trampoline28):
+    trampoline 28
+SYMBOL(Trampoline29):
+    trampoline 29
+SYMBOL(Trampoline30):
+    trampoline 30
+SYMBOL(Trampoline31):
+    trampoline 31
 
 SYMBOL(TrampolineX0):
     trampoline_xmm 0
@@ -329,6 +393,38 @@ SYMBOL(TrampolineX14):
     trampoline_xmm 14
 SYMBOL(TrampolineX15):
     trampoline_xmm 15
+SYMBOL(TrampolineX16):
+    trampoline_xmm 16
+SYMBOL(TrampolineX17):
+    trampoline_xmm 17
+SYMBOL(TrampolineX18):
+    trampoline_xmm 18
+SYMBOL(TrampolineX19):
+    trampoline_xmm 19
+SYMBOL(TrampolineX20):
+    trampoline_xmm 20
+SYMBOL(TrampolineX21):
+    trampoline_xmm 21
+SYMBOL(TrampolineX22):
+    trampoline_xmm 22
+SYMBOL(TrampolineX23):
+    trampoline_xmm 23
+SYMBOL(TrampolineX24):
+    trampoline_xmm 24
+SYMBOL(TrampolineX25):
+    trampoline_xmm 25
+SYMBOL(TrampolineX26):
+    trampoline_xmm 26
+SYMBOL(TrampolineX27):
+    trampoline_xmm 27
+SYMBOL(TrampolineX28):
+    trampoline_xmm 28
+SYMBOL(TrampolineX29):
+    trampoline_xmm 29
+SYMBOL(TrampolineX30):
+    trampoline_xmm 30
+SYMBOL(TrampolineX31):
+    trampoline_xmm 31
 
 # When a callback is relayed, Koffi will call into Node.js and V8 to execute Javascript.
 # The problem is that we're still running on the separate Koffi stack, and V8 will

package/src/abi_x64_win.cc

@@ -50,6 +50,22 @@ extern "C" int Trampoline12; extern "C" int TrampolineX12;
 extern "C" int Trampoline13; extern "C" int TrampolineX13;
 extern "C" int Trampoline14; extern "C" int TrampolineX14;
 extern "C" int Trampoline15; extern "C" int TrampolineX15;
+extern "C" int Trampoline16; extern "C" int TrampolineX16;
+extern "C" int Trampoline17; extern "C" int TrampolineX17;
+extern "C" int Trampoline18; extern "C" int TrampolineX18;
+extern "C" int Trampoline19; extern "C" int TrampolineX19;
+extern "C" int Trampoline20; extern "C" int TrampolineX20;
+extern "C" int Trampoline21; extern "C" int TrampolineX21;
+extern "C" int Trampoline22; extern "C" int TrampolineX22;
+extern "C" int Trampoline23; extern "C" int TrampolineX23;
+extern "C" int Trampoline24; extern "C" int TrampolineX24;
+extern "C" int Trampoline25; extern "C" int TrampolineX25;
+extern "C" int Trampoline26; extern "C" int TrampolineX26;
+extern "C" int Trampoline27; extern "C" int TrampolineX27;
+extern "C" int Trampoline28; extern "C" int TrampolineX28;
+extern "C" int Trampoline29; extern "C" int TrampolineX29;
+extern "C" int Trampoline30; extern "C" int TrampolineX30;
+extern "C" int Trampoline31; extern "C" int TrampolineX31;
 
 extern "C" napi_value CallSwitchStack(Napi::Function *func, size_t argc, napi_value *argv,
                                       uint8_t *old_sp, Span<uint8_t> *new_stack,
@@ -71,9 +87,25 @@ static void *const Trampolines[][2] = {
     { &Trampoline12, &TrampolineX12 },
     { &Trampoline13, &TrampolineX13 },
     { &Trampoline14, &TrampolineX14 },
-    { &Trampoline15, &TrampolineX15 }
+    { &Trampoline15, &TrampolineX15 },
+    { &Trampoline16, &TrampolineX16 },
+    { &Trampoline17, &TrampolineX17 },
+    { &Trampoline18, &TrampolineX18 },
+    { &Trampoline19, &TrampolineX19 },
+    { &Trampoline20, &TrampolineX20 },
+    { &Trampoline21, &TrampolineX21 },
+    { &Trampoline22, &TrampolineX22 },
+    { &Trampoline23, &TrampolineX23 },
+    { &Trampoline24, &TrampolineX24 },
+    { &Trampoline25, &TrampolineX25 },
+    { &Trampoline26, &TrampolineX26 },
+    { &Trampoline27, &TrampolineX27 },
+    { &Trampoline28, &TrampolineX28 },
+    { &Trampoline29, &TrampolineX29 },
+    { &Trampoline30, &TrampolineX30 },
+    { &Trampoline31, &TrampolineX31 }
 };
-RG_STATIC_ASSERT(RG_LEN(Trampolines) == MaxTrampolines);
+RG_STATIC_ASSERT(RG_LEN(Trampolines) == MaxTrampolines * 2);
 
 static RG_THREAD_LOCAL CallData *exec_call;
 
@@ -235,10 +267,10 @@ bool CallData::Prepare(const Napi::CallbackInfo &info)
                 if (value.IsFunction()) {
                     Napi::Function func = value.As<Napi::Function>();
 
-                    ptr = ReserveTrampoline(param.type->proto, func);
+                    ptr = ReserveTrampoline(param.type->ref.proto, func);
                     if (RG_UNLIKELY(!ptr))
                         return false;
-                } else if (CheckValueTag(instance, value, param.type)) {
+                } else if (CheckValueTag(instance, value, param.type->ref.marker)) {
                     ptr = value.As<Napi::External<uint8_t>>().Data();
                 } else if (IsNullOrUndefined(value)) {
                     ptr = nullptr;
@@ -249,6 +281,8 @@ bool CallData::Prepare(const Napi::CallbackInfo &info)
 
                 *(void **)(args_ptr++) = ptr;
             } break;
+
+            case PrimitiveKind::Prototype: { RG_UNREACHABLE(); } break;
         }
     }
 
@@ -287,6 +321,8 @@ void CallData::Execute()
         case PrimitiveKind::Array: { RG_UNREACHABLE(); } break;
         case PrimitiveKind::Float32: { result.f = PERFORM_CALL(F); } break;
         case PrimitiveKind::Float64: { result.d = PERFORM_CALL(D); } break;
+
+        case PrimitiveKind::Prototype: { RG_UNREACHABLE(); } break;
     }
 
 #undef PERFORM_CALL
@@ -294,7 +330,13 @@ void CallData::Execute()
 
 Napi::Value CallData::Complete()
 {
-    PopOutArguments();
+    RG_DEFER {
+       PopOutArguments();
+
+        if (func->ret.type->dispose) {
+            func->ret.type->dispose(env, func->ret.type, result.ptr);
+        }
+    };
 
     switch (func->ret.type->primitive) {
         case PrimitiveKind::Void: return env.Null();
@@ -313,7 +355,7 @@ Napi::Value CallData::Complete()
         case PrimitiveKind::Callback: {
             if (result.ptr) {
                 Napi::External<void> external = Napi::External<void>::New(env, result.ptr);
-                SetValueTag(instance, external, func->ret.type);
+                SetValueTag(instance, external, func->ret.type->ref.marker);
 
                 return external;
             } else {
@@ -330,6 +372,8 @@ Napi::Value CallData::Complete()
         case PrimitiveKind::Array: { RG_UNREACHABLE(); } break;
         case PrimitiveKind::Float32: return Napi::Number::New(env, (double)result.f);
         case PrimitiveKind::Float64: return Napi::Number::New(env, result.d);
+
+        case PrimitiveKind::Prototype: { RG_UNREACHABLE(); } break;
     }
 
     RG_UNREACHABLE();
@@ -337,12 +381,10 @@ Napi::Value CallData::Complete()
 
 void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegisters *out_reg)
 {
-    const TrampolineInfo &trampoline = instance->trampolines[idx];
-
-    if (RG_UNLIKELY(trampoline.generation != mem->generation)) {
-        ThrowError<Napi::Error>(env, "Cannot use non-persistent callback beyond FFI call");
+    if (RG_UNLIKELY(env.IsExceptionPending()))
         return;
-    }
+
+    const TrampolineInfo &trampoline = instance->trampolines[idx];
 
     const FunctionInfo *proto = trampoline.proto;
     Napi::Function func = trampoline.func.Value();
@@ -353,6 +395,13 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
 
     uint8_t *return_ptr = !proto->ret.regular ? (uint8_t *)gpr_ptr[0] : nullptr;
 
+    RG_DEFER_N(err_guard) { memset(out_reg, 0, RG_SIZE(*out_reg)); };
+
+    if (RG_UNLIKELY(trampoline.generation >= 0 && trampoline.generation != (int32_t)mem->generation)) {
+        ThrowError<Napi::Error>(env, "Cannot use non-registered callback beyond FFI call");
+        return;
+    }
+
     LocalArray<napi_value, MaxParameters> arguments;
 
     // Convert to JS arguments
@@ -432,6 +481,10 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
 
                 Napi::Value arg = str ? Napi::String::New(env, str) : env.Null();
                 arguments.Append(arg);
+
+                if (param.type->dispose) {
+                    param.type->dispose(env, param.type, str);
+                }
             } break;
             case PrimitiveKind::String16: {
                 const char16_t *str16 = *(const char16_t **)(j < 4 ? gpr_ptr + j : args_ptr);
@@ -439,6 +492,10 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
 
                 Napi::Value arg = str16 ? Napi::String::New(env, str16) : env.Null();
                 arguments.Append(arg);
+
+                if (param.type->dispose) {
+                    param.type->dispose(env, param.type, str16);
+                }
             } break;
             case PrimitiveKind::Pointer:
             case PrimitiveKind::Callback: {
@@ -447,12 +504,16 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
 
                 if (ptr2) {
                     Napi::External<void> external = Napi::External<void>::New(env, ptr2);
-                    SetValueTag(instance, external, param.type);
+                    SetValueTag(instance, external, param.type->ref.marker);
 
                     arguments.Append(external);
                 } else {
                     arguments.Append(env.Null());
                 }
+
+                if (param.type->dispose) {
+                    param.type->dispose(env, param.type, ptr2);
+                }
             } break;
             case PrimitiveKind::Record: {
                 uint8_t *ptr;
@@ -481,6 +542,8 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
                 Napi::Value arg = Napi::Number::New(env, d);
                 arguments.Append(arg);
             } break;
+
+            case PrimitiveKind::Prototype: { RG_UNREACHABLE(); } break;
         }
     }
 
@@ -491,6 +554,9 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
                                      [](Napi::Function *func, size_t argc, napi_value *argv) { return (napi_value)func->Call(argc, argv); });
     Napi::Value value(env, ret);
 
+    if (RG_UNLIKELY(env.IsExceptionPending()))
+        return;
+
     switch (type->primitive) {
         case PrimitiveKind::Void: {} break;
         case PrimitiveKind::Bool: {
@@ -551,14 +617,14 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
         case PrimitiveKind::Pointer: {
             uint8_t *ptr;
 
-            if (CheckValueTag(instance, value, type)) {
+            if (CheckValueTag(instance, value, type->ref.marker)) {
                 ptr = value.As<Napi::External<uint8_t>>().Data();
-            } else if (IsObject(value) && type->ref->primitive == PrimitiveKind::Record) {
+            } else if (IsObject(value) && type->ref.type->primitive == PrimitiveKind::Record) {
                 Napi::Object obj = value.As<Napi::Object>();
 
-                ptr = AllocHeap(type->ref->size, 16);
+                ptr = AllocHeap(type->ref.type->size, 16);
 
-                if (!PushObject(obj, type->ref, ptr))
+                if (!PushObject(obj, type->ref.type, ptr))
                     return;
             } else if (IsNullOrUndefined(value)) {
                 ptr = nullptr;
@@ -612,10 +678,10 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
             if (value.IsFunction()) {
                 Napi::Function func2 = value.As<Napi::Function>();
 
-                ptr = ReserveTrampoline(type->proto, func2);
+                ptr = ReserveTrampoline(type->ref.proto, func2);
                 if (RG_UNLIKELY(!ptr))
                     return;
-            } else if (CheckValueTag(instance, value, type)) {
+            } else if (CheckValueTag(instance, value, type->ref.marker)) {
                 ptr = value.As<Napi::External<uint8_t>>().Data();
             } else if (IsNullOrUndefined(value)) {
                 ptr = nullptr;
@@ -626,7 +692,11 @@ void CallData::Relay(Size idx, uint8_t *own_sp, uint8_t *caller_sp, BackRegister
 
             out_reg->rax = (uint64_t)ptr;
         } break;
+
+        case PrimitiveKind::Prototype: { RG_UNREACHABLE(); } break;
     }
+
+    err_guard.Disable();
 }
 
 void *GetTrampoline(Size idx, const FunctionInfo *proto)

package/src/abi_x64_win_fwd.asm

@@ -126,6 +126,22 @@ public Trampoline12
 public Trampoline13
 public Trampoline14
 public Trampoline15
+public Trampoline16
+public Trampoline17
+public Trampoline18
+public Trampoline19
+public Trampoline20
+public Trampoline21
+public Trampoline22
+public Trampoline23
+public Trampoline24
+public Trampoline25
+public Trampoline26
+public Trampoline27
+public Trampoline28
+public Trampoline29
+public Trampoline30
+public Trampoline31
 public TrampolineX0
 public TrampolineX1
 public TrampolineX2
@@ -142,6 +158,22 @@ public TrampolineX12
 public TrampolineX13
 public TrampolineX14
 public TrampolineX15
+public TrampolineX16
+public TrampolineX17
+public TrampolineX18
+public TrampolineX19
+public TrampolineX20
+public TrampolineX21
+public TrampolineX22
+public TrampolineX23
+public TrampolineX24
+public TrampolineX25
+public TrampolineX26
+public TrampolineX27
+public TrampolineX28
+public TrampolineX29
+public TrampolineX30
+public TrampolineX31
 extern RelayCallback : PROC
 public CallSwitchStack
 
@@ -242,6 +274,54 @@ Trampoline14 endp
 Trampoline15 proc frame
     trampoline 15
 Trampoline15 endp
+Trampoline16 proc frame
+    trampoline 16
+Trampoline16 endp
+Trampoline17 proc frame
+    trampoline 17
+Trampoline17 endp
+Trampoline18 proc frame
+    trampoline 18
+Trampoline18 endp
+Trampoline19 proc frame
+    trampoline 19
+Trampoline19 endp
+Trampoline20 proc frame
+    trampoline 20
+Trampoline20 endp
+Trampoline21 proc frame
+    trampoline 21
+Trampoline21 endp
+Trampoline22 proc frame
+    trampoline 22
+Trampoline22 endp
+Trampoline23 proc frame
+    trampoline 23
+Trampoline23 endp
+Trampoline24 proc frame
+    trampoline 24
+Trampoline24 endp
+Trampoline25 proc frame
+    trampoline 25
+Trampoline25 endp
+Trampoline26 proc frame
+    trampoline 26
+Trampoline26 endp
+Trampoline27 proc frame
+    trampoline 27
+Trampoline27 endp
+Trampoline28 proc frame
+    trampoline 28
+Trampoline28 endp
+Trampoline29 proc frame
+    trampoline 29
+Trampoline29 endp
+Trampoline30 proc frame
+    trampoline 30
+Trampoline30 endp
+Trampoline31 proc frame
+    trampoline 31
+Trampoline31 endp
 
 TrampolineX0 proc frame
     trampoline_xmm 0
@@ -291,6 +371,54 @@ TrampolineX14 endp
 TrampolineX15 proc frame
     trampoline_xmm 15
 TrampolineX15 endp
+TrampolineX16 proc frame
+    trampoline_xmm 16
+TrampolineX16 endp
+TrampolineX17 proc frame
+    trampoline_xmm 17
+TrampolineX17 endp
+TrampolineX18 proc frame
+    trampoline_xmm 18
+TrampolineX18 endp
+TrampolineX19 proc frame
+    trampoline_xmm 19
+TrampolineX19 endp
+TrampolineX20 proc frame
+    trampoline_xmm 20
+TrampolineX20 endp
+TrampolineX21 proc frame
+    trampoline_xmm 21
+TrampolineX21 endp
+TrampolineX22 proc frame
+    trampoline_xmm 22
+TrampolineX22 endp
+TrampolineX23 proc frame
+    trampoline_xmm 23
+TrampolineX23 endp
+TrampolineX24 proc frame
+    trampoline_xmm 24
+TrampolineX24 endp
+TrampolineX25 proc frame
+    trampoline_xmm 25
+TrampolineX25 endp
+TrampolineX26 proc frame
+    trampoline_xmm 26
+TrampolineX26 endp
+TrampolineX27 proc frame
+    trampoline_xmm 27
+TrampolineX27 endp
+TrampolineX28 proc frame
+    trampoline_xmm 28
+TrampolineX28 endp
+TrampolineX29 proc frame
+    trampoline_xmm 29
+TrampolineX29 endp
+TrampolineX30 proc frame
+    trampoline_xmm 30
+TrampolineX30 endp
+TrampolineX31 proc frame
+    trampoline_xmm 31
+TrampolineX31 endp
 
 ; When a callback is relayed, Koffi will call into Node.js and V8 to execute Javascript.
 ; The problem is that we're still running on the separate Koffi stack, and V8 will