kodevu 0.1.60 → 0.1.62

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kodevu",
-  "version": "0.1.60",
+  "version": "0.1.62",
   "license": "MIT",
   "type": "module",
   "description": "Poll SVN revisions or Git commits, send each change diff to a reviewer CLI, and write configurable review reports.",

package/src/config.js

@@ -31,6 +31,13 @@ const defaultConfig = {
   openaiProject: ""
 };
 
+function mkCliError(message) {
+  const e = new Error(message);
+  // exit code 2 = usage / configuration errors
+  e.exitCode = 2;
+  return e;
+}
+
 const ENV_MAP = {
   KODEVU_REVIEWER: "reviewer",
   KODEVU_LANG: "lang",
@@ -65,16 +72,16 @@ async function loadConfigFile(configPath = defaultConfigFilePath) {
     content = await fs.readFile(resolvedPath, "utf8");
   } catch (err) {
     if (err.code === "ENOENT") return {};
-    throw new Error(`Failed to read config file ${resolvedPath}: ${err.message}`);
+    throw mkCliError(`Failed to read config file ${resolvedPath}: ${err.message}`);
   }
   let parsed;
   try {
     parsed = JSON.parse(content);
   } catch (err) {
-    throw new Error(`Invalid JSON in config file ${resolvedPath}: ${err.message}`);
+    throw mkCliError(`Invalid JSON in config file ${resolvedPath}: ${err.message}`);
   }
   if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) {
-    throw new Error(`Config file ${resolvedPath} must contain a JSON object`);
+    throw mkCliError(`Config file ${resolvedPath} must contain a JSON object`);
   }
   const result = {};
   for (const [key, value] of Object.entries(parsed)) {
@@ -93,7 +100,7 @@ function normalizeOutputFormats(outputFormats) {
   const invalid = normalized.filter((item) => !supported.includes(item));
 
   if (invalid.length > 0) {
-    throw new Error(`Unsupported output format(s): ${invalid.join(", ")}. Use: ${supported.join(", ")}`);
+    throw mkCliError(`Unsupported output format(s): ${invalid.join(", ")}. Use: ${supported.join(", ")}`);
   }
   return normalized.length === 0 ? ["markdown"] : normalized;
 }
@@ -187,28 +194,28 @@ export function parseCliArgs(argv) {
     const hasNextValue = nextValue && !nextValue.startsWith("-");
 
     if (value === "--reviewer" || value === "-r") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.reviewer = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--prompt" || value === "-p") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.prompt = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--lang" || value === "-l") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.lang = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--rev" || value === "-v") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.rev = nextValue;
       index += 1;
       continue;
@@ -216,7 +223,7 @@ export function parseCliArgs(argv) {
 
     if (value === "--last" || value === "-n") {
       const hasLastValue = nextValue !== undefined && /^-?\d+$/.test(nextValue);
-      if (!hasLastValue) throw new Error(`Missing value for ${value}`);
+      if (!hasLastValue) throw mkCliError(`Missing value for ${value}`);
       args.last = nextValue;
       index += 1;
       continue;
@@ -228,49 +235,49 @@ export function parseCliArgs(argv) {
     }
 
     if (value === "--output" || value === "-o") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.outputDir = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--format" || value === "-f") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.outputFormats = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--openai-api-key") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.openaiApiKey = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--openai-base-url") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.openaiBaseUrl = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--openai-model") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.openaiModel = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--openai-org") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.openaiOrganization = nextValue;
       index += 1;
       continue;
     }
 
     if (value === "--openai-project") {
-      if (!hasNextValue) throw new Error(`Missing value for ${value}`);
+      if (!hasNextValue) throw mkCliError(`Missing value for ${value}`);
       args.openaiProject = nextValue;
       index += 1;
       continue;
@@ -281,7 +288,7 @@ export function parseCliArgs(argv) {
       continue;
     }
 
-    throw new Error(`Unexpected argument: ${value}`);
+    throw mkCliError(`Unexpected argument: ${value}`);
   }
 
   return args;

package/src/index.js

@@ -11,7 +11,9 @@ try {
 } catch (error) {
   console.error(error?.message || String(error));
   printHelp();
-  process.exit(1);
+  // CLI/usage errors -> exit code 2
+  const code = Number(error?.exitCode) || 2;
+  process.exit(code);
 }
 
 if (cliArgs.help) {
@@ -81,6 +83,7 @@ try {
     scope: "session",
     console: true
   });
-  process.exitCode = 1;
+  // Map any attached exitCode (from thrown errors) to process exitCode, fallback to 1
+  process.exitCode = Number(error?.exitCode) || 1;
 }
 process.exit(process.exitCode || 0);

package/src/review-runner.js

@@ -137,7 +137,14 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
       reasonParts.push(`\n${detail}`);
     }
 
-    throw new Error(reasonParts.join(" "));
+    const err = new Error(reasonParts.join(" "));
+    // Prefer reviewer-provided exit code when available (HTTP status or child exit code), otherwise 3
+    try {
+      err.exitCode = reviewerResult?.code || 3;
+    } catch {
+      err.exitCode = 3;
+    }
+    throw err;
   }
 
   progress?.update(0.82, "writing report");

package/src/reviewers.js

@@ -172,6 +172,8 @@ export const REVIEWERS = {
     async run(config, workingDir, promptText, diffText) {
       const requestBody = {
         model: config.openaiModel,
+        stream: true,
+        stream_options: { include_usage: true },
         messages: [
           {
             role: "user",
@@ -188,17 +190,16 @@ export const REVIEWERS = {
           signal: AbortSignal.timeout(config.commandTimeoutMs)
         });
 
-        const responseText = await response.text();
-        let payload;
-
-        try {
-          payload = responseText ? JSON.parse(responseText) : {};
-        } catch {
-          payload = null;
-        }
-
         if (!response.ok) {
-          const errorMessage = payload?.error?.message || responseText || `HTTP ${response.status}`;
+          let errorMessage = `HTTP ${response.status}`;
+          let responseText = "";
+          try {
+            responseText = await response.text();
+            const payload = JSON.parse(responseText);
+            errorMessage = payload?.error?.message || responseText;
+          } catch {
+            if (responseText) errorMessage = responseText;
+          }
           return {
             code: response.status,
             timedOut: false,
@@ -208,19 +209,67 @@ export const REVIEWERS = {
           };
         }
 
-        const message = extractOpenAiMessageContent(payload?.choices?.[0]?.message?.content);
-        const usage = payload?.usage
-          ? {
+        let message = "";
+        let usage = null;
+        let stdoutText = "";
+        const contentType = response.headers.get("content-type") || "";
+
+        if (contentType.includes("text/event-stream")) {
+          const decoder = new TextDecoder("utf8");
+          let buffer = "";
+
+          for await (const chunk of response.body) {
+            const textChunk = decoder.decode(chunk, { stream: true });
+            stdoutText += textChunk;
+            buffer += textChunk;
+            const parts = buffer.split("\n");
+            buffer = parts.pop() || "";
+            for (const line of parts) {
+              const trimmed = line.trim();
+              if (trimmed.startsWith("data: ")) {
+                if (trimmed === "data: [DONE]") continue;
+                try {
+                  const data = JSON.parse(trimmed.slice(6));
+                  if (data.choices?.[0]?.delta?.content) {
+                    message += data.choices[0].delta.content;
+                  }
+                  if (data.usage) {
+                    usage = {
+                      inputTokens: Number(data.usage.prompt_tokens || 0),
+                      outputTokens: Number(data.usage.completion_tokens || 0),
+                      totalTokens: Number(data.usage.total_tokens || 0)
+                    };
+                  }
+                } catch (e) {
+                  // Ignore JSON parse errors for individual chunks
+                }
+              }
+            }
+          }
+        } else {
+          stdoutText = await response.text();
+          let payload;
+
+          try {
+            payload = stdoutText ? JSON.parse(stdoutText) : {};
+          } catch {
+            payload = null;
+          }
+
+          message = extractOpenAiMessageContent(payload?.choices?.[0]?.message?.content);
+          if (payload?.usage) {
+            usage = {
               inputTokens: Number(payload.usage.prompt_tokens || 0),
               outputTokens: Number(payload.usage.completion_tokens || 0),
               totalTokens: Number(payload.usage.total_tokens || 0)
-            }
-          : null;
+            };
+          }
+        }
 
         return {
           code: 0,
           timedOut: false,
-          stdout: responseText,
+          stdout: stdoutText,
           stderr: "",
           message,
           usage

package/src/shell.js

@@ -65,6 +65,13 @@ export async function runCommand(command, args = [], options = {}) {
         args,
         cwd: cwd || ""
       });
+      // Mark spawn/runtime errors as runtime failures (exit code 3)
+      try {
+        if (!err || typeof err !== "object") err = new Error(String(err));
+        if (err.exitCode == null) err.exitCode = 3;
+      } catch (e) {
+        // ignore
+      }
       reject(err);
     });
 
@@ -108,6 +115,8 @@ export async function runCommand(command, args = [], options = {}) {
           `Command failed: ${command} ${args.join(" ")}\n${result.stderr || result.stdout}`.trim()
         );
         error.result = result;
+        // Map command failures to exit code 3 (runtime / external command failure)
+        error.exitCode = 3;
         reject(error);
         return;
       }