kodevu 0.1.56 → 0.1.58
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/src/config.js +1 -1
- package/src/logger.js +1 -1
- package/src/review-runner.js +19 -4
package/package.json
CHANGED
package/src/config.js
CHANGED
package/src/logger.js
CHANGED
|
@@ -90,7 +90,7 @@ class Logger {
|
|
|
90
90
|
fs.mkdirSync(config.logsDir, { recursive: true });
|
|
91
91
|
}
|
|
92
92
|
const date = formatDate(new Date()).split(" ")[0];
|
|
93
|
-
this.logFile = path.join(config.logsDir, `run-${date}
|
|
93
|
+
this.logFile = path.join(config.logsDir, `run-${date}.log`);
|
|
94
94
|
|
|
95
95
|
// Simple rotation: Clean up logs older than 7 days
|
|
96
96
|
this._cleanupOldLogs(config.logsDir);
|
package/src/review-runner.js
CHANGED
|
@@ -105,7 +105,8 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
|
|
|
105
105
|
reviewer: reviewerName,
|
|
106
106
|
console: false
|
|
107
107
|
});
|
|
108
|
-
//
|
|
108
|
+
// Store the result so the final throw can include stderr/exit code details
|
|
109
|
+
reviewerResult = err?.result ?? null;
|
|
109
110
|
}
|
|
110
111
|
|
|
111
112
|
if (reviewerName !== reviewersToTry[reviewersToTry.length - 1]) {
|
|
@@ -120,9 +121,23 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
|
|
|
120
121
|
}
|
|
121
122
|
|
|
122
123
|
if (!reviewerResult || reviewerResult.code !== 0 || reviewerResult.timedOut) {
|
|
123
|
-
|
|
124
|
-
|
|
125
|
-
|
|
124
|
+
const displayName = reviewer?.displayName || config.reviewer;
|
|
125
|
+
const reasonParts = [`${displayName} failed for ${details.displayId}`];
|
|
126
|
+
|
|
127
|
+
if (reviewerResult?.timedOut) {
|
|
128
|
+
reasonParts.push("(timed out)");
|
|
129
|
+
} else if (reviewerResult?.code != null && reviewerResult.code !== 0) {
|
|
130
|
+
reasonParts.push(`(exit code: ${reviewerResult.code})`);
|
|
131
|
+
} else if (!reviewerResult) {
|
|
132
|
+
reasonParts.push("(reviewer produced no result)");
|
|
133
|
+
}
|
|
134
|
+
|
|
135
|
+
const detail = (reviewerResult?.stderr || reviewerResult?.stdout || "").trim();
|
|
136
|
+
if (detail) {
|
|
137
|
+
reasonParts.push(`\n${detail}`);
|
|
138
|
+
}
|
|
139
|
+
|
|
140
|
+
throw new Error(reasonParts.join(" "));
|
|
126
141
|
}
|
|
127
142
|
|
|
128
143
|
progress?.update(0.82, "writing report");
|