kodevu 0.1.48 → 0.1.49

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kodevu",
-  "version": "0.1.48",
+  "version": "0.1.49",
   "license": "MIT",
   "type": "module",
   "description": "Poll SVN revisions or Git commits, send each change diff to a reviewer CLI, and write configurable review reports.",

package/src/logger.js

@@ -6,7 +6,6 @@ class Logger {
   constructor() {
     this.config = null;
     this.logFile = null;
-    this.progressDisplay = null;
     this.initialized = false;
   }
 
@@ -31,10 +30,6 @@ class Logger {
     }
   }
 
-  setProgressDisplay(pd) {
-    this.progressDisplay = pd;
-  }
-
   info(message) {
     this._log("INFO", message);
   }
@@ -78,14 +73,10 @@ class Logger {
     // If it's debug and debug mode is off, skip console
     if (isDebug && !this.config?.debug) return;
 
-    if (this.progressDisplay) {
-      this.progressDisplay.log(logLine);
+    if (isError || isWarn) {
+      console.error(logLine);
     } else {
-      if (isError || isWarn) {
-        console.error(logLine);
-      } else {
-        console.log(logLine);
-      }
+      console.log(logLine);
     }
   }
 

package/src/progress-ui.js

@@ -1,5 +1,3 @@
-import { logger } from "./logger.js";
-
 function clampProgress(value) {
   if (!Number.isFinite(value)) {
     return 0;
@@ -8,89 +6,34 @@ function clampProgress(value) {
   return Math.max(0, Math.min(1, value));
 }
 
-class ProgressItem {
-  constructor(display, label) {
-    this.display = display;
-    this.label = label;
-    this.progress = 0;
-    this.stage = "";
-    this.active = false;
-    this.lastStatusLine = "";
-  }
-
-  start(stage = "starting") {
-    this.active = true;
-    this.stage = stage;
-    logger.debug(`${this.label} batch start: ${stage}`);
-    this.writeStatus();
-  }
-
-  update(progress, stage) {
-    this.progress = clampProgress(progress);
-
-    if (stage) {
-      this.stage = stage;
-      logger.debug(`${this.label} stage: ${stage} (${Math.round(this.progress * 100)}%)`);
-    }
-
-    this.writeStatus();
-  }
+function formatStatusLine(label, progress, stage) {
+  const pct = `${Math.round(progress * 100)}`.padStart(3, " ");
+  return `[progress] ${pct}% ${label}${stage ? ` | ${stage}` : ""}`;
+}
 
-  log(message) {
-    // We don't log to file here because usually progress.log() is called alongside logger.info()
-    // or we want the caller to decide whether it goes to the log file.
-    this.display.writeLine(message);
-  }
+export function createProgressReporter(label, options = {}) {
+  const stream = options.stream || process.stdout;
+  let lastStatusLine = "";
 
-  succeed(message) {
-    const finalMsg = message || `${this.label} complete`;
-    this.finish("[done]", 1, finalMsg);
-    logger.debug(`${this.label} batch succeed: ${finalMsg}`);
+  function writeLine(message) {
+    stream.write(`${message}\n`);
   }
 
-  fail(message) {
-    const finalMsg = message || `${this.label} failed`;
-    this.finish("[fail]", this.progress, finalMsg);
-    logger.error(`${this.label} batch fail: ${finalMsg}`);
-  }
+  return {
+    update(progress, stage = "") {
+      const line = formatStatusLine(label, clampProgress(progress), stage);
 
-  finish(prefix, progress, message) {
-    this.progress = clampProgress(progress);
-    this.active = false;
-    this.display.writeLine(`${prefix} ${message}`);
-  }
+      if (line === lastStatusLine) {
+        return;
+      }
 
-  writeStatus() {
-    const line = this.buildStatusLine();
+      lastStatusLine = line;
+      writeLine(line);
+    },
 
-    if (line === this.lastStatusLine) {
-      return;
+    finish(status, message) {
+      const prefix = status === "fail" ? "[fail]" : "[done]";
+      writeLine(`${prefix} ${message || label}`);
     }
-
-    this.lastStatusLine = line;
-    this.display.writeLine(line);
-  }
-
-  buildStatusLine() {
-    const pct = `${Math.round(this.progress * 100)}`.padStart(3, " ");
-    return `[progress] ${pct}% ${this.label}${this.stage ? ` | ${this.stage}` : ""}`;
-  }
-}
-
-export class ProgressDisplay {
-  constructor(options = {}) {
-    this.stream = options.stream || process.stdout;
-  }
-
-  createItem(label) {
-    return new ProgressItem(this, label);
-  }
-
-  writeLine(message) {
-    this.stream.write(`${message}\n`);
-  }
-
-  log(message) {
-    this.writeLine(message);
-  }
+  };
 }

package/src/review-runner.js

@@ -1,5 +1,5 @@
 import path from "node:path";
-import { ProgressDisplay } from "./progress-ui.js";
+import { createProgressReporter } from "./progress-ui.js";
 import { resolveRepositoryContext } from "./vcs-client.js";
 import { logger } from "./logger.js";
 import {
@@ -172,10 +172,8 @@ export async function runReviewCycle(config) {
   }
 
   logger.info(`Reviewing ${backend.displayName} ${backend.changeName}s ${formatChangeList(backend, changeIdsToReview)}`);
-  const progressDisplay = new ProgressDisplay();
-  logger.setProgressDisplay(progressDisplay);
-  const progress = progressDisplay.createItem(`${backend.displayName} ${backend.changeName} batch`);
-  progress.start("0/" + changeIdsToReview.length + " completed");
+  const progress = createProgressReporter(`${backend.displayName} ${backend.changeName} batch`);
+  progress.update(0, `0/${changeIdsToReview.length} completed`);
 
   for (const [index, changeId] of changeIdsToReview.entries()) {
     logger.debug(`Starting review for ${backend.formatChangeId(changeId)}.`);
@@ -187,11 +185,13 @@ export async function runReviewCycle(config) {
     };
 
     try {
-      await reviewChange(config, backend, targetInfo, changeId, { update: syncOverallProgress, log: (message) => progress.log(message) });
+      await reviewChange(config, backend, targetInfo, changeId, { update: syncOverallProgress });
       updateOverallProgress(progress, index + 1, changeIdsToReview.length, 0, `finished ${displayId}`);
     } catch (error) {
-      progress.fail(`failed at ${displayId} (${index}/${changeIdsToReview.length} completed)`);
+      progress.finish("fail", `failed at ${displayId} (${index}/${changeIdsToReview.length} completed)`);
       throw error;
     }
   }
+
+  progress.finish("done", `${backend.displayName} ${backend.changeName} batch complete`);
 }