kodevu 0.1.26 → 0.1.27

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kodevu",
-  "version": "0.1.26",
+  "version": "0.1.27",
   "license": "MIT",
   "type": "module",
   "description": "Poll SVN revisions or Git commits, send each change diff to a reviewer CLI, and write configurable review reports.",

package/src/logger.js

@@ -38,6 +38,10 @@ class Logger {
     this._log("INFO", message);
   }
 
+  warn(message) {
+    this._log("WARN", message);
+  }
+
   error(message, error) {
     let msg = message;
     if (error) {
@@ -68,6 +72,7 @@ class Logger {
     // Console output
     const isDebug = level === "DEBUG";
     const isError = level === "ERROR";
+    const isWarn = level === "WARN";
 
     // If it's debug and debug mode is off, skip console
     if (isDebug && !this.config?.debug) return;
@@ -75,10 +80,10 @@ class Logger {
     if (this.progressDisplay) {
       this.progressDisplay.log(logLine);
     } else {
-      if (isError) {
+      if (isError || isWarn) {
         console.error(logLine);
       } else {
-        console.error(logLine);
+        console.log(logLine);
       }
     }
   }

package/src/progress-ui.js

@@ -1,3 +1,5 @@
+import { logger } from "./logger.js";
+
 function clampProgress(value) {
   if (!Number.isFinite(value)) {
     return 0;
@@ -19,6 +21,7 @@ class ProgressItem {
   start(stage = "starting") {
     this.active = true;
     this.stage = stage;
+    logger.debug(`${this.label} batch start: ${stage}`);
     this.writeStatus();
   }
 
@@ -27,21 +30,28 @@ class ProgressItem {
 
     if (stage) {
       this.stage = stage;
+      logger.debug(`${this.label} stage: ${stage} (${Math.round(this.progress * 100)}%)`);
     }
 
     this.writeStatus();
   }
 
   log(message) {
+    // We don't log to file here because usually progress.log() is called alongside logger.info()
+    // or we want the caller to decide whether it goes to the log file.
     this.display.writeLine(message);
   }
 
   succeed(message) {
-    this.finish("[done]", 1, message || `${this.label} complete`);
+    const finalMsg = message || `${this.label} complete`;
+    this.finish("[done]", 1, finalMsg);
+    logger.debug(`${this.label} batch succeed: ${finalMsg}`);
   }
 
   fail(message) {
-    this.finish("[fail]", this.progress, message || `${this.label} failed`);
+    const finalMsg = message || `${this.label} failed`;
+    this.finish("[fail]", this.progress, finalMsg);
+    logger.error(`${this.label} batch fail: ${finalMsg}`);
   }
 
   finish(prefix, progress, message) {

package/src/review-runner.js

@@ -582,6 +582,8 @@ function buildStateSnapshot(backend, targetInfo, changeId) {
 }
 
 async function reviewChange(config, backend, targetInfo, changeId, progress) {
+  const displayId = backend.formatChangeId(changeId);
+  logger.info(`Starting review for ${backend.changeName} ${displayId}`);
   progress?.update(0.05, "loading change details");
   const details = await backend.getChangeDetails(config, targetInfo, changeId);
 
@@ -650,7 +652,8 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
     }
 
     if (reviewerName !== reviewersToTry[reviewersToTry.length - 1]) {
-      progress?.log(`${reviewer.displayName} failed for ${details.displayId}; trying next reviewer...`);
+      const msg = `${reviewer.displayName} failed for ${details.displayId}; trying next reviewer...`;
+      logger.warn(msg);
     }
   }
 
@@ -679,6 +682,13 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
     );
   }
 
+  const outputLabels = [
+    shouldWriteFormat(config, "markdown") ? `md: ${outputFile}` : null,
+    shouldWriteFormat(config, "json") ? `json: ${jsonOutputFile}` : null
+  ].filter(Boolean);
+  
+  logger.info(`Completed review for ${displayId}: ${outputLabels.join(" | ") || "(no report file generated)"}`);
+
   return {
     success: true,
     outputFile: shouldWriteFormat(config, "markdown") ? outputFile : null,
@@ -772,15 +782,10 @@ export async function runReviewCycle(config) {
       throw error;
     }
 
-    const outputLabels = [
-      result.outputFile ? `md: ${result.outputFile}` : null,
-      result.jsonOutputFile ? `json: ${result.jsonOutputFile}` : null
-    ].filter(Boolean);
     const nextProjectState = buildStateSnapshot(backend, targetInfo, changeId);
     await saveState(config.stateFilePath, updateProjectState(stateFile, targetInfo, nextProjectState));
     stateFile.projects[targetInfo.stateKey] = nextProjectState;
     logger.debug(`Saved checkpoint for ${backend.formatChangeId(changeId)} to ${config.stateFilePath}.`);
-    progress.log(`[done] reviewed ${displayId}: ${outputLabels.join(" | ") || "(no report file generated)"}`);
     updateOverallProgress(progress, index + 1, changeIdsToReview.length, 0, `finished ${displayId}`);
   }
 

package/src/shell.js

@@ -25,7 +25,9 @@ export async function runCommand(command, args = [], options = {}) {
   } = options;
 
   logger.debug(
-    `run: ${command} ${args.join(" ")}${cwd ? ` | cwd=${cwd}` : ""}${timeoutMs > 0 ? ` | timeoutMs=${timeoutMs}` : ""}`
+    `run: ${command} ${args.join(" ")}${cwd ? ` | cwd=${cwd}` : ""}${timeoutMs > 0 ? ` | timeoutMs=${timeoutMs}` : ""}${
+      input ? ` | input=${summarizeOutput(input)}` : ""
+    }`
   );
 
   return await new Promise((resolve, reject) => {
@@ -51,7 +53,10 @@ export async function runCommand(command, args = [], options = {}) {
       stderrChunks.push(Buffer.from(chunk));
     });
 
-    child.on("error", reject);
+    child.on("error", (err) => {
+      logger.error(`spawn error: ${command}`, err);
+      reject(err);
+    });
 
     child.on("close", (code) => {
       if (timer) {
@@ -67,9 +72,14 @@ export async function runCommand(command, args = [], options = {}) {
         stderr: trim ? stderr.trim() : stderr
       };
 
-      logger.debug(
-        `exit: ${command} code=${result.code} timedOut=${result.timedOut} stdout=${summarizeOutput(result.stdout)} stderr=${summarizeOutput(result.stderr)}`
-      );
+      const level = (result.code !== 0 || result.timedOut) && !allowFailure ? "ERROR" : "DEBUG";
+      const exitMsg = `exit: ${command} code=${result.code} timedOut=${result.timedOut} stdout=${summarizeOutput(result.stdout)} stderr=${summarizeOutput(result.stderr)}`;
+      
+      if (level === "ERROR") {
+        logger.error(exitMsg);
+      } else {
+        logger.debug(exitMsg);
+      }
 
       if ((result.code !== 0 || result.timedOut) && !allowFailure) {
         const error = new Error(