kodevu 0.1.24 → 0.1.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kodevu",
-  "version": "0.1.24",
+  "version": "0.1.25",
   "license": "MIT",
   "type": "module",
   "description": "Poll SVN revisions or Git commits, send each change diff to a reviewer CLI, and write configurable review reports.",

package/src/config.js

@@ -11,6 +11,7 @@ const defaultConfig = {
   target: "",
   outputDir: defaultStorageDir,
   stateFilePath: path.join(defaultStorageDir, "state.json"),
+  logsDir: path.join(defaultStorageDir, "logs"),
   commandTimeoutMs: 600000,
   prompt:
     "请严格审查当前变更，优先指出 bug、回归风险、兼容性问题、安全问题、边界条件缺陷和缺失测试。请使用简体中文输出 Markdown；如果没有明确缺陷，请写“未发现明确缺陷”，并补充剩余风险。",
@@ -24,6 +25,7 @@ const configTemplate = {
   prompt: defaultConfig.prompt,
   outputDir: "~/.kodevu",
   stateFilePath: "~/.kodevu/state.json",
+  logsDir: "~/.kodevu/logs",
   commandTimeoutMs: defaultConfig.commandTimeoutMs,
   maxRevisionsPerRun: defaultConfig.maxRevisionsPerRun,
   outputFormats: defaultConfig.outputFormats
@@ -231,6 +233,7 @@ export async function loadConfig(configPath, cliArgs = {}) {
   config.baseDir = baseDir;
   config.outputDir = resolveConfigPath(config.baseDir, config.outputDir);
   config.stateFilePath = resolveConfigPath(config.baseDir, config.stateFilePath);
+  config.logsDir = resolveConfigPath(config.baseDir, config.logsDir);
   config.maxRevisionsPerRun = Number(config.maxRevisionsPerRun);
   config.commandTimeoutMs = Number(config.commandTimeoutMs);
   config.outputFormats = normalizeOutputFormats(config.outputFormats, loadedConfigPath);

package/src/index.js

@@ -2,6 +2,7 @@
 
 import { initConfig, loadConfig, parseCliArgs, printHelp } from "./config.js";
 import { runReviewCycle } from "./review-runner.js";
+import { logger } from "./logger.js";
 
 let cliArgs;
 
@@ -29,32 +30,36 @@ if (cliArgs.command === "init") {
   }
 }
 
-const config = await loadConfig(cliArgs.configPath, cliArgs);
+try {
+  const config = await loadConfig(cliArgs.configPath, cliArgs);
+  logger.init(config);
 
-if (config.reviewerWasAutoSelected) {
-  console.log(
-    `Reviewer "auto" selected ${config.reviewer}${config.reviewerCommandPath ? ` (${config.reviewerCommandPath})` : ""}.`
-  );
-}
+  if (config.reviewerWasAutoSelected) {
+    logger.info(
+      `Reviewer "auto" selected ${config.reviewer}${config.reviewerCommandPath ? ` (${config.reviewerCommandPath})` : ""}.`
+    );
+  }
 
-if (config.debug) {
-  console.error(
-    `[debug] Loaded config: ${JSON.stringify({
-      configPath: config.configPath,
-      reviewer: config.reviewer,
-      reviewerCommandPath: config.reviewerCommandPath,
-      reviewerWasAutoSelected: config.reviewerWasAutoSelected,
-      target: config.target,
-      outputDir: config.outputDir,
-      debug: config.debug
-    })}`
-  );
-}
+  if (config.debug) {
+    logger.debug(
+      `Loaded config: ${JSON.stringify({
+        configPath: config.configPath,
+        reviewer: config.reviewer,
+        reviewerCommandPath: config.reviewerCommandPath,
+        reviewerWasAutoSelected: config.reviewerWasAutoSelected,
+        target: config.target,
+        outputDir: config.outputDir,
+        debug: config.debug
+      })}`
+    );
+  }
 
-try {
+  logger.info(`Session started. Target: ${config.target}`);
   await runReviewCycle(config);
+  logger.info("Session completed successfully.");
 } catch (error) {
-  console.error(error?.stack || String(error));
+  // If config was loaded, logger might be initialized, otherwise it will fall back to stderr
+  logger.error("Session failed with error", error);
   process.exitCode = 1;
 }
 process.exit(process.exitCode || 0);

package/src/logger.js

@@ -0,0 +1,107 @@
+import fs from "node:fs";
+import path from "node:path";
+
+class Logger {
+  constructor() {
+    this.config = null;
+    this.logFile = null;
+    this.progressDisplay = null;
+    this.initialized = false;
+  }
+
+  init(config) {
+    if (this.initialized) return;
+    this.config = config;
+    
+    if (config.logsDir) {
+      try {
+        if (!fs.existsSync(config.logsDir)) {
+          fs.mkdirSync(config.logsDir, { recursive: true });
+        }
+        const date = new Date().toISOString().split("T")[0];
+        this.logFile = path.join(config.logsDir, `run-${date}.log`);
+        
+        // Simple rotation: Clean up logs older than 7 days
+        this._cleanupOldLogs(config.logsDir);
+        this.initialized = true;
+      } catch (err) {
+        console.error(`[logger] Failed to initialize log file: ${err.message}`);
+      }
+    }
+  }
+
+  setProgressDisplay(pd) {
+    this.progressDisplay = pd;
+  }
+
+  info(message) {
+    this._log("INFO", message);
+  }
+
+  error(message, error) {
+    let msg = message;
+    if (error) {
+      msg += `\n${error.stack || error}`;
+    }
+    this._log("ERROR", msg);
+  }
+
+  debug(message) {
+    if (this.config?.debug) {
+      this._log("DEBUG", message);
+    }
+  }
+
+  _log(level, message) {
+    const timestamp = new Date().toISOString();
+    const logLine = `[${timestamp}] [${level}] ${message}`;
+
+    // Write to file
+    if (this.logFile) {
+      try {
+        fs.appendFileSync(this.logFile, logLine + "\n");
+      } catch (err) {
+        // Ignore file errors during logging to prevent crashes
+      }
+    }
+
+    // Console output
+    const isDebug = level === "DEBUG";
+    const isError = level === "ERROR";
+
+    // If it's debug and debug mode is off, skip console
+    if (isDebug && !this.config?.debug) return;
+
+    if (this.progressDisplay) {
+      this.progressDisplay.log(logLine);
+    } else {
+      if (isError) {
+        console.error(logLine);
+      } else {
+        console.error(logLine);
+      }
+    }
+  }
+
+  _cleanupOldLogs(logsDir) {
+    try {
+      const files = fs.readdirSync(logsDir);
+      const now = Date.now();
+      const MAX_AGE_MS = 7 * 24 * 60 * 60 * 1000; // 7 days
+
+      for (const file of files) {
+        if (file.startsWith("run-") && file.endsWith(".log")) {
+          const filePath = path.join(logsDir, file);
+          const stats = fs.statSync(filePath);
+          if (now - stats.mtimeMs > MAX_AGE_MS) {
+            fs.unlinkSync(filePath);
+          }
+        }
+      }
+    } catch (err) {
+      // Ignore cleanup errors
+    }
+  }
+}
+
+export const logger = new Logger();

package/src/review-runner.js

@@ -4,6 +4,7 @@ import path from "node:path";
 import { ProgressDisplay } from "./progress-ui.js";
 import { runCommand } from "./shell.js";
 import { resolveRepositoryContext } from "./vcs-client.js";
+import { logger } from "./logger.js";
 
 const DIFF_LIMITS = {
   review: {
@@ -17,11 +18,6 @@ const DIFF_LIMITS = {
   tailLines: 200
 };
 
-function debugLog(config, message) {
-  if (config.debug) {
-    console.error(`[debug] ${message}`);
-  }
-}
 
 function estimateTokenCount(text) {
   if (!text) {
@@ -634,7 +630,7 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
 
   for (const reviewerName of reviewersToTry) {
     currentReviewerConfig = { ...config, reviewer: reviewerName };
-    debugLog(config, `Trying reviewer: ${reviewerName}`);
+    logger.debug(`Trying reviewer: ${reviewerName}`);
     progress?.update(0.45, `running reviewer ${reviewerName}`);
 
     const res = await runReviewerPrompt(
@@ -659,7 +655,7 @@ async function reviewChange(config, backend, targetInfo, changeId, progress) {
   }
 
   progress?.update(0.82, "writing report");
-  debugLog(config, `Token usage: input=${tokenUsage.inputTokens} output=${tokenUsage.outputTokens} total=${tokenUsage.totalTokens} source=${tokenUsage.source}`);
+  logger.debug(`Token usage: input=${tokenUsage.inputTokens} output=${tokenUsage.outputTokens} total=${tokenUsage.totalTokens} source=${tokenUsage.source}`);
   const report = buildReport(currentReviewerConfig, backend, targetInfo, details, diffPayloads, reviewer, reviewerResult, tokenUsage);
   const outputFile = path.join(config.outputDir, backend.getReportFileName(changeId));
   const jsonOutputFile = outputFile.replace(/\.md$/i, ".json");
@@ -708,16 +704,14 @@ export async function runReviewCycle(config) {
   await ensureDir(config.outputDir);
 
   const { backend, targetInfo } = await resolveRepositoryContext(config);
-  debugLog(
-    config,
+  logger.debug(
     `Resolved repository context: backend=${backend.kind} target=${targetInfo.targetDisplay || config.target} stateKey=${targetInfo.stateKey}`
   );
   const latestChangeId = await backend.getLatestChangeId(config, targetInfo);
   const stateFile = await loadState(config.stateFilePath);
   const projectState = getProjectState(stateFile, targetInfo);
   let lastReviewedId = readLastReviewedId(projectState, backend, targetInfo);
-  debugLog(
-    config,
+  logger.debug(
     `Checkpoint status: latest=${backend.formatChangeId(latestChangeId)} lastReviewed=${lastReviewedId ? backend.formatChangeId(lastReviewedId) : "(none)"}`
   );
 
@@ -725,7 +719,7 @@ export async function runReviewCycle(config) {
     const checkpointIsValid = await backend.isValidCheckpoint(config, targetInfo, lastReviewedId, latestChangeId);
 
     if (!checkpointIsValid) {
-      console.log("Saved review state no longer matches repository history. Resetting checkpoint.");
+      logger.info("Saved review state no longer matches repository history. Resetting checkpoint.");
       lastReviewedId = null;
     }
   }
@@ -734,7 +728,7 @@ export async function runReviewCycle(config) {
 
   if (!lastReviewedId) {
     changeIdsToReview = [latestChangeId];
-    console.log(`Initialized state to review the latest ${backend.changeName} ${backend.formatChangeId(latestChangeId)} first.`);
+    logger.info(`Initialized state to review the latest ${backend.changeName} ${backend.formatChangeId(latestChangeId)} first.`);
   } else {
     changeIdsToReview = await backend.getPendingChangeIds(
       config,
@@ -745,21 +739,22 @@ export async function runReviewCycle(config) {
     );
   }
 
-  debugLog(config, `Planned ${changeIdsToReview.length} ${backend.changeName}(s) for this cycle.`);
+  logger.debug(`Planned ${changeIdsToReview.length} ${backend.changeName}(s) for this cycle.`);
 
   if (changeIdsToReview.length === 0) {
     const lastKnownId = lastReviewedId ? backend.formatChangeId(lastReviewedId) : "(none)";
-    console.log(`No new ${backend.changeName}s. Last reviewed: ${lastKnownId}`);
+    logger.info(`No new ${backend.changeName}s. Last reviewed: ${lastKnownId}`);
     return;
   }
 
-  console.log(`Reviewing ${backend.displayName} ${backend.changeName}s ${formatChangeList(backend, changeIdsToReview)}`);
+  logger.info(`Reviewing ${backend.displayName} ${backend.changeName}s ${formatChangeList(backend, changeIdsToReview)}`);
   const progressDisplay = new ProgressDisplay();
+  logger.setProgressDisplay(progressDisplay);
   const progress = progressDisplay.createItem(`${backend.displayName} ${backend.changeName} batch`);
   progress.start("0/" + changeIdsToReview.length + " completed");
 
   for (const [index, changeId] of changeIdsToReview.entries()) {
-    debugLog(config, `Starting review for ${backend.formatChangeId(changeId)}.`);
+    logger.debug(`Starting review for ${backend.formatChangeId(changeId)}.`);
     const displayId = backend.formatChangeId(changeId);
     updateOverallProgress(progress, index, changeIdsToReview.length, 0, `starting ${displayId}`);
 
@@ -784,7 +779,7 @@ export async function runReviewCycle(config) {
     const nextProjectState = buildStateSnapshot(backend, targetInfo, changeId);
     await saveState(config.stateFilePath, updateProjectState(stateFile, targetInfo, nextProjectState));
     stateFile.projects[targetInfo.stateKey] = nextProjectState;
-    debugLog(config, `Saved checkpoint for ${backend.formatChangeId(changeId)} to ${config.stateFilePath}.`);
+    logger.debug(`Saved checkpoint for ${backend.formatChangeId(changeId)} to ${config.stateFilePath}.`);
     progress.log(`[done] reviewed ${displayId}: ${outputLabels.join(" | ") || "(no report file generated)"}`);
     updateOverallProgress(progress, index + 1, changeIdsToReview.length, 0, `finished ${displayId}`);
   }
@@ -800,6 +795,6 @@ export async function runReviewCycle(config) {
   );
 
   if (remainingChanges.length > 0) {
-    console.log(`Backlog remains. Latest ${backend.changeName} is ${backend.formatChangeId(latestChangeId)}.`);
+    logger.info(`Backlog remains. Latest ${backend.changeName} is ${backend.formatChangeId(latestChangeId)}.`);
   }
 }

package/src/shell.js

@@ -1,11 +1,7 @@
 import spawn from "cross-spawn";
 import iconv from "iconv-lite";
+import { logger } from "./logger.js";
 
-function debugLog(enabled, message) {
-  if (enabled) {
-    console.error(`[debug] ${message}`);
-  }
-}
 
 function summarizeOutput(text) {
   if (!text) {
@@ -28,8 +24,7 @@ export async function runCommand(command, args = [], options = {}) {
     debug = false
   } = options;
 
-  debugLog(
-    debug,
+  logger.debug(
     `run: ${command} ${args.join(" ")}${cwd ? ` | cwd=${cwd}` : ""}${timeoutMs > 0 ? ` | timeoutMs=${timeoutMs}` : ""}`
   );
 
@@ -72,8 +67,7 @@ export async function runCommand(command, args = [], options = {}) {
         stderr: trim ? stderr.trim() : stderr
       };
 
-      debugLog(
-        debug,
+      logger.debug(
         `exit: ${command} code=${result.code} timedOut=${result.timedOut} stdout=${summarizeOutput(result.stdout)} stderr=${summarizeOutput(result.stderr)}`
       );