kodelyth-ecc 2.4.2 → 2.4.3

package/CHANGELOG.md

@@ -2,6 +2,31 @@
 
 All notable changes to Kodelyth ECC are documented here.
 
+## v2.4.3 — Memory recall crash fix (the "still dummy" bug) (July 2026)
+
+Found by testing ECC as a real user actually experiences it, not just in the test harness. **Memory recall was silently crashing on every prompt** for any user whose `~/.kodelythecc/memory/index.json` was written by an older/foreign BM25 schema.
+
+### Fixed
+
+- **`scripts/memory/store.js` — recall threw `Cannot read properties of undefined (reading '<token>')` on every UserPromptSubmit** when the on-disk `index.json` used the schema `{k1, b, corpusStats, index, documents, docFreq}` (from a prior BM25 implementation) instead of the current `{tokens, docCount, avgDocLength, totalLength}`. `search()` read `index.tokens[token]` where `index.tokens` was undefined.
+- **Root cause was a two-headed bug**:
+  1. `loadIndex()` blindly returned whatever JSON was on disk, with no schema validation
+  2. The canonical `rebuildIndex()` correctly rebuilt + saved a valid index but **returned `{count}` instead of the index object**
+- **Fix**: `loadIndex()` now validates the schema via `isValidIndexSchema()` and, on any mismatch/corruption, rebuilds from the append-only `memories.jsonl` (the source of truth). `rebuildIndex()` now returns the rebuilt index (with a `count` property preserved for its other caller). Recall self-heals on first call — no crash, no manual `index.json` deletion needed.
+
+### Added
+
+- **Regression test** in `tests/memory/store.test.js` — writes a foreign-schema `index.json`, asserts `recall()` does not throw and returns results, and asserts the on-disk index is rebuilt to the valid schema. This class of bug can no longer ship silently.
+
+### Impact
+
+- Every real user with a stale index had **zero working memory recall** — the hook fired, errored, and returned nothing. Auto-recall now works end-to-end.
+- Verified live: corrupted the index with the foreign schema, ran both `store.recall()` and the actual `hooks/memory/auto-recall.js` hook — both self-heal and return real Stripe/CORS memories.
+
+### Why this matters
+
+This is exactly the "is it real or is it dummy" gap. Files were installed, hooks were registered, rules loaded — but one core feature crashed on real input while passing every existing test. The lesson: test the installed experience with real data, not just unit fixtures.
+
 ## v2.4.2 — SEO-massive documentation refresh (July 2026)
 
 Full documentation rewrite for website-ready SEO. Every doc now ships with YAML frontmatter (title, description, keywords, Open Graph, Twitter card, canonical URL, last_updated, version, category). Six new feature docs cover subsystems shipped since v2.0 that were undocumented until now.

package/VERSION

@@ -1 +1 @@
-2.4.2
+2.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kodelyth-ecc",
-  "version": "2.4.2",
+  "version": "2.4.3",
   "description": "Production-grade AI coding toolkit — 70 agents (incl. devil-mode adversarial crew), 194 skills, 97 commands, parallel multi-agent commands, semantic intent routing, self-learning memory, and a built-in MCP server (16 tools / 6 prompts / 377 resources) that bridges to Claude Desktop, LangGraph, AutoGen, CrewAI, and OpenAI Agents SDK. Works with Claude Code, Windsurf, Cursor, Codex, Antigravity, OpenCode, Cline, RooCode, Aider, Kimi, and Gemini CLI.",
   "author": "Kodelyth <github.com/sifxprime>",
   "license": "MIT",

package/scripts/memory/store.js

@@ -72,15 +72,37 @@ function newMemoryId() {
 }
 
 // ── Index ────────────────────────────────────────────────────────────────────
+function emptyIndex() {
+  return { tokens: {}, docCount: 0, avgDocLength: 0, totalLength: 0 };
+}
+
+// A valid index for the current schema MUST have a `tokens` object and a
+// numeric `docCount`. Older/foreign schemas (e.g. `{index, documents, docFreq}`
+// from a prior BM25 implementation) are unrecognised — we rebuild from the
+// append-only memories.jsonl rather than crash on `index.tokens[token]`.
+function isValidIndexSchema(idx) {
+  return !!idx
+    && typeof idx === 'object'
+    && idx.tokens && typeof idx.tokens === 'object'
+    && typeof idx.docCount === 'number';
+}
+
 function loadIndex() {
   if (!fs.existsSync(PATHS.index)) {
-    return { tokens: {}, docCount: 0, avgDocLength: 0, totalLength: 0 };
+    return rebuildIndex();
   }
+  let parsed;
   try {
-    return JSON.parse(fs.readFileSync(PATHS.index, 'utf8'));
+    parsed = JSON.parse(fs.readFileSync(PATHS.index, 'utf8'));
   } catch {
-    return { tokens: {}, docCount: 0, avgDocLength: 0, totalLength: 0 };
+    return rebuildIndex();
+  }
+  if (!isValidIndexSchema(parsed)) {
+    // Stale or foreign schema on disk — rebuild from the source of truth
+    // (the canonical rebuildIndex defined below rebuilds AND persists a valid index).
+    return rebuildIndex();
   }
+  return parsed;
 }
 
 function saveIndex(index) {
@@ -360,14 +382,19 @@ function autoResolveOnEdit(filePath, projectRoot = null) {
   return resolved;
 }
 
+// Rebuild the inverted index from memories.jsonl, persist it, and RETURN the
+// index object (with a `count` property for callers that want the memory total).
+// Returning the index lets loadIndex() self-heal a stale/foreign on-disk schema
+// in a single pass instead of returning a bare {count} that breaks search().
 function rebuildIndex() {
   const memories = readMemories();
-  let index = { tokens: {}, docCount: 0, avgDocLength: 0, totalLength: 0 };
+  let index = emptyIndex();
   for (const m of memories) {
-    index = indexMemory(index, m);
+    if (m && m.id) index = indexMemory(index, m);
   }
-  saveIndex(index);
-  return { count: memories.length };
+  try { saveIndex(index); } catch { /* read-only fs — keep in-memory index */ }
+  index.count = memories.length;
+  return index;
 }
 
 function stats() {