knoxis-helper 1.4.2 → 1.4.4

package/lib/knoxis-local-agent.js

@@ -426,6 +426,20 @@ function sendJSON(res, statusCode, data, requestOrigin) {
   res.end(JSON.stringify(data));
 }
 
+// Resolve the interactive pair programming script
+function resolveInteractiveScript() {
+  const candidates = [
+    path.join(__dirname, 'knoxis-interactive-pair.js'),
+    path.join(__dirname, '..', 'knoxis-interactive-pair.js'),
+    path.join(os.homedir(), '.knoxis', 'agent', 'knoxis-interactive-pair.js'),
+    path.join(__dirname, '..', '..', 'knoxis-interactive-pair.js'),
+  ];
+  for (const candidate of candidates) {
+    if (fs.existsSync(candidate)) return candidate;
+  }
+  return null;
+}
+
 // Request handler
 async function handleRequest(req, res) {
   const parsedUrl = url.parse(req.url, true);
@@ -679,20 +693,6 @@ async function handleRequest(req, res) {
 
   // ===== PAIR PROGRAMMING ENDPOINTS =====
 
-  // Resolve the interactive pair programming script
-  function resolveInteractiveScript() {
-    const candidates = [
-      path.join(__dirname, 'knoxis-interactive-pair.js'),
-      path.join(__dirname, '..', 'knoxis-interactive-pair.js'),
-      path.join(os.homedir(), '.knoxis', 'agent', 'knoxis-interactive-pair.js'),
-      path.join(__dirname, '..', '..', 'knoxis-interactive-pair.js'),
-    ];
-    for (const candidate of candidates) {
-      if (fs.existsSync(candidate)) return candidate;
-    }
-    return null;
-  }
-
   // Start pair programming session (opens terminal)
   if (pathname === '/pair/start' && method === 'POST') {
     // Build CLAUDE.md content from task when backend doesn't provide claudeMdContent
@@ -876,7 +876,15 @@ end tell
 }
 
 /**
- * Open terminal on Windows
+ * Open terminal on Windows.
+ *
+ * If the agent is running elevated (admin), Windows won't let us spawn an
+ * unelevated child directly — `start cmd` inherits the parent's integrity
+ * level. We detect that case and route through a one-shot scheduled task
+ * at /rl LIMITED, which runs as the interactive user at medium integrity.
+ * That matters because claude's credentials live under the user's real
+ * %USERPROFILE%\.claude\, not the admin profile, so an elevated cmd can't
+ * find them and hangs on launch.
  */
 function openWindowsTerminal(workspaceDir, command) {
   return new Promise((resolve, reject) => {
@@ -884,16 +892,57 @@ function openWindowsTerminal(workspaceDir, command) {
       fs.mkdirSync(workspaceDir, { recursive: true });
     }
 
-    const fullCommand = `start cmd /K "cd /d "${workspaceDir}" && ${command}"`;
+    // `net session` exits 0 only when elevated.
+    exec('net session >nul 2>&1', (elevErr) => {
+      const isElevated = !elevErr;
 
-    exec(fullCommand, (error) => {
-      if (error) {
-        console.error('❌ Windows terminal error:', error);
-        reject(error);
-      } else {
-        console.log('✅ Terminal opened on Windows');
-        resolve();
+      if (!isElevated) {
+        const fullCommand = `start cmd /K "cd /d "${workspaceDir}" && ${command}"`;
+        exec(fullCommand, (error) => {
+          if (error) {
+            console.error('❌ Windows terminal error:', error);
+            reject(error);
+          } else {
+            console.log('✅ Terminal opened on Windows');
+            resolve();
+          }
+        });
+        return;
       }
+
+      const tempBat = path.join(
+        os.tmpdir(),
+        `knoxis-launch-${process.pid}-${Date.now()}.bat`
+      );
+      const batContent = `@echo off\r\ncd /d "${workspaceDir}"\r\n${command}\r\ncmd /K\r\n`;
+      fs.writeFileSync(tempBat, batContent);
+
+      const taskName = `KnoxisSpawn_${process.pid}_${Date.now()}`;
+      const createCmd = `schtasks /create /tn "${taskName}" /tr "${tempBat}" /sc once /st 00:00 /it /rl LIMITED /f`;
+
+      exec(createCmd, (cErr) => {
+        if (cErr) {
+          try { fs.unlinkSync(tempBat); } catch (_) {}
+          console.error('❌ Windows terminal error (schtasks create):', cErr);
+          return reject(cErr);
+        }
+
+        exec(`schtasks /run /tn "${taskName}"`, (rErr) => {
+          // Task registration cleanup. Leave the .bat in %TEMP% — cmd may
+          // still have an open handle to it, and the OS cleans %TEMP%.
+          setTimeout(() => {
+            exec(`schtasks /delete /tn "${taskName}" /f`, () => {});
+          }, 5000);
+
+          if (rErr) {
+            console.error('❌ Windows terminal error (schtasks run):', rErr);
+            reject(rErr);
+          } else {
+            console.log('✅ Terminal opened on Windows (de-elevated via scheduled task)');
+            resolve();
+          }
+        });
+      });
     });
   });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knoxis-helper",
-  "version": "1.4.2",
+  "version": "1.4.4",
   "description": "Local helper for Knoxis pair programming - connects your machine to Knoxis on qig.ai",
   "bin": {
     "knoxis-helper": "./bin/knoxis-helper.js"