knosky 0.4.0 → 0.4.1

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 All notable changes to KnoSky. Versions are git-tagged on this repo.
 
+## [0.4.1] - 2026-06-29 — Security review fixes
+
+### Security
+- **The fail-closed secret scan now actually fails closed.** It previously ran *after* scrubbing, so a secret in a title/heading/summary was silently redacted instead of blocking the build. It now scans the **un-scrubbed** projections before serialization and blocks (the post-scrub residual is kept as a defense-in-depth gap detector). A secret in a heading now stops the build.
+- **Embedded mode is fail-closed.** The postMessage bridge now requires a non-empty `window.__KC_ALLOWED_ORIGINS` allowlist (the bridge is disabled if it is empty), only accepts messages from the embedding parent frame, and never broadcasts readiness to `"*"`.
+
+### Added
+- `test/security-fixtures.mjs` — pure-Node regression tests (secret block, ignore rules, XSS escaping, embed fail-closed). Run `node test/security-fixtures.mjs`.
+- `.github/workflows/ci.yml` — runs the fixtures + `npm audit` on every PR.
+- Root `package-lock.json` for reproducible `npx` / `npm ci` installs.
+
+### Changed
+- README: removed a "zero data risk" line that contradicted PRIVACY.md.
+
 ## [0.4.0] - 2026-06-29 — File Connections + churn (code-intel)
 
 ### Added

package/README.md

@@ -21,7 +21,7 @@ Your project grows faster than anyone can hold in their head. Hundreds of files,
 - **See your whole project in one screen.** Instead of scrolling a file tree, you see the *shape* of everything — which areas are big, how they connect, where the gaps are. New collaborators get oriented in minutes, not weeks.
 - **Find anything in seconds.** Search the city — or ask your assistant *"where does auth live / what did we decide about billing"* — and jump straight to the **live file**.
 - **Your AI answers from YOUR source, with citations.** Connect it to Claude / Cursor / VS Code / Gemini and your assistant stops guessing about your codebase — it cites the real file, every time.
-- **Zero setup tax, zero data risk.** Point it at a folder → a city in under a minute. Deterministic, **$0 tokens** to keep fresh, and **nothing ever leaves your machine.**
+- **Zero setup tax, local-first by default.** Point it at a folder → a city in under a minute. Deterministic, **$0 tokens** to keep fresh, **nothing ever leaves your machine**, and a fail-closed secret scan before you share. (KnoSky does not claim "zero data risk" — see [PRIVACY.md](./PRIVACY.md).)
 
 **Net:** faster comprehension, reliable recall of your own knowledge, and a grounded AI — without giving up privacy or paying a cent.
 

package/core/fs-indexer.mjs

@@ -143,6 +143,20 @@ if (!NO_CHURN) {
   }
 }
 
+// --- fail-closed secret scan on RAW projections, BEFORE scrubbing (the decisive boundary).
+// Scans exactly the text that will be emitted (title/summary/headings/tags + relative path) in
+// its un-scrubbed form, so detection cannot be defeated by serializeNode()'s scrub. ---
+const _NL = String.fromCharCode(10);
+const rawText = raw.map(n => [
+  n.title, n.summary,
+  (n.headings || []).join(_NL),
+  (n.tags || []).join(' '),
+  n.provenance && n.provenance.ref,
+].filter(Boolean).join(_NL)).join(_NL);
+const preHits = findSecrets(rawText);
+const preTotal = preHits.reduce((a, h) => a + h[1], 0);
+const preList = preHits.map(h => h[0] + ':' + h[1]).join(', ');
+
 const nodes = raw.map(serializeNode);
 const catIds = [...new Set(nodes.map(n => n.category))].sort();
 const categories = deriveCategories(catIds);
@@ -170,21 +184,25 @@ console.log('post-scrub leak hits (emails/keys, should be ~0):', leakHits);
 console.log('redacted-path files skipped:', redactedPaths);
 if (flags.length) console.log('flags:', flags.join('; '));
 
-// --- fail-closed safe-share audit on the FINAL emitted projections (defense in depth) ---
-const secretHits = findSecrets(blob);
-const totalSecrets = secretHits.reduce((a, h) => a + h[1], 0);
-const secretList = secretHits.map(h => h[0] + ':' + h[1]).join(', ');
+// --- fail-closed safe-share audit.
+// PRIMARY   = pre-scrub detection (preTotal, computed above) -> the real boundary.
+// SECONDARY = post-scrub residual on the emitted artifact -> flags scrub gaps (defense in depth). ---
+const residualHits = findSecrets(blob);
+const residualTotal = residualHits.reduce((a, h) => a + h[1], 0);
+const residualList = residualHits.map(h => h[0] + ':' + h[1]).join(', ');
 if (SHARE_SAFE) {
   console.log('');
   console.log('KnoSky safety report');
   console.log('- Files scanned:', scanned);
   console.log('- Files skipped (redact-path):', redactedPaths);
-  console.log('- Secrets found:', totalSecrets, totalSecrets ? '[' + secretList + ']' : '');
+  console.log('- Secrets found (pre-scrub):', preTotal, preTotal ? '[' + preList + ']' : '');
+  console.log('- Residual after scrub (should be 0):', residualTotal, residualTotal ? '[' + residualList + ']' : '');
   console.log('- Absolute path in output:', INCLUDE_ABS ? 'INCLUDED' : 'removed (basename only)');
-  console.log('- Risk level:', totalSecrets ? 'HIGH' : 'Low');
+  console.log('- Risk level:', (preTotal || residualTotal) ? 'HIGH' : 'Low');
 }
-if (totalSecrets && !ALLOW_LEAKS) {
-  console.error('BLOCKED: ' + totalSecrets + ' secret-like value(s) in the index [' + secretList + ']. Nothing written.');
+if ((preTotal || residualTotal) && !ALLOW_LEAKS) {
+  const why = preTotal ? preList : residualList;
+  console.error('BLOCKED: ' + (preTotal || residualTotal) + ' secret-like value(s) detected [' + why + ']. Nothing written.');
   console.error('Add the offending paths to .kcignore or pass --redact <term>, then rebuild. Override with --allow-leaks (not recommended).');
   process.exit(1);
 }

package/mcp/server.mjs

@@ -9,7 +9,7 @@ const CITY = process.env.KC_CITY || process.argv[2];
 if (!CITY) { console.error("Knowledge City MCP: set KC_CITY (or pass a path) to a city-data.v2.json"); process.exit(1); }
 const ctx = load(CITY);
 
-const server = new McpServer({ name: "knowledge-city", version: "0.4.0" });
+const server = new McpServer({ name: "knowledge-city", version: "0.4.1" });
 
 server.registerTool("kc_search", {
   title: "Search the Knowledge City",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knosky",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Turn any repo or docs folder into an explorable city, plus a local MCP that grounds your AI in your own source with citations. Local-first, free, $0 tokens.",
   "type": "module",
   "bin": {

package/renderer/city.template.html

@@ -690,20 +690,25 @@
 
   // ---------- host bridge over postMessage (embedded mode ONLY; OFF in the standalone gift) ----------
   if(window.__KC_EMBED__){
-    var KC_OK=window.__KC_ALLOWED_ORIGINS||[];
-    window.addEventListener('message',function(ev){
-      if(KC_OK.length&&KC_OK.indexOf(ev.origin)===-1)return;   // origin allowlist
-      var d=ev&&ev.data;if(!d||typeof d!=='object')return;
-      if(d.type==='kc:data'){ingest(d.payload);return;}
-      if(d.type==='kc:refit'){resize();if(typeof fitAll==='function'){fitAll();cam.x=cam.tx;cam.y=cam.ty;cam.zoom=cam.tz;}return;}
-      if(d.type==='kc:focus'&&d.id!=null){var id=String(d.id);if(byId[id]){selectBuilding(id);}}
-    });
+    var KC_OK=(Array.isArray(window.__KC_ALLOWED_ORIGINS)?window.__KC_ALLOWED_ORIGINS:[]).filter(Boolean);
+    if(!KC_OK.length){
+      console.warn('KnoSky embed disabled: window.__KC_ALLOWED_ORIGINS is empty. Set at least one allowed origin to enable the postMessage bridge.');
+    }else{
+      window.addEventListener('message',function(ev){
+        if(KC_OK.indexOf(ev.origin)===-1)return;   // origin allowlist (REQUIRED, fail-closed)
+        if(ev.source!==window.parent)return;       // only accept from the embedding parent
+        var d=ev&&ev.data;if(!d||typeof d!=='object')return;
+        if(d.type==='kc:data'){ingest(d.payload);return;}
+        if(d.type==='kc:refit'){resize();if(typeof fitAll==='function'){fitAll();cam.x=cam.tx;cam.y=cam.ty;cam.zoom=cam.tz;}return;}
+        if(d.type==='kc:focus'&&d.id!=null){var id=String(d.id);if(byId[id]){selectBuilding(id);}}
+      });
+    }
   }
   if(window.__KC_KENNEY__)loadKenney();
   // Standalone (local product): render immediately from injected page data.
   try{ if(window.__KC_DATA__&&typeof window.__KC_DATA__==='object'&&Array.isArray(window.__KC_DATA__.nodes)) ingest(window.__KC_DATA__); }catch(e){}
   // Announce readiness to an authenticated parent (embedded mode only, no wildcard broadcast in standalone).
-  if(window.__KC_EMBED__){try{window.parent&&window.parent.postMessage({type:"kc:ready"},(window.__KC_ALLOWED_ORIGINS&&window.__KC_ALLOWED_ORIGINS[0])||"*");}catch(e){}}
+  if(window.__KC_EMBED__){var KC_RDY=(Array.isArray(window.__KC_ALLOWED_ORIGINS)?window.__KC_ALLOWED_ORIGINS:[]).filter(Boolean);if(KC_RDY.length){try{window.parent&&window.parent.postMessage({type:"kc:ready"},KC_RDY[0]);}catch(e){}}}
 })();
 </script>
 </body>