knip 6.35.0 → 6.35.1

package/dist/IssueCollector.d.ts

@@ -12,6 +12,7 @@ export declare class IssueCollector {
     private referencedFiles;
     private configurationHints;
     private tagHints;
+    private hasConfigLoadErrors;
     private ignorePatterns;
     private ignoreFilesPatterns;
     private isMatch;
@@ -46,12 +47,14 @@ export declare class IssueCollector {
     addIssue(issue: Issue): true | undefined;
     addConfigurationHint(issue: ConfigurationHint): void;
     addTagHint(issue: TagHint): void;
+    addConfigLoadError(): void;
     purge(): Set<string>;
     getIssues(): {
         issues: import("./types/issues.ts").Issues;
         counters: import("./types/issues.ts").Counters;
         tagHints: Set<TagHint>;
         configurationHints: ConfigurationHint[];
+        hasConfigLoadErrors: boolean;
     };
     getUnusedIgnorePatternHints(options: MainOptions): ConfigurationHint[];
     private retainedIssues;

package/dist/IssueCollector.js

@@ -22,6 +22,7 @@ export class IssueCollector {
     referencedFiles = new Set();
     configurationHints = new Map();
     tagHints = new Set();
+    hasConfigLoadErrors = false;
     ignorePatterns = new Set();
     ignoreFilesPatterns = new Set();
     isMatch;
@@ -162,6 +163,9 @@ export class IssueCollector {
     addTagHint(issue) {
         this.tagHints.add(issue);
     }
+    addConfigLoadError() {
+        this.hasConfigLoadErrors = true;
+    }
     purge() {
         const unusedFiles = new Set();
         for (const issues of Object.values(this.issues.files)) {
@@ -178,6 +182,7 @@ export class IssueCollector {
             counters: this.counters,
             tagHints: this.tagHints,
             configurationHints: Array.from(this.configurationHints.values()),
+            hasConfigLoadErrors: this.hasConfigLoadErrors,
         };
     }
     getUnusedIgnorePatternHints(options) {

package/dist/WorkspaceWorker.d.ts

@@ -16,6 +16,7 @@ type WorkspaceManagerOptions = {
     dependencies: DependencySet;
     rootManifest: Manifest | undefined;
     handleInput: HandleInput;
+    handleConfigLoadError: () => void;
     findWorkspaceByFilePath: (filePath: string) => Workspace | undefined;
     getManifest: (dir: string) => Manifest | undefined;
     readRawFile: (filePath: string) => string;
@@ -38,6 +39,7 @@ export declare class WorkspaceWorker {
     rootManifest: Manifest | undefined;
     dependencies: DependencySet;
     handleInput: HandleInput;
+    handleConfigLoadError: () => void;
     findWorkspaceByFilePath: (filePath: string) => Workspace | undefined;
     getManifest: (dir: string) => Manifest | undefined;
     readRawFile: (filePath: string) => string;
@@ -49,7 +51,7 @@ export declare class WorkspaceWorker {
     enabledPluginsInAncestors: string[];
     cache: CacheConsultant<CacheItem>;
     configFilesMap: Map<string, Map<PluginName, Set<string>>>;
-    constructor({ name, dir, config, manifest, dependencies, rootManifest, negatedWorkspacePatterns, ignoredWorkspacePatterns, enabledPluginsInAncestors, handleInput, findWorkspaceByFilePath, getManifest, readRawFile, configFilesMap, options, }: WorkspaceManagerOptions);
+    constructor({ name, dir, config, manifest, dependencies, rootManifest, negatedWorkspacePatterns, ignoredWorkspacePatterns, enabledPluginsInAncestors, handleInput, handleConfigLoadError, findWorkspaceByFilePath, getManifest, readRawFile, configFilesMap, options, }: WorkspaceManagerOptions);
     init(): Promise<void>;
     private determineEnabledPlugins;
     private getConfigForPlugin;

package/dist/WorkspaceWorker.js

@@ -29,6 +29,7 @@ export class WorkspaceWorker {
     rootManifest;
     dependencies;
     handleInput;
+    handleConfigLoadError;
     findWorkspaceByFilePath;
     getManifest;
     readRawFile;
@@ -40,7 +41,7 @@ export class WorkspaceWorker {
     enabledPluginsInAncestors;
     cache;
     configFilesMap;
-    constructor({ name, dir, config, manifest, dependencies, rootManifest, negatedWorkspacePatterns, ignoredWorkspacePatterns, enabledPluginsInAncestors, handleInput, findWorkspaceByFilePath, getManifest, readRawFile, configFilesMap, options, }) {
+    constructor({ name, dir, config, manifest, dependencies, rootManifest, negatedWorkspacePatterns, ignoredWorkspacePatterns, enabledPluginsInAncestors, handleInput, handleConfigLoadError, findWorkspaceByFilePath, getManifest, readRawFile, configFilesMap, options, }) {
         this.name = name;
         this.dir = dir;
         this.config = config;
@@ -52,6 +53,7 @@ export class WorkspaceWorker {
         this.enabledPluginsInAncestors = enabledPluginsInAncestors;
         this.configFilesMap = configFilesMap;
         this.handleInput = handleInput;
+        this.handleConfigLoadError = handleConfigLoadError;
         this.findWorkspaceByFilePath = findWorkspaceByFilePath;
         this.getManifest = getManifest;
         this.readRawFile = readRawFile;
@@ -378,6 +380,7 @@ export class WorkspaceWorker {
                                 if (!(error instanceof Error))
                                     throw error;
                                 hasLoadConfigError = true;
+                                this.handleConfigLoadError();
                                 const relPath = toRelative(configFilePath, this.options.cwd);
                                 const cause = formatCauseMessage(error, this.options.cwd);
                                 logError(`Error loading ${relPath} (${cause})`);

package/dist/cli.js

@@ -54,6 +54,10 @@ const main = async () => {
             console.log('\nTotal running time:', prettyMilliseconds(duration));
             perfObserver.reset();
         }
+        if (results.hasConfigLoadErrors) {
+            process.exitCode = 2;
+            return;
+        }
         if (!args['no-exit-code'] &&
             (totalErrorCount > options.maxIssues ||
                 (!options.isDisableConfigHints &&

package/dist/graph/build.js

@@ -88,6 +88,7 @@ export async function build({ chief, collector, counselor, deputy, principal, is
             dependencies,
             rootManifest,
             handleInput: (input) => handleInput(input, workspace),
+            handleConfigLoadError: () => collector.addConfigLoadError(),
             findWorkspaceByFilePath: chief.findWorkspaceByFilePath.bind(chief),
             getManifest,
             negatedWorkspacePatterns: chief.getNegatedWorkspacePatterns(name),

package/dist/index.d.ts

@@ -4,6 +4,7 @@ export declare const main: (options: MainOptions) => Promise<{
     counters: import("./types/issues.ts").Counters;
     tagHints: Set<import("./types/issues.ts").TagHint>;
     configurationHints: import("./types/issues.ts").ConfigurationHint[];
+    hasConfigLoadErrors: boolean;
     selectedWorkspaces: string[] | undefined;
     includedWorkspaceDirs: string[];
     enabledPlugins: {

package/dist/reporters/util/configuration-hints.d.ts

@@ -18,6 +18,6 @@ export declare const finalizeConfigurationHints: (results: Results, options: {
     cwd: string;
     configFilePath?: string;
 }) => ProcessedHint[];
-export declare const printConfigurationHints: ({ cwd, counters, issues, tagHints, configurationHints, enabledPlugins, isTreatConfigHintsAsErrors, includedWorkspaceDirs, selectedWorkspaces, configFilePath, }: ReporterOptions) => void;
+export declare const printConfigurationHints: ({ cwd, counters, issues, tagHints, configurationHints, hasConfigLoadErrors, enabledPlugins, isTreatConfigHintsAsErrors, includedWorkspaceDirs, selectedWorkspaces, configFilePath, }: ReporterOptions) => void;
 export declare const printTagHints: ({ cwd, tagHints, isTreatTagHintsAsErrors }: ReporterOptions) => void;
 export {};

package/dist/reporters/util/configuration-hints.js

@@ -128,8 +128,17 @@ export const finalizeConfigurationHints = (results, options) => {
         return row;
     }));
 };
-export const printConfigurationHints = ({ cwd, counters, issues, tagHints, configurationHints, enabledPlugins, isTreatConfigHintsAsErrors, includedWorkspaceDirs, selectedWorkspaces, configFilePath, }) => {
-    const rows = finalizeConfigurationHints({ issues, counters, configurationHints, tagHints, includedWorkspaceDirs, selectedWorkspaces, enabledPlugins }, { cwd, configFilePath });
+export const printConfigurationHints = ({ cwd, counters, issues, tagHints, configurationHints, hasConfigLoadErrors, enabledPlugins, isTreatConfigHintsAsErrors, includedWorkspaceDirs, selectedWorkspaces, configFilePath, }) => {
+    const rows = finalizeConfigurationHints({
+        issues,
+        counters,
+        configurationHints,
+        hasConfigLoadErrors,
+        tagHints,
+        includedWorkspaceDirs,
+        selectedWorkspaces,
+        enabledPlugins,
+    }, { cwd, configFilePath });
     if (rows.length > 0) {
         const getTitle = isTreatConfigHintsAsErrors ? getColoredTitle : getDimmedTitle;
         console.warn(getTitle('Configuration hints', configurationHints.length));

package/dist/run.d.ts

@@ -7,6 +7,7 @@ export declare const run: (options: MainOptions) => Promise<{
         counters: import("./types/issues.ts").Counters;
         tagHints: Set<import("./types/issues.ts").TagHint>;
         configurationHints: import("./types/issues.ts").ConfigurationHint[];
+        hasConfigLoadErrors: boolean;
         selectedWorkspaces: string[] | undefined;
         includedWorkspaceDirs: string[];
         enabledPlugins: {
@@ -26,6 +27,7 @@ export declare const run: (options: MainOptions) => Promise<{
             counters: import("./types/issues.ts").Counters;
             tagHints: Set<import("./types/issues.ts").TagHint>;
             configurationHints: import("./types/issues.ts").ConfigurationHint[];
+            hasConfigLoadErrors: boolean;
         };
     } | undefined;
     streamer: ConsoleStreamer;

package/dist/run.js

@@ -114,7 +114,7 @@ export const run = async (options) => {
         if (options.isWatch)
             watch('.', { recursive: true }, session.listener);
     }
-    const { issues, counters, tagHints, configurationHints } = collector.getIssues();
+    const { issues, counters, tagHints, configurationHints, hasConfigLoadErrors } = collector.getIssues();
     if (!options.isWatch)
         streamer.clear();
     if (options.isCache) {
@@ -127,6 +127,7 @@ export const run = async (options) => {
             counters,
             tagHints,
             configurationHints,
+            hasConfigLoadErrors,
             selectedWorkspaces: chief.selectedWorkspaces ? Array.from(chief.selectedWorkspaces) : undefined,
             includedWorkspaceDirs: Array.from(chief.workspacesByDir.keys()),
             enabledPlugins: Object.fromEntries(enabledPluginsStore),

package/dist/types/issues.d.ts

@@ -56,6 +56,7 @@ export type ReporterOptions = {
     counters: Counters;
     tagHints: TagHints;
     configurationHints: ConfigurationHint[];
+    hasConfigLoadErrors: boolean;
     enabledPlugins: Record<string, string[]>;
     isDisableConfigHints: boolean;
     isDisableTagHints: boolean;

package/dist/typescript/resolve-module-names.js

@@ -1,11 +1,11 @@
-import { existsSync, realpathSync } from 'node:fs';
+import { existsSync } from 'node:fs';
 import { isBuiltin } from 'node:module';
 import { DEFAULT_EXTENSIONS, DTS_EXTENSIONS, IS_DTS } from '../constants.js';
 import { isFile } from '../util/fs.js';
 import { getPackageNameFromFilePath, getPackageNameFromModuleSpecifier, sanitizeSpecifier } from '../util/modules.js';
 import { timerify } from '../util/Performance.js';
 import { dirname, extname, isAbsolute, isInNodeModules, join, toPosix } from '../util/path.js';
-import { _createSyncModuleResolver, _resolveModuleSync } from '../util/resolve.js';
+import { _createSyncModuleResolver, _resolveModuleSync, resolvePackageManifestPath } from '../util/resolve.js';
 function pickStringTarget(value) {
     if (typeof value === 'string')
         return value;
@@ -64,40 +64,20 @@ function pickExistingPackageTarget(value, dir, patternMatch, moduleExtensions) {
     }
 }
 const moduleResolutionCaches = [];
-const installedPackageRootCache = new Map();
 export function clearModuleResolutionCaches() {
     for (const cache of moduleResolutionCaches)
         cache.clear();
-    installedPackageRootCache.clear();
-}
-function getInstalledPackageRoot(candidate) {
-    if (installedPackageRootCache.has(candidate))
-        return installedPackageRootCache.get(candidate);
-    let packageRoot;
-    try {
-        packageRoot = toPosix(realpathSync(candidate));
-    }
-    catch { }
-    installedPackageRootCache.set(candidate, packageRoot);
-    return packageRoot;
 }
 function getAttributedPackageName(specifier, containingFile, resolvedFileName) {
     const packageName = getPackageNameFromFilePath(resolvedFileName);
     const specifierPackageName = getPackageNameFromModuleSpecifier(specifier);
     if (!specifierPackageName || specifierPackageName === packageName)
         return packageName;
-    let dir = dirname(containingFile);
-    while (true) {
-        const packageRoot = getInstalledPackageRoot(join(dir, 'node_modules', specifierPackageName));
-        if (packageRoot) {
-            const isResolvedInstall = resolvedFileName === packageRoot || resolvedFileName.startsWith(`${packageRoot}/`);
-            return isResolvedInstall ? specifierPackageName : packageName;
-        }
-        const parent = dirname(dir);
-        if (parent === dir)
-            return packageName;
-        dir = parent;
-    }
+    const manifestPath = resolvePackageManifestPath(specifierPackageName, dirname(containingFile));
+    if (!manifestPath)
+        return packageName;
+    const packageRoot = dirname(manifestPath);
+    return resolvedFileName.startsWith(`${packageRoot}/`) ? specifierPackageName : packageName;
 }
 function compilePathMappings(scopedPaths) {
     if (!scopedPaths)

package/dist/util/watch.d.ts

@@ -41,6 +41,7 @@ export declare const getSessionHandler: (options: MainOptions, { analyzedFiles,
         counters: import("../types/issues.ts").Counters;
         tagHints: Set<import("../types/issues.ts").TagHint>;
         configurationHints: import("../types/issues.ts").ConfigurationHint[];
+        hasConfigLoadErrors: boolean;
     };
 }>;
 export {};

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "6.35.0";
+export declare const version = "6.35.1";

package/dist/version.js

@@ -1 +1 @@
-export const version = '6.35.0';
+export const version = '6.35.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "6.35.0",
+  "version": "6.35.1",
   "description": "Find and fix unused dependencies, exports and files in your TypeScript and JavaScript projects",
   "keywords": [
     "analysis",