knip 5.33.1 → 5.33.3

package/dist/WorkspaceWorker.d.ts

@@ -44,7 +44,6 @@ export declare class WorkspaceWorker {
     private getConfigForPlugin;
     getEntryFilePatterns(): string[];
     getProjectFilePatterns(projectFilePatterns: string[]): string[];
-    getPluginEntryFilePatterns(patterns: string[]): string[];
     getPluginProjectFilePatterns(): string[];
     getPluginConfigPatterns(): string[];
     getProductionEntryFilePatterns(negatedTestFilePatterns: string[]): string[];

package/dist/WorkspaceWorker.js

@@ -89,9 +89,6 @@ export class WorkspaceWorker {
             this.negatedWorkspacePatterns,
         ].flat();
     }
-    getPluginEntryFilePatterns(patterns) {
-        return [patterns, this.negatedWorkspacePatterns].flat();
-    }
     getPluginProjectFilePatterns() {
         const patterns = [];
         for (const [pluginName, plugin] of Object.entries(plugins)) {

package/dist/index.js

@@ -160,7 +160,7 @@ export const main = async (unresolvedConfiguration) => {
                     principal.addProjectPath(projectPath);
             }
             {
-                const patterns = worker.getPluginEntryFilePatterns([...entryFilePatterns, ...productionEntryFilePatterns]);
+                const patterns = [...entryFilePatterns, ...productionEntryFilePatterns];
                 const pluginWorkspaceEntryPaths = await _glob({ ...sharedGlobOptions, patterns });
                 debugLogArray(name, 'Plugin entry paths', pluginWorkspaceEntryPaths);
                 principal.addEntryPaths(pluginWorkspaceEntryPaths, { skipExportsAnalysis: true });

package/dist/plugins/travis/index.js

@@ -2,7 +2,7 @@ import { _glob } from '#p/util/glob.js';
 import { getDependenciesFromScripts } from '../../util/plugin.js';
 const title = 'Travis CI';
 const enablers = 'This plugin is enabled when a `.travis.yml` file is found in the root folder.';
-const isEnabled = async ({ cwd }) => Boolean(await _glob({ cwd, patterns: ['.travis.yml'] }));
+const isEnabled = async ({ cwd }) => (await _glob({ cwd, patterns: ['.travis.yml'] })).length > 0;
 const config = ['.travis.yml'];
 const resolveConfig = async (config, options) => {
     if (!config)

package/dist/typescript/ast-helpers.d.ts

@@ -24,7 +24,7 @@ export declare const isObjectEnumerationCallExpressionArgument: (node: ts.Identi
 export declare const isTopLevel: (node: ts.Node) => boolean;
 export declare const getTypeName: (node: ts.Identifier) => ts.QualifiedName | undefined;
 export declare const isImportSpecifier: (node: ts.Node) => boolean;
-export declare const isReferencedInExportedType: (node: ts.Node) => boolean;
+export declare const isReferencedInExport: (node: ts.Node) => boolean;
 export declare const getExportKeywordNode: (node: ts.Node) => ts.ExportKeyword | undefined;
 export declare const getDefaultKeywordNode: (node: ts.Node) => ts.DefaultKeyword | undefined;
 export declare const hasRequireCall: (node: ts.Node) => boolean;

package/dist/typescript/ast-helpers.js

@@ -172,7 +172,11 @@ const getAncestorTypeDeclaration = (node) => {
         node = node.parent;
     }
 };
-export const isReferencedInExportedType = (node) => {
+export const isReferencedInExport = (node) => {
+    if (ts.isTypeQueryNode(node.parent) && isExported(node.parent.parent))
+        return true;
+    if (ts.isTypeReferenceNode(node.parent) && isExported(node.parent.parent))
+        return true;
     const typeNode = getAncestorTypeDeclaration(node);
     return Boolean(typeNode && isExported(typeNode));
 };

package/dist/typescript/find-internal-references.d.ts

@@ -1,4 +1,4 @@
 import ts from 'typescript';
 import type { Export, ExportMember } from '../types/dependency-graph.js';
 export declare const isType: (item: Export | ExportMember) => boolean;
-export declare const findInternalReferences: (item: Export | ExportMember, sourceFile: ts.SourceFile, typeChecker: ts.TypeChecker, referencedSymbolsInExportedTypes: Set<ts.Symbol>) => [number, boolean];
+export declare const findInternalReferences: (item: Export | ExportMember, sourceFile: ts.SourceFile, typeChecker: ts.TypeChecker, referencedSymbolsInExport: Set<ts.Symbol>, isBindingElement?: boolean) => [number, boolean];

package/dist/typescript/find-internal-references.js

@@ -1,7 +1,7 @@
 import ts from 'typescript';
 import { isIdChar } from '../util/regex.js';
 export const isType = (item) => item.type === 'type' || item.type === 'interface' || item.type === 'enum';
-export const findInternalReferences = (item, sourceFile, typeChecker, referencedSymbolsInExportedTypes) => {
+export const findInternalReferences = (item, sourceFile, typeChecker, referencedSymbolsInExport, isBindingElement) => {
     if (!item.symbol)
         return [0, false];
     if (item.identifier === '')
@@ -12,7 +12,7 @@ export const findInternalReferences = (item, sourceFile, typeChecker, referenced
     const id = item.identifier;
     const symbols = new Set();
     let refCount = 0;
-    let isSymbolInExportedType = false;
+    let isSymbolInExport = false;
     let index = 0;
     while (index < text.length && (index = text.indexOf(id, index)) !== -1) {
         if (!isIdChar(text.charAt(index - 1)) && !isIdChar(text.charAt(index + id.length))) {
@@ -20,21 +20,23 @@ export const findInternalReferences = (item, sourceFile, typeChecker, referenced
             if (!isExportDeclaration) {
                 const symbol = typeChecker.getSymbolAtLocation(ts.getTokenAtPosition(sourceFile, index));
                 if (symbol) {
-                    const isInExportedType = referencedSymbolsInExportedTypes.has(symbol);
-                    if (isInExportedType)
-                        isSymbolInExportedType = true;
+                    const isInExport = referencedSymbolsInExport.has(symbol);
+                    if (isInExport)
+                        isSymbolInExport = true;
                     if (item.symbol === symbol) {
                         refCount++;
-                        if (isInExportedType || isType(item))
-                            return [refCount, isSymbolInExportedType];
+                        if (isInExport || isType(item))
+                            return [refCount, isSymbolInExport];
+                        if (isBindingElement)
+                            return [refCount, true];
                     }
                     const declaration = symbol.declarations?.[0];
                     if (declaration) {
                         if (item.symbol === declaration.name?.flowNode?.node?.symbol) {
-                            return [++refCount, isSymbolInExportedType];
+                            return [++refCount, isSymbolInExport];
                         }
                         if (ts.isImportSpecifier(declaration) && symbols.has(symbol)) {
-                            return [++refCount, isSymbolInExportedType];
+                            return [++refCount, isSymbolInExport];
                         }
                     }
                     symbols.add(symbol);
@@ -43,5 +45,5 @@ export const findInternalReferences = (item, sourceFile, typeChecker, referenced
         }
         index += id.length;
     }
-    return [refCount, isSymbolInExportedType];
+    return [refCount, isSymbolInExport];
 };

package/dist/typescript/get-imports-and-exports.js

@@ -6,7 +6,7 @@ import { addNsValue, addValue, createImports } from '../util/dependency-graph.js
 import { getPackageNameFromFilePath, isStartsLikePackageName, sanitizeSpecifier } from '../util/modules.js';
 import { extname, isInNodeModules } from '../util/path.js';
 import { shouldIgnore } from '../util/tag.js';
-import { getAccessMembers, getDestructuredIds, getJSDocTags, getLineAndCharacterOfPosition, getTypeName, isAccessExpression, isConsiderReferencedNS, isDestructuring, isImportSpecifier, isObjectEnumerationCallExpressionArgument, isReferencedInExportedType, } from './ast-helpers.js';
+import { getAccessMembers, getDestructuredIds, getJSDocTags, getLineAndCharacterOfPosition, getTypeName, isAccessExpression, isConsiderReferencedNS, isDestructuring, isImportSpecifier, isObjectEnumerationCallExpressionArgument, isReferencedInExport, } from './ast-helpers.js';
 import { findInternalReferences, isType } from './find-internal-references.js';
 import getDynamicImportVisitors from './visitors/dynamic-imports/index.js';
 import getExportVisitors from './visitors/exports/index.js';
@@ -45,7 +45,7 @@ const getImportsAndExports = (sourceFile, resolveModule, typeChecker, options) =
     const scripts = new Set();
     const traceRefs = new Set();
     const importedInternalSymbols = new Map();
-    const referencedSymbolsInExportedTypes = new Set();
+    const referencedSymbolsInExport = new Set();
     const visitors = getVisitors(sourceFile);
     const addNsMemberRefs = (internalImport, namespace, member) => {
         if (typeof member === 'string') {
@@ -280,10 +280,8 @@ const getImportsAndExports = (sourceFile, resolveModule, typeChecker, options) =
                         }
                     }
                 }
-                if (!isTopLevel && symbol.exportSymbol) {
-                    if (ts.isTypeQueryNode(node.parent) || isReferencedInExportedType(node)) {
-                        referencedSymbolsInExportedTypes.add(symbol.exportSymbol);
-                    }
+                if (!isTopLevel && symbol.exportSymbol && isReferencedInExport(node)) {
+                    referencedSymbolsInExport.add(symbol.exportSymbol);
                 }
             }
         }
@@ -308,17 +306,22 @@ const getImportsAndExports = (sourceFile, resolveModule, typeChecker, options) =
         for (const node of pragmaImports)
             addImport(node, sourceFile);
     for (const item of exports.values()) {
-        const isType_ = isType(item);
-        if (item.symbol && referencedSymbolsInExportedTypes.has(item.symbol)) {
+        if (item.symbol && referencedSymbolsInExport.has(item.symbol)) {
             item.refs = [1, true];
         }
-        else if (ignoreExportsUsedInFile === true ||
-            (typeof ignoreExportsUsedInFile === 'object' && item.type !== 'unknown' && ignoreExportsUsedInFile[item.type]) ||
-            isType_) {
-            item.refs = findInternalReferences(item, sourceFile, typeChecker, referencedSymbolsInExportedTypes);
+        else {
+            const isBindingElement = item.symbol?.valueDeclaration && ts.isBindingElement(item.symbol.valueDeclaration);
+            if (ignoreExportsUsedInFile === true ||
+                (typeof ignoreExportsUsedInFile === 'object' &&
+                    item.type !== 'unknown' &&
+                    ignoreExportsUsedInFile[item.type]) ||
+                isType(item) ||
+                isBindingElement) {
+                item.refs = findInternalReferences(item, sourceFile, typeChecker, referencedSymbolsInExport, isBindingElement);
+            }
         }
         for (const member of item.members) {
-            member.refs = findInternalReferences(member, sourceFile, typeChecker, referencedSymbolsInExportedTypes);
+            member.refs = findInternalReferences(member, sourceFile, typeChecker, referencedSymbolsInExport);
             member.symbol = undefined;
         }
         item.symbol = undefined;

package/dist/typescript/visitors/exports/exportKeyword.js

@@ -19,6 +19,7 @@ export default visit(() => true, (node, { isFixExports, isFixTypes, isReportClas
                                 : undefined;
                             return {
                                 node: element,
+                                symbol: element.symbol,
                                 identifier: element.name.escapedText.toString(),
                                 type: SymbolType.UNKNOWN,
                                 pos: element.name.getStart(),
@@ -33,6 +34,7 @@ export default visit(() => true, (node, { isFixExports, isFixTypes, isReportClas
                             const fix = isFixExports ? [element.getStart(), element.getEnd(), FIX_FLAGS.NONE] : undefined;
                             return {
                                 node: element,
+                                symbol: element.symbol,
                                 identifier: element.getText(),
                                 type: SymbolType.UNKNOWN,
                                 pos: element.getStart(),

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "5.33.1";
+export declare const version = "5.33.3";

package/dist/version.js

@@ -1 +1 @@
-export const version = '5.33.1';
+export const version = '5.33.3';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "5.33.1",
+  "version": "5.33.3",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://knip.dev",
   "repository": {