knip 3.8.0 → 3.8.1

package/dist/ConfigurationChief.js

@@ -334,8 +334,8 @@ export class ConfigurationChief {
         const project = workspaceConfig.project ? arrayify(workspaceConfig.project) : defaultConfig.project;
         const paths = workspaceConfig.paths ?? defaultConfig.paths;
         const ignore = arrayify(workspaceConfig.ignore);
-        const ignoreBinaries = arrayify(workspaceConfig.ignoreBinaries);
-        const ignoreDependencies = arrayify(workspaceConfig.ignoreDependencies);
+        const ignoreBinaries = arrayify(workspaceConfig.ignoreBinaries).map(toRegexOrString);
+        const ignoreDependencies = arrayify(workspaceConfig.ignoreDependencies).map(toRegexOrString);
         const isIncludeEntryExports = workspaceConfig.includeEntryExports ?? this.config.isIncludeEntryExports;
         const plugins = {};
         for (const [name, pluginConfig] of Object.entries(this.config.rootPluginConfigs)) {

package/dist/DependencyDeputy.js

@@ -1,7 +1,7 @@
 import { isBuiltin } from 'node:module';
 import { IGNORE_DEFINITELY_TYPED, IGNORED_DEPENDENCIES, IGNORED_GLOBAL_BINARIES, ROOT_WORKSPACE_NAME, } from './constants.js';
 import { isDefinitelyTyped, getDefinitelyTypedFor, getPackageFromDefinitelyTyped } from './util/modules.js';
-import { hasMatch, hasMatchInArray, hasMatchInSet } from './util/regex.js';
+import { hasMatch, hasMatchInArray, hasMatchInSet, toRegexOrString, findKey } from './util/regex.js';
 export class DependencyDeputy {
     isProduction;
     isStrict;
@@ -49,8 +49,8 @@ export class DependencyDeputy {
         });
     }
     addIgnored(ignoreBinaries, ignoreDependencies) {
-        this.ignoreBinaries = ignoreBinaries;
-        this.ignoreDependencies = ignoreDependencies;
+        this.ignoreBinaries = ignoreBinaries.map(toRegexOrString);
+        this.ignoreDependencies = ignoreDependencies.map(toRegexOrString);
     }
     getWorkspaceManifest(workspaceName) {
         return this._manifests.get(workspaceName);
@@ -236,22 +236,32 @@ export class DependencyDeputy {
             const referencedDependencies = this.referencedDependencies.get(workspaceName);
             const referencedBinaries = this.referencedBinaries.get(workspaceName);
             const installedBinaries = this.getInstalledBinaries(workspaceName);
+            const ignoredBinaries = this._manifests.get(workspaceName)?.ignoreBinaries ?? [];
+            const ignoredDependencies = this._manifests.get(workspaceName)?.ignoreDependencies ?? [];
             referencedDependencies?.forEach(pkg => {
-                for (const key of rootIgnoreDependencies.keys()) {
+                for (const key of [...ignoredDependencies, ...rootIgnoreDependencies.keys()]) {
                     if ((typeof key === 'string' && key === pkg) || (key instanceof RegExp && key.test(pkg))) {
-                        rootIgnoreDependencies.set(key, rootIgnoreDependencies.get(key) + 1);
-                        return;
+                        const rootKey = typeof key === 'string' ? key : findKey(rootIgnoreDependencies, key);
+                        if (rootKey && rootIgnoreDependencies.has(rootKey)) {
+                            rootIgnoreDependencies.set(rootKey, rootIgnoreDependencies.get(rootKey) + 1);
+                            return;
+                        }
                     }
                 }
             });
             referencedBinaries?.forEach(binaryName => {
-                for (const key of rootIgnoreBinaries.keys()) {
+                for (const key of [...ignoredBinaries, ...rootIgnoreBinaries.keys()]) {
                     if ((typeof key === 'string' && key === binaryName) || (key instanceof RegExp && key.test(binaryName))) {
-                        rootIgnoreBinaries.set(key, rootIgnoreBinaries.get(key) + 1);
-                        return;
+                        const rootKey = typeof key === 'string' ? key : findKey(rootIgnoreBinaries, key);
+                        if (rootKey && rootIgnoreBinaries.has(rootKey)) {
+                            rootIgnoreBinaries.set(rootKey, rootIgnoreBinaries.get(rootKey) + 1);
+                            return;
+                        }
                     }
                 }
             });
+            if (workspaceName === ROOT_WORKSPACE_NAME)
+                continue;
             const dependencies = [
                 ...this.getProductionDependencies(workspaceName),
                 ...this.getDevDependencies(workspaceName),
@@ -261,11 +271,11 @@ export class DependencyDeputy {
                 .filter(packageName => {
                 if (hasMatchInArray(IGNORED_DEPENDENCIES, packageName))
                     return true;
-                if (workspaceName !== ROOT_WORKSPACE_NAME && this.ignoreDependencies.includes(packageName))
+                if (this.ignoreDependencies.includes(packageName))
                     return true;
                 const isReferenced = hasMatchInSet(referencedDependencies, packageName);
                 const isListed = hasMatchInArray(dependencies, packageName) && !hasMatchInArray(peerDependencies, packageName);
-                return isListed && isReferenced;
+                return (isListed && isReferenced) || (!isReferenced && !isListed);
             })
                 .forEach(identifier => {
                 configurationHints.add({ workspaceName, identifier, type: 'ignoreDependencies' });
@@ -274,11 +284,11 @@ export class DependencyDeputy {
                 .filter(binaryName => {
                 if (hasMatchInArray(IGNORED_GLOBAL_BINARIES, binaryName))
                     return true;
-                if (workspaceName !== ROOT_WORKSPACE_NAME && this.ignoreBinaries.includes(binaryName))
+                if (this.ignoreBinaries.includes(binaryName))
                     return true;
                 const isReferenced = hasMatchInSet(referencedBinaries, binaryName);
                 const isInstalled = hasMatchInArray(Array.from(installedBinaries?.keys() ?? []), binaryName);
-                return isReferenced && isInstalled;
+                return (isReferenced && isInstalled) || (!isInstalled && !isReferenced);
             })
                 .forEach(identifier => configurationHints.add({ workspaceName, identifier, type: 'ignoreBinaries' }));
         }

package/dist/types/config.d.ts

@@ -6,6 +6,7 @@ import type { Rules } from './issues.js';
 export type RawConfiguration = z.infer<typeof ConfigurationValidator>;
 export type RawPluginConfiguration = z.infer<typeof pluginSchema>;
 type NormalizedGlob = string[];
+type IgnorePatterns = (string | RegExp)[];
 export type PluginName = keyof typeof Plugins;
 export type PluginMap = typeof Plugins;
 export type EnsuredPluginConfiguration = {
@@ -20,8 +21,8 @@ interface BaseWorkspaceConfiguration {
     project: NormalizedGlob;
     paths: Record<string, string[]>;
     ignore: NormalizedGlob;
-    ignoreBinaries: string[];
-    ignoreDependencies: string[];
+    ignoreBinaries: IgnorePatterns;
+    ignoreDependencies: IgnorePatterns;
     isIncludeEntryExports: boolean;
 }
 export interface WorkspaceConfiguration extends BaseWorkspaceConfiguration, Partial<PluginsConfiguration> {
@@ -32,8 +33,8 @@ export interface Configuration {
     include: string[];
     exclude: string[];
     ignore: NormalizedGlob;
-    ignoreBinaries: (string | RegExp)[];
-    ignoreDependencies: (string | RegExp)[];
+    ignoreBinaries: IgnorePatterns;
+    ignoreDependencies: IgnorePatterns;
     ignoreExportsUsedInFile: boolean | Partial<Record<IgnorableExport, boolean>>;
     ignoreWorkspaces: string[];
     isIncludeEntryExports: boolean;

package/dist/util/regex.d.ts

@@ -2,3 +2,4 @@ export declare const toRegexOrString: (value: string | RegExp) => string | RegEx
 export declare const hasMatch: (haystack: undefined | (string | RegExp)[], needle: string) => boolean | undefined;
 export declare const hasMatchInSet: (haystack: undefined | Set<string>, needle: string | RegExp) => boolean | undefined;
 export declare const hasMatchInArray: (haystack: string[], needle: string | RegExp) => boolean;
+export declare const findKey: (map: Map<string | RegExp, unknown>, key: RegExp) => string | RegExp | undefined;

package/dist/util/regex.js

@@ -2,3 +2,4 @@ export const toRegexOrString = (value) => typeof value === 'string' && /[*+\\(|{
 export const hasMatch = (haystack, needle) => haystack && haystack.some(n => (typeof n === 'string' ? n === needle : n.test(needle)));
 export const hasMatchInSet = (haystack, needle) => haystack && (typeof needle === 'string' ? haystack.has(needle) : [...haystack].some(n => needle.test(n)));
 export const hasMatchInArray = (haystack, needle) => typeof needle === 'string' ? haystack.includes(needle) : haystack.some(n => needle.test(n));
+export const findKey = (map, key) => [...map.keys()].find(k => k instanceof RegExp && k.source === key.source);

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "3.8.0";
+export declare const version = "3.8.1";

package/dist/version.js

@@ -1 +1 @@
-export const version = '3.8.0';
+export const version = '3.8.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "3.8.0",
+  "version": "3.8.1",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://knip.dev",
   "repository": {
@@ -58,7 +58,7 @@
     "@npmcli/package-json": "5.0.0",
     "@pkgjs/parseargs": "0.11.0",
     "@pnpm/logger": "5.0.0",
-    "@pnpm/workspace.pkgs-graph": "^2.0.11",
+    "@pnpm/workspace.pkgs-graph": "^2.0.12",
     "@snyk/github-codeowners": "1.1.0",
     "chalk": "^5.3.0",
     "easy-table": "1.2.0",
@@ -94,8 +94,8 @@
     "c8": "8.0.1",
     "eslint": "^8.55.0",
     "playwright": "^1.40.1",
-    "prettier": "^3.1.0",
-    "release-it": "^17.0.0",
+    "prettier": "^3.1.1",
+    "release-it": "^17.0.1",
     "tsx": "^4.6.2",
     "type-fest": "^4.8.3",
     "typescript": "5.3.3"