knip 2.40.0 → 2.40.2

package/dist/ConfigurationChief.d.ts

@@ -6,6 +6,7 @@ import type { PackageJson } from '@npmcli/package-json';
 type ConfigurationManagerOptions = {
     cwd: string;
     isProduction: boolean;
+    isStrict: boolean;
 };
 export type Workspace = {
     name: string;
@@ -19,6 +20,7 @@ export type Workspace = {
 export declare class ConfigurationChief {
     cwd: string;
     isProduction: boolean;
+    isStrict: boolean;
     config: Configuration;
     manifestPath?: string;
     manifest?: PackageJson;
@@ -36,7 +38,7 @@ export declare class ConfigurationChief {
     enabledWorkspaces: Workspace[];
     resolvedConfigFilePath?: string;
     rawConfig?: any;
-    constructor({ cwd, isProduction }: ConfigurationManagerOptions);
+    constructor({ cwd, isProduction, isStrict }: ConfigurationManagerOptions);
     init(): Promise<void>;
     private loadResolvedConfigurationFile;
     getCompilers(): [SyncCompilers, AsyncCompilers];

package/dist/ConfigurationChief.js

@@ -51,6 +51,7 @@ const PLUGIN_NAMES = Object.keys(plugins);
 export class ConfigurationChief {
     cwd;
     isProduction = false;
+    isStrict = false;
     config;
     manifestPath;
     manifest;
@@ -65,9 +66,10 @@ export class ConfigurationChief {
     enabledWorkspaces = [];
     resolvedConfigFilePath;
     rawConfig;
-    constructor({ cwd, isProduction }) {
+    constructor({ cwd, isProduction, isStrict }) {
         this.cwd = cwd;
         this.isProduction = isProduction;
+        this.isStrict = isStrict;
         this.config = defaultConfig;
     }
     async init() {
@@ -233,7 +235,10 @@ export class ConfigurationChief {
             : this.availableWorkspaceNames;
         const graph = this.workspacesGraph?.graph;
         const ws = new Set();
-        if (graph && workspaceArg) {
+        if (workspaceArg && this.isStrict) {
+            ws.add(workspaceArg);
+        }
+        else if (graph && workspaceArg) {
             const seen = new Set();
             const initialWorkspaces = new Set(workspaceNames.map(name => join(this.cwd, name)));
             const workspaceDirsWithDependants = new Set(initialWorkspaces);

package/dist/ProjectPrincipal.js

@@ -122,7 +122,8 @@ export class ProjectPrincipal {
             const resolvedModule = this.resolveModule(specifier, filePath);
             if (resolvedModule) {
                 if (resolvedModule.isExternalLibraryImport) {
-                    external.add(specifier);
+                    const sanitizedSpecifier = sanitizeSpecifier(specifier);
+                    external.add(sanitizedSpecifier);
                 }
                 else {
                     this.addEntryPath(resolvedModule.resolvedFileName, { skipExportsAnalysis: true });

package/dist/index.js

@@ -17,7 +17,7 @@ import { WorkspaceWorker } from './WorkspaceWorker.js';
 export const main = async (unresolvedConfiguration) => {
     const { cwd, tsConfigFile, gitignore, isStrict, isProduction, isIgnoreInternal, isShowProgress, isIncludeEntryExports, } = unresolvedConfiguration;
     debugLogObject('*', 'Unresolved configuration (from CLI arguments)', unresolvedConfiguration);
-    const chief = new ConfigurationChief({ cwd, isProduction });
+    const chief = new ConfigurationChief({ cwd, isProduction, isStrict });
     const deputy = new DependencyDeputy({ isStrict });
     const factory = new PrincipalFactory();
     const streamer = new ConsoleStreamer({ isEnabled: isShowProgress });

package/dist/plugins/node-test-runner/index.d.ts

@@ -1,6 +1,6 @@
 import type { IsPluginEnabledCallback, GenericPluginCallback } from '../../types/plugins.js';
 export declare const NAME = "Node.js Test Runner";
-export declare const ENABLERS: string[];
+export declare const ENABLERS = "This plugin is enabled when any script in `package.json` includes `node --test`";
 export declare const isEnabled: IsPluginEnabledCallback;
 export declare const ENTRY_FILE_PATTERNS: string[];
 export declare const findDependencies: GenericPluginCallback;

package/dist/plugins/node-test-runner/index.js

@@ -1,7 +1,7 @@
 import { timerify } from '../../util/Performance.js';
 import { toEntryPattern } from '../../util/protocols.js';
 export const NAME = 'Node.js Test Runner';
-export const ENABLERS = [''];
+export const ENABLERS = 'This plugin is enabled when any script in `package.json` includes `node --test`';
 export const isEnabled = ({ manifest }) => {
     return Object.keys(manifest.scripts ?? {})
         .filter(s => /test/.test(s))

package/dist/typescript/ast-helpers.d.ts

@@ -13,12 +13,6 @@ export declare function isImportCall(node: ts.Node): node is ts.ImportCall;
 export declare function isRequireCall(callExpression: ts.Node): callExpression is ts.CallExpression;
 export declare function isPropertyAccessCall(node: ts.Node, identifier: string): node is ts.CallExpression;
 export declare function getAccessExpressionName(node: ts.PropertyAccessExpression | ts.ElementAccessExpression): string;
-type LiteralLikeElementAccessExpression = ts.ElementAccessExpression & ts.Declaration & {
-    readonly argumentExpression: ts.StringLiteralLike | ts.NumericLiteral;
-};
-export declare function isModuleExportsAccessExpression(node: ts.Node): node is LiteralLikeElementAccessExpression & {
-    expression: ts.Identifier;
-};
 export declare function stripQuotes(name: string): string;
 export declare function findAncestor<T>(node: ts.Node | undefined, callback: (element: ts.Node) => boolean | 'STOP'): T | undefined;
 export declare function findDescendants<T>(node: ts.Node | undefined, callback: (element: ts.Node) => boolean | 'STOP'): T[];

package/dist/typescript/ast-helpers.js

@@ -36,12 +36,6 @@ export function isPropertyAccessCall(node, identifier) {
 export function getAccessExpressionName(node) {
     return 'argumentExpression' in node ? stripQuotes(node.argumentExpression.getText()) : node.name.getText();
 }
-export function isModuleExportsAccessExpression(node) {
-    return ((ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) &&
-        ts.isIdentifier(node.expression) &&
-        node.expression.escapedText === 'module' &&
-        getAccessExpressionName(node) === 'exports');
-}
 export function stripQuotes(name) {
     const length = name.length;
     if (length >= 2 && name.charCodeAt(0) === name.charCodeAt(length - 1) && isQuoteOrBacktick(name.charCodeAt(0))) {
@@ -103,7 +97,8 @@ export const isInModuleBlock = (node) => {
 };
 export const getJSDocTags = (node) => {
     const tags = new Set();
-    for (const tagNode of ts.getJSDocTags(node)) {
+    const declaration = ts.isExportSpecifier(node) || ts.isBindingElement(node) ? node.parent.parent : node;
+    for (const tagNode of ts.getJSDocTags(declaration)) {
         const match = tagNode.getText()?.match(/@\S+/);
         if (match)
             tags.add(match[0]);

package/dist/typescript/getImportsAndExports.js

@@ -122,11 +122,14 @@ export const getImportsAndExports = (sourceFile, options) => {
                     [results].flat().forEach(addImport);
             }
         }
-        for (const visitor of visitors.export) {
-            if (visitor) {
-                const results = visitor(node, options);
-                if (results)
-                    [results].flat().forEach(addExport);
+        const isTopLevel = node.parent === sourceFile || node.parent?.parent === sourceFile;
+        if (isTopLevel) {
+            for (const visitor of visitors.export) {
+                if (visitor) {
+                    const results = visitor(node, options);
+                    if (results)
+                        [results].flat().forEach(addExport);
+                }
             }
         }
         for (const visitor of visitors.script) {

package/dist/typescript/visitors/exports/moduleExportsAccessExpression.js

@@ -1,30 +1,43 @@
 import ts from 'typescript';
 import { SymbolType } from '../../../types/issues.js';
-import { isModuleExportsAccessExpression, stripQuotes } from '../../ast-helpers.js';
+import { stripQuotes } from '../../ast-helpers.js';
 import { isJS } from '../helpers.js';
 import { exportVisitor as visit } from '../index.js';
 export default visit(isJS, node => {
-    if (isModuleExportsAccessExpression(node)) {
-        const parent = node.parent;
-        if (ts.isPropertyAccessExpression(parent)) {
-            const identifier = parent.name.getText();
-            const pos = parent.name.getStart();
-            return { node, identifier, type: SymbolType.UNKNOWN, pos };
-        }
-        else if (ts.isElementAccessExpression(parent)) {
-            const identifier = stripQuotes(parent.argumentExpression.getText());
-            const pos = parent.argumentExpression.getStart();
-            return { node, identifier, type: SymbolType.UNKNOWN, pos };
-        }
-        else if (ts.isBinaryExpression(parent)) {
-            const expr = parent.right;
-            if (ts.isObjectLiteralExpression(expr) && expr.properties.every(ts.isShorthandPropertyAssignment)) {
-                return expr.properties.map(node => {
-                    return { node, identifier: node.getText(), type: SymbolType.UNKNOWN, pos: node.pos };
-                });
+    if (ts.isExpressionStatement(node)) {
+        if (ts.isBinaryExpression(node.expression)) {
+            if (ts.isPropertyAccessExpression(node.expression.left) &&
+                ts.isPropertyAccessExpression(node.expression.left.expression) &&
+                ts.isIdentifier(node.expression.left.expression.expression) &&
+                node.expression.left.expression.expression.escapedText === 'module' &&
+                node.expression.left.expression.name.escapedText === 'exports') {
+                const identifier = node.expression.left.name.getText();
+                const pos = node.expression.left.name.pos;
+                return { node, identifier, type: SymbolType.UNKNOWN, pos };
+            }
+            else if (ts.isElementAccessExpression(node.expression.left) &&
+                ts.isPropertyAccessExpression(node.expression.left.expression) &&
+                ts.isIdentifier(node.expression.left.expression.name) &&
+                ts.isIdentifier(node.expression.left.expression.expression) &&
+                node.expression.left.expression.expression.escapedText === 'module' &&
+                node.expression.left.expression.name.escapedText === 'exports') {
+                const identifier = stripQuotes(node.expression.left.argumentExpression.getText());
+                const pos = node.expression.left.argumentExpression.pos;
+                return { node, identifier, type: SymbolType.UNKNOWN, pos };
             }
-            else {
-                return { node, identifier: 'default', type: SymbolType.UNKNOWN, pos: node.getStart() };
+            else if (ts.isPropertyAccessExpression(node.expression.left) &&
+                ts.isIdentifier(node.expression.left.expression) &&
+                node.expression.left.expression.escapedText === 'module' &&
+                node.expression.left.name.escapedText === 'exports') {
+                const expr = node.expression.right;
+                if (ts.isObjectLiteralExpression(expr) && expr.properties.every(ts.isShorthandPropertyAssignment)) {
+                    return expr.properties.map(node => {
+                        return { node, identifier: node.getText(), type: SymbolType.UNKNOWN, pos: node.pos };
+                    });
+                }
+                else {
+                    return { node, identifier: 'default', type: SymbolType.UNKNOWN, pos: expr.pos };
+                }
             }
         }
     }

package/dist/util/modules.js

@@ -51,4 +51,8 @@ export const getEntryPathFromManifest = (cwd, dir, manifest) => {
     }
     return _glob({ cwd, workingDir: dir, patterns: Array.from(entryPaths) });
 };
-export const sanitizeSpecifier = (specifier) => specifier.replace(/^([?!|-]+)?([^!?:]+).*/, '$2');
+export const sanitizeSpecifier = (specifier) => {
+    if (specifier.startsWith('node:'))
+        return specifier;
+    return specifier.replace(/^([?!|-]+)?([^!?:]+).*/, '$2');
+};

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "2.40.0";
+export declare const version = "2.40.2";

package/dist/version.js

@@ -1 +1 @@
-export const version = '2.40.0';
+export const version = '2.40.2';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "2.40.0",
+  "version": "2.40.2",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://github.com/webpro/knip",
   "repository": "github:webpro/knip",