knip 2.24.1 → 2.25.1

package/dist/DependencyDeputy.d.ts

@@ -1,8 +1,7 @@
 /// <reference types="npmcli__package-json" />
 import type { Workspace } from './ConfigurationChief.js';
 import type { ConfigurationHints, Issue } from './types/issues.js';
-import type { WorkspaceManifests } from './types/workspace.js';
-import type { PeerDependencies, InstalledBinaries } from './types/workspace.js';
+import type { WorkspaceManifests, HostDependencies, InstalledBinaries } from './types/workspace.js';
 import type { PackageJson } from '@npmcli/package-json';
 type Options = {
     isStrict: boolean;
@@ -12,7 +11,7 @@ export declare class DependencyDeputy {
     _manifests: WorkspaceManifests;
     referencedDependencies: Map<string, Set<string>>;
     referencedBinaries: Map<string, Set<string>>;
-    peerDependencies: Map<string, PeerDependencies>;
+    hostDependencies: Map<string, HostDependencies>;
     installedBinaries: Map<string, InstalledBinaries>;
     ignoreBinaries: string[];
     ignoreDependencies: string[];
@@ -45,8 +44,8 @@ export declare class DependencyDeputy {
     getInstalledBinaries(workspaceName: string): InstalledBinaries | undefined;
     addReferencedDependency(workspaceName: string, packageName: string): void;
     addReferencedBinary(workspaceName: string, binaryName: string): void;
-    addPeerDependencies(workspaceName: string, peerDependencies: Map<string, Set<string>>): void;
-    getPeerDependenciesOf(workspaceName: string, dependency: string): string[];
+    addHostDependencies(workspaceName: string, hostDependencies: HostDependencies): void;
+    getHostDependenciesFor(workspaceName: string, dependency: string): string[];
     getPeerDependencies(workspaceName: string): string[];
     getOptionalPeerDependencies(workspaceName: string): string[];
     maybeAddReferencedExternalDependency(workspace: Workspace, packageName: string): boolean;

package/dist/DependencyDeputy.js

@@ -6,7 +6,7 @@ export class DependencyDeputy {
     _manifests = new Map();
     referencedDependencies;
     referencedBinaries;
-    peerDependencies;
+    hostDependencies;
     installedBinaries;
     ignoreBinaries = [];
     ignoreDependencies = [];
@@ -14,7 +14,7 @@ export class DependencyDeputy {
         this.isStrict = isStrict;
         this.referencedDependencies = new Map();
         this.referencedBinaries = new Map();
-        this.peerDependencies = new Map();
+        this.hostDependencies = new Map();
         this.installedBinaries = new Map();
     }
     addWorkspace({ name, dir, manifestPath, manifest, ignoreDependencies, ignoreBinaries, }) {
@@ -79,11 +79,11 @@ export class DependencyDeputy {
         }
         this.referencedBinaries.get(workspaceName)?.add(binaryName);
     }
-    addPeerDependencies(workspaceName, peerDependencies) {
-        this.peerDependencies.set(workspaceName, peerDependencies);
+    addHostDependencies(workspaceName, hostDependencies) {
+        this.hostDependencies.set(workspaceName, hostDependencies);
     }
-    getPeerDependenciesOf(workspaceName, dependency) {
-        return Array.from(this.peerDependencies.get(workspaceName)?.get(dependency) ?? []);
+    getHostDependenciesFor(workspaceName, dependency) {
+        return Array.from(this.hostDependencies.get(workspaceName)?.get(dependency) ?? []);
     }
     getPeerDependencies(workspaceName) {
         const manifest = this._manifests.get(workspaceName);
@@ -179,17 +179,19 @@ export class DependencyDeputy {
                     const typedPackageName = getPackageFromDefinitelyTyped(typedDependency);
                     if (IGNORE_DEFINITELY_TYPED.includes(typedPackageName))
                         return true;
-                    const peerDependencies = this.getPeerDependenciesOf(workspaceName, typedPackageName);
-                    if (peerDependencies.length) {
-                        return !!peerDependencies.find(peerDependency => isReferencedDependency(peerDependency, true));
-                    }
+                    const hostDependencies = [
+                        ...this.getHostDependenciesFor(workspaceName, dependency),
+                        ...this.getHostDependenciesFor(workspaceName, typedPackageName),
+                    ];
+                    if (hostDependencies.length)
+                        return !!hostDependencies.find(host => isReferencedDependency(host, true));
                     if (!referencedDependencies)
                         return false;
                     return referencedDependencies.has(typedPackageName);
                 }
-                const peerDependenciesOf = this.getPeerDependenciesOf(workspaceName, dependency);
-                peerDependenciesOf.forEach(dep => (!peerDepRecs[dep] ? (peerDepRecs[dep] = 1) : peerDepRecs[dep]++));
-                return peerDependenciesOf.some(peerDependency => isReferencedDependency(peerDependency, true));
+                const hostDependencies = this.getHostDependenciesFor(workspaceName, dependency);
+                hostDependencies.forEach(dep => (!peerDepRecs[dep] ? (peerDepRecs[dep] = 1) : peerDepRecs[dep]++));
+                return hostDependencies.some(peerDependency => isReferencedDependency(peerDependency, true));
             };
             const isNotReferencedDependency = (dependency) => !isReferencedDependency(dependency);
             const pd = this.getProductionDependencies(workspaceName);

package/dist/ProjectPrincipal.js

@@ -178,7 +178,7 @@ export class ProjectPrincipal {
     findUnusedMembers(filePath, members) {
         return members
             .filter(member => {
-            if (getJSDocTags(member.node).includes('@public'))
+            if (getJSDocTags(member.node).has('@public'))
                 return false;
             const referencedSymbols = this.findReferences(filePath, member.pos);
             const files = referencedSymbols

package/dist/WorkspaceWorker.d.ts

@@ -1,6 +1,6 @@
 import type { Configuration, PluginName, WorkspaceConfiguration } from './types/config.js';
 import type { PackageJsonWithPlugins } from './types/plugins.js';
-import type { InstalledBinaries, PeerDependencies } from './types/workspace.js';
+import type { InstalledBinaries, HostDependencies } from './types/workspace.js';
 type WorkspaceManagerOptions = {
     name: string;
     dir: string;
@@ -28,7 +28,7 @@ export declare class WorkspaceWorker {
     enabled: Record<PluginName, boolean>;
     enabledPlugins: PluginName[];
     referencedDependencies: ReferencedDependencies;
-    peerDependencies: PeerDependencies;
+    hostDependencies: HostDependencies;
     installedBinaries: InstalledBinaries;
     constructor({ name, dir, cwd, config, manifest, isProduction, isStrict, rootIgnore, negatedWorkspacePatterns, enabledPluginsInAncestors, }: WorkspaceManagerOptions);
     init(): Promise<void>;
@@ -47,7 +47,7 @@ export declare class WorkspaceWorker {
     getIgnorePatterns(): string[];
     private findDependenciesByPlugins;
     findAllDependencies(): Promise<{
-        peerDependencies: PeerDependencies;
+        hostDependencies: HostDependencies;
         installedBinaries: InstalledBinaries;
         referencedDependencies: ReferencedDependencies;
         enabledPlugins: ("ava" | "babel" | "capacitor" | "changesets" | "commitizen" | "commitlint" | "cspell" | "cypress" | "eslint" | "gatsby" | "husky" | "jest" | "lefthook" | "markdownlint" | "mocha" | "next" | "nx" | "nyc" | "playwright" | "postcss" | "prettier" | "remark" | "remix" | "rollup" | "sentry" | "storybook" | "stryker" | "stylelint" | "tailwind" | "typedoc" | "typescript" | "vite" | "vitest" | "webpack" | "githubActions" | "lintStaged" | "npmPackageJsonLint" | "releaseIt" | "semanticRelease" | "svelte")[];

package/dist/WorkspaceWorker.js

@@ -20,7 +20,7 @@ export class WorkspaceWorker {
     enabled;
     enabledPlugins = [];
     referencedDependencies = new Set();
-    peerDependencies = new Map();
+    hostDependencies = new Map();
     installedBinaries = new Map();
     constructor({ name, dir, cwd, config, manifest, isProduction, isStrict, rootIgnore, negatedWorkspacePatterns, enabledPluginsInAncestors, }) {
         this.name = name;
@@ -59,7 +59,7 @@ export class WorkspaceWorker {
         debugLogObject(`Enabled plugins (${this.name})`, enabledPluginNames);
     }
     async initReferencedDependencies() {
-        const { dependencies, peerDependencies, installedBinaries } = await npm.findDependencies({
+        const { dependencies, hostDependencies, installedBinaries } = await npm.findDependencies({
             manifest: this.manifest,
             isProduction: this.isProduction,
             isStrict: this.isStrict,
@@ -68,7 +68,7 @@ export class WorkspaceWorker {
         });
         const filePath = join(this.dir, 'package.json');
         dependencies.forEach(dependency => this.referencedDependencies.add([filePath, dependency]));
-        this.peerDependencies = peerDependencies;
+        this.hostDependencies = hostDependencies;
         this.installedBinaries = installedBinaries;
     }
     getConfigForPlugin(pluginName) {
@@ -235,7 +235,7 @@ export class WorkspaceWorker {
     async findAllDependencies() {
         await this.findDependenciesByPlugins();
         return {
-            peerDependencies: this.peerDependencies,
+            hostDependencies: this.hostDependencies,
             installedBinaries: this.installedBinaries,
             referencedDependencies: this.referencedDependencies,
             enabledPlugins: this.enabledPlugins,

package/dist/binaries/resolvers/index.d.ts

@@ -3,6 +3,7 @@ export * as dotenv from './dotenv.js';
 export * as node from './node.js';
 export * as nodemon from './nodemon.js';
 export * as npx from './npx.js';
+export * as nx from './nx.js';
 export * as pnpm from './pnpm.js';
 export * as rollup from './rollup.js';
 export * as yarn from './yarn.js';

package/dist/binaries/resolvers/index.js

@@ -3,6 +3,7 @@ export * as dotenv from './dotenv.js';
 export * as node from './node.js';
 export * as nodemon from './nodemon.js';
 export * as npx from './npx.js';
+export * as nx from './nx.js';
 export * as pnpm from './pnpm.js';
 export * as rollup from './rollup.js';
 export * as yarn from './yarn.js';

package/dist/binaries/resolvers/nx.d.ts

@@ -0,0 +1,2 @@
+import type { Resolver } from '../types.js';
+export declare const resolve: Resolver;

package/dist/binaries/resolvers/nx.js

@@ -0,0 +1,9 @@
+import parseArgs from 'minimist';
+import { toBinary } from '../util.js';
+export const resolve = (binary, args, { fromArgs }) => {
+    const parsed = parseArgs(args);
+    const [command] = parsed._;
+    if (command === 'exec')
+        return [toBinary(binary), ...fromArgs(parsed._.slice(1))];
+    return [toBinary(binary)];
+};

package/dist/index.js

@@ -166,8 +166,8 @@ export const main = async (unresolvedConfiguration) => {
         if (chief.resolvedConfigFilePath)
             principal.addEntryPath(chief.resolvedConfigFilePath, { skipExportsAnalysis: true });
         const dependencies = await worker.findAllDependencies();
-        const { referencedDependencies, peerDependencies, installedBinaries, enabledPlugins } = dependencies;
-        deputy.addPeerDependencies(name, peerDependencies);
+        const { referencedDependencies, hostDependencies, installedBinaries, enabledPlugins } = dependencies;
+        deputy.addHostDependencies(name, hostDependencies);
         deputy.setInstalledBinaries(name, installedBinaries);
         enabledPluginsStore.set(name, enabledPlugins);
         referencedDependencies.forEach(([containingFilePath, specifier]) => {
@@ -278,9 +278,9 @@ export const main = async (unresolvedConfiguration) => {
                     continue;
                 const importingModule = importedSymbols.get(filePath);
                 for (const [symbol, exportedItem] of exportItems.entries()) {
-                    if (exportedItem.jsDocTags.includes('@public') || exportedItem.jsDocTags.includes('@beta'))
+                    if (exportedItem.jsDocTags.has('@public') || exportedItem.jsDocTags.has('@beta'))
                         continue;
-                    if (isIgnoreInternal && exportedItem.jsDocTags.includes('@internal'))
+                    if (isIgnoreInternal && exportedItem.jsDocTags.has('@internal'))
                         continue;
                     if (importingModule && isSymbolImported(symbol, importingModule)) {
                         if (importingModule.isReExport && isExportedInEntryFile(importingModule))

package/dist/manifest/index.d.ts

@@ -1,5 +1,5 @@
 /// <reference types="npmcli__package-json" />
-import type { InstalledBinaries, PeerDependencies } from '../types/workspace.js';
+import type { InstalledBinaries, HostDependencies } from '../types/workspace.js';
 import type { PackageJson } from '@npmcli/package-json';
 type Options = {
     manifest: PackageJson;
@@ -10,7 +10,7 @@ type Options = {
 };
 export declare const findDependencies: ({ manifest, isProduction, isStrict, dir, cwd }: Options) => Promise<{
     dependencies: string[];
-    peerDependencies: PeerDependencies;
+    hostDependencies: HostDependencies;
     installedBinaries: InstalledBinaries;
 }>;
 export {};

package/dist/manifest/index.js

@@ -3,7 +3,7 @@ import { timerify } from '../util/Performance.js';
 import { getPackageManifest } from './helpers.js';
 const findManifestDependencies = async ({ manifest, isProduction, isStrict, dir, cwd }) => {
     const scriptFilter = isProduction ? ['start', 'postinstall'] : [];
-    const peerDependencies = new Map();
+    const hostDependencies = new Map();
     const scripts = Object.entries(manifest.scripts ?? {}).reduce((scripts, [scriptName, script]) => {
         if (script && (scriptFilter.length === 0 || scriptFilter.includes(scriptName))) {
             return [...scripts, script];
@@ -38,18 +38,18 @@ const findManifestDependencies = async ({ manifest, isProduction, isStrict, dir,
             });
             const packagePeerDependencies = Object.keys(manifest.peerDependencies ?? {});
             packagePeerDependencies.forEach(packagePeerDependency => {
-                if (peerDependencies.has(packagePeerDependency)) {
-                    peerDependencies.get(packagePeerDependency)?.add(packageName);
+                if (hostDependencies.has(packagePeerDependency)) {
+                    hostDependencies.get(packagePeerDependency)?.add(packageName);
                 }
                 else {
-                    peerDependencies.set(packagePeerDependency, new Set([packageName]));
+                    hostDependencies.set(packagePeerDependency, new Set([packageName]));
                 }
             });
         }
     }
     return {
         dependencies,
-        peerDependencies,
+        hostDependencies,
         installedBinaries,
     };
 };

package/dist/plugins/jest/index.js

@@ -62,7 +62,8 @@ const findJestDependencies = async (configFilePath, { cwd, manifest }) => {
         config = await config();
     if (!config)
         return [];
-    const replaceRootDir = (name) => name.includes('<rootDir>') ? join(cwd, name.replace(/^.*<rootDir>/, '')) : name;
+    const rootDir = config.rootDir ?? '';
+    const replaceRootDir = (name) => name.includes('<rootDir>') ? join(cwd, name.replace(/^.*<rootDir>/, rootDir)) : name;
     return resolveDependencies(config).map(replaceRootDir);
 };
 export const findDependencies = timerify(findJestDependencies);

package/dist/plugins/typescript/index.js

@@ -1,3 +1,4 @@
+import ts from 'typescript';
 import { compact } from '../../util/array.js';
 import { dirname, isInternal, toAbsolute } from '../../util/path.js';
 import { timerify } from '../../util/Performance.js';
@@ -21,6 +22,7 @@ const resolveExtensibleConfig = async (configFilePath) => {
     }
     return config;
 };
+const jsxWithReact = [ts.JsxEmit.React, ts.JsxEmit.ReactJSX, ts.JsxEmit.ReactJSXDev, ts.JsxEmit.ReactNative];
 const findTypeScriptDependencies = async (configFilePath) => {
     const compilerOptions = await loadTSConfig(configFilePath);
     const config = await resolveExtensibleConfig(configFilePath);
@@ -34,7 +36,7 @@ const findTypeScriptDependencies = async (configFilePath) => {
     const importHelpers = compilerOptions?.importHelpers ? ['tslib'] : [];
     const jsx = compilerOptions?.jsxImportSource
         ? [compilerOptions.jsxImportSource]
-        : compilerOptions?.jsx
+        : compilerOptions?.jsx && jsxWithReact.includes(compilerOptions.jsx)
             ? ['react']
             : [];
     return compact([...extend, ...types, ...plugins, ...importHelpers, ...jsx]);

package/dist/types/exports.d.ts

@@ -7,7 +7,7 @@ export type ExportItem = {
     pos: number;
     type: SymbolType;
     members?: ExportItemMember[];
-    jsDocTags?: string[];
+    jsDocTags?: Set<string>;
 };
 export type ExportItemMember = {
     node: ts.Node;

package/dist/types/workspace.d.ts

@@ -12,6 +12,6 @@ type WorkspaceManifest = {
     ignoreBinaries: string[];
 };
 export type WorkspaceManifests = Map<string, WorkspaceManifest>;
-export type PeerDependencies = Map<string, Set<string>>;
+export type HostDependencies = Map<string, Set<string>>;
 export type InstalledBinaries = Map<string, Set<string>>;
 export {};

package/dist/typescript/ast-helpers.d.ts

@@ -23,5 +23,5 @@ export declare function findAncestor<T>(node: ts.Node | undefined, callback: (el
 export declare function findDescendants<T>(node: ts.Node | undefined, callback: (element: ts.Node) => boolean | 'STOP'): T[];
 export declare const isDeclarationFileExtension: (extension: string) => boolean;
 export declare const isInModuleBlock: (node: ts.Node) => boolean;
-export declare const getJSDocTags: (node: ts.Node) => string[];
+export declare const getJSDocTags: (node: ts.Node) => Set<string>;
 export {};

package/dist/typescript/ast-helpers.js

@@ -98,4 +98,12 @@ export const isInModuleBlock = (node) => {
     }
     return false;
 };
-export const getJSDocTags = (node) => ts.getJSDocTags(node).map(node => node.getText().match(/@\S+/)[0]);
+export const getJSDocTags = (node) => {
+    const tags = new Set();
+    for (const tagNode of ts.getJSDocTags(node)) {
+        const match = tagNode.getText()?.match(/@\S+/);
+        if (match)
+            tags.add(match[0]);
+    }
+    return tags;
+};

package/dist/typescript/getImportsAndExports.js

@@ -101,13 +101,13 @@ export const getImportsAndExports = (sourceFile, options) => {
         if (exports.has(identifier)) {
             const item = exports.get(identifier);
             const crew = [...item.members, ...members];
-            const tags = [...item.jsDocTags, ...jsDocTags];
+            const tags = new Set([...item.jsDocTags, ...jsDocTags]);
             exports.set(identifier, { ...item, node, type, pos, members: crew, jsDocTags: tags });
         }
         else {
             exports.set(identifier, { node, type, pos, members, jsDocTags });
         }
-        if (!jsDocTags.includes('@alias')) {
+        if (!jsDocTags.has('@alias')) {
             if (ts.isExportAssignment(node))
                 maybeAddAliasedExport(node.expression, 'default');
             if (ts.isVariableDeclaration(node))

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "2.24.1";
+export declare const version = "2.25.1";

package/dist/version.js

@@ -1 +1 @@
-export const version = '2.24.1';
+export const version = '2.25.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "2.24.1",
+  "version": "2.25.1",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://github.com/webpro/knip",
   "repository": "github:webpro/knip",
@@ -65,12 +65,12 @@
     "@npmcli/package-json": "5.0.0",
     "@release-it/bumper": "5.1.0",
     "@swc/cli": "0.1.62",
-    "@swc/core": "1.3.84",
+    "@swc/core": "1.3.85",
     "@types/eslint": "8.44.2",
-    "@types/js-yaml": "4.0.5",
+    "@types/js-yaml": "4.0.6",
     "@types/micromatch": "4.0.2",
     "@types/minimist": "1.2.2",
-    "@types/node": "20.6.0",
+    "@types/node": "20.6.2",
     "@types/npmcli__map-workspaces": "3.0.1",
     "@types/webpack": "5.28.2",
     "@typescript-eslint/eslint-plugin": "6.7.0",
@@ -84,7 +84,7 @@
     "release-it": "16.1.5",
     "remark-cli": "11.0.0",
     "remark-preset-webpro": "0.0.3",
-    "tsx": "3.12.8",
+    "tsx": "3.12.10",
     "type-fest": "4.3.1"
   },
   "engines": {