knip 2.21.0 → 2.21.2

package/README.md

@@ -624,7 +624,7 @@ Tip: back up files or use an VCS like Git before deleting files or making change
 
 Repeat the process to reveal new unused files and exports. It's so liberating to remove unused things!
 
-Getting too many reported issues and false positives? Read more about [handling issues][50] describing potential causes
+Getting too many reported issues and false positives? Read more about [handling issues][48] describing potential causes
 for false positives, and how to handle them.
 
 ## Command Line Options
@@ -675,13 +675,13 @@ for false positives, and how to handle them.
 
 ## Potential boost with `--no-gitignore`
 
-To increase performance in a large monorepo, check out [Potential boost with `--no-gitignore`][51].
+To increase performance in a large monorepo, check out [Potential boost with `--no-gitignore`][50].
 
 ## Comparison & Migration
 
 This table is an ongoing comparison. Based on their docs (please report any mistakes):
 
-| Feature                 | **knip** | [depcheck][52] | [unimported][53] | [ts-unused-exports][54] | [ts-prune][55] |
+| Feature                 | **knip** | [depcheck][51] | [unimported][52] | [ts-unused-exports][53] | [ts-prune][54] |
 | :---------------------- | :------: | :------------: | :--------------: | :---------------------: | :------------: |
 | Unused files            |    ✅    |       -        |        ✅        |            -            |       -        |
 | Unused dependencies     |    ✅    |       ✅       |        ✅        |            -            |       -        |
@@ -739,25 +739,25 @@ The following commands are similar:
 
 Many thanks to some of the early adopters of Knip:
 
-- [Block Protocol][56]
-- [DeepmergeTS][57]
-- [eslint-plugin-functional][58]
-- [freeCodeCamp.org][59]
-- [is-immutable-type][60]
-- [IsaacScript][61]
-- [Nuxt][62]
-- [Owncast][63]
-- [release-it][64]
-- [Template TypeScript Node Package][65]
-- [Tipi][66]
+- [Block Protocol][55]
+- [DeepmergeTS][56]
+- [eslint-plugin-functional][57]
+- [freeCodeCamp.org][58]
+- [is-immutable-type][59]
+- [IsaacScript][60]
+- [Nuxt][61]
+- [Owncast][62]
+- [release-it][63]
+- [Template TypeScript Node Package][64]
+- [Tipi][65]
 
 ## Articles, etc.
 
 - Discord: hang out in [The Knip Barn][9]
-- Ask your questions in the [Knip knowledge base][67] (powered by OpenAI and [7-docs][68], experimental!)
-- Smashing Magazine: [Knip: An Automated Tool For Finding Unused Files, Exports, And Dependencies][69]
-- Effective TypeScript: [Recommendation Update: ✂️ Use knip to detect dead code and types][70]
-- Josh Goldberg: [Speeding Up Centered Part 4: Unused Code Bloat][71]
+- Ask your questions in the [Knip knowledge base][66] (powered by OpenAI and [7-docs][67], experimental!)
+- Smashing Magazine: [Knip: An Automated Tool For Finding Unused Files, Exports, And Dependencies][68]
+- Effective TypeScript: [Recommendation Update: ✂️ Use knip to detect dead code and types][69]
+- Josh Goldberg: [Speeding Up Centered Part 4: Unused Code Bloat][70]
 
 ## Why "Knip"?
 
@@ -775,7 +775,7 @@ each file, and traversing all of this, why not collect the various issues in one
 
 Special thanks to the wonderful people who have contributed to this project:
 
-[![Contributors][73]][72]
+[![Contributors][72]][71]
 
 [1]: #workspaces
 [2]: #plugins
@@ -824,32 +824,31 @@ Special thanks to the wonderful people who have contributed to this project:
 [45]: https://nx.dev/concepts/integrated-vs-package-based
 [46]: ./docs/writing-a-plugin.md
 [47]: ./docs/compilers.md
-[48]: #handling-issues
+[48]: ./docs/handling-issues.md
 [49]: ./docs/reporters-and-preprocessors.md
-[50]: ./docs/handling-issues.md
-[51]: ./docs/perf-boost-with-no-gitignore.md
-[52]: https://github.com/depcheck/depcheck
-[53]: https://github.com/smeijer/unimported
-[54]: https://github.com/pzavolinsky/ts-unused-exports
-[55]: https://github.com/nadeesha/ts-prune
-[56]: https://github.com/blockprotocol/blockprotocol
-[57]: https://github.com/RebeccaStevens/deepmerge-ts
-[58]: https://github.com/eslint-functional/eslint-plugin-functional
-[59]: https://github.com/freeCodeCamp/freeCodeCamp
-[60]: https://github.com/RebeccaStevens/is-immutable-type
-[61]: https://github.com/IsaacScript/isaacscript
-[62]: https://github.com/nuxt/nuxt
-[63]: https://github.com/owncast/owncast
-[64]: https://github.com/release-it/release-it
-[65]: https://github.com/JoshuaKGoldberg/template-typescript-node-package
-[66]: https://github.com/meienberger/runtipi
-[67]: https://knip.deno.dev
-[68]: https://github.com/7-docs/7-docs
-[69]: https://www.smashingmagazine.com/2023/08/knip-automated-tool-find-unused-files-exports-dependencies/
-[70]: https://effectivetypescript.com/2023/07/29/knip/
-[71]: https://www.joshuakgoldberg.com/blog/speeding-up-centered-part-4-unused-code-bloat/
-[72]: https://github.com/webpro/knip/graphs/contributors
-[73]: https://contrib.rocks/image?repo=webpro/knip
+[50]: ./docs/perf-boost-with-no-gitignore.md
+[51]: https://github.com/depcheck/depcheck
+[52]: https://github.com/smeijer/unimported
+[53]: https://github.com/pzavolinsky/ts-unused-exports
+[54]: https://github.com/nadeesha/ts-prune
+[55]: https://github.com/blockprotocol/blockprotocol
+[56]: https://github.com/RebeccaStevens/deepmerge-ts
+[57]: https://github.com/eslint-functional/eslint-plugin-functional
+[58]: https://github.com/freeCodeCamp/freeCodeCamp
+[59]: https://github.com/RebeccaStevens/is-immutable-type
+[60]: https://github.com/IsaacScript/isaacscript
+[61]: https://github.com/nuxt/nuxt
+[62]: https://github.com/owncast/owncast
+[63]: https://github.com/release-it/release-it
+[64]: https://github.com/JoshuaKGoldberg/template-typescript-node-package
+[65]: https://github.com/meienberger/runtipi
+[66]: https://knip.deno.dev
+[67]: https://github.com/7-docs/7-docs
+[68]: https://www.smashingmagazine.com/2023/08/knip-automated-tool-find-unused-files-exports-dependencies/
+[69]: https://effectivetypescript.com/2023/07/29/knip/
+[70]: https://www.joshuakgoldberg.com/blog/speeding-up-centered-part-4-unused-code-bloat/
+[71]: https://github.com/webpro/knip/graphs/contributors
+[72]: https://contrib.rocks/image?repo=webpro/knip
 [plugin-ava]: ./src/plugins/ava
 [plugin-babel]: ./src/plugins/babel
 [plugin-capacitor]: ./src/plugins/capacitor

package/dist/ConfigurationChief.d.ts

@@ -22,8 +22,8 @@ export declare class ConfigurationChief {
     ignoredWorkspacePatterns: string[];
     manifestWorkspaces: Map<string, string>;
     additionalWorkspaceNames: Set<string>;
-    enabledWorkspaceNames: string[];
-    enabledWorkspaceDirs: string[];
+    availableWorkspaceNames: string[];
+    availableWorkspaceDirs: string[];
     enabledWorkspaces: Workspace[];
     localWorkspaces: Set<string>;
     resolvedConfigFilePath?: string;
@@ -37,7 +37,7 @@ export declare class ConfigurationChief {
     private getIgnoredWorkspacePatterns;
     private getManifestWorkspaces;
     private getAdditionalWorkspaceNames;
-    private getEnabledWorkspaceNames;
+    private getAvailableWorkspaceNames;
     private getEnabledWorkspaces;
     getWorkspaces(): Workspace[];
     private getDescendentWorkspaces;

package/dist/ConfigurationChief.js

@@ -55,8 +55,8 @@ export class ConfigurationChief {
     ignoredWorkspacePatterns = [];
     manifestWorkspaces = new Map();
     additionalWorkspaceNames = new Set();
-    enabledWorkspaceNames = [];
-    enabledWorkspaceDirs = [];
+    availableWorkspaceNames = [];
+    availableWorkspaceDirs = [];
     enabledWorkspaces = [];
     localWorkspaces = new Set();
     resolvedConfigFilePath;
@@ -170,12 +170,12 @@ export class ConfigurationChief {
         this.ignoredWorkspacePatterns = this.getIgnoredWorkspacePatterns();
         this.manifestWorkspaces = await this.getManifestWorkspaces();
         this.additionalWorkspaceNames = await this.getAdditionalWorkspaceNames();
-        this.enabledWorkspaceNames = this.getEnabledWorkspaceNames();
-        this.enabledWorkspaces = this.getEnabledWorkspaces();
-        this.enabledWorkspaceDirs = this.enabledWorkspaceNames
+        this.availableWorkspaceNames = this.getAvailableWorkspaceNames();
+        this.availableWorkspaceDirs = this.availableWorkspaceNames
             .sort(byPathDepth)
             .reverse()
             .map(dir => join(this.cwd, dir));
+        this.enabledWorkspaces = this.getEnabledWorkspaces();
         this.localWorkspaces = new Set(compact(this.enabledWorkspaces.map(w => w.pkgName)));
     }
     getListedWorkspaces() {
@@ -211,16 +211,13 @@ export class ConfigurationChief {
             !this.manifestWorkspaces.has(name) &&
             !micromatch.isMatch(name, this.ignoredWorkspacePatterns)));
     }
-    getEnabledWorkspaceNames() {
+    getAvailableWorkspaceNames() {
         return [ROOT_WORKSPACE_NAME, ...this.manifestWorkspaces.keys(), ...this.additionalWorkspaceNames].filter(name => !micromatch.isMatch(name, this.ignoredWorkspacePatterns));
     }
     getEnabledWorkspaces() {
         if (workspaceArg && !existsSync(workspaceArg)) {
             throw new ConfigurationError(`Directory does not exist: ${workspaceArg}`);
         }
-        const workspaceNames = workspaceArg
-            ? this.enabledWorkspaceNames.filter(name => name === workspaceArg)
-            : this.enabledWorkspaceNames;
         const getAncestors = (name) => (ancestors, ancestorName) => {
             if (name === ancestorName)
                 return ancestors;
@@ -228,19 +225,25 @@ export class ConfigurationChief {
                 ancestors.push(ancestorName);
             return ancestors;
         };
+        const workspaceNames = workspaceArg
+            ? [
+                ...this.availableWorkspaceNames.reduce(getAncestors(workspaceArg), []),
+                ...this.availableWorkspaceNames.filter(name => name === workspaceArg),
+            ]
+            : this.availableWorkspaceNames;
         return workspaceNames.sort(byPathDepth).map((name) => ({
             name,
             pkgName: this.manifestWorkspaces.get(name) ?? this.manifest?.name,
             dir: join(this.cwd, name),
             config: this.getConfigForWorkspace(name),
-            ancestors: workspaceNames.reduce(getAncestors(name), []),
+            ancestors: this.availableWorkspaceNames.reduce(getAncestors(name), []),
         }));
     }
     getWorkspaces() {
         return this.enabledWorkspaces;
     }
     getDescendentWorkspaces(name) {
-        return this.enabledWorkspaceNames
+        return this.availableWorkspaceNames
             .filter(workspaceName => workspaceName !== name)
             .filter(workspaceName => name === ROOT_WORKSPACE_NAME || workspaceName.startsWith(name + '/'));
     }
@@ -280,7 +283,7 @@ export class ConfigurationChief {
         return getIncludedIssueTypes(cliArgs, config);
     }
     findWorkspaceByFilePath(filePath) {
-        const workspaceDir = this.enabledWorkspaceDirs.find(workspaceDir => filePath.startsWith(workspaceDir + '/'));
+        const workspaceDir = this.availableWorkspaceDirs.find(workspaceDir => filePath.startsWith(workspaceDir + '/'));
         return this.enabledWorkspaces.find(workspace => workspace.dir === workspaceDir);
     }
     findWorkspaceByPackageName(packageName) {

package/dist/index.js

@@ -244,6 +244,15 @@ export const main = async (unresolvedConfiguration) => {
         const unusedFiles = principal.getUnreferencedFiles();
         collector.addFilesIssues(unusedFiles);
         collector.addFileCounts({ processed: analyzedFiles.size, unused: unusedFiles.length });
+        const isSymbolImported = (symbol, importingModule) => {
+            if (!importingModule)
+                return false;
+            if (importingModule.symbols.has(symbol))
+                return true;
+            const { isReExport, isReExportedBy } = importingModule;
+            const hasSymbol = (file) => isSymbolImported(symbol, importedSymbols.get(file));
+            return isReExport ? Array.from(isReExportedBy).some(hasSymbol) : false;
+        };
         const isExportedInEntryFile = (importedModule) => {
             if (!importedModule)
                 return false;
@@ -265,15 +274,15 @@ export const main = async (unresolvedConfiguration) => {
             for (const [filePath, exportItems] of exportedSymbols.entries()) {
                 if (!isIncludeEntryExports && principal.entryPaths.has(filePath))
                     continue;
-                const importedModule = importedSymbols.get(filePath);
+                const importingModule = importedSymbols.get(filePath);
                 for (const [symbol, exportedItem] of exportItems.entries()) {
                     const jsDocTags = principal.getJSDocTags(exportedItem);
                     if (jsDocTags.includes('@public') || jsDocTags.includes('@beta'))
                         continue;
                     if (isIgnoreInternal && jsDocTags.includes('@internal'))
                         continue;
-                    if (importedModule?.symbols.has(symbol)) {
-                        if (importedModule.isReExport && isExportedInEntryFile(importedModule))
+                    if (importingModule && isSymbolImported(symbol, importingModule)) {
+                        if (importingModule.isReExport && isExportedInEntryFile(importingModule))
                             continue;
                         if (report.enumMembers && exportedItem.type === 'enum' && exportedItem.members) {
                             if (isProduction)
@@ -289,8 +298,8 @@ export const main = async (unresolvedConfiguration) => {
                         }
                         continue;
                     }
-                    const isStar = Boolean(importedModule?.isStar);
-                    const isReExportedByEntryFile = !isIncludeEntryExports && isStar && isExportedInEntryFile(importedModule);
+                    const isStar = Boolean(importingModule?.isStar);
+                    const isReExportedByEntryFile = !isIncludeEntryExports && isStar && isExportedInEntryFile(importingModule);
                     if (!isReExportedByEntryFile && !isExportedItemReferenced(exportedItem, filePath)) {
                         if (['enum', 'type', 'interface'].includes(exportedItem.type)) {
                             if (isProduction)

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "2.21.0";
+export declare const version = "2.21.2";

package/dist/version.js

@@ -1 +1 @@
-export const version = '2.21.0';
+export const version = '2.21.2';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "2.21.0",
+  "version": "2.21.2",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://github.com/webpro/knip",
   "repository": "github:webpro/knip",
@@ -65,16 +65,16 @@
     "@npmcli/package-json": "5.0.0",
     "@release-it/bumper": "5.1.0",
     "@swc/cli": "0.1.62",
-    "@swc/core": "1.3.80",
+    "@swc/core": "1.3.82",
     "@types/eslint": "8.44.2",
     "@types/js-yaml": "4.0.5",
     "@types/micromatch": "4.0.2",
     "@types/minimist": "1.2.2",
-    "@types/node": "20.5.7",
+    "@types/node": "20.5.9",
     "@types/npmcli__map-workspaces": "3.0.1",
     "@types/webpack": "5.28.2",
-    "@typescript-eslint/eslint-plugin": "6.5.0",
-    "@typescript-eslint/parser": "6.5.0",
+    "@typescript-eslint/eslint-plugin": "6.6.0",
+    "@typescript-eslint/parser": "6.6.0",
     "c8": "8.0.1",
     "eslint": "8.48.0",
     "eslint-import-resolver-typescript": "3.6.0",
@@ -84,7 +84,7 @@
     "release-it": "16.1.5",
     "remark-cli": "11.0.0",
     "remark-preset-webpro": "0.0.3",
-    "tsx": "3.12.7",
+    "tsx": "3.12.8",
     "type-fest": "4.3.1"
   },
   "engines": {