knip 2.2.0 → 2.2.2

package/README.md

@@ -20,7 +20,7 @@ The dots don't connect themselves. This is where Knip comes in:
 - [x] Built-in support for [workspaces (monorepos)][1]
 - [x] Growing list of [built-in plugins][2]
 - [x] Use [compilers][3] to include other file types (e.g. `.mdx`, `.vue`, `.svelte`)
-- [x] Checks npm scripts for used and unlisted dependencies
+- [x] Finds binaries and dependencies in npm scripts, and a lot more locations
 - [x] Finds unused members of classes and enums
 - [x] Finds duplicate exports
 - [x] Supports any combination of JavaScript and TypeScript
@@ -237,9 +237,9 @@ As always, make sure to backup files or use Git before deleting files or making
 
 Workspaces and monorepos are handled out-of-the-box by Knip. Every workspace is part of the analysis.
 
-Here's an example configuration with some custom `entry` and `project` patterns:
+Here's an example `knip.json` configuration with some custom `entry` and `project` patterns:
 
-```jsonc
+```json
 {
   "workspaces": {
     ".": {
@@ -280,6 +280,9 @@ Here's some example output when running Knip in a workspace:
 
 Use `--debug` to get more verbose output.
 
+Use `ignoreBinaries` and `ignoreDependencies` at the root of `knip.json` for global effect, or inside any workspace
+config for local effect.
+
 ## Plugins
 
 Plugins tell Knip where to look for configuration and entry files, and if necessary have a custom dependency finder.
@@ -439,10 +442,9 @@ use the `--production` flag. Here's an example:
 Here's what's included in production mode analysis:
 
 - Only `entry` and `project` patterns suffixed with `!`.
-- Only `entry` patterns from plugins exported as `PRODUCTION_ENTRY_FILE_PATTERNS` (such as Next.js and Gatsby).
-- Only the `postinstall` and `start` script (e.g. not the `test` or other npm scripts in `package.json`).
-- Only `exports`, `nsExports` and `classMembers` are included in the report (`types`, `nsTypes`, `enumMembers` are
-  ignored).
+- Only production `entry` file patterns exported for plugins (such as Next.js and Gatsby).
+- Only the `start` and `postinstall` scripts (e.g. not the `test` or other npm scripts in `package.json`).
+- Only unused `exports`, `nsExports` and `classMembers` are reported (not `types`, `nsTypes`, `enumMembers`).
 
 ### Strict
 
@@ -587,7 +589,7 @@ This table is an ongoing comparison. Based on their docs (please report any mist
 | Custom reporters        |    ✅    |       -        |        -         |            -            |       -        |
 | JavaScript support      |    ✅    |       ✅       |        ✅        |            -            |       -        |
 | Configure entry files   |    ✅    |       ❌       |        ✅        |           ❌            |       ❌       |
-| [Support workspaces][1] |    ✅    |       ❌       |        ❌        |            -            |       -        |
+| [Workspaces][1]         |    ✅    |       ❌       |        ❌        |            -            |       -        |
 | ESLint plugin available |    -     |       -        |        -         |           ✅            |       -        |
 
 ✅ = Supported, ❌ = Not supported, - = Out of scope

package/dist/index.js

@@ -283,7 +283,7 @@ export const main = async (unresolvedConfiguration) => {
                         if (['enum', 'type', 'interface'].includes(exportedItem.type)) {
                             collector.addIssue({ type: 'types', filePath, symbol, symbolType: exportedItem.type });
                         }
-                        else {
+                        else if (!importedModule.isDynamic || !principal.hasExternalReferences(filePath, exportedItem)) {
                             collector.addIssue({ type: 'exports', filePath, symbol });
                         }
                     }

package/dist/types/imports.d.ts

@@ -8,6 +8,7 @@ export type ImportedModule = {
     isStar: boolean;
     isReExported: boolean;
     isReExportedBy: Set<string>;
+    isDynamic: boolean;
 };
 export type Imports = Map<FilePath, ImportedModule>;
 export {};

package/dist/typescript/getImportsAndExports.d.ts

@@ -10,6 +10,7 @@ export type AddImportOptions = {
     specifier: string;
     symbol?: ts.Symbol;
     identifier?: string;
+    isDynamic?: boolean;
 };
 export type AddExportOptions = ExportItem & {
     identifier: string;

package/dist/typescript/getImportsAndExports.js

@@ -19,7 +19,7 @@ export const getImportsAndExports = (sourceFile, options) => {
     const scripts = new Set();
     const importedInternalSymbols = new Map();
     const visitors = getVisitors(sourceFile);
-    const addInternalImport = ({ identifier = '__anonymous', specifier, symbol, filePath, }) => {
+    const addInternalImport = ({ identifier, specifier, symbol, filePath, isDynamic }) => {
         const isStar = identifier === '*';
         const isReExported = Boolean(isStar && !symbol);
         if (!internalImports.has(filePath)) {
@@ -29,6 +29,7 @@ export const getImportsAndExports = (sourceFile, options) => {
                 isReExported,
                 isReExportedBy: new Set(),
                 symbols: new Set(),
+                isDynamic,
             });
         }
         const internalImport = internalImports.get(filePath);
@@ -36,17 +37,17 @@ export const getImportsAndExports = (sourceFile, options) => {
             internalImport.isReExported = isReExported;
             internalImport.isReExportedBy.add(sourceFile.fileName);
         }
-        if (isStar) {
+        if (isStar)
             internalImport.isStar = isStar;
-        }
-        if (!isStar) {
+        if (!isStar)
             internalImport.symbols.add(identifier);
-        }
         if (isStar && symbol) {
             importedInternalSymbols.set(symbol, filePath);
         }
+        if (isDynamic)
+            internalImport.isDynamic = isDynamic;
     };
-    const addImport = ({ specifier, symbol, identifier = '__anonymous' }) => {
+    const addImport = ({ specifier, symbol, identifier = '__anonymous', isDynamic = false }) => {
         if (isBuiltin(specifier))
             return;
         const module = sourceFile.resolvedModules?.get(specifier, undefined);
@@ -55,7 +56,7 @@ export const getImportsAndExports = (sourceFile, options) => {
             if (filePath) {
                 if (module.resolvedModule.isExternalLibraryImport) {
                     if (!isInNodeModules(filePath)) {
-                        addInternalImport({ identifier, specifier, symbol, filePath });
+                        addInternalImport({ identifier, specifier, symbol, filePath, isDynamic });
                     }
                     else if (isDeclarationFileExtension(module.resolvedModule.extension)) {
                         externalImports.add(specifier);
@@ -65,7 +66,7 @@ export const getImportsAndExports = (sourceFile, options) => {
                     }
                 }
                 else {
-                    addInternalImport({ identifier, specifier, symbol, filePath });
+                    addInternalImport({ identifier, specifier, symbol, filePath, isDynamic });
                 }
             }
         }

package/dist/typescript/visitors/imports/importCall.js

@@ -1,28 +1,25 @@
 import ts from 'typescript';
-import { isImportCall, isAccessExpression, getAccessExpressionName, isVariableDeclarationList, findDescendants, } from '../../ast-helpers.js';
+import { isImportCall, isAccessExpression, isVariableDeclarationList, findDescendants } from '../../ast-helpers.js';
 import { importVisitor as visit } from '../index.js';
 export default visit(() => true, node => {
     if (isImportCall(node)) {
         if (node.arguments[0] && ts.isStringLiteralLike(node.arguments[0])) {
             const specifier = node.arguments[0].text;
-            let _node = node.parent;
-            while (_node) {
-                if (_node.parent && ts.isCallExpression(_node.parent)) {
-                    return { specifier, identifier: 'default' };
-                }
-                if (isAccessExpression(_node)) {
-                    const identifier = getAccessExpressionName(_node);
-                    const isPromiseLike = identifier === 'then';
-                    const symbol = isPromiseLike ? 'default' : identifier;
-                    return { identifier: symbol, specifier };
-                }
-                if (isVariableDeclarationList(_node)) {
-                    return findDescendants(_node, ts.isVariableDeclaration).flatMap(variableDeclaration => {
+            if (isAccessExpression(node.parent)) {
+                return { specifier, isDynamic: true };
+            }
+            let _ancestor = node.parent?.parent?.parent;
+            if (_ancestor && isAccessExpression(_ancestor)) {
+                return { specifier, isDynamic: true };
+            }
+            while (_ancestor) {
+                if (_ancestor && isVariableDeclarationList(_ancestor)) {
+                    return findDescendants(_ancestor, ts.isVariableDeclaration).flatMap(variableDeclaration => {
                         if (ts.isIdentifier(variableDeclaration.name)) {
                             return { identifier: 'default', specifier };
                         }
                         else {
-                            const binds = findDescendants(variableDeclaration, _node => ts.isBindingElement(_node));
+                            const binds = findDescendants(variableDeclaration, _node => ts.isBindingElement(_node) && ts.isIdentifier(_node.name));
                             return binds.flatMap(element => {
                                 const symbol = element.propertyName?.getText() || element.name.getText();
                                 return { identifier: symbol, specifier };
@@ -30,7 +27,7 @@ export default visit(() => true, node => {
                         }
                     });
                 }
-                _node = _node.parent;
+                _ancestor = _ancestor.parent;
             }
             return { specifier };
         }

package/dist/typescript/visitors/imports/requireCall.js

@@ -1,8 +1,7 @@
 import ts from 'typescript';
 import { isRequireCall, findAncestor, findDescendants } from '../../ast-helpers.js';
-import { isJS } from '../helpers.js';
 import { importVisitor as visit } from '../index.js';
-export default visit(isJS, node => {
+export default visit(() => true, node => {
     if (isRequireCall(node)) {
         if (ts.isStringLiteralLike(node.arguments[0])) {
             const specifier = node.arguments[0].text;

package/dist/typescript/visitors/imports/requireResolveCall.js

@@ -1,14 +1,12 @@
 import ts from 'typescript';
 import { isRequireResolveCall } from '../../ast-helpers.js';
-import { isJS } from '../helpers.js';
 import { importVisitor as visit } from '../index.js';
-export default visit(isJS, node => {
+export default visit(() => true, node => {
     if (isRequireResolveCall(node)) {
         if (node.arguments[0] && ts.isStringLiteralLike(node.arguments[0])) {
             const specifier = node.arguments[0].text;
-            if (specifier) {
+            if (specifier)
                 return { specifier };
-            }
         }
     }
 });

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "2.2.0";
+export declare const version = "2.2.2";

package/dist/version.js

@@ -1 +1 @@
-export const version = '2.2.0';
+export const version = '2.2.2';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "2.2.0",
+  "version": "2.2.2",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://github.com/webpro/knip",
   "repository": "github:webpro/knip",
@@ -66,14 +66,14 @@
     "@types/js-yaml": "4.0.5",
     "@types/micromatch": "4.0.2",
     "@types/minimist": "1.2.2",
-    "@types/node": "18.15.10",
+    "@types/node": "18.15.11",
     "@types/npmcli__map-workspaces": "3.0.0",
-    "@types/webpack": "5.28.0",
-    "@typescript-eslint/eslint-plugin": "5.56.0",
-    "@typescript-eslint/parser": "5.56.0",
+    "@types/webpack": "5.28.1",
+    "@typescript-eslint/eslint-plugin": "5.57.0",
+    "@typescript-eslint/parser": "5.57.0",
     "c8": "7.13.0",
-    "eslint": "8.36.0",
-    "eslint-import-resolver-typescript": "3.5.3",
+    "eslint": "8.37.0",
+    "eslint-import-resolver-typescript": "3.5.4",
     "eslint-plugin-import": "2.27.5",
     "globstar": "1.0.0",
     "prettier": "2.8.7",
@@ -81,7 +81,7 @@
     "remark-cli": "11.0.0",
     "remark-preset-webpro": "0.0.2",
     "tsx": "3.12.6",
-    "type-fest": "3.7.1"
+    "type-fest": "3.7.2"
   },
   "engines": {
     "node": ">=16.17.0 <17 || >=18.6.0"