knip 2.19.8 → 2.19.10

package/README.md

@@ -746,6 +746,7 @@ Many thanks to some of the early adopters of Knip:
 - Ask your questions in the [Knip knowledge base][65] (powered by OpenAI and [7-docs][66], experimental!)
 - Smashing Magazine: [Knip: An Automated Tool For Finding Unused Files, Exports, And Dependencies][67]
 - Effective TypeScript: [Recommendation Update: ✂️ Use knip to detect dead code and types][68]
+- Josh Goldberg: [Speeding Up Centered Part 4: Unused Code Bloat][69]
 
 ## Why "Knip"?
 
@@ -763,7 +764,7 @@ each file, and traversing all of this, why not collect the various issues in one
 
 Special thanks to the wonderful people who have contributed to this project:
 
-[![Contributors][70]][69]
+[![Contributors][71]][70]
 
 [1]: #workspaces
 [2]: #plugins
@@ -833,8 +834,9 @@ Special thanks to the wonderful people who have contributed to this project:
 [66]: https://github.com/7-docs/7-docs
 [67]: https://www.smashingmagazine.com/2023/08/knip-automated-tool-find-unused-files-exports-dependencies/
 [68]: https://effectivetypescript.com/2023/07/29/knip/
-[69]: https://github.com/webpro/knip/graphs/contributors
-[70]: https://contrib.rocks/image?repo=webpro/knip
+[69]: https://www.joshuakgoldberg.com/blog/speeding-up-centered-part-4-unused-code-bloat/
+[70]: https://github.com/webpro/knip/graphs/contributors
+[71]: https://contrib.rocks/image?repo=webpro/knip
 [plugin-ava]: ./src/plugins/ava
 [plugin-babel]: ./src/plugins/babel
 [plugin-capacitor]: ./src/plugins/capacitor

package/dist/DependencyDeputy.d.ts

@@ -45,7 +45,7 @@ export declare class DependencyDeputy {
     addReferencedDependency(workspaceName: string, packageName: string): void;
     addReferencedBinary(workspaceName: string, binaryName: string): void;
     addPeerDependencies(workspaceName: string, peerDependencies: Map<string, Set<string>>): void;
-    getPeerDependencies(workspaceName: string, dependency: string): string[];
+    getPeerDependenciesOf(workspaceName: string, dependency: string): string[];
     maybeAddReferencedExternalDependency(workspace: Workspace, packageName: string): boolean;
     maybeAddReferencedBinary(workspace: Workspace, binaryName: string): boolean;
     private isInDependencies;

package/dist/DependencyDeputy.js

@@ -76,7 +76,7 @@ export class DependencyDeputy {
     addPeerDependencies(workspaceName, peerDependencies) {
         this.peerDependencies.set(workspaceName, peerDependencies);
     }
-    getPeerDependencies(workspaceName, dependency) {
+    getPeerDependenciesOf(workspaceName, dependency) {
         return Array.from(this.peerDependencies.get(workspaceName)?.get(dependency) ?? []);
     }
     maybeAddReferencedExternalDependency(workspace, packageName) {
@@ -150,35 +150,38 @@ export class DependencyDeputy {
                 return true;
             };
             const peerDepRecs = {};
-            const isNotReferencedDependency = (dependency, isPeerDep) => {
+            const isReferencedDependency = (dependency, isPeerDep) => {
                 if (referencedDependencies?.has(dependency))
-                    return false;
-                if (isPeerDep && peerDepRecs[dependency])
                     return true;
+                if (isPeerDep && peerDepRecs[dependency])
+                    return false;
                 const [scope, typedDependency] = dependency.split('/');
                 if (scope === '@types') {
                     const typedPackageName = getPackageFromDefinitelyTyped(typedDependency);
                     if (IGNORE_DEFINITELY_TYPED.includes(typedPackageName))
-                        return false;
-                    const peerDependencies = this.getPeerDependencies(workspaceName, typedPackageName);
+                        return true;
+                    const peerDependencies = this.getPeerDependenciesOf(workspaceName, typedPackageName);
                     if (peerDependencies.length) {
-                        return !peerDependencies.find(peerDependency => !isNotReferencedDependency(peerDependency, true));
+                        return !!peerDependencies.find(peerDependency => isReferencedDependency(peerDependency, true));
                     }
-                    return !referencedDependencies?.has(typedPackageName);
+                    if (!referencedDependencies)
+                        return false;
+                    return referencedDependencies.has(typedPackageName);
                 }
-                const peerDependencies = this.getPeerDependencies(workspaceName, dependency);
+                const peerDependencies = this.getPeerDependenciesOf(workspaceName, dependency);
                 peerDependencies.forEach(dep => (!peerDepRecs[dep] ? (peerDepRecs[dep] = 1) : peerDepRecs[dep]++));
-                return !peerDependencies.find(peerDependency => !isNotReferencedDependency(peerDependency, true));
+                return !!peerDependencies.find(peerDependency => isReferencedDependency(peerDependency, true));
             };
+            const isNotReferencedDependency = (dependency) => !isReferencedDependency(dependency);
             const pd = this.getProductionDependencies(workspaceName);
             const dd = this.getDevDependencies(workspaceName);
             pd.filter(isNotIgnoredDependency)
                 .filter(isNotIgnoredBinary)
-                .filter(d => isNotReferencedDependency(d))
+                .filter(isNotReferencedDependency)
                 .forEach(symbol => dependencyIssues.push({ type: 'dependencies', filePath: manifestPath, symbol }));
             dd.filter(isNotIgnoredDependency)
                 .filter(isNotIgnoredBinary)
-                .filter(d => isNotReferencedDependency(d))
+                .filter(isNotReferencedDependency)
                 .forEach(symbol => devDependencyIssues.push({ type: 'devDependencies', filePath: manifestPath, symbol }));
         }
         return { dependencyIssues, devDependencyIssues };

package/dist/ProjectPrincipal.js

@@ -158,8 +158,7 @@ export class ProjectPrincipal {
     }
     getHasReferences(filePath, exportedItem) {
         const hasReferences = { external: false, internal: false };
-        const node = ts.isExportAssignment(exportedItem.node) ? exportedItem.node.getChildAt(1) : exportedItem.node;
-        const symbolReferences = this.findReferences(filePath, node).flatMap(f => f.references);
+        const symbolReferences = this.findReferences(filePath, exportedItem.pos).flatMap(f => f.references);
         for (const reference of symbolReferences) {
             if (reference.fileName === filePath) {
                 if (!reference.isDefinition) {
@@ -180,7 +179,7 @@ export class ProjectPrincipal {
             .filter(member => {
             if (this.isPublicExport(member))
                 return false;
-            const referencedSymbols = this.findReferences(filePath, member.node);
+            const referencedSymbols = this.findReferences(filePath, member.pos);
             const files = referencedSymbols
                 .flatMap(refs => refs.references)
                 .filter(ref => !ref.isDefinition)
@@ -191,8 +190,8 @@ export class ProjectPrincipal {
         })
             .map(member => member.identifier);
     }
-    findReferences(filePath, node) {
-        return this.backend.lsFindReferences(filePath, node.getStart()) ?? [];
+    findReferences(filePath, pos) {
+        return this.backend.lsFindReferences(filePath, pos) ?? [];
     }
     isPublicExport(exportedItem) {
         const tags = this.getJSDocTags(exportedItem);

package/dist/plugins/next/index.js

@@ -6,4 +6,6 @@ export const ENTRY_FILE_PATTERNS = ['next.config.{js,ts,cjs,mjs}'];
 export const PRODUCTION_ENTRY_FILE_PATTERNS = [
     '{app,pages}/**/*.{js,jsx,ts,tsx}',
     'src/{app,pages}/**/*.{js,jsx,ts,tsx}',
+    'middleware.{js,ts}',
+    'src/middleware.{js,ts}',
 ];

package/dist/typescript/visitors/exports/exportAssignment.js

@@ -3,6 +3,7 @@ import { SymbolType } from '../../../types/issues.js';
 import { exportVisitor as visit } from '../index.js';
 export default visit(() => true, node => {
     if (ts.isExportAssignment(node)) {
-        return { node, identifier: 'default', type: SymbolType.UNKNOWN, pos: node.expression.getStart() };
+        const pos = node.getChildAt(1).getStart();
+        return { node, identifier: 'default', type: SymbolType.UNKNOWN, pos };
     }
 });

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "2.19.8";
+export declare const version = "2.19.10";

package/dist/version.js

@@ -1 +1 @@
-export const version = '2.19.8';
+export const version = '2.19.10';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "2.19.8",
+  "version": "2.19.10",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript projects",
   "homepage": "https://github.com/webpro/knip",
   "repository": "github:webpro/knip",
@@ -62,7 +62,7 @@
     "zod-validation-error": "^1.5.0"
   },
   "devDependencies": {
-    "@jest/types": "29.6.1",
+    "@jest/types": "29.6.3",
     "@npmcli/package-json": "5.0.0",
     "@release-it/bumper": "5.1.0",
     "@swc/cli": "0.1.62",
@@ -74,13 +74,13 @@
     "@types/node": "20.5.1",
     "@types/npmcli__map-workspaces": "3.0.1",
     "@types/webpack": "5.28.1",
-    "@typescript-eslint/eslint-plugin": "6.4.0",
-    "@typescript-eslint/parser": "6.4.0",
+    "@typescript-eslint/eslint-plugin": "6.4.1",
+    "@typescript-eslint/parser": "6.4.1",
     "c8": "8.0.1",
     "eslint": "8.47.0",
     "eslint-import-resolver-typescript": "3.6.0",
     "eslint-plugin-import": "2.28.1",
-    "eslint-plugin-n": "16.0.1",
+    "eslint-plugin-n": "16.0.2",
     "prettier": "3.0.2",
     "release-it": "16.1.5",
     "remark-cli": "11.0.0",