knip 0.7.3 → 0.8.1

package/README.md

@@ -209,6 +209,11 @@ Using the `--dev` flag will now switch to the non-production analysis.
 
 Depending on the complexity of the project, be aware that it might require some fine-tuning on your end.
 
+## Zero-config
+
+Knip can work without any configuration. Then an existing `tsconfig.json` file is required. Since `entryFiles` and
+`projectFiles` are now the same, Knip is unable to report unused files.
+
 ## More configuration examples
 
 ### Monorepos
@@ -434,7 +439,7 @@ for the job. I'm motivated to make knip perfectly suited for the job of cutting
 
 [1]: #reporters
 [2]: #custom-reporters
-[3]: #why-yet-another-unused-filedependencyexport-finder
+[3]: #really-another-unused-filedependencyexport-finder
 [4]: https://labs.openai.com/s/xZQACaLepaKya0PRUPtIN5dC
 [5]: ./assets/cow-with-orange-scissors-van-gogh-style.webp
 [6]: ./assets/how-it-works.drawio.svg

package/dist/cli.js

@@ -10,7 +10,7 @@ const _1 = require(".");
 const help_1 = require("./help");
 const reporters_1 = __importDefault(require("./reporters"));
 const errors_1 = require("./util/errors");
-const { values: { help, dir, config: configFilePath = 'knip.json', tsConfig: tsConfigFilePath, include = [], exclude = [], ignore = [], 'no-gitignore': isNoGitIgnore = false, dev: isDev = false, 'no-progress': noProgress = false, reporter = 'symbols', 'reporter-options': reporterOptions = '', 'max-issues': maxIssues = '0', jsdoc: jsDoc = [], debug: isDebug = false, 'debug-level': debugLevel = '1', }, } = (0, node_util_1.parseArgs)({
+const { values: { help, dir, config: configFilePath, tsConfig: tsConfigFilePath, include = [], exclude = [], ignore = [], 'no-gitignore': isNoGitIgnore = false, dev: isDev = false, 'include-entry-files': isIncludeEntryFiles = false, 'no-progress': noProgress = false, reporter = 'symbols', 'reporter-options': reporterOptions = '', 'max-issues': maxIssues = '0', jsdoc: jsDoc = [], debug: isDebug = false, 'debug-level': debugLevel = '1', }, } = (0, node_util_1.parseArgs)({
     options: {
         help: { type: 'boolean' },
         config: { type: 'string', short: 'c' },
@@ -21,6 +21,7 @@ const { values: { help, dir, config: configFilePath = 'knip.json', tsConfig: tsC
         ignore: { type: 'string', multiple: true },
         'no-gitignore': { type: 'boolean' },
         dev: { type: 'boolean' },
+        'include-entry-files': { type: 'boolean' },
         'no-progress': { type: 'boolean' },
         'max-issues': { type: 'string' },
         reporter: { type: 'string' },
@@ -49,6 +50,7 @@ const run = async () => {
             exclude,
             ignore,
             gitignore: !isNoGitIgnore,
+            isIncludeEntryFiles,
             isDev,
             isShowProgress,
             jsDoc,

package/dist/help.js

@@ -13,6 +13,7 @@ Options:
   --ignore               Ignore files matching this glob pattern (can be set multiple times)
   --no-gitignore         Don't use .gitignore
   --dev                  Include \`devDependencies\` in report(s)
+  --include-entry-files  Report unused exports and types for entry files
   --no-progress          Don't show dynamic progress updates
   --max-issues           Maximum number of issues before non-zero exit code (default: 0)
   --reporter             Select reporter: symbols, compact, codeowners (default: symbols)

package/dist/index.js

@@ -14,74 +14,89 @@ const runner_1 = require("./runner");
 const errors_1 = require("./util/errors");
 const debug_1 = require("./util/debug");
 const main = async (options) => {
-    const { cwd, workingDir, configFilePath = 'knip.json', tsConfigFilePath, include, exclude, ignore, gitignore, isDev, isShowProgress, jsDoc, debug, } = options;
+    const { cwd, workingDir, configFilePath: configFilePathArg, tsConfigFilePath: tsConfigFilePathArg, include, exclude, ignore, gitignore, isIncludeEntryFiles, isDev, isShowProgress, jsDoc, debug, } = options;
     (0, debug_1.debugLogObject)(options, 1, 'Unresolved onfiguration', options);
-    const localConfigurationPath = configFilePath && (await (0, fs_1.findFile)(workingDir, configFilePath));
-    const manifestPath = await (0, fs_1.findFile)(workingDir, 'package.json');
-    const localConfiguration = localConfigurationPath && require(localConfigurationPath);
+    const manifestPath = await (0, fs_1.findFile)(cwd, workingDir, 'package.json');
     const manifest = manifestPath && require(manifestPath);
-    if (!localConfigurationPath && !manifest.knip) {
-        const location = workingDir === cwd ? 'current directory' : `${node_path_1.default.relative(cwd, workingDir)} or up.`;
-        throw new errors_1.ConfigurationError(`Unable to find ${configFilePath} or package.json#knip in ${location}`);
+    const configFilePath = configFilePathArg ?? 'knip.json';
+    const resolvedConfigFilePath = await (0, fs_1.findFile)(cwd, workingDir, configFilePath);
+    const localConfig = resolvedConfigFilePath && require(resolvedConfigFilePath);
+    if (configFilePathArg && !resolvedConfigFilePath) {
+        throw new errors_1.ConfigurationError(`Unable to find ${configFilePathArg}`);
     }
-    const dir = node_path_1.default.relative(cwd, workingDir);
-    const resolvedConfig = (0, config_1.resolveConfig)(manifest.knip ?? localConfiguration, { workingDir: dir, isDev });
-    (0, debug_1.debugLogObject)(options, 1, 'Resolved onfiguration', resolvedConfig);
-    if (!resolvedConfig) {
-        throw new errors_1.ConfigurationError('Unable to find `entryFiles` and/or `projectFiles` in configuration.');
+    const tsConfigFilePath = tsConfigFilePathArg ?? 'tsconfig.json';
+    const resolvedTsConfigFilePath = await (0, fs_1.findFile)(cwd, workingDir, tsConfigFilePath);
+    if (tsConfigFilePathArg && !resolvedTsConfigFilePath) {
+        throw new errors_1.ConfigurationError(`Unable to find ${tsConfigFilePathArg}`);
     }
-    const report = (0, config_1.resolveIncludedIssueGroups)(include, exclude, resolvedConfig);
     let tsConfigPaths = [];
-    const tsConfigPath = await (0, fs_1.findFile)(workingDir, tsConfigFilePath ?? 'tsconfig.json');
-    if (tsConfigFilePath && !tsConfigPath) {
-        throw new errors_1.ConfigurationError(`Unable to find ${tsConfigFilePath}`);
-    }
-    if (tsConfigPath) {
-        const tsConfig = typescript_1.default.readConfigFile(tsConfigPath, typescript_1.default.sys.readFile);
-        tsConfigPaths = tsConfig.config.compilerOptions?.paths
-            ? Object.keys(tsConfig.config.compilerOptions.paths).map(p => p.replace(/\*/g, '**'))
+    if (resolvedTsConfigFilePath) {
+        const config = typescript_1.default.readConfigFile(resolvedTsConfigFilePath, typescript_1.default.sys.readFile);
+        tsConfigPaths = config.config.compilerOptions?.paths
+            ? Object.keys(config.config.compilerOptions.paths).map(p => p.replace(/\*/g, '**'))
             : [];
-        if (tsConfig.error) {
-            throw new errors_1.ConfigurationError(`An error occured when reading ${node_path_1.default.relative(cwd, tsConfigPath)}`);
+        if (config.error) {
+            throw new errors_1.ConfigurationError(`Unable to read ${node_path_1.default.relative(cwd, resolvedTsConfigFilePath)}`);
         }
     }
-    const projectOptions = tsConfigPath ? { tsConfigFilePath: tsConfigPath } : { compilerOptions: { allowJs: true } };
-    const entryPaths = await (0, path_1.resolvePaths)({
-        cwd,
-        workingDir,
-        patterns: resolvedConfig.entryFiles,
-        ignore,
-        gitignore,
-    });
-    (0, debug_1.debugLogFiles)(options, 1, 'Globbed entry paths', entryPaths);
-    const production = (0, project_1.createProject)({ projectOptions, paths: entryPaths });
-    const entryFiles = production.getSourceFiles();
-    (0, debug_1.debugLogSourceFiles)(options, 1, 'Included entry source files', entryFiles);
-    production.resolveSourceFileDependencies();
-    const productionFiles = production.getSourceFiles();
-    (0, debug_1.debugLogSourceFiles)(options, 1, 'Included production source files', productionFiles);
-    const projectPaths = await (0, path_1.resolvePaths)({
-        cwd,
-        workingDir,
-        patterns: resolvedConfig.projectFiles,
-        ignore,
-        gitignore,
-    });
-    (0, debug_1.debugLogFiles)(options, 1, 'Globbed project paths', projectPaths);
-    const project = (0, project_1.createProject)({ projectOptions, paths: projectPaths });
-    const projectFiles = project.getSourceFiles();
-    (0, debug_1.debugLogSourceFiles)(options, 1, 'Included project source files', projectFiles);
+    const dir = node_path_1.default.relative(cwd, workingDir);
+    const resolvedConfig = (0, config_1.resolveConfig)(manifest.knip ?? localConfig, { workingDir: dir, isDev });
+    (0, debug_1.debugLogObject)(options, 1, 'Resolved onfiguration', resolvedConfig);
+    if (!resolvedConfigFilePath && !manifest.knip && !resolvedTsConfigFilePath) {
+        throw new errors_1.ConfigurationError(`Unable to find ${configFilePath} or package.json#knip or ${tsConfigFilePath}`);
+    }
+    const { entryFiles, productionFiles, projectFiles } = await (async () => {
+        if (resolvedConfig) {
+            const skipAddFiles = { skipAddingFilesFromTsConfig: true, skipFileDependencyResolution: true };
+            const projectOptions = resolvedTsConfigFilePath
+                ? { tsConfigFilePath: resolvedTsConfigFilePath }
+                : { compilerOptions: { allowJs: true } };
+            const entryPaths = await (0, path_1.resolvePaths)({
+                cwd,
+                workingDir,
+                patterns: resolvedConfig.entryFiles,
+                ignore,
+                gitignore,
+            });
+            (0, debug_1.debugLogFiles)(options, 1, 'Globbed entry paths', entryPaths);
+            const production = (0, project_1.createProject)({ ...projectOptions, ...skipAddFiles }, entryPaths);
+            const entryFiles = production.getSourceFiles();
+            (0, debug_1.debugLogSourceFiles)(options, 1, 'Included entry source files', entryFiles);
+            production.resolveSourceFileDependencies();
+            const productionFiles = production.getSourceFiles();
+            (0, debug_1.debugLogSourceFiles)(options, 1, 'Included production source files', productionFiles);
+            const projectPaths = await (0, path_1.resolvePaths)({
+                cwd,
+                workingDir,
+                patterns: resolvedConfig.projectFiles,
+                ignore,
+                gitignore,
+            });
+            (0, debug_1.debugLogFiles)(options, 1, 'Globbed project paths', projectPaths);
+            const project = (0, project_1.createProject)({ ...projectOptions, ...skipAddFiles }, projectPaths);
+            const projectFiles = project.getSourceFiles();
+            (0, debug_1.debugLogSourceFiles)(options, 1, 'Included project source files', projectFiles);
+            return { entryFiles, productionFiles, projectFiles };
+        }
+        else {
+            const project = (0, project_1.createProject)({ tsConfigFilePath: resolvedTsConfigFilePath });
+            const files = project.getSourceFiles();
+            return { entryFiles: files, productionFiles: files, projectFiles: files };
+        }
+    })();
+    const report = (0, config_1.resolveIncludedIssueGroups)(include, resolvedConfig ? exclude : ['files'], resolvedConfig);
     const config = {
         workingDir,
         report,
         entryFiles,
         productionFiles,
         projectFiles,
+        isIncludeEntryFiles: !resolvedConfig || isIncludeEntryFiles,
         dependencies: Object.keys(manifest.dependencies ?? {}),
         peerDependencies: Object.keys(manifest.peerDependencies ?? {}),
         optionalDependencies: Object.keys(manifest.optionalDependencies ?? {}),
         devDependencies: Object.keys(manifest.devDependencies ?? {}),
-        isDev: typeof resolvedConfig.dev === 'boolean' ? resolvedConfig.dev : isDev,
+        isDev: typeof resolvedConfig?.dev === 'boolean' ? resolvedConfig.dev : isDev,
         tsConfigPaths,
         isShowProgress,
         jsDocOptions: {

package/dist/runner.js

@@ -15,14 +15,14 @@ const debug_1 = require("./util/debug");
 const lineRewriter = new log_1.LineRewriter();
 async function findIssues(configuration) {
     const { workingDir, isShowProgress, report, isDev, jsDocOptions } = configuration;
-    const { entryFiles, productionFiles, projectFiles } = configuration;
+    const { entryFiles, productionFiles, projectFiles, isIncludeEntryFiles } = configuration;
     const { getUnresolvedDependencies, getUnusedDependencies, getUnusedDevDependencies } = (0, dependencies_1.getDependencyAnalyzer)(configuration);
     const [usedProductionFiles, unreferencedProductionFiles] = (0, project_1.partitionSourceFiles)(projectFiles, productionFiles);
     const [usedEntryFiles, usedNonEntryFiles] = (0, project_1.partitionSourceFiles)(usedProductionFiles, entryFiles);
-    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'usedProductionFiles', usedProductionFiles);
-    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'unreferencedProductionFiles', unreferencedProductionFiles);
-    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'usedEntryFiles', usedEntryFiles);
-    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'usedNonEntryFiles', usedNonEntryFiles);
+    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'Used production files', usedProductionFiles);
+    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'Unreferenced production files', unreferencedProductionFiles);
+    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'Used entry files', usedEntryFiles);
+    (0, debug_1.debugLogSourceFiles)(configuration, 1, 'Used non-entry files', usedNonEntryFiles);
     const issues = {
         files: new Set(unreferencedProductionFiles.map(file => file.getFilePath())),
         dependencies: new Set(),
@@ -81,13 +81,6 @@ async function findIssues(configuration) {
         }
         updateProcessingOutput(issue);
     };
-    if (report.dependencies || report.unlisted) {
-        usedEntryFiles.forEach(sourceFile => {
-            counters.processed++;
-            const unresolvedDependencies = getUnresolvedDependencies(sourceFile);
-            unresolvedDependencies.forEach(issue => addSymbolIssue('unresolved', issue));
-        });
-    }
     if (report.dependencies ||
         report.unlisted ||
         report.exports ||
@@ -95,7 +88,7 @@ async function findIssues(configuration) {
         report.nsExports ||
         report.nsTypes ||
         report.duplicates) {
-        usedNonEntryFiles.forEach(sourceFile => {
+        usedProductionFiles.forEach(sourceFile => {
             counters.processed++;
             const filePath = sourceFile.getFilePath();
             if (report.dependencies || report.unlisted) {
@@ -110,10 +103,14 @@ async function findIssues(configuration) {
                     addSymbolIssue('duplicates', { filePath, symbol, symbols });
                 });
             }
+            if (!isIncludeEntryFiles && usedEntryFiles.includes(sourceFile))
+                return;
             if (report.exports || report.types || report.nsExports || report.nsTypes) {
-                const uniqueExportedSymbols = new Set([...exportDeclarations.values()].flat());
-                if (uniqueExportedSymbols.size === 1)
-                    return;
+                if (!isIncludeEntryFiles) {
+                    const uniqueExportedSymbols = new Set([...exportDeclarations.values()].flat());
+                    if (uniqueExportedSymbols.size === 1)
+                        return;
+                }
                 exportDeclarations.forEach(declarations => {
                     declarations.forEach(declaration => {
                         const type = (0, type_1.getType)(declaration);
@@ -126,10 +123,18 @@ async function findIssues(configuration) {
                         if (jsDocOptions.isReadPublicTag && ts_morph_1.ts.getJSDocPublicTag(declaration.compilerNode))
                             return;
                         let identifier;
+                        let fakeIdentifier;
                         if (declaration.isKind(ts_morph_1.ts.SyntaxKind.Identifier)) {
                             identifier = declaration;
                         }
-                        else if (declaration.isKind(ts_morph_1.ts.SyntaxKind.ArrowFunction)) {
+                        else if (declaration.isKind(ts_morph_1.ts.SyntaxKind.ArrowFunction) ||
+                            declaration.isKind(ts_morph_1.ts.SyntaxKind.ObjectLiteralExpression) ||
+                            declaration.isKind(ts_morph_1.ts.SyntaxKind.ArrayLiteralExpression) ||
+                            declaration.isKind(ts_morph_1.ts.SyntaxKind.StringLiteral) ||
+                            declaration.isKind(ts_morph_1.ts.SyntaxKind.NumericLiteral)) {
+                            if (!(0, ts_morph_helpers_1.hasReferencingDefaultImport)(sourceFile)) {
+                                fakeIdentifier = 'default';
+                            }
                         }
                         else if (declaration.isKind(ts_morph_1.ts.SyntaxKind.FunctionDeclaration) ||
                             declaration.isKind(ts_morph_1.ts.SyntaxKind.ClassDeclaration) ||
@@ -144,8 +149,8 @@ async function findIssues(configuration) {
                         else {
                             identifier = declaration.getFirstDescendantByKind(ts_morph_1.ts.SyntaxKind.Identifier);
                         }
-                        if (identifier) {
-                            const identifierText = identifier.getText();
+                        if (identifier || fakeIdentifier) {
+                            const identifierText = fakeIdentifier ?? identifier?.getText() ?? '*';
                             if (report.exports && issues.exports[filePath]?.[identifierText])
                                 return;
                             if (report.types && issues.types[filePath]?.[identifierText])
@@ -154,7 +159,7 @@ async function findIssues(configuration) {
                                 return;
                             if (report.nsTypes && issues.nsTypes[filePath]?.[identifierText])
                                 return;
-                            const refs = identifier.findReferences();
+                            const refs = identifier?.findReferences() ?? [];
                             if (refs.length === 0) {
                                 addSymbolIssue('exports', { filePath, symbol: identifierText });
                             }

package/dist/types.d.ts

@@ -44,6 +44,7 @@ export declare type UnresolvedConfiguration = {
     exclude: string[];
     ignore: string[];
     gitignore: boolean;
+    isIncludeEntryFiles: boolean;
     isDev: boolean;
     isShowProgress: boolean;
     jsDoc: string[];
@@ -61,6 +62,7 @@ export declare type Configuration = {
     projectFiles: SourceFile[];
     productionFiles: SourceFile[];
     entryFiles: SourceFile[];
+    isIncludeEntryFiles: boolean;
     dependencies: string[];
     peerDependencies: string[];
     optionalDependencies: string[];

package/dist/util/config.js

@@ -6,6 +6,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.resolveIncludedIssueGroups = exports.resolveConfig = void 0;
 const micromatch_1 = __importDefault(require("micromatch"));
 const resolveConfig = (importedConfiguration, options) => {
+    if (!importedConfiguration)
+        return;
     let resolvedConfig = importedConfiguration;
     const { workingDir, isDev } = options ?? {};
     const configKeys = Object.keys(importedConfiguration);

package/dist/util/fs.d.ts

@@ -1 +1 @@
-export declare const findFile: (cwd: string, fileName: string) => Promise<string | undefined>;
+export declare const findFile: (cwd: string, workingDir: string, fileName: string) => Promise<string | undefined>;

package/dist/util/fs.js

@@ -15,14 +15,16 @@ const isFile = async (filePath) => {
         return false;
     }
 };
-const findFile = async (cwd, fileName) => {
-    const filePath = node_path_1.default.join(cwd, fileName);
+const findFile = async (cwd, workingDir, fileName) => {
+    const filePath = node_path_1.default.join(workingDir, fileName);
     if (await isFile(filePath)) {
         return filePath;
     }
     else {
-        const parentDir = node_path_1.default.resolve(cwd, '..');
-        return parentDir === '/' ? undefined : (0, exports.findFile)(parentDir, fileName);
+        if (cwd === workingDir)
+            return;
+        const parentDir = node_path_1.default.resolve(workingDir, '..');
+        return (0, exports.findFile)(cwd, parentDir, fileName);
     }
 };
 exports.findFile = findFile;

package/dist/util/project.d.ts

@@ -1,7 +1,4 @@
 import { Project } from 'ts-morph';
 import type { ProjectOptions, SourceFile } from 'ts-morph';
-export declare const createProject: ({ projectOptions, paths }: {
-    projectOptions: ProjectOptions;
-    paths?: string[] | undefined;
-}) => Project;
+export declare const createProject: (projectOptions: ProjectOptions, paths?: string[]) => Project;
 export declare const partitionSourceFiles: (projectFiles: SourceFile[], productionFiles: SourceFile[]) => SourceFile[][];

package/dist/util/project.js

@@ -2,12 +2,8 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.partitionSourceFiles = exports.createProject = void 0;
 const ts_morph_1 = require("ts-morph");
-const createProject = ({ projectOptions, paths }) => {
-    const workspace = new ts_morph_1.Project({
-        ...projectOptions,
-        skipAddingFilesFromTsConfig: true,
-        skipFileDependencyResolution: true,
-    });
+const createProject = (projectOptions, paths) => {
+    const workspace = new ts_morph_1.Project(projectOptions);
     if (paths)
         workspace.addSourceFilesAtPaths(paths);
     return workspace;

package/license

@@ -0,0 +1,12 @@
+ISC License (ISC)
+
+Copyright 2022 Lars Kappert
+
+Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted,
+provided that the above copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
+INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
+THIS SOFTWARE.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knip",
-  "version": "0.7.3",
+  "version": "0.8.1",
   "description": "Find unused files, dependencies and exports in your TypeScript and JavaScript project",
   "keywords": [
     "find",
@@ -45,7 +45,7 @@
     "is-builtin-module": "3.2.0",
     "micromatch": "4.0.5",
     "ts-morph": "16.0.0",
-    "ts-morph-helpers": "0.5.1"
+    "ts-morph-helpers": "0.6.0"
   },
   "devDependencies": {
     "@types/micromatch": "4.0.2",