knex 0.21.20 → 0.21.21

package/lib/dialects/mysql/transaction.js

@@ -1,48 +1,48 @@
-const Transaction = require('../../transaction');
-const Debug = require('debug');
-
-const debug = Debug('knex:tx');
-
-class Transaction_MySQL extends Transaction {}
-
-Object.assign(Transaction_MySQL.prototype, {
-  query(conn, sql, status, value) {
-    const t = this;
-    const q = this.trxClient
-      .query(conn, sql)
-      .catch((err) => {
-        if (err.errno === 1305) {
-          this.trxClient.logger.warn(
-            'Transaction was implicitly committed, do not mix transactions and ' +
-              'DDL with MySQL (#805)'
-          );
-          return;
-        }
-
-        status = 2;
-        value = err;
-        t._completed = true;
-        debug('%s error running transaction query', t.txid);
-      })
-      .then(function (res) {
-        if (status === 1) t._resolver(value);
-        if (status === 2) {
-          if (value === undefined) {
-            if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) {
-              t._resolver();
-              return;
-            }
-            value = new Error(`Transaction rejected with non-error: ${value}`);
-          }
-          t._rejecter(value);
-        }
-        return res;
-      });
-    if (status === 1 || status === 2) {
-      t._completed = true;
-    }
-    return q;
-  },
-});
-
-module.exports = Transaction_MySQL;
+const Transaction = require('../../transaction');
+const Debug = require('debug');
+
+const debug = Debug('knex:tx');
+
+class Transaction_MySQL extends Transaction {}
+
+Object.assign(Transaction_MySQL.prototype, {
+  query(conn, sql, status, value) {
+    const t = this;
+    const q = this.trxClient
+      .query(conn, sql)
+      .catch((err) => {
+        if (err.errno === 1305) {
+          this.trxClient.logger.warn(
+            'Transaction was implicitly committed, do not mix transactions and ' +
+              'DDL with MySQL (#805)'
+          );
+          return;
+        }
+
+        status = 2;
+        value = err;
+        t._completed = true;
+        debug('%s error running transaction query', t.txid);
+      })
+      .then(function (res) {
+        if (status === 1) t._resolver(value);
+        if (status === 2) {
+          if (value === undefined) {
+            if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) {
+              t._resolver();
+              return;
+            }
+            value = new Error(`Transaction rejected with non-error: ${value}`);
+          }
+          t._rejecter(value);
+        }
+        return res;
+      });
+    if (status === 1 || status === 2) {
+      t._completed = true;
+    }
+    return q;
+  },
+});
+
+module.exports = Transaction_MySQL;

package/lib/dialects/mysql2/index.js

@@ -1,35 +1,35 @@
-// MySQL2 Client
-// -------
-const { inherits } = require('util');
-const Client_MySQL = require('../mysql');
-const Transaction = require('./transaction');
-
-// Always initialize with the "QueryBuilder" and "QueryCompiler"
-// objects, which extend the base 'lib/query/builder' and
-// 'lib/query/compiler', respectively.
-function Client_MySQL2(config) {
-  Client_MySQL.call(this, config);
-}
-inherits(Client_MySQL2, Client_MySQL);
-
-Object.assign(Client_MySQL2.prototype, {
-  // The "dialect", for reference elsewhere.
-  driverName: 'mysql2',
-
-  transaction() {
-    return new Transaction(this, ...arguments);
-  },
-
-  _driver() {
-    return require('mysql2');
-  },
-
-  validateConnection(connection) {
-    if (connection._fatalError) {
-      return false;
-    }
-    return true;
-  },
-});
-
-module.exports = Client_MySQL2;
+// MySQL2 Client
+// -------
+const { inherits } = require('util');
+const Client_MySQL = require('../mysql');
+const Transaction = require('./transaction');
+
+// Always initialize with the "QueryBuilder" and "QueryCompiler"
+// objects, which extend the base 'lib/query/builder' and
+// 'lib/query/compiler', respectively.
+function Client_MySQL2(config) {
+  Client_MySQL.call(this, config);
+}
+inherits(Client_MySQL2, Client_MySQL);
+
+Object.assign(Client_MySQL2.prototype, {
+  // The "dialect", for reference elsewhere.
+  driverName: 'mysql2',
+
+  transaction() {
+    return new Transaction(this, ...arguments);
+  },
+
+  _driver() {
+    return require('mysql2');
+  },
+
+  validateConnection(connection) {
+    if (connection._fatalError) {
+      return false;
+    }
+    return true;
+  },
+});
+
+module.exports = Client_MySQL2;

package/lib/dialects/mysql2/transaction.js

@@ -1,46 +1,46 @@
-const Transaction = require('../../transaction');
-const debug = require('debug')('knex:tx');
-
-class Transaction_MySQL2 extends Transaction {}
-
-Object.assign(Transaction_MySQL2.prototype, {
-  query(conn, sql, status, value) {
-    const t = this;
-    const q = this.trxClient
-      .query(conn, sql)
-      .catch((err) => {
-        if (err.code === 'ER_SP_DOES_NOT_EXIST') {
-          this.trxClient.logger.warn(
-            'Transaction was implicitly committed, do not mix transactions and ' +
-              'DDL with MySQL (#805)'
-          );
-          return;
-        }
-
-        status = 2;
-        value = err;
-        t._completed = true;
-        debug('%s error running transaction query', t.txid);
-      })
-      .then(function (res) {
-        if (status === 1) t._resolver(value);
-        if (status === 2) {
-          if (value === undefined) {
-            if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) {
-              t._resolver();
-              return;
-            }
-            value = new Error(`Transaction rejected with non-error: ${value}`);
-          }
-          t._rejecter(value);
-          return res;
-        }
-      });
-    if (status === 1 || status === 2) {
-      t._completed = true;
-    }
-    return q;
-  },
-});
-
-module.exports = Transaction_MySQL2;
+const Transaction = require('../../transaction');
+const debug = require('debug')('knex:tx');
+
+class Transaction_MySQL2 extends Transaction {}
+
+Object.assign(Transaction_MySQL2.prototype, {
+  query(conn, sql, status, value) {
+    const t = this;
+    const q = this.trxClient
+      .query(conn, sql)
+      .catch((err) => {
+        if (err.code === 'ER_SP_DOES_NOT_EXIST') {
+          this.trxClient.logger.warn(
+            'Transaction was implicitly committed, do not mix transactions and ' +
+              'DDL with MySQL (#805)'
+          );
+          return;
+        }
+
+        status = 2;
+        value = err;
+        t._completed = true;
+        debug('%s error running transaction query', t.txid);
+      })
+      .then(function (res) {
+        if (status === 1) t._resolver(value);
+        if (status === 2) {
+          if (value === undefined) {
+            if (t.doNotRejectOnRollback && /^ROLLBACK\b/i.test(sql)) {
+              t._resolver();
+              return;
+            }
+            value = new Error(`Transaction rejected with non-error: ${value}`);
+          }
+          t._rejecter(value);
+          return res;
+        }
+      });
+    if (status === 1 || status === 2) {
+      t._completed = true;
+    }
+    return q;
+  },
+});
+
+module.exports = Transaction_MySQL2;

package/lib/dialects/oracle/DEAD_CODE.md

@@ -1,5 +1,5 @@
-# Warning: Dead Code #
-
-The `oracle` dialect is mostly dead code at this point.  However, a handful of its methods are still referenced by the `oracledb` dialect.  So, we are in the process of migrating those methods over to the `oracledb` dialect where they belong.  Once that task is completed, we will officially remove the `oracle` dialect.
-
-In short: do not use the `oracle` dialect.  Use the `oracledb` dialect instead.
+# Warning: Dead Code #
+
+The `oracle` dialect is mostly dead code at this point.  However, a handful of its methods are still referenced by the `oracledb` dialect.  So, we are in the process of migrating those methods over to the `oracledb` dialect where they belong.  Once that task is completed, we will officially remove the `oracle` dialect.
+
+In short: do not use the `oracle` dialect.  Use the `oracledb` dialect instead.

package/lib/dialects/oracle/formatter.js

@@ -1,20 +1,20 @@
-const Formatter = require('../../formatter');
-const { ReturningHelper } = require('./utils');
-
-class Oracle_Formatter extends Formatter {
-  alias(first, second) {
-    return first + ' ' + second;
-  }
-
-  parameter(value, notSetValue) {
-    // Returning helper uses always ROWID as string
-    if (value instanceof ReturningHelper && this.client.driver) {
-      value = new this.client.driver.OutParam(this.client.driver.OCCISTRING);
-    } else if (typeof value === 'boolean') {
-      value = value ? 1 : 0;
-    }
-    return super.parameter(value, notSetValue);
-  }
-}
-
-module.exports = Oracle_Formatter;
+const Formatter = require('../../formatter');
+const { ReturningHelper } = require('./utils');
+
+class Oracle_Formatter extends Formatter {
+  alias(first, second) {
+    return first + ' ' + second;
+  }
+
+  parameter(value, notSetValue) {
+    // Returning helper uses always ROWID as string
+    if (value instanceof ReturningHelper && this.client.driver) {
+      value = new this.client.driver.OutParam(this.client.driver.OCCISTRING);
+    } else if (typeof value === 'boolean') {
+      value = value ? 1 : 0;
+    }
+    return super.parameter(value, notSetValue);
+  }
+}
+
+module.exports = Oracle_Formatter;

package/lib/dialects/oracle/index.js

@@ -1,79 +1,79 @@
-// Oracle Client
-// -------
-const { inherits } = require('util');
-const Client = require('../../client');
-
-const SchemaCompiler = require('./schema/compiler');
-const ColumnBuilder = require('./schema/columnbuilder');
-const ColumnCompiler = require('./schema/columncompiler');
-const TableCompiler = require('./schema/tablecompiler');
-const { isConnectionError } = require('./utils');
-
-// Always initialize with the "QueryBuilder" and "QueryCompiler"
-// objects, which extend the base 'lib/query/builder' and
-// 'lib/query/compiler', respectively.
-function Client_Oracle(config) {
-  Client.call(this, config);
-}
-
-inherits(Client_Oracle, Client);
-
-Object.assign(Client_Oracle.prototype, {
-  dialect: 'oracle',
-
-  driverName: 'oracle',
-
-  schemaCompiler() {
-    return new SchemaCompiler(this, ...arguments);
-  },
-
-  columnBuilder() {
-    return new ColumnBuilder(this, ...arguments);
-  },
-
-  columnCompiler() {
-    return new ColumnCompiler(this, ...arguments);
-  },
-
-  tableCompiler() {
-    return new TableCompiler(this, ...arguments);
-  },
-
-  // Return the database for the Oracle client.
-  database() {
-    return this.connectionSettings.database;
-  },
-
-  // Position the bindings for the query.
-  positionBindings(sql) {
-    let questionCount = 0;
-    return sql.replace(/\?/g, function () {
-      questionCount += 1;
-      return `:${questionCount}`;
-    });
-  },
-
-  _stream(connection, obj, stream, options) {
-    return new Promise(function (resolver, rejecter) {
-      stream.on('error', (err) => {
-        if (isConnectionError(err)) {
-          connection.__knex__disposed = err;
-        }
-        rejecter(err);
-      });
-      stream.on('end', resolver);
-      const queryStream = connection.queryStream(
-        obj.sql,
-        obj.bindings,
-        options
-      );
-      queryStream.pipe(stream);
-      queryStream.on('error', function (error) {
-        rejecter(error);
-        stream.emit('error', error);
-      });
-    });
-  },
-});
-
-module.exports = Client_Oracle;
+// Oracle Client
+// -------
+const { inherits } = require('util');
+const Client = require('../../client');
+
+const SchemaCompiler = require('./schema/compiler');
+const ColumnBuilder = require('./schema/columnbuilder');
+const ColumnCompiler = require('./schema/columncompiler');
+const TableCompiler = require('./schema/tablecompiler');
+const { isConnectionError } = require('./utils');
+
+// Always initialize with the "QueryBuilder" and "QueryCompiler"
+// objects, which extend the base 'lib/query/builder' and
+// 'lib/query/compiler', respectively.
+function Client_Oracle(config) {
+  Client.call(this, config);
+}
+
+inherits(Client_Oracle, Client);
+
+Object.assign(Client_Oracle.prototype, {
+  dialect: 'oracle',
+
+  driverName: 'oracle',
+
+  schemaCompiler() {
+    return new SchemaCompiler(this, ...arguments);
+  },
+
+  columnBuilder() {
+    return new ColumnBuilder(this, ...arguments);
+  },
+
+  columnCompiler() {
+    return new ColumnCompiler(this, ...arguments);
+  },
+
+  tableCompiler() {
+    return new TableCompiler(this, ...arguments);
+  },
+
+  // Return the database for the Oracle client.
+  database() {
+    return this.connectionSettings.database;
+  },
+
+  // Position the bindings for the query.
+  positionBindings(sql) {
+    let questionCount = 0;
+    return sql.replace(/\?/g, function () {
+      questionCount += 1;
+      return `:${questionCount}`;
+    });
+  },
+
+  _stream(connection, obj, stream, options) {
+    return new Promise(function (resolver, rejecter) {
+      stream.on('error', (err) => {
+        if (isConnectionError(err)) {
+          connection.__knex__disposed = err;
+        }
+        rejecter(err);
+      });
+      stream.on('end', resolver);
+      const queryStream = connection.queryStream(
+        obj.sql,
+        obj.bindings,
+        options
+      );
+      queryStream.pipe(stream);
+      queryStream.on('error', function (error) {
+        rejecter(error);
+        stream.emit('error', error);
+      });
+    });
+  },
+});
+
+module.exports = Client_Oracle;