knex-migrator 5.4.0 → 5.4.1

package/lib/database.js

@@ -180,7 +180,16 @@ exports.drop = function drop(options) {
     } else if (DatabaseInfo.isSQLite(connection)) {
         // @NOTE: sqlite3 does not support "DROP DATABASE". We have to drop each table instead.
         // @NOTE: We cannot just remove the sqlite3 file, because any database connection will get invalid.
-        return connection.raw(`SELECT name FROM sqlite_master WHERE type='table';`)
+        // @NOTE: better-sqlite3 enforces foreign key constraints, so dropping a parent table before
+        // its referencing children trips an FK error. Disable foreign keys for the duration of the
+        // drop and restore afterwards. SQLite uses a single connection here, so the PRAGMA persists
+        // across the drops. The legacy sqlite3 driver does not enforce these, so we leave it untouched.
+        const isBetterSqlite = connection.client.config.client === 'better-sqlite3';
+
+        return (isBetterSqlite ? connection.raw('PRAGMA foreign_keys = OFF;') : Promise.resolve())
+            .then(function () {
+                return connection.raw(`SELECT name FROM sqlite_master WHERE type='table';`);
+            })
             .then(function (tables) {
                 return sequence(tables.map(table => () => {
                     if (table.name === 'sqlite_sequence') {
@@ -201,6 +210,11 @@ exports.drop = function drop(options) {
                 return Promise.reject(new errors.KnexMigrateError({
                     err: err
                 }));
+            })
+            .finally(function () {
+                if (isBetterSqlite) {
+                    return connection.raw('PRAGMA foreign_keys = ON;');
+                }
             });
     } else {
         return Promise.reject(new errors.KnexMigrateError({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "knex-migrator",
-  "version": "5.4.0",
+  "version": "5.4.1",
   "description": "Database migrations with knex.",
   "keywords": [
     "ghost",