kipphi 2.1.1 → 2.1.2

package/bpm.ts

@@ -63,6 +63,15 @@ export class BPMEndNode extends EventEndNode {
     override previous: BPMStartNode;
     /** 下一个BPM起始节点 */
     override next: BPMStartNode;
+
+    // @ts-expect-error 强加一个getter
+    get value(): number {
+        return this.previous.value;
+    }
+    set value(value: number) {
+        if (!this.previous) { return; }
+        this.previous.value = value;
+    }
     
     /**
      * 创建一个新的BPM结束节点

package/env.ts

@@ -53,6 +53,7 @@ export enum ERROR_IDS {
     SEQUENCE_NODE_TIME_OCCUPIED =                   ENS        | OCCPIED       | 1,
     INVALID_EVENT_NODE_SEQUENCE_TYPE =              ENS        | INVALID_DATA  | 0,
     EVENT_NODE_TIME_NOT_INCREMENTAL =               ENS        | INVALID_DATA  | 1,
+    EVENT_NODE_NOT_DENSE =                          ENS        | INVALID_DATA  | 2,
     PARENT_SEQUENCE_NOT_FOUND =                     ENS        | INVALID_USAGE | 1,
     NEEDS_AT_LEAST_ONE_ENS =                        ENS        | INVALID_USAGE | 2,
     SEQUENCE_TYPE_NOT_CONSISTENT =                  ENS        | INVALID_USAGE | 3,
@@ -80,6 +81,7 @@ export enum ERROR_IDS {
     
 
     INVALID_NOTE_PROP_TYPE =                        NOTE       | INVALID_TYPE  | 0,
+    HOLD_HAS_NO_DURATION =                          NOTE       | INVALID_DATA  | 0,
 
 
     INVALID_TIME_TUPLE =                            TC         | INVALID_DATA  | 0,
@@ -175,9 +177,39 @@ export const ERRORS = {
         `Parametric Macro requires key. At ${pos}`,
     MACRO_NOT_PARAMETRIC: (macroId: string, pos) =>
         `Macro '${macroId}' is not parametric. At ${pos}`,
+    EVENT_NODE_NOT_DENSE: (pos: string) =>
+        `EventNode is not dense. At ${pos}`,
+    HOLD_HAS_NO_DURATION: () =>
+        `Hold should have a duration.`,
 } satisfies Record<keyof typeof ERROR_IDS, (...args: any[]) => string>
 
+type EnumKeys<E extends Record<string, string | number>> = E[keyof E];
+
+// 工具类型：检查 T 的键是否恰好等于枚举的值集合
+type AssertExactEnumKeys<T, E extends Record<string, string | number>> =
+  // 1. 收集 T 的键（作为字符串字面量类型）
+  (keyof T) extends (keyof E)            // 不能有多余键
+    ? (keyof E) extends (keyof T)        // 不能缺键
+      ? T                                   // 通过检查
+      : { error: any/*error: "Interface is missing some enum keys"*/ }
+    : { error: "Interface has extra keys not in enum" };
+
+// 用类型别名做“编译期断言”
+type _CheckMap = AssertExactEnumKeys<ErrorMap, typeof ERROR_IDS>;
+interface _Error extends _CheckMap {
+    error: "";
+}
+
+
+interface ErrorMap extends Record<keyof typeof ERROR_IDS, Array<any>>{
+    EVENT_NODE_NOT_DENSE: [EventNode];
+}
+
+type ArgsOf<ET extends ERROR_IDS> = ET extends keyof ErrorMap ? ErrorMap[ET] : never;
+
 export class KPAError<ET extends ERROR_IDS> extends Error {
+    fixed = false;
+    args: ArgsOf<ET> | [];
     constructor(message: string, public id: ET) {
         super(message);
     }
@@ -186,8 +218,15 @@ export class KPAError<ET extends ERROR_IDS> extends Error {
      * 
      * 此时可以调用该方法，该方法会输出错误并把它保存到KPAError的一个`buffer`静态属性下。
      */
-    warn() {
+    warn(...args: ArgsOf<ET> | []) {
         console.warn(this.stack);
+        this.args = args;
+        KPAError.buffer.push(this);
+    }
+    fix(...args: ArgsOf<ET> | []) {
+        console.warn("[Auto Fixed]" + this.stack);
+        this.fixed = true;
+        this.args = args;
         KPAError.buffer.push(this);
     }
     static buffer: KPAError<ERROR_IDS>[] = [];

package/event.ts

@@ -505,7 +505,7 @@ export class EventNodeSequence<VT extends EventValueESType = number> { // 泛型
         return type === EventType.speed                               ? 10  :
                type === EventType.scaleX || type === EventType.scaleY ? 1.0 :
                type === EventType.text                                ? ""  :
-               type === EventType.color                               ? [0, 0, 0] :
+               type === EventType.color                               ? [255, 255, 255] :
                0
     }
     /**
@@ -649,32 +649,28 @@ export class EventNodeSequence<VT extends EventValueESType = number> { // 泛型
                 err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}] and the previous`).warn()
             }
             if (!TC.lt(event.startTime, event.endTime)) {
-                err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).warn()
+                if (TC.eq(event.startTime, event.endTime)) {
+                    // 零长事件直接忽略，并认为已经修复
+                    err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).fix();
+                    continue;
+                } else {
+                    err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).warn()
+                }
             }
-            lastEndTime = event.endTime;
             if (lastEnd.type === NodeType.HEAD) {
                 EventNode.connect(lastEnd, start)
-            // 如果上一个是钩定事件，那么一块捋平
-            } else if (
-                   lastEnd.value === lastEnd.previous.value
-                && lastEnd.previous.evaluator instanceof EasedEvaluator
-            ) {
-                lastEnd.time = start.time
-                EventNode.connect(lastEnd, start)
-            } else if (TC.eq(lastEnd.time, start.time)) {
-                const val = lastEnd.value;
-                const midStart = new EventStartNode(lastEnd.time, val);
-                const midEnd = new EventEndNode(start.time, val);
-                midStart.evaluator = lastEnd.previous.evaluator;
-                EventNode.connect(lastEnd, midStart);
-                EventNode.connect(midStart, midEnd);
+            } else if (TC.gt(event.startTime, lastEndTime)) {
+                err.EVENT_NODE_NOT_DENSE(`${pos}.events[${index}]`).warn();
+                const mid = new EventStartNode(lastEndTime, start.value);
+                const midEnd = new EventEndNode(event.startTime, end.value);
+                EventNode.connect(lastEnd, mid);
+                EventNode.connect(mid, midEnd);
                 EventNode.connect(midEnd, start);
-                listLength++;
             } else {
-                
                 EventNode.connect(lastEnd, start)
             }
             
+            lastEndTime = event.endTime;
             lastEnd = end;
         }
         const last = lastEnd;
@@ -948,6 +944,29 @@ export class EventNodeSequence<VT extends EventValueESType = number> { // 泛型
         dest.initJump();
         return dest;
     }
+    checkErrors() {
+        let currentNode: EventStartNode<VT> = this.head.next;
+        if (TC.ne(currentNode.time, [0, 0, 1])) {
+            err.EVENT_NODE_NOT_DENSE(`${this.id}, ${currentNode.time}`).fix();
+            currentNode.time = [0, 0, 1];
+        }
+        const endNode = currentNode.next;
+        if (endNode.type === NodeType.TAIL) {
+            return;
+        }
+
+        let lastEnd: EventEndNode<VT> = endNode;
+        while (true) {
+            const endNode = currentNode.next;
+            if (endNode.type === NodeType.TAIL) {
+                break;
+            }
+            if (TC.ne(lastEnd.time, currentNode.time)) {
+                err.EVENT_NODE_NOT_DENSE(`${this.id}, ${currentNode.time}`).warn();
+            }
+            currentNode = currentNode.next.next;
+        }
+    }
 }
 
 export type SpeedENS = EventNodeSequence<number> & { type: EventType.speed };

package/index.d.ts

@@ -533,7 +533,7 @@ declare module "chartTypes" {
     export type ExtendedEventTypeName = "scaleX" | "scaleY" | "text" | "color";
 }
 declare module "version" {
-    export const VERSION = 211;
+    export const VERSION = 212;
     export const SCHEMA = "https://cdn.jsdelivr.net/npm/kipphi@2.1.0/chartType2.schema.json";
 }
 declare module "util" {
@@ -652,6 +652,8 @@ declare module "bpm" {
         previous: BPMStartNode;
         /** 下一个BPM起始节点 */
         next: BPMStartNode;
+        get value(): number;
+        set value(value: number);
         /**
          * 创建一个新的BPM结束节点
          * @param endTime 节点结束时间
@@ -2179,6 +2181,7 @@ declare module "event" {
          * @throws {KPAError<ERROR_IDS.NEEDS_AT_LEAST_ONE_ENS>}
          */
         static mergeSequences(sequences: EventNodeSequence[]): EventNodeSequence<number>;
+        checkErrors(): void;
     }
     export type SpeedENS = EventNodeSequence<number> & {
         type: EventType.speed;
@@ -2186,12 +2189,14 @@ declare module "event" {
 }
 declare module "env" {
     import { type TimeT, type EventValueType } from "chartTypes";
+    import { EventNode } from "event";
     export enum ERROR_IDS {
         UI_OCCUPIED = 272,
         SEQUENCE_NAME_OCCUPIED = 1552,
         SEQUENCE_NODE_TIME_OCCUPIED = 1553,
         INVALID_EVENT_NODE_SEQUENCE_TYPE = 1568,
         EVENT_NODE_TIME_NOT_INCREMENTAL = 1569,
+        EVENT_NODE_NOT_DENSE = 1570,
         PARENT_SEQUENCE_NOT_FOUND = 1585,
         NEEDS_AT_LEAST_ONE_ENS = 1586,
         SEQUENCE_TYPE_NOT_CONSISTENT = 1587,
@@ -2212,6 +2217,7 @@ declare module "env" {
         MISSING_MACRO_EVALUATOR_KEY = 2336,
         MACRO_EVALUATOR_NOT_FOUND = 2337,
         INVALID_NOTE_PROP_TYPE = 2880,
+        HOLD_HAS_NO_DURATION = 2848,
         INVALID_TIME_TUPLE = 3104,
         TIME_MACRO_NOT_FOUND = 3360,
         VALUE_MACRO_NOT_FOUND = 3361,
@@ -2255,16 +2261,25 @@ declare module "env" {
         JAVASCRIPT_SYNTAX_ERROR: (error: Error, macroId: string) => string;
         PARAMETRIC_MACRO_REQUIRES_PROTO_KEY: (pos: any) => string;
         MACRO_NOT_PARAMETRIC: (macroId: string, pos: any) => string;
+        EVENT_NODE_NOT_DENSE: (pos: string) => string;
+        HOLD_HAS_NO_DURATION: () => string;
     };
+    interface ErrorMap extends Record<keyof typeof ERROR_IDS, Array<any>> {
+        EVENT_NODE_NOT_DENSE: [EventNode];
+    }
+    type ArgsOf<ET extends ERROR_IDS> = ET extends keyof ErrorMap ? ErrorMap[ET] : never;
     export class KPAError<ET extends ERROR_IDS> extends Error {
         id: ET;
+        fixed: boolean;
+        args: ArgsOf<ET> | [];
         constructor(message: string, id: ET);
         /**
          * 对于解析谱面等场景，有时可能需要找出全部的错误，不宜直接抛出错误中断代码执行
          *
          * 此时可以调用该方法，该方法会输出错误并把它保存到KPAError的一个`buffer`静态属性下。
          */
-        warn(): void;
+        warn(...args: ArgsOf<ET> | []): void;
+        fix(...args: ArgsOf<ET> | []): void;
         static buffer: KPAError<ERROR_IDS>[];
         static flush(): void;
     }
@@ -2311,6 +2326,8 @@ declare module "env" {
             JAVASCRIPT_SYNTAX_ERROR: (error: Error, macroId: string) => KPAError<ERROR_IDS.JAVASCRIPT_SYNTAX_ERROR>;
             PARAMETRIC_MACRO_REQUIRES_PROTO_KEY: (pos: any) => KPAError<ERROR_IDS.PARAMETRIC_MACRO_REQUIRES_PROTO_KEY>;
             MACRO_NOT_PARAMETRIC: (macroId: string, pos: any) => KPAError<ERROR_IDS.MACRO_NOT_PARAMETRIC>;
+            EVENT_NODE_NOT_DENSE: (pos: string) => KPAError<ERROR_IDS.EVENT_NODE_NOT_DENSE>;
+            HOLD_HAS_NO_DURATION: () => KPAError<ERROR_IDS.HOLD_HAS_NO_DURATION>;
         };
         freeze(): void;
     };
@@ -2423,6 +2440,7 @@ declare module "operation/basic" {
         undo(): void;
         redo(): void;
         do(operation: Operation): void;
+        tryDo(returnOperation: () => Operation): void;
         processFlags(operation: Operation): void;
         clear(): void;
         addEventListener<T extends OpEventType>(type: T, listener: (event: OpEventMap[T]) => void, options?: boolean | AddEventListenerOptions): void;
@@ -2518,8 +2536,8 @@ declare module "operation/event" {
          * @param targetPrevious 要插在谁后面 The node to insert after, accessed through `EventNodeSequence.getNodeAt(TC.toBeats(node))`
          */
         constructor(node: EventStartNode<VT>, targetPrevious: EventStartNode<VT>, updatesFP?: boolean);
-        do(): void;
-        undo(): void;
+        do(chart: Chart): void;
+        undo(chart: Chart): void;
     }
     export class EventNodePairInsertOrOverwriteOperation<VT extends EventValueESType> extends UnionOperation<LazyOperation<typeof EventNodePairInsertOperation<VT>> | EventNodeValueChangeOperation<VT>> {
         overlapping: boolean;

package/index.js

@@ -60,6 +60,7 @@ var ERROR_IDS;
   ERROR_IDS2[ERROR_IDS2["SEQUENCE_NODE_TIME_OCCUPIED"] = ENS | OCCPIED | 1] = "SEQUENCE_NODE_TIME_OCCUPIED";
   ERROR_IDS2[ERROR_IDS2["INVALID_EVENT_NODE_SEQUENCE_TYPE"] = ENS | INVALID_DATA | 0] = "INVALID_EVENT_NODE_SEQUENCE_TYPE";
   ERROR_IDS2[ERROR_IDS2["EVENT_NODE_TIME_NOT_INCREMENTAL"] = ENS | INVALID_DATA | 1] = "EVENT_NODE_TIME_NOT_INCREMENTAL";
+  ERROR_IDS2[ERROR_IDS2["EVENT_NODE_NOT_DENSE"] = ENS | INVALID_DATA | 2] = "EVENT_NODE_NOT_DENSE";
   ERROR_IDS2[ERROR_IDS2["PARENT_SEQUENCE_NOT_FOUND"] = ENS | INVALID_USAGE | 1] = "PARENT_SEQUENCE_NOT_FOUND";
   ERROR_IDS2[ERROR_IDS2["NEEDS_AT_LEAST_ONE_ENS"] = ENS | INVALID_USAGE | 2] = "NEEDS_AT_LEAST_ONE_ENS";
   ERROR_IDS2[ERROR_IDS2["SEQUENCE_TYPE_NOT_CONSISTENT"] = ENS | INVALID_USAGE | 3] = "SEQUENCE_TYPE_NOT_CONSISTENT";
@@ -80,6 +81,7 @@ var ERROR_IDS;
   ERROR_IDS2[ERROR_IDS2["MISSING_MACRO_EVALUATOR_KEY"] = EVALUATOR | INVALID_DATA | 0] = "MISSING_MACRO_EVALUATOR_KEY";
   ERROR_IDS2[ERROR_IDS2["MACRO_EVALUATOR_NOT_FOUND"] = EVALUATOR | INVALID_DATA | 1] = "MACRO_EVALUATOR_NOT_FOUND";
   ERROR_IDS2[ERROR_IDS2["INVALID_NOTE_PROP_TYPE"] = NOTE | INVALID_TYPE | 0] = "INVALID_NOTE_PROP_TYPE";
+  ERROR_IDS2[ERROR_IDS2["HOLD_HAS_NO_DURATION"] = NOTE | INVALID_DATA | 0] = "HOLD_HAS_NO_DURATION";
   ERROR_IDS2[ERROR_IDS2["INVALID_TIME_TUPLE"] = TC | INVALID_DATA | 0] = "INVALID_TIME_TUPLE";
   ERROR_IDS2[ERROR_IDS2["TIME_MACRO_NOT_FOUND"] = MACRO | INVALID_DATA | 0] = "TIME_MACRO_NOT_FOUND";
   ERROR_IDS2[ERROR_IDS2["VALUE_MACRO_NOT_FOUND"] = MACRO | INVALID_DATA | 1] = "VALUE_MACRO_NOT_FOUND";
@@ -122,17 +124,28 @@ var ERRORS = {
   PROTO_PRESENT_IN_NONPARAMETRIC: (macroId) => `'@proto can only be used in parametric Macros. At ${macroId}'`,
   JAVASCRIPT_SYNTAX_ERROR: (error, macroId) => `JavaScript Syntax Error: ${error.message}. At ${macroId}`,
   PARAMETRIC_MACRO_REQUIRES_PROTO_KEY: (pos) => `Parametric Macro requires key. At ${pos}`,
-  MACRO_NOT_PARAMETRIC: (macroId, pos) => `Macro '${macroId}' is not parametric. At ${pos}`
+  MACRO_NOT_PARAMETRIC: (macroId, pos) => `Macro '${macroId}' is not parametric. At ${pos}`,
+  EVENT_NODE_NOT_DENSE: (pos) => `EventNode is not dense. At ${pos}`,
+  HOLD_HAS_NO_DURATION: () => `Hold should have a duration.`
 };
 
 class KPAError extends Error {
   id;
+  fixed = false;
+  args;
   constructor(message, id) {
     super(message);
     this.id = id;
   }
-  warn() {
+  warn(...args) {
     console.warn(this.stack);
+    this.args = args;
+    KPAError.buffer.push(this);
+  }
+  fix(...args) {
+    console.warn("[Auto Fixed]" + this.stack);
+    this.fixed = true;
+    this.args = args;
     KPAError.buffer.push(this);
   }
   static buffer = [];
@@ -1643,7 +1656,7 @@ class EventNodeSequence {
     this.listLength = 1;
   }
   static getDefaultValueFromEventType(type) {
-    return type === 4 /* speed */ ? 10 : type === 7 /* scaleX */ || type === 8 /* scaleY */ ? 1 : type === 9 /* text */ ? "" : type === 10 /* color */ ? [0, 0, 0] : 0;
+    return type === 4 /* speed */ ? 10 : type === 7 /* scaleX */ || type === 8 /* scaleY */ ? 1 : type === 9 /* text */ ? "" : type === 10 /* color */ ? [255, 255, 255] : 0;
   }
   static fromRPEJSON(type, data, chart, pos, endValue) {
     const { templateEasingLib: templates } = chart;
@@ -1723,26 +1736,26 @@ class EventNodeSequence {
         err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}] and the previous`).warn();
       }
       if (!TC2.lt(event.startTime, event.endTime)) {
-        err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).warn();
+        if (TC2.eq(event.startTime, event.endTime)) {
+          err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).fix();
+          continue;
+        } else {
+          err.EVENT_NODE_TIME_NOT_INCREMENTAL(`${pos}.events[${index}]`).warn();
+        }
       }
-      lastEndTime = event.endTime;
       if (lastEnd.type === 0 /* HEAD */) {
         EventNode.connect(lastEnd, start);
-      } else if (lastEnd.value === lastEnd.previous.value && lastEnd.previous.evaluator instanceof EasedEvaluator) {
-        lastEnd.time = start.time;
-        EventNode.connect(lastEnd, start);
-      } else if (TC2.eq(lastEnd.time, start.time)) {
-        const val = lastEnd.value;
-        const midStart = new EventStartNode(lastEnd.time, val);
-        const midEnd = new EventEndNode(start.time, val);
-        midStart.evaluator = lastEnd.previous.evaluator;
-        EventNode.connect(lastEnd, midStart);
-        EventNode.connect(midStart, midEnd);
+      } else if (TC2.gt(event.startTime, lastEndTime)) {
+        err.EVENT_NODE_NOT_DENSE(`${pos}.events[${index}]`).warn();
+        const mid = new EventStartNode(lastEndTime, start.value);
+        const midEnd = new EventEndNode(event.startTime, end.value);
+        EventNode.connect(lastEnd, mid);
+        EventNode.connect(mid, midEnd);
         EventNode.connect(midEnd, start);
-        listLength++;
       } else {
         EventNode.connect(lastEnd, start);
       }
+      lastEndTime = event.endTime;
       lastEnd = end;
     }
     const last = lastEnd;
@@ -1945,6 +1958,28 @@ class EventNodeSequence {
     dest.initJump();
     return dest;
   }
+  checkErrors() {
+    let currentNode = this.head.next;
+    if (TC2.ne(currentNode.time, [0, 0, 1])) {
+      err.EVENT_NODE_NOT_DENSE(`${this.id}, ${currentNode.time}`).fix();
+      currentNode.time = [0, 0, 1];
+    }
+    const endNode = currentNode.next;
+    if (endNode.type === 1 /* TAIL */) {
+      return;
+    }
+    let lastEnd = endNode;
+    while (true) {
+      const endNode2 = currentNode.next;
+      if (endNode2.type === 1 /* TAIL */) {
+        break;
+      }
+      if (TC2.ne(lastEnd.time, currentNode.time)) {
+        err.EVENT_NODE_NOT_DENSE(`${this.id}, ${currentNode.time}`).warn();
+      }
+      currentNode = currentNode.next.next;
+    }
+  }
 }
 // src/note.ts
 var notePropTypes = {
@@ -3033,6 +3068,15 @@ class BPMEndNode extends EventEndNode {
   spb;
   previous;
   next;
+  get value() {
+    return this.previous.value;
+  }
+  set value(value) {
+    if (!this.previous) {
+      return;
+    }
+    this.previous.value = value;
+  }
   constructor(endTime) {
     super(endTime, null);
   }
@@ -3167,7 +3211,7 @@ class TimeCalculator {
   }
 }
 // src/version.ts
-var VERSION = 211;
+var VERSION = 212;
 var SCHEMA = "https://cdn.jsdelivr.net/npm/kipphi@2.1.0/chartType2.schema.json";
 
 // src/chart.ts
@@ -3803,9 +3847,20 @@ class OperationList extends EventTarget {
       this.dispatchEvent(new OperationErrorEvent(operation, e));
       return;
     }
+    this.undoneOperations = [];
+    this.operations.push(operation);
     this.dispatchEvent(new OperationEvent("do", operation));
     this.processFlags(operation);
-    this.operations.push(operation);
+  }
+  tryDo(returnOperation) {
+    let op;
+    try {
+      op = returnOperation();
+    } catch (e) {
+      this.dispatchEvent(new OperationErrorEvent(op, e));
+      return;
+    }
+    this.do(op);
   }
   processFlags(operation) {
     if (operation.updatesEditor) {
@@ -3970,12 +4025,18 @@ class EventNodePairInsertOperation extends Operation {
     }
     this.updatesFP = updatesFP && targetPrevious.isSpeed();
   }
-  do() {
+  do(chart) {
     const [endNode, startNode] = EventNode.insert(this.node, this.tarPrev);
     this.node.parentSeq.updateJump(endNode, startNode);
+    if (this.updatesFP) {
+      this.sequence.updateFloorPositionAfter(this.tarPrev, chart.timeCalculator);
+    }
   }
-  undo() {
+  undo(chart) {
     this.sequence.updateJump(...EventNode.removeNodePair(...EventNode.getEndStart(this.node)));
+    if (this.updatesFP) {
+      this.sequence.updateFloorPositionAfter(this.tarPrev, chart.timeCalculator);
+    }
   }
 }
 
@@ -4461,6 +4522,11 @@ class NoteAddOperation extends Operation {
     super();
     this.note = note;
     this.isHold = note.type === 2 /* hold */;
+    if (this.isHold) {
+      if (TC2.lt(note.endTime, note.startTime)) {
+        throw err.HOLD_HAS_NO_DURATION();
+      }
+    }
     this.noteNode = node;
     this.comboDelta = note.isFake ? 0 : 1;
   }

package/operation/basic.ts

@@ -147,10 +147,21 @@ export class OperationList extends EventTarget {
             this.dispatchEvent(new OperationErrorEvent(operation, e as Error))
             return
         }
+        this.undoneOperations = [];
+        this.operations.push(operation);
         this.dispatchEvent(new OperationEvent("do", operation));
         this.processFlags(operation);
-        this.operations.push(operation);
     }
+    tryDo(returnOperation: () => Operation) {
+        let op: Operation;
+        try {
+            op = returnOperation();
+        } catch (e) {
+            this.dispatchEvent(new OperationErrorEvent(op, e as Error))
+            return
+        }
+        this.do(op);
+    } 
     processFlags(operation: Operation) {
 
         if (operation.updatesEditor) {

package/operation/event.ts

@@ -81,12 +81,20 @@ export class EventNodePairInsertOperation <VT extends EventValueESType> extends
         }
         this.updatesFP = updatesFP && targetPrevious.isSpeed();
     }
-    do() {
+    do(chart: Chart) {
         const [endNode, startNode] = EventNode.insert(this.node, this.tarPrev);
         this.node.parentSeq.updateJump(endNode, startNode)
+        if (this.updatesFP) {
+            // updatesFP的校验确保了序列为速度序列
+            (this.sequence as SpeedENS).updateFloorPositionAfter(this.tarPrev as EventStartNode, chart.timeCalculator) 
+        }
     }
-    undo() {
+    undo(chart: Chart) {
         this.sequence.updateJump(...EventNode.removeNodePair(...EventNode.getEndStart(this.node)))
+        if (this.updatesFP) {
+            // updatesFP的校验确保了序列为速度序列
+            (this.sequence as SpeedENS).updateFloorPositionAfter(this.tarPrev as EventStartNode, chart.timeCalculator) 
+        }
     }
 }
 

package/operation/note.ts

@@ -140,6 +140,11 @@ export class NoteAddOperation extends Operation {
         super()
         this.note = note;
         this.isHold = note.type === NoteType.hold;
+        if (this.isHold) {
+            if (TC.lt(note.endTime, note.startTime)) {
+                throw err.HOLD_HAS_NO_DURATION();
+            }
+        }
         this.noteNode = node;
         // 一般来说，操作是对于在谱里面的NoteNode，谱外面的不需要操作
         this.comboDelta = note.isFake ? 0 : +1;

package/package.json

@@ -1,26 +1,26 @@
 {
-  "name": "kipphi",
-  "description": "Parse your Phigros Chart(.rpe.json or .kpa.json) into an editor-friendly format.",
-  "version": "2.1.1",
-  "author": "Team Zincs (https://github.com/TeamZincs)",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/TeamZincs/kipphi.git"
-  },
-  "module": "index.ts",
-  "main": "index.ts",
-  "type": "module",
-  "devDependencies": {
-    "@types/bun": "latest"
-  },
-  "peerDependencies": {
-    "typescript": "^5"
-  },
-  "exports": {
-    "./operation": null,
-    ".": {
-      "import": "./index.ts"
+    "name": "kipphi",
+    "description": "Parse your Phigros Chart(.rpe.json or .kpa.json) into an editor-friendly format.",
+    "version": "2.1.2",
+    "author": "Team Zincs (https://github.com/TeamZincs)",
+    "license": "MIT",
+    "repository": {
+        "type": "git",
+        "url": "https://github.com/TeamZincs/kipphi.git"
+    },
+    "module": "index.ts",
+    "main": "index.ts",
+    "type": "module",
+    "devDependencies": {
+        "@types/bun": "latest"
+    },
+    "peerDependencies": {
+        "typescript": "^5"
+    },
+    "exports": {
+        "./operation": null,
+        ".": {
+            "import": "./index.ts"
+        }
     }
-  }
 }

package/version.ts

@@ -2,7 +2,7 @@
 
 /// #declaration:global
 
-export const VERSION = 211;
+export const VERSION = 212;
 export const SCHEMA = "https://cdn.jsdelivr.net/npm/kipphi@2.1.0/chartType2.schema.json"
 
 

package/line.ts

@@ -1,246 +0,0 @@
-import { Chart, JudgeLineGroup, BasicEventName, UIName } from "../chart";
-import { ExtendedEventTypeName, RGB } from "../chartTypes";
-import { EventNodeSequence } from "../event";
-import { JudgeLine, ExtendedLayer } from "../judgeline";
-import { Operation } from "./basic";
-
-
-
-// 有点怪异，感觉破坏了纯净性。不管了（
-enum JudgeLinesEditorLayoutType {
-    ordered = 0b001,
-    tree    = 0b010,
-    grouped = 0b100
-}
-
-
-export class JudgeLineInheritanceChangeOperation extends Operation {
-    originalValue: JudgeLine | null;
-    updatesEditor = true;
-    static REFLOWS = JudgeLinesEditorLayoutType.tree;
-    reflows = JudgeLineInheritanceChangeOperation.REFLOWS;
-    constructor(public chart: Chart, public judgeLine: JudgeLine, public value: JudgeLine | null) {
-        super();
-        this.originalValue = judgeLine.father;
-        // 这里只会让它静默失败，外面调用的时候能够在判断一次并抛错误才是最好的
-        if (JudgeLine.checkinterdependency(judgeLine, value)) {
-            this.ineffective = true;
-        }
-    }
-    do() {
-        const line = this.judgeLine;
-        line.father = this.value;
-        if (this.originalValue) {
-            this.originalValue.children.delete(line);
-        } else {
-            const index = this.chart.orphanLines.indexOf(line);
-            if (index >= 0) // Impossible to be false, theoretically
-                this.chart.orphanLines.splice(index, 1)
-        }
-        if (this.value) {
-            this.value.children.add(line);
-        } else {
-            this.chart.orphanLines.push(line);
-        }
-    }
-    undo() {
-        const line = this.judgeLine;
-        line.father = this.originalValue;
-        if (this.originalValue) {
-            this.originalValue.children.add(line);
-        } else {
-            this.chart.orphanLines.push(line);
-        }
-        if (this.value) {
-            this.value.children.delete(line);
-        } else {
-            const index = this.chart.orphanLines.indexOf(line);
-            if (index >= 0) // Impossible to be false, theoretically
-                this.chart.orphanLines.splice(index, 1)
-        }
-    }
-}
-
-export class JudgeLineRenameOperation extends Operation { 
-    updatesEditor = true;
-    originalValue: string;
-    constructor(public judgeLine: JudgeLine, public value: string) {
-        super();
-        this.originalValue = judgeLine.name;
-    }
-    do() {
-        this.judgeLine.name = this.value;
-    }
-    undo() {
-        this.judgeLine.name = this.originalValue;
-    }
-}
-
-type JudgeLinePropName = "name" | "rotatesWithFather" | "anchor" | "texture" | "cover" | "zOrder";
-
-export class JudgeLinePropChangeOperation<T extends JudgeLinePropName> extends Operation {
-    updatesEditor = true;
-    originalValue: JudgeLine[T];
-    constructor(public judgeLine: JudgeLine, public field: T, public value: JudgeLine[T]) {
-        super();
-        this.originalValue = judgeLine[field];
-    }
-    do() {
-        this.judgeLine[this.field] = this.value;
-    }
-    undo() {
-        this.judgeLine[this.field] = this.originalValue;
-    }
-}
-
-export class JudgeLineRegroupOperation extends Operation {
-    updatesEditor = true;
-    reflows = JudgeLinesEditorLayoutType.grouped;
-    originalValue: JudgeLineGroup;
-    constructor(public judgeLine: JudgeLine, public value: JudgeLineGroup) {
-        super();
-        this.originalValue = judgeLine.group;
-    }
-    do() {
-        this.judgeLine.group = this.value;
-        this.value.add(this.judgeLine);
-        this.originalValue.remove(this.judgeLine);
-    }
-    undo() {
-        this.judgeLine.group = this.originalValue;
-        this.originalValue.add(this.judgeLine);
-        this.value.remove(this.judgeLine);
-    }
-}
-
-export class JudgeLineCreateOperation extends Operation {
-    reflows = JudgeLinesEditorLayoutType.grouped | JudgeLinesEditorLayoutType.tree | JudgeLinesEditorLayoutType.ordered;
-    // 之前把=写成了:半天不知道咋错了
-    constructor(public chart: Chart, public judgeLine: JudgeLine) {
-        super();
-    }
-    do() {
-        const id = this.chart.judgeLines.length;
-        this.judgeLine.id = id;
-        this.chart.judgeLines.push(this.judgeLine);
-        this.chart.orphanLines.push(this.judgeLine);
-        this.chart.judgeLineGroups[0].add(this.judgeLine);
-    }
-    undo() {
-        this.chart.judgeLineGroups[0].remove(this.judgeLine);
-        this.chart.judgeLines.splice(this.chart.judgeLines.indexOf(this.judgeLine), 1);
-        this.chart.orphanLines.splice(this.chart.orphanLines.indexOf(this.judgeLine), 1);
-    }
-}
-
-export class JudgeLineDeleteOperation extends Operation {
-    readonly originalGroup: JudgeLineGroup;
-    constructor(public chart: Chart, public judgeLine: JudgeLine) {
-        super();
-        if (!this.chart.judgeLines.includes(this.judgeLine)) {
-            this.ineffective = true;
-        }
-        this.originalGroup = judgeLine.group;
-    }
-    do() {
-        this.chart.judgeLines.splice(this.chart.judgeLines.indexOf(this.judgeLine), 1);
-        if (this.chart.orphanLines.includes(this.judgeLine)) {
-            this.chart.orphanLines.splice(this.chart.orphanLines.indexOf(this.judgeLine), 1);
-        }
-        this.originalGroup.remove(this.judgeLine);
-    }
-    undo() {
-        this.chart.judgeLines.push(this.judgeLine);
-        this.chart.orphanLines.push(this.judgeLine);
-        this.originalGroup.add(this.judgeLine);
-    }
-}
-
-
-
-export class JudgeLineENSChangeOperation extends Operation {
-    originalValue: EventNodeSequence;
-    constructor(public judgeLine: JudgeLine, public layerId: number, public typeStr: BasicEventName, public value: EventNodeSequence) {
-        super();
-        this.originalValue = judgeLine.eventLayers[layerId][typeStr];
-    }
-    do() {
-        this.judgeLine.eventLayers[this.layerId][this.typeStr] = this.value;
-    }
-    undo() {
-        this.judgeLine.eventLayers[this.layerId][this.typeStr] = this.originalValue;
-    }
-}
-
-
-export type ENSOfTypeName<T extends ExtendedEventTypeName> = {
-    "scaleX": EventNodeSequence<number>,
-    "scaleY": EventNodeSequence<number>
-    "text": EventNodeSequence<string>,
-    "color": EventNodeSequence<RGB> 
-}[T]
-export class JudgeLineExtendENSChangeOperation<T extends ExtendedEventTypeName> extends Operation {
-    originalValue: ENSOfTypeName<T>;
-    constructor(public judgeLine: JudgeLine, public typeStr: T, public value: ENSOfTypeName<T> | null) {
-        super();
-        this.originalValue = judgeLine.extendedLayer[typeStr satisfies keyof ExtendedLayer] as ENSOfTypeName<T>;
-    }
-    do() {
-        this.judgeLine.extendedLayer[this.typeStr] = this.value
-    }
-    undo() {
-        this.judgeLine.extendedLayer[this.typeStr] = this.originalValue
-    }
-
-}
-
-export class UIAttachOperation extends Operation {
-    updatesEditor = true;
-    constructor(public chart: Chart, public judgeLine: JudgeLine, public ui: UIName) {
-        super();
-    }
-    do() {
-        this.chart.attachUIToLine(this.ui, this.judgeLine);
-    }
-    undo() {
-        this.chart.detachUI(this.ui);
-    }
-}
-
-export class UIDetachOperation extends Operation {
-    updatesEditor = true;
-    judgeLine: JudgeLine;
-    constructor(public chart: Chart, public ui: UIName) {
-        super();
-        if (chart[`${ui}Attach` satisfies keyof Chart]) {
-            this.judgeLine = chart[`${ui}Attach` satisfies keyof Chart];
-        } else {
-            this.ineffective = true;
-        }
-    }
-    do() {
-        this.chart.detachUI(this.ui);
-    }
-    undo() {
-        this.chart.attachUIToLine(this.ui, this.judgeLine);
-    }
-}
-
-export class JudgeLineDetachAllUIOperation extends Operation {
-    updatesEditor = true;
-    uinames: UIName[];
-    constructor(public chart: Chart, public judgeLine: JudgeLine) {
-        super();
-        this.uinames = chart.queryJudgeLineUI(this.judgeLine);
-    }
-    do() {
-        for (const ui of this.uinames) {
-            this.chart.detachUI(ui);
-        }
-    }
-    undo() {
-        for (const ui of this.uinames) {
-            this.chart.attachUIToLine(ui, this.judgeLine);
-        }
-    }
-}