kimaki 1.3.0 → 1.5.0

package/src/thread-reducer.test.ts

@@ -13,7 +13,8 @@ test('text-only turn: banner, text, typing, footer with context percent', () =>
   expect(effects).toMatchInlineSnapshot(`
     [
       {
-        "text": "» **user:** Do these steps with tools, one by one: 1) run \`ls cli/src | head -5\` with bash, 2) write a file tmp-events/hello.txt containing "hello", 3) edit that file to replace hello with "hello world", 4) glob for **/*.txt under tmp-events, 5) read the file. Then reply with one short line.",
+        "echo": true,
+        "text": "-# » **user:** Do these steps with tools, one by one: 1) run \`ls cli/src | head -5\` with bash, 2) write a file tmp-events/hello.txt containing "hello", 3) edit that file to replace hello with "hello world", 4) glob for **/*.txt under tmp-events, 5) read the file. Then reply with one short line.",
         "type": "send",
       },
       {
@@ -26,6 +27,7 @@ test('text-only turn: banner, text, typing, footer with context percent', () =>
       },
       {
         "blankLineBefore": false,
+        "replyTo": null,
         "text": "Done. \`tmp-events/hello.txt\` contains \`hello world\`.",
         "type": "markdown",
       },
@@ -35,6 +37,7 @@ test('text-only turn: banner, text, typing, footer with context percent', () =>
       },
       {
         "agent": "build",
+        "channelId": "channel",
         "contextPercent": 6,
         "directory": "/project",
         "durationMs": 17597,
@@ -55,32 +58,65 @@ test('text-only turn: banner, text, typing, footer with context percent', () =>
   expect(view.turn).toBe(null)
 })
 
-test('message mode: send_message shows as markdown, plain text only when the turn sent nothing', () => {
+test('a turn that posts nothing visible ends without a footer', () => {
+  const events = loadFixture('tools.events.jsonl')
+  // Read-only tools are hidden at the default verbosity.
+  const hiddenTools = new Set(events.flatMap((event) => (event.type === 'session.tool.input.started' && ['read', 'glob'].includes(event.data.name) ? [event.data.id] : [])))
+  const quiet = events.filter((event) => {
+    if (event.type.startsWith('session.text.')) return false
+    if (!event.type.startsWith('session.tool.')) return true
+    const data: { readonly [key: string]: JsonValue | undefined } = event.data
+    return typeof data['id'] === 'string' && hiddenTools.has(data['id'])
+  })
+  const footers = (input: ThreadEvent[]) => replay({ events: input }).effects.filter((effect) => effect.type === 'footer').length
+  expect(hiddenTools.size).toBe(2)
+  expect({ quiet: footers(quiet), normal: footers(events) }).toMatchInlineSnapshot(`
+    {
+      "normal": 1,
+      "quiet": 0,
+    }
+  `)
+})
+
+test('any turn that answers IDLE posts no text and no footer', () => {
   const turn = loadFixture('tools.events.jsonl').filter((event) => !event.type.startsWith('session.tool.'))
-  const prefs = { ...DEFAULT_PREFS, messageTool: true }
-  const textIndex = turn.findIndex((event) => event.type === 'session.text.ended')
-  const text = turn[textIndex]!
-  if (text.type !== 'session.text.ended') throw new Error('Expected text')
-  const call = { sessionID: text.data.sessionID, assistantMessageID: text.data.assistantMessageID, id: 'call_message' }
-  const durable = { aggregateID: text.data.sessionID, seq: 1, version: 1 as const }
-  const message: V2Event[] = [
-    { id: 'evt_message_input', created: text.created, durable, type: 'session.tool.input.started', data: { ...call, name: 'send_message' } },
-    { id: 'evt_message_called', created: text.created, durable, type: 'session.tool.called', data: { ...call, executed: false, input: { text: 'Visible **reply**' } } },
-  ]
-  const sent = replay({ prefs, events: [...turn.slice(0, textIndex), ...message, ...turn.slice(textIndex)] })
-  const silent = replay({ prefs, events: turn })
-  const lines = (effects: typeof sent.effects) => effectLines(effects).filter((line) => !line.startsWith('»') && !line.startsWith('[typing'))
-  expect({ sent: lines(sent.effects), silent: lines(silent.effects) }).toMatchInlineSnapshot(`
+  const idle = turn.map((event) => (event.type === 'session.text.ended' ? { ...event, data: { ...event.data, text: 'IDLE' } } : event))
+  const visible = replay({ events: idle }).effects.filter((effect) => effect.type === 'markdown' || effect.type === 'footer')
+  expect(visible).toEqual([])
+})
+
+test('a coordinator turn with tool lines but no text (or only IDLE) posts no footer; a thread turn does', () => {
+  const events = loadFixture('tools.events.jsonl')
+  const idle = events.map((event) => (event.type === 'session.text.ended' ? { ...event, data: { ...event.data, text: 'IDLE' } } : event))
+  const silent = events.filter((event) => !event.type.startsWith('session.text.'))
+  const sessionId = rootSessionId(events.filter((event): event is V2Event => !event.type.startsWith('kimaki.')))
+  const shown = (input: ThreadEvent[], coordinator: boolean) =>
+    replay({ events: input, view: emptyView({ sessionId, channelId: 'channel', directory: '/project', isNew: true, coordinator }) }).effects.flatMap((effect) =>
+      effect.type === 'footer' ? ['footer'] : effect.type === 'send' && effect.text.includes('┣') ? ['tool'] : [],
+    )
+  expect({ coordinatorIdle: shown(idle, true), coordinatorNoText: shown(silent, true), threadIdle: shown(idle, false) }).toMatchInlineSnapshot(`
     {
-      "sent": [
-        "-# *using openai/gpt-6-luna low ⋅ build*",
-        "Visible **reply**",
-        "-# *project ⋅ main ⋅ 17s ⋅ 6% ⋅ gpt-6-luna*",
+      "coordinatorIdle": [
+        "tool",
+        "tool",
+        "tool",
+        "tool",
+        "tool",
       ],
-      "silent": [
-        "-# *using openai/gpt-6-luna low ⋅ build*",
-        "Done. \`tmp-events/hello.txt\` contains \`hello world\`.",
-        "-# *project ⋅ main ⋅ 17s ⋅ 6% ⋅ gpt-6-luna*",
+      "coordinatorNoText": [
+        "tool",
+        "tool",
+        "tool",
+        "tool",
+        "tool",
+      ],
+      "threadIdle": [
+        "tool",
+        "tool",
+        "tool",
+        "tool",
+        "tool",
+        "footer",
       ],
     }
   `)
@@ -100,11 +136,27 @@ test('kimaki sleep in a turn makes its footer silent, the next turn notifies aga
   `)
 })
 
+test('root model and agent switches after the banner show as subtext lines', () => {
+  const events = loadFixture('switch-model.events.jsonl')
+  const switches = events.filter((event) => event.type === 'session.model.selected' || event.type === 'session.agent.selected')
+  // Before the first step the banner shows the model and agent; a re-select of the same model shows nothing.
+  const sameModel = switches.flatMap((event) => (event.type === 'session.model.selected' ? [{ ...event, data: { ...event.data, previous: event.data.model } }] : []))
+  const created = events.findIndex((event) => event.type === 'session.created')
+  const lines = effectLines(replay({ events: [...events.slice(0, created + 1), ...switches, ...events.slice(created + 1), ...sameModel] }).effects)
+  expect(lines.filter((line) => /Switched|using/.test(line))).toMatchInlineSnapshot(`
+    [
+      "-# *using openai/gpt-6-luna low ⋅ build*",
+      "-# Switched model to GPT 6 Luna (medium)",
+      "-# Switched agent to Plan",
+    ]
+  `)
+})
+
 test('execution failure shows the error and no footer, interrupt shows nothing', () => {
   const events = loadFixture('abort.events.jsonl')
   const sessionID = rootSessionId(events)
   const started = events.find((event) => event.type === 'session.execution.started')!
-  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false })
+  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false, coordinator: false })
   const busy = reduce({ view, event: started, prefs: DEFAULT_PREFS }).view
   const failed = reduce({
     view: busy,
@@ -138,7 +190,8 @@ test('execution failure shows the error and no footer, interrupt shows nothing',
   expect(replay({ events, view }).effects).toMatchInlineSnapshot(`
     [
       {
-        "text": "» **user:** Run \`sleep 30 && echo never\` with bash, then summarize.",
+        "echo": true,
+        "text": "-# » **user:** Run \`sleep 30 && echo never\` with bash, then summarize.",
         "type": "send",
       },
       {
@@ -159,7 +212,8 @@ test('execution failure shows the error and no footer, interrupt shows nothing',
         "type": "viewed",
       },
       {
-        "text": "» **user:** Say only: resumed after abort.",
+        "echo": true,
+        "text": "-# » **user:** Say only: resumed after abort.",
         "type": "send",
       },
       {
@@ -168,6 +222,7 @@ test('execution failure shows the error and no footer, interrupt shows nothing',
       },
       {
         "blankLineBefore": false,
+        "replyTo": null,
         "text": "resumed after abort",
         "type": "markdown",
       },
@@ -177,6 +232,7 @@ test('execution failure shows the error and no footer, interrupt shows nothing',
       },
       {
         "agent": "build",
+        "channelId": "channel",
         "contextPercent": 6,
         "directory": "/project",
         "durationMs": 1387,
@@ -211,7 +267,7 @@ test('only these event types produce effects for the root session', () => {
   for (const file of files) {
     const events = loadFixture(file)
     const sessionId = rootSessionId(events)
-    let view = emptyView({ sessionId, channelId: 'channel', directory: '/project', isNew: true })
+    let view = emptyView({ sessionId, channelId: 'channel', directory: '/project', isNew: true, coordinator: false })
     for (const event of events) {
       const result = reduce({ view, event, prefs: DEFAULT_PREFS })
       view = result.view
@@ -220,11 +276,13 @@ test('only these event types produce effects for the root session', () => {
   }
   expect([...producing].sort()).toMatchInlineSnapshot(`
     [
+      "session.agent.selected",
       "session.execution.interrupted",
       "session.execution.started",
       "session.execution.succeeded",
       "session.inbox.delivered",
       "session.inbox.enqueued",
+      "session.model.selected",
       "session.shell.ended",
       "session.shell.started",
       "session.step.started",
@@ -244,14 +302,12 @@ test('only these event types produce effects for the root session', () => {
       "provider.updated",
       "reference.updated",
       "server.connected",
-      "session.agent.selected",
       "session.compaction.delta",
       "session.compaction.ended",
       "session.compaction.started",
       "session.created",
       "session.forked",
       "session.instructions.updated",
-      "session.model.selected",
       "session.renamed",
       "session.step.ended",
       "session.step.failed",
@@ -277,7 +333,7 @@ test('only these event types produce effects for the root session', () => {
 test('retry notices are throttled to one per 10s', () => {
   const events = loadFixture('abort.events.jsonl')
   const sessionID = rootSessionId(events)
-  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false })
+  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false, coordinator: false })
   const retry = (created: number, attempt: number): V2Event => ({
     id: `evt_retry_${attempt}`,
     created,
@@ -294,8 +350,8 @@ test('retry notices are throttled to one per 10s', () => {
   const { effects } = replay({ events: [retry(1_000, 1), retry(6_000, 2), retry(12_000, 3)], view })
   expect(effectLines(effects)).toMatchInlineSnapshot(`
     [
-      "-# ⬦ retrying in 5s (attempt 1): rate limited",
-      "-# ⬦ retrying in 5s (attempt 3): rate limited",
+      "-# retrying in 5s (attempt 1): rate limited",
+      "-# retrying in 5s (attempt 3): rate limited",
     ]
   `)
 })
@@ -308,40 +364,133 @@ test('cache miss notice when the cached prefix shrinks, e.g. after the cache TTL
   const last = events[lastIndex]
   if (last?.type !== 'session.step.ended') return expect.fail('fixture has no root step.ended')
   // Same turn, but the last request found nothing in cache 10 minutes later.
-  const missed = events.map((event, index) =>
-    index === lastIndex ? { ...last, created: last.created + 600_000, data: { ...last.data, tokens: { ...last.data.tokens, cache: { read: 0, write: 0 } } } } : event,
-  )
-  expect(effectLines(replay({ events: missed }).effects).filter((line) => line.includes('cache'))).toMatchInlineSnapshot(`
+  const withCache = (cache: { read: number; write: number }, input = last.data.tokens.input) =>
+    events.map((event, index) =>
+      index === lastIndex ? { ...last, created: last.created + 600_000, data: { ...last.data, tokens: { ...last.data.tokens, input, cache } } } : event,
+    )
+  const cacheLines = (stream: V2Event[]) => effectLines(replay({ events: stream }).effects).filter((line) => line.includes('cache'))
+  // Everything was written again: a full loss.
+  expect(cacheLines(withCache({ read: 0, write: 25_000 }, 0))).toMatchInlineSnapshot(`
     [
-      "\\n-# ⬦ prompt cache miss: 0 of 25k tokens cached, 10m 1s after the last request",
+      "\\n-# prompt cache miss: 0 of 25k tokens cached, 10m 1s after the last request",
     ]
   `)
+  // Less than half of the prompt was written: a partial miss shows nothing.
+  expect(cacheLines(withCache({ read: 0, write: 5_000 }, 20_000))).toEqual([])
   expect(effectLines(replay({ events }).effects).filter((line) => line.includes('cache'))).toEqual([])
 })
 
+test('compaction posts the new context size from the next root step', () => {
+  const events = loadFixture('tools.events.jsonl')
+  const sessionID = rootSessionId(events)
+  const lastIndex = events.findLastIndex((event) => event.type === 'session.step.ended' && event.data.sessionID === sessionID)
+  const compacted: V2Event = {
+    id: 'evt_compacted',
+    created: 0,
+    type: 'session.compaction.ended',
+    durable: { aggregateID: sessionID, seq: 0, version: 1 },
+    data: { sessionID, reason: 'auto', text: '## Objective', recent: '' },
+  }
+  const withCompaction = [...events.slice(0, lastIndex), compacted, ...events.slice(lastIndex)]
+  expect(effectLines(replay({ events: withCompaction }).effects).filter((line) => line.includes('compacted'))).toMatchInlineSnapshot(`
+    [
+      "\\n-# context compacted to 26k tokens (6%)",
+    ]
+  `)
+  // `/compact` alone: the execution ends with no step after it.
+  const end = events.findLastIndex((event) => event.type === 'session.execution.succeeded')
+  const manual = [...events.slice(0, end), compacted, ...events.slice(end)]
+  expect(effectLines(replay({ events: manual }).effects).filter((line) => line.includes('compacted'))).toMatchInlineSnapshot(`
+    [
+      "\\n-# context compacted",
+    ]
+  `)
+})
+
 test('prompts from other clients echo, except the expanded prompt of a command Kimaki ran', () => {
   const events = loadFixture('queue-plain.events.jsonl')
-  const echoes = (before: ThreadEvent[]) => effectLines(replay({ events: [...before, ...events] }).effects).filter((line) => line.startsWith('»'))
-  const command = { type: 'kimaki.command' as const, text: '/review auth', username: 'tommy' }
+  // Queued ones show in their ack (`[show queue:...]`), a reply to it marks the run.
+  const echoes = (before: ThreadEvent[]) =>
+    effectLines(replay({ events: [...before, ...events] }).effects).filter((line) => line.includes('» ') || line.startsWith('[reply to'))
+  const command = { type: 'kimaki.command' as const, text: '/review auth', username: 'tommy', messageId: null, echo: null }
   expect(echoes([])).toMatchInlineSnapshot(`
     [
-      "» **user:** Run \`sleep 6 && echo slow-done\` with bash, then say done.",
-      "» **user:** QUEUED-1: reply with the word apple.",
-      "» **user:** QUEUED-2: reply with the word cherry.",
+      "-# » **user:** Run \`sleep 6 && echo slow-done\` with bash, then say done.",
+      "[show queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# » **user:** QUEUED-1: reply with the word apple.
+    -# Queued at position 1. Remove it with /clear-queue position:1",
+      "[show queue:msg_0f20347e500196F4o0voD7LGMV] -# » **user:** QUEUED-2: reply with the word cherry.
+    -# Queued at position 2. Remove it with /clear-queue position:2",
+      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# » **user:** QUEUED-1: reply with the word apple.",
+      "[reply to queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued message sent",
+      "[edit queue:msg_0f20347e500196F4o0voD7LGMV] -# » **user:** QUEUED-2: reply with the word cherry.",
+      "[reply to queue:msg_0f20347e500196F4o0voD7LGMV] -# Queued message sent",
     ]
   `)
-  // The first prompt is the command's template: hidden. The queued ones still echo.
+  // The first prompt is the command's template: hidden. The queued ones still show.
   expect(echoes([command])).toMatchInlineSnapshot(`
     [
-      "» **user:** QUEUED-1: reply with the word apple.",
-      "» **user:** QUEUED-2: reply with the word cherry.",
+      "[show queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# » **user:** QUEUED-1: reply with the word apple.
+    -# Queued at position 1. Remove it with /clear-queue position:1",
+      "[show queue:msg_0f20347e500196F4o0voD7LGMV] -# » **user:** QUEUED-2: reply with the word cherry.
+    -# Queued at position 2. Remove it with /clear-queue position:2",
+      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# » **user:** QUEUED-1: reply with the word apple.",
+      "[reply to queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued message sent",
+      "[edit queue:msg_0f20347e500196F4o0voD7LGMV] -# » **user:** QUEUED-2: reply with the word cherry.",
+      "[reply to queue:msg_0f20347e500196F4o0voD7LGMV] -# Queued message sent",
     ]
   `)
+  // A command sent with `kimaki send` has no Discord message: its echo stands in for the template.
+  expect(echoes([{ ...command, echo: '-# » **CLI:** /review auth' }])[0]).toMatchInlineSnapshot(`"-# » **CLI:** /review auth"`)
   // A failed command leaves nothing pending.
   expect(echoes([command, { type: 'kimaki.command-failed' }])).toEqual(echoes([]))
 })
 
-test('snapshot closes the ack of an item promoted while disconnected, without an echo', () => {
+test('coordinator: a prompt reply goes to its Discord message, a queued one gets "Queued message sent" even when it answers IDLE', () => {
+  // The fixture's prompts get Discord metadata, like prompt.ts writes it: messages 101, 102, 103.
+  const withDiscord = (threadId: string) => {
+    let next = 101
+    return loadFixture('queue-plain.events.jsonl').map((event): V2Event => {
+      if (event.type !== 'session.inbox.enqueued' || event.data.item.type !== 'user') return event
+      const discord = { messageId: String(next++), threadId, username: 'tommy' }
+      const item = { ...event.data.item, payload: { ...event.data.item.payload, metadata: { discord } } }
+      return { ...event, data: { ...event.data, item } }
+    })
+  }
+  // replay() binds the view to channel `channel`: a prompt whose conversation is that channel is a coordinator prompt.
+  expect(effectLines(replay({ events: withDiscord('channel') }).effects)).toMatchInlineSnapshot(`
+    [
+      "[typing on]",
+      "-# *using openai/gpt-6-luna low ⋅ build*",
+      "-# ┣ shell _sleep 6 && echo slow-done_",
+      "[show queue:msg_0f20347e1001nsJ7W4hOvhBpQb reply to 102] -# Queued at position 1. Delete the original message to remove it, or use /clear-queue position:1",
+      "[show queue:msg_0f20347e500196F4o0voD7LGMV reply to 103] -# Queued at position 2. Delete the original message to remove it, or use /clear-queue position:2",
+      "[reply to 101] Done.",
+      "[silent] -# *main ⋅ 10s ⋅ 6% ⋅ gpt-6-luna*",
+      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued",
+      "[reply to 102] -# Queued message sent",
+      "apple",
+      "[silent] -# *main ⋅ 2s ⋅ 6% ⋅ gpt-6-luna*",
+      "[edit queue:msg_0f20347e500196F4o0voD7LGMV] -# Queued",
+      "[reply to 103] -# Queued message sent",
+      "cherry",
+      "[typing off]",
+      "-# *main ⋅ 2s ⋅ 6% ⋅ gpt-6-luna*",
+    ]
+  `)
+  // A coordinator that starts a worker answers IDLE: the queued prompt still shows that it started.
+  const idle = withDiscord('channel').map((event) => (event.type === 'session.text.ended' && event.data.text.trim() === 'apple' ? { ...event, data: { ...event.data, text: 'IDLE' } } : event))
+  expect(effectLines(replay({ events: idle }).effects).filter((line) => line.includes('queue:msg_0f20347e1001') || line.startsWith('[reply to 102]'))).toMatchInlineSnapshot(`
+    [
+      "[show queue:msg_0f20347e1001nsJ7W4hOvhBpQb reply to 102] -# Queued at position 1. Delete the original message to remove it, or use /clear-queue position:1",
+      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued",
+      "[reply to 102] -# Queued message sent",
+    ]
+  `)
+  const thread = replay({ events: withDiscord('thread') }).effects
+  expect(thread.filter((effect) => effect.type === 'markdown').map((effect) => effect.replyTo)).toEqual([null, null, null])
+})
+
+test('snapshot marks an item promoted while disconnected as started, without an echo', () => {
   const events = loadFixture('queue-plain.events.jsonl')
   const index = events.findIndex((event) => event.type === 'session.inbox.enqueued' && event.data.item.delivery === 'queue')
   const enqueued = events[index]
@@ -363,7 +512,8 @@ test('snapshot closes the ack of an item promoted while disconnected, without an
   const hydrated = reduce({ view, event: snapshot, prefs: DEFAULT_PREFS })
   expect(effectLines(hydrated.effects)).toMatchInlineSnapshot(`
     [
-      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued message sent",
+      "[edit queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# » **user:** QUEUED-1: reply with the word apple.",
+      "[reply to queue:msg_0f20347e1001nsJ7W4hOvhBpQb] -# Queued message sent",
     ]
   `)
   expect(hydrated.effects.map((effect) => effect.type)).toEqual(['edit'])
@@ -374,7 +524,7 @@ test('snapshot closes the ack of an item promoted while disconnected, without an
 test('execute: final metadata shows inner calls whose progress was missed, then failures', () => {
   const events = loadFixture('abort.events.jsonl')
   const sessionID = rootSessionId(events)
-  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false })
+  const view = emptyView({ sessionId: sessionID, channelId: 'channel', directory: '/project', isNew: false, coordinator: false })
   const base = { created: 1_000 }
   const durable = <V extends number>(version: V) => ({ aggregateID: sessionID, seq: 1, version })
   const call = { sessionID, assistantMessageID: 'msg_a', id: 'call_1' }