killeros 2.0.17 → 2.0.19

package/killeros/personal-instructions.ts

@@ -34,20 +34,21 @@ function readBoundedText(filePath: string, limit = PERSONAL_INSTRUCTIONS_LIMIT):
   }
 }
 
-export function resolvePersonalInstructions(cwd: string): { content: string; source: string } | undefined {
+export function resolvePersonalInstructions(cwd: string): string | undefined {
   const localPath = path.join(cwd, PERSONAL_INSTRUCTIONS_FILE);
   const local = readBoundedText(localPath);
   if (!local) return undefined;
 
   const importMatch = local.trim().match(/^@(.+)$/u);
-  if (!importMatch) return { content: local, source: localPath };
-
-  const requestedPath = importMatch[1]!.trim();
-  const importedPath = requestedPath.startsWith("~/") || requestedPath.startsWith("~\\")
-    ? path.join(os.homedir(), requestedPath.slice(2))
-    : path.resolve(cwd, requestedPath);
-  const imported = readBoundedText(importedPath);
-  return imported ? { content: imported, source: importedPath } : { content: local, source: localPath };
+  let content = local;
+  if (importMatch) {
+    const requestedPath = (importMatch[1] ?? "").trim();
+    const importedPath = requestedPath.startsWith("~/") || requestedPath.startsWith("~\\")
+      ? path.join(os.homedir(), requestedPath.slice(2))
+      : path.resolve(cwd, requestedPath);
+    content = readBoundedText(importedPath) ?? local;
+  }
+  return `<personal_instructions>\n${content}\n</personal_instructions>`;
 }
 
 export function registerPersonalInstructions(pi: ExtensionAPI, initState: InitRuntime): void {
@@ -59,9 +60,7 @@ export function registerPersonalInstructions(pi: ExtensionAPI, initState: InitRu
       systemPrompt: [
         event.systemPrompt,
         "",
-        `<personal_instructions source="${personal.source}">`,
-        personal.content,
-        "</personal_instructions>",
+        personal,
       ].join("\n"),
     };
   });

package/killeros/question.ts

@@ -165,7 +165,9 @@ function boundedQuestionLines(question: string, width: number, rowLimit: number)
   const wrapped = wrapTextWithAnsi(question.replace(/\s+/gu, " ").trim(), width);
   if (wrapped.length <= rowLimit) return wrapped;
   const visible = wrapped.slice(0, rowLimit);
-  visible[rowLimit - 1] = truncateToWidth(visible[rowLimit - 1]!, width, "…");
+  const finalIndex = rowLimit - 1;
+  const finalLine = visible[finalIndex];
+  if (finalLine !== undefined) visible[finalIndex] = truncateToWidth(finalLine, width, "…");
   return visible;
 }
 
@@ -173,12 +175,12 @@ function compactMultipleAnswers(answers: readonly string[], width: number): stri
   const prefix = "✓ ";
   if (answers.length === 0) return truncateToWidth(prefix + "No answers", width, "…");
   const visible: string[] = [];
-  for (let index = 0; index < answers.length; index += 1) {
+  for (const [index, answer] of answers.entries()) {
     const remaining = answers.length - index - 1;
-    const candidate = [...visible, oneLine(answers[index]!)].join(", ");
+    const candidate = [...visible, oneLine(answer)].join(", ");
     const suffix = remaining > 0 ? `, +${remaining} more` : "";
     if (visibleWidth(prefix + candidate + suffix) > width) break;
-    visible.push(oneLine(answers[index]!));
+    visible.push(oneLine(answer));
   }
   if (visible.length === answers.length) return prefix + visible.join(", ");
   const hidden = answers.length - visible.length;
@@ -228,7 +230,8 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
     if (bytes > CUSTOM_INPUT_HISTORY_BYTES) return false;
     const existingIndex = customInputHistory.indexOf(value);
     if (existingIndex >= 0) {
-      customInputHistoryBytes -= Buffer.byteLength(customInputHistory[existingIndex]!, "utf8");
+      const existing = customInputHistory[existingIndex];
+      if (existing !== undefined) customInputHistoryBytes -= Buffer.byteLength(existing, "utf8");
       customInputHistory.splice(existingIndex, 1);
     }
     while (customInputHistory.length >= CUSTOM_INPUT_HISTORY_LIMIT || customInputHistoryBytes + bytes > CUSTOM_INPUT_HISTORY_BYTES) {
@@ -329,7 +332,11 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
         const selectedCount = (): number => selectedOriginalIndices.size + (customAnswer === undefined ? 0 : 1);
         const orderedMultipleSelection = () => {
           const selectedIndices = [...selectedOriginalIndices].sort((left, right) => left - right);
-          const predefined = selectedIndices.map((index) => params.options[index - 1]!.label);
+          const predefined = selectedIndices.map((index) => {
+            const option = params.options[index - 1];
+            if (!option) throw new Error("Question selection no longer matches an available option");
+            return option.label;
+          });
           return {
             answers: customAnswer === undefined ? predefined : [...predefined, customAnswer],
             selectedIndices,
@@ -640,7 +647,8 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
               lines.push(...(draftLines.length > 0 ? draftLines : [editMode === "filter" ? "Type a filter" : "Type an answer"]).slice(-contentRows));
             } else {
               for (let index = start; index < end; index += 1) {
-                const option = visibleOptions[index]!;
+                const option = visibleOptions[index];
+                if (!option) continue;
                 const color: ThemeColor = index === optionIndex ? "accent" : "text";
                 lines.push(theme.fg(color, truncateToWidth(optionLabel(option, index), width, "…")));
               }

package/killeros/runtime.ts

@@ -38,31 +38,63 @@ export interface GoalFileVerification {
   baseline: GoalFileBaseline;
 }
 
-export interface GoalState {
+export interface GoalStateCommon {
   version: 1;
   revision: number;
   objective: string;
-  status: GoalStatus;
   createdAt: number;
   updatedAt: number;
   activeMilliseconds: number;
-  activeStartedAt?: number;
   turns: number;
   blockedAuditStartTurn: number;
   baselineTokens: number;
-  result?: string;
-  resumeAfterManualCompaction?: true;
-  blockerAudit?: GoalBlockerAudit;
   verification?: GoalFileVerification;
 }
 
+export type GoalState = GoalStateCommon & (
+  | {
+      status: "active";
+      activeStartedAt: number;
+      result?: string;
+      blockerAudit?: GoalBlockerAudit;
+      resumeAfterManualCompaction?: never;
+    }
+  | {
+      status: "paused";
+      activeStartedAt?: never;
+      result?: string;
+      blockerAudit?: GoalBlockerAudit;
+      resumeAfterManualCompaction?: true;
+    }
+  | {
+      status: "blocked";
+      activeStartedAt?: never;
+      result: string;
+      blockerAudit?: GoalBlockerAudit;
+      resumeAfterManualCompaction?: never;
+    }
+  | {
+      status: "complete";
+      activeStartedAt?: never;
+      result: string;
+      blockerAudit?: never;
+      resumeAfterManualCompaction?: never;
+    }
+);
+
+export interface AutomaticGoalCompaction {
+  pausedRevision: number;
+  compactionSucceeded: boolean;
+  turnSettled: boolean;
+}
+
 export interface GoalRuntime {
   state?: GoalState;
   continuationScheduled: boolean;
   continuationHeld: boolean;
   goalTurnInFlight: boolean;
   agentEndObserved: boolean;
-  automaticCompaction?: "pending";
+  automaticCompaction?: AutomaticGoalCompaction;
   persistenceRetryNeeded: boolean;
   lastStopReason?: string;
   lastError?: string;

package/killeros/settings.ts

@@ -2,6 +2,7 @@ import { randomUUID } from "node:crypto";
 import { mkdirSync, readFileSync, renameSync, rmSync, writeFileSync } from "node:fs";
 import { dirname, join } from "node:path";
 import { getAgentDir } from "@earendil-works/pi-coding-agent";
+import { hasErrorCode } from "./errors.ts";
 
 export type KillerosSettings = Record<string, unknown>;
 
@@ -10,15 +11,17 @@ export interface KillerosSettingsStore {
   update(patch: Readonly<Record<string, unknown>>): void;
 }
 
+function isSettings(value: unknown): value is KillerosSettings {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+
 function readStoredSettings(settingsPath: string): KillerosSettings {
   try {
     const parsed: unknown = JSON.parse(readFileSync(settingsPath, "utf8"));
-    if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) {
-      throw new Error("KillerOS settings must contain a JSON object");
-    }
-    return parsed as KillerosSettings;
+    if (!isSettings(parsed)) throw new Error("KillerOS settings must contain a JSON object");
+    return parsed;
   } catch (error) {
-    if ((error as NodeJS.ErrnoException).code === "ENOENT") return {};
+    if (hasErrorCode(error, "ENOENT")) return {};
     throw error;
   }
 }

package/killeros/shell-ui.ts

@@ -25,14 +25,19 @@ import {
 } from "./commands.ts";
 import { reportError } from "./errors.ts";
 import { formatModel } from "./footer.ts";
-import { LEVEL_COLORS, type ThinkingLevel } from "./variants.ts";
+import { LEVEL_COLORS } from "./variants.ts";
 
 const COMPACT_HEADER_MAX_WIDTH = 52;
 
 function readPackageVersion(path: string | URL): string | undefined {
   try {
-    const value = JSON.parse(readFileSync(path, "utf8")) as { version?: unknown };
-    return typeof value.version === "string" ? value.version : undefined;
+    const value: unknown = JSON.parse(readFileSync(path, "utf8"));
+    return typeof value === "object"
+      && value !== null
+      && "version" in value
+      && typeof value.version === "string"
+      ? value.version
+      : undefined;
   } catch {
     return undefined;
   }
@@ -93,7 +98,11 @@ function shuffledDeck(values: readonly string[]): string[] {
   const deck = [...values];
   for (let index = deck.length - 1; index > 0; index -= 1) {
     const swapIndex = Math.floor(Math.random() * (index + 1));
-    [deck[index], deck[swapIndex]] = [deck[swapIndex]!, deck[index]!];
+    const current = deck[index];
+    const swap = deck[swapIndex];
+    if (current === undefined || swap === undefined) continue;
+    deck[index] = swap;
+    deck[swapIndex] = current;
   }
   return deck;
 }
@@ -152,7 +161,7 @@ class PiStartupHeader {
     const innerWidth = panelWidth - 4;
     const version = KILLEROS_VERSION ? theme.fg("dim", ` (v${KILLEROS_VERSION})`) : "";
     const identity = `${theme.fg("dim", "›")} ${theme.fg("text", theme.bold("KillerOS"))}${version}`;
-    const thinkingLevel = this.pi.getThinkingLevel() as ThinkingLevel;
+    const thinkingLevel = this.pi.getThinkingLevel();
     const reasoning = this.ctx.model?.reasoning === false
       ? theme.fg("thinkingOff", "no reasoning")
       : theme.fg(LEVEL_COLORS[thinkingLevel], thinkingLevel);

package/killeros/variants.ts

@@ -1,5 +1,6 @@
 import { DynamicBorder, type ExtensionAPI, type ExtensionContext, type ThemeColor } from "@earendil-works/pi-coding-agent";
 import { SelectList, truncateToWidth } from "@earendil-works/pi-tui";
+import { safeTerminalText } from "./safe-terminal-text.ts";
 
 export type ThinkingLevel = ReturnType<ExtensionAPI["getThinkingLevel"]>;
 
@@ -60,7 +61,7 @@ function supportedLevels(model: ExtensionContext["model"]): ThinkingLevel[] {
 }
 
 function modelLabel(model: ExtensionContext["model"]): string {
-  return model ? `${model.provider}/${model.id}` : "unknown model";
+  return model ? safeTerminalText(`${model.provider}/${model.id}`).replaceAll("\n", "") : "unknown model";
 }
 
 export function registerVariants(pi: ExtensionAPI): void {
@@ -80,7 +81,7 @@ export function registerVariants(pi: ExtensionAPI): void {
       if (args.trim()) {
         const level = resolveThinkingLevel(args);
         if (!level) {
-          ctx.ui.notify(`Unknown reasoning level "${args.trim()}". Use: ${ALL_LEVELS.join(", ")}`, "error");
+          ctx.ui.notify(`Unknown reasoning level "${safeTerminalText(args.trim()).replaceAll("\n", "")}". Use: ${ALL_LEVELS.join(", ")}`, "error");
           return;
         }
         setLevel(ctx, level);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "killeros",
-  "version": "2.0.17",
+  "version": "2.0.19",
   "description": "TUI, goals, and workflow automation for the Pi coding agent",
   "type": "module",
   "keywords": [
@@ -42,15 +42,15 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-ai": ">=0.84.2",
-    "@earendil-works/pi-coding-agent": ">=0.84.2",
-    "@earendil-works/pi-tui": ">=0.84.2",
+    "@earendil-works/pi-ai": ">=0.84.3",
+    "@earendil-works/pi-coding-agent": ">=0.84.3",
+    "@earendil-works/pi-tui": ">=0.84.3",
     "typebox": ">=1.1.38 <2"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "0.84.2",
-    "@earendil-works/pi-coding-agent": "0.84.2",
-    "@earendil-works/pi-tui": "0.84.2",
+    "@earendil-works/pi-ai": "0.84.3",
+    "@earendil-works/pi-coding-agent": "0.84.3",
+    "@earendil-works/pi-tui": "0.84.3",
     "@types/node": "24.12.4",
     "typebox": "1.1.38",
     "typescript": "5.9.3"