killeros 2.0.13 → 2.0.14

package/CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to KillerOS are documented here.
 
 ## [Unreleased]
 
+## [2.0.14] - 2026-08-22
+
+### Fixed
+
+- Prevented direct tag pushes from publishing commits that have not passed CI on `main`.
+- Kept oversized hook payloads valid JSON and marked their bounded preview as truncated.
+- Stripped terminal escape sequences and unsafe controls from model-controlled question and goal text.
+- Aligned hook timeout validation and execution on the documented five-minute maximum.
+- Required file-backed goals to create or change their deliverable after the goal starts, including after session restore.
+- Removed a CI test dependency on an intentionally untracked internal document.
+
 ## [2.0.13] - 2026-08-21
 
 ### Added

package/README.md

@@ -24,10 +24,10 @@ Install from GitHub:
 pi install git:github.com/KyrosHendrix/pi-KillerOS
 ```
 
-Pin an install to version `v2.0.13`:
+Pin an install to version `v2.0.14`:
 
 ```bash
-pi install git:github.com/KyrosHendrix/pi-KillerOS@v2.0.13
+pi install git:github.com/KyrosHendrix/pi-KillerOS@v2.0.14
 ```
 
 Add `-l` to either command to install only for the current project. Restart Pi after installing.
@@ -175,7 +175,7 @@ For a normal release:
 
 After the full CI workflow passes on `main`, the release workflow validates the commit and changelog, publishes the package to npm through trusted publishing, and creates the matching tag and GitHub release. The [`pi-package` keyword](https://github.com/earendil-works/pi/blob/main/packages/coding-agent/docs/packages.md) makes the npm package visible in Pi's package catalog.
 
-Do not create a tag for the normal path. If a release is missing, use the manual tag recovery path and push the matching version tag. The recovery path checks the tag against the package and changelog, skips npm publication when that version already exists, and creates only the missing GitHub release.
+Do not push version tags manually. Tag pushes cannot publish; every published commit must pass the full `main` CI workflow.
 
 ## Security
 

package/killeros/goals.ts

@@ -9,7 +9,8 @@ import { BoundedText } from "./bounded-text.ts";
 import { formatTime, formatTokens } from "./display.ts";
 import { reportError } from "./errors.ts";
 import { resolvePersonalInstructions } from "./personal-instructions.ts";
-import type { GoalBlockerAudit, GoalFileVerification, GoalRuntime, GoalState, GoalStatus, InitRuntime } from "./runtime.ts";
+import type { GoalBlockerAudit, GoalFileBaseline, GoalFileVerification, GoalRuntime, GoalState, GoalStatus, InitRuntime } from "./runtime.ts";
+import { safeTerminalText } from "./safe-terminal-text.ts";
 
 const GOAL_ENTRY_TYPE = "killeros-goal";
 const GOAL_CONTINUATION_TYPE = "killeros-goal-continuation";
@@ -67,13 +68,21 @@ function finiteNonNegative(value: unknown): value is number {
   return typeof value === "number" && Number.isFinite(value) && value >= 0;
 }
 
+function isGoalFileBaseline(value: unknown): value is GoalFileBaseline {
+  if (!value || typeof value !== "object") return false;
+  const candidate = value as { exists?: unknown; size?: unknown; mtimeMs?: unknown };
+  if (candidate.exists === false) return candidate.size === undefined && candidate.mtimeMs === undefined;
+  return candidate.exists === true && finiteNonNegative(candidate.size) && finiteNonNegative(candidate.mtimeMs);
+}
+
 function isGoalFileVerification(value: unknown): value is GoalFileVerification {
   if (!value || typeof value !== "object") return false;
   const candidate = value as Partial<GoalFileVerification>;
   return candidate.kind === "file"
     && typeof candidate.path === "string"
     && candidate.path === candidate.path.trim()
-    && isAbsoluteFilePath(candidate.path);
+    && isAbsoluteFilePath(candidate.path)
+    && isGoalFileBaseline(candidate.baseline);
 }
 
 function isAbsoluteFilePath(value: string): boolean {
@@ -81,13 +90,23 @@ function isAbsoluteFilePath(value: string): boolean {
   return path.isAbsolute(value) || path.win32.isAbsolute(value);
 }
 
+function captureGoalFileBaseline(filePath: string): GoalFileBaseline {
+  try {
+    const artifact = lstatSync(filePath);
+    return { exists: true, size: artifact.size, mtimeMs: artifact.mtimeMs };
+  } catch {
+    return { exists: false };
+  }
+}
+
 function inferGoalVerification(objective: string): GoalFileVerification | undefined {
   const destination = /\b(?:create|write|save|generate)\b[^\r\n]{0,160}?\b(?:file|document|markdown|report|spreadsheet|presentation|image)\b\s+(?:to|at|as|destination(?:\s+is)?|output(?:\s+(?:to|at))?)\b\s*(?:`([^`\r\n]+)`|"([^"\r\n]+)"|'([^'\r\n]+)'|([A-Za-z]:\\[^\s,;]+|\/[^\s,;]+))/giu;
   const paths = [...objective.matchAll(destination)]
     .map((match) => (match[1] ?? match[2] ?? match[3] ?? match[4] ?? "").trim())
     .filter(isAbsoluteFilePath);
   const unique = [...new Set(paths)];
-  return unique.length === 1 ? { kind: "file", path: unique[0]! } : undefined;
+  const filePath = unique.length === 1 ? unique[0] : undefined;
+  return filePath ? { kind: "file", path: filePath, baseline: captureGoalFileBaseline(filePath) } : undefined;
 }
 
 function verifyGoalDeliverable(verification: GoalFileVerification): void {
@@ -100,6 +119,11 @@ function verifyGoalDeliverable(verification: GoalFileVerification): void {
   if (!artifact.isFile()) {
     throw new Error(`Goal deliverable is not a regular file at the required path: ${verification.path}`);
   }
+  if (verification.baseline.exists
+    && artifact.size === verification.baseline.size
+    && artifact.mtimeMs === verification.baseline.mtimeMs) {
+    throw new Error(`Goal deliverable has not changed since the goal started: ${verification.path}`);
+  }
 }
 
 function isGoalBlockerAudit(value: unknown, turns: number, status: GoalStatus): value is GoalBlockerAudit {
@@ -555,9 +579,10 @@ export function registerGoal(
     const icon = state.status === "active" ? "✻" : state.status === "paused" ? "Ⅱ" : state.status === "blocked" ? "!" : "✓";
     const color: ThemeColor = state.status === "active" ? "accent" : state.status === "paused" ? "warning" : state.status === "blocked" ? "error" : "success";
     const status = theme.fg(color, `${icon} Goal ${state.status}`);
-    if (!options.expanded) return new BoundedText(`${status}${theme.fg("dim", ` · ${state.objective}`)}`, 3);
-    const lines = [status, theme.fg("dim", state.objective)];
-    if (state.result) lines.push(theme.fg("muted", state.result));
+    const objective = safeTerminalText(state.objective);
+    if (!options.expanded) return new BoundedText(`${status}${theme.fg("dim", ` · ${objective}`)}`, 3);
+    const lines = [status, theme.fg("dim", objective)];
+    if (state.result) lines.push(theme.fg("muted", safeTerminalText(state.result)));
     return new BoundedText(lines.join("\n"));
   });
 
@@ -615,18 +640,18 @@ export function registerGoal(
       };
     },
     renderCall(args, theme) {
-      return new Text(`${theme.fg("toolTitle", theme.bold("goal "))}${theme.fg("muted", args.status)}`, 0, 0);
+      return new Text(`${theme.fg("toolTitle", theme.bold("goal "))}${theme.fg("muted", safeTerminalText(args.status))}`, 0, 0);
     },
     renderResult(result, options, theme, context) {
       if (context?.isError) {
         const first = result.content[0];
-        const message = first?.type === "text" ? first.text : "Goal update failed";
+        const message = first?.type === "text" ? safeTerminalText(first.text) : "Goal update failed";
         return new BoundedText(theme.fg("error", message), options.expanded ? undefined : 3);
       }
       const details = result.details;
       if (!details) return new BoundedText(theme.fg("dim", "Goal updated"));
       const label = details.status === "complete" ? "✓ Complete" : details.status === "blocked" ? "! Blocked" : `! Blocker audit ${details.streak}/3`;
-      const text = `${theme.fg(details.status === "complete" ? "success" : "warning", label)}${theme.fg("dim", ` · ${details.evidence}`)}`;
+      const text = `${theme.fg(details.status === "complete" ? "success" : "warning", label)}${theme.fg("dim", ` · ${safeTerminalText(details.evidence)}`)}`;
       return new BoundedText(text, options.expanded ? undefined : 3);
     },
   });

package/killeros/hooks.ts

@@ -4,7 +4,6 @@ import path from "node:path";
 import { StringDecoder } from "node:string_decoder";
 import { CONFIG_DIR_NAME, type ExtensionAPI, type ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { reportError } from "./errors.ts";
-import { MAX_NODE_TIMER_MS } from "./limits.ts";
 
 type KillerosHookEvent = "tool_call" | "tool_result" | "agent_settled";
 
@@ -29,6 +28,8 @@ interface HookExecutionResult {
 
 const HOOK_EVENTS: readonly KillerosHookEvent[] = ["tool_call", "tool_result", "agent_settled"];
 const HOOK_OUTPUT_LIMIT = 16 * 1024;
+const HOOK_PAYLOAD_LIMIT = 8_000;
+const HOOK_TIMEOUT_MAX_MS = 300_000;
 
 function loadKillerosHooks(ctx: ExtensionContext): KillerosHookConfig {
   const configPath = path.join(ctx.cwd, CONFIG_DIR_NAME, "killeros-hooks.json");
@@ -49,11 +50,14 @@ function loadKillerosHooks(ctx: ExtensionContext): KillerosHookConfig {
           ctx.ui.notify(`Ignored ${event} hook ${index + 1}: matchers are only valid for tool events`, "warning");
           return false;
         }
+        if (hook?.timeoutMs !== undefined && (!Number.isSafeInteger(hook.timeoutMs) || hook.timeoutMs <= 0 || hook.timeoutMs > HOOK_TIMEOUT_MAX_MS)) {
+          ctx.ui.notify(`Ignored ${event} hook ${index + 1}: timeoutMs must be an integer from 1 to ${HOOK_TIMEOUT_MAX_MS}`, "warning");
+          return false;
+        }
         const valid = hook
           && typeof hook.command === "string"
           && hook.command.trim().length > 0
-          && (hook.matcher === undefined || typeof hook.matcher === "string")
-          && (hook.timeoutMs === undefined || Number.isSafeInteger(hook.timeoutMs) && hook.timeoutMs > 0 && hook.timeoutMs <= MAX_NODE_TIMER_MS);
+          && (hook.matcher === undefined || typeof hook.matcher === "string");
         if (!valid) {
           ctx.ui.notify(`Ignored invalid ${event} hook ${index + 1} in ${configPath}`, "warning");
           return false;
@@ -189,15 +193,22 @@ export function executeHook(
       finish(termination ? terminationCode() : 1);
     });
     child.once("close", (code) => finish(termination ? terminationCode() : code ?? 1));
-    timer = setTimeout(() => beginTermination("timeout"), Math.max(1_000, Math.min(timeoutMs, 300_000)));
+    timer = setTimeout(() => beginTermination("timeout"), Math.max(1, Math.min(timeoutMs, HOOK_TIMEOUT_MAX_MS)));
   });
 }
 
+function serializeHookPayload(payload: unknown): string {
+  const serialized = JSON.stringify(payload) ?? "null";
+  if (serialized.length <= HOOK_PAYLOAD_LIMIT) return serialized;
+  const previewLength = Math.floor((HOOK_PAYLOAD_LIMIT - 64) / 2);
+  return JSON.stringify({ truncated: true, preview: serialized.slice(0, previewLength) });
+}
+
 function hookEnvironment(event: KillerosHookEvent, toolName = "", payload: unknown = {}): Record<string, string> {
   return {
     KILLEROS_EVENT: event,
     KILLEROS_TOOL: toolName,
-    KILLEROS_PAYLOAD: JSON.stringify(payload).slice(0, 8_000),
+    KILLEROS_PAYLOAD: serializeHookPayload(payload),
   };
 }
 

package/killeros/question.ts

@@ -16,6 +16,7 @@ import {
 } from "@earendil-works/pi-tui";
 import { Type, type Static } from "typebox";
 import { BoundedText } from "./bounded-text.ts";
+import { safeTerminalText } from "./safe-terminal-text.ts";
 
 const OptionSchema = Type.Object({
   label: Type.String({ minLength: 1, maxLength: 200, description: "Display label for the option" }),
@@ -264,11 +265,12 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
       if (ctx.mode !== "tui") throw new Error("The question tool requires interactive TUI mode");
       if (signal?.aborted) throw new Error("Question cancelled before it opened");
 
+      const question = safeTerminalText(params.question);
       const options: DisplayOption[] = [
         ...params.options.map((option, index) => ({
-          label: option.label,
-          description: option.description,
-          preview: option.preview,
+          label: safeTerminalText(option.label),
+          description: option.description === undefined ? undefined : safeTerminalText(option.description),
+          preview: option.preview === undefined ? undefined : safeTerminalText(option.preview),
           originalIndex: index + 1,
           isOther: false,
         })),
@@ -599,7 +601,7 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
             } else lines = [`${selected ? `> ${selected.label}` : "No matching options"} · ${position}`];
           } else if (rowBudget <= 5) {
             lines = [
-              ...boundedQuestionLines(params.question, width, Math.max(1, rowBudget - 3)),
+              ...boundedQuestionLines(question, width, Math.max(1, rowBudget - 3)),
               editMode !== "none"
                 ? `${editMode === "filter" ? "Filter" : "Answer"} ${editMode === "filter" ? filterCount : editorCount}/${CUSTOM_INPUT_MAX_CHARACTERS.toLocaleString()}`
                 : selected ? optionLabel(selected, optionIndex) : "No matching options",
@@ -607,7 +609,7 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
               editMode !== "none" ? editHint : browseHint,
             ];
           } else {
-            const questionLines = boundedQuestionLines(params.question, width, Math.max(1, rowBudget - 5));
+            const questionLines = boundedQuestionLines(question, width, Math.max(1, rowBudget - 5));
             const contentRows = rowBudget - questionLines.length - 4;
             const optionCapacity = Math.max(1, Math.min(5, Math.ceil(contentRows / 2)));
             const detailCapacity = Math.max(0, contentRows - optionCapacity);
@@ -723,20 +725,26 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
     renderCall(args, theme, context) {
       const { mode, minSelections: minimum, maxSelections: maximum } = normalizeQuestionSelection(args);
       const multiple = mode === "multiple";
+      const question = safeTerminalText(args.question);
+      const options = args.options.map((option) => ({
+        label: safeTerminalText(option.label),
+        description: option.description === undefined ? undefined : safeTerminalText(option.description),
+        preview: option.preview === undefined ? undefined : safeTerminalText(option.preview),
+      }));
       if (!context.expanded) {
         const title = multiple ? "question (multi-select) " : "question ";
-        const detail = multiple ? `${args.options.length} options · choose ${minimum}–${maximum}` : `${args.options.length} option${args.options.length === 1 ? "" : "s"}`;
-        return new BoundedText(`${theme.fg("toolTitle", theme.bold(title))}${theme.fg("muted", oneLine(args.question))}\n${theme.fg("dim", `  ${detail}`)}`, 3);
+        const detail = multiple ? `${options.length} options · choose ${minimum}–${maximum}` : `${options.length} option${options.length === 1 ? "" : "s"}`;
+        return new BoundedText(`${theme.fg("toolTitle", theme.bold(title))}${theme.fg("muted", oneLine(question))}\n${theme.fg("dim", `  ${detail}`)}`, 3);
       }
       const title = multiple ? "question (multi-select) " : "question ";
-      const lines = [`${theme.fg("toolTitle", theme.bold(title))}${theme.fg("muted", args.question)}`];
-      if (multiple) lines.push(theme.fg("dim", `${args.options.length} options · choose ${minimum}–${maximum}`));
-      args.options.forEach((option, index) => {
+      const lines = [`${theme.fg("toolTitle", theme.bold(title))}${theme.fg("muted", question)}`];
+      if (multiple) lines.push(theme.fg("dim", `${options.length} options · choose ${minimum}–${maximum}`));
+      options.forEach((option, index) => {
         lines.push(theme.fg("text", `${multiple ? "[ ] " : ""}${index + 1}. ${option.label}`));
         if (option.description) lines.push(theme.fg("muted", `   ${option.description}`));
         if (option.preview) lines.push(theme.fg("dim", option.preview));
       });
-      lines.push(theme.fg("text", `${multiple ? "[ ] " : ""}${args.options.length + 1}. Type a custom answer`));
+      lines.push(theme.fg("text", `${multiple ? "[ ] " : ""}${options.length + 1}. Type a custom answer`));
       return new BoundedText(lines.join("\n"));
     },
 
@@ -744,14 +752,16 @@ export function registerQuestionTool(pi: ExtensionAPI): void {
       const details = result.details;
       if (!details) {
         const first = result.content[0];
-        return new BoundedText(first?.type === "text" ? first.text : "", options.expanded ? undefined : 3);
+        return new BoundedText(first?.type === "text" ? safeTerminalText(first.text) : "", options.expanded ? undefined : 3);
       }
       if (details.cancelled || ("answer" in details && details.answer === null)) return new BoundedText(theme.fg("warning", "Cancelled"));
       if ("mode" in details && details.mode === "multiple") {
-        return new MultipleResultText(details.answers, options.expanded, details.customAnswer, theme.fg.bind(theme));
+        const answers = details.answers.map(safeTerminalText);
+        const customAnswer = details.customAnswer === undefined ? undefined : safeTerminalText(details.customAnswer);
+        return new MultipleResultText(answers, options.expanded, customAnswer, theme.fg.bind(theme));
       }
       if (!("answer" in details) || details.answer === null) return new BoundedText("");
-      const answer = details.answer;
+      const answer = safeTerminalText(details.answer);
       if (details.wasCustom) {
         return new BoundedText(`${theme.fg("success", "✓ ")}${theme.fg("muted", "(wrote) ")}${theme.fg("accent", answer)}`, options.expanded ? undefined : 3);
       }

package/killeros/runtime.ts

@@ -28,9 +28,14 @@ export interface GoalBlockerAudit {
   lastTurn: number;
 }
 
+export type GoalFileBaseline =
+  | { exists: false }
+  | { exists: true; size: number; mtimeMs: number };
+
 export interface GoalFileVerification {
   kind: "file";
   path: string;
+  baseline: GoalFileBaseline;
 }
 
 export interface GoalState {

package/killeros/safe-terminal-text.ts

@@ -0,0 +1,6 @@
+import { stripTerminalSequences } from "@earendil-works/pi-tui";
+
+/** Remove terminal commands and unsafe controls while preserving line feeds. */
+export function safeTerminalText(value: string): string {
+  return stripTerminalSequences(value).replace(/[\u0000-\u0009\u000B-\u001F\u007F-\u009F]/gu, "");
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "killeros",
-  "version": "2.0.13",
+  "version": "2.0.14",
   "description": "TUI, goals, and workflow automation for the Pi coding agent",
   "type": "module",
   "keywords": [