kiku-agent 1.3.1 → 1.3.3

package/server/agent/tests/citations.test.js

@@ -0,0 +1,180 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { extractCitations, formatCitationsBlock, resolveCitationReference } from '../citations.js';
+import { routeCommand } from '../commands.js';
+
+test('extractCitations: correctly extracts and deduplicates works from search_works', () => {
+  const tools = [
+    {
+      name: 'search_works',
+      result: {
+        count: 2,
+        works: [
+          {
+            id: 'legend-of-yunxi',
+            titleTh: 'ตำนานหยุนซี มเหสียอดอัจฉริยะแห่งพิษ',
+            titleCn: '芸汐传',
+            category: 'ซีรีส์โบราณ',
+            year: 2018,
+            role: 'หานอวิ๋นซี (Han Yunxi)'
+          },
+          {
+            id: 'in-blossom',
+            titleTh: 'บุปผารักอลวน',
+            titleCn: '花间令',
+            category: 'ซีรีส์สืบสวนโบราณ',
+            year: 2024,
+            role: 'หยางไฉ่เวย / ซ่างกวนจื่อ'
+          }
+        ]
+      }
+    }
+  ];
+
+  const answer = 'จวีจิ้งอี มีผลงานซีรีส์ชื่อดังอย่าง ตำนานหยุนซี (芸汐传) รับบทเป็น หานอวิ๋นซี';
+  const citations = extractCitations(answer, tools);
+
+  assert.equal(citations.length, 1);
+  assert.equal(citations[0].id, 1);
+  assert.equal(citations[0].type, 'work');
+  assert.match(citations[0].title, /ตำนานหยุนซี/);
+  assert.equal(citations[0].year, 2018);
+  assert.equal(citations[0].verified, true);
+});
+
+test('extractCitations: extracts discography, timeline, and web search results', () => {
+  const tools = [
+    {
+      name: 'search_discography',
+      result: {
+        songs: [
+          {
+            title: 'Everyday',
+            titleTh: 'ทุกๆ วัน',
+            category: 'Single',
+            year: 2016
+          }
+        ]
+      }
+    },
+    {
+      name: 'get_career_timeline',
+      result: {
+        timeline: [
+          {
+            year: 2013,
+            event: 'เดบิวต์ในฐานะสมาชิกรุ่นที่ 2 ของ SNH48'
+          }
+        ]
+      }
+    },
+    {
+      name: 'web_search',
+      result: {
+        results: [
+          {
+            title: 'Ju Jingyi Studio Official Statement',
+            url: 'https://weibo.com/jujingyi/status/12345'
+          }
+        ]
+      }
+    }
+  ];
+
+  const answer = 'เธอเดบิวต์ในปี 2013 กับ SNH48 และมีเพลง Everyday รวมถึงแถลงการณ์อย่างเป็นทางการ';
+  const citations = extractCitations(answer, tools);
+
+  assert.equal(citations.length, 3);
+  assert.equal(citations[0].id, 1);
+  assert.equal(citations[0].type, 'song');
+  assert.equal(citations[1].id, 2);
+  assert.equal(citations[1].type, 'timeline');
+  assert.equal(citations[2].id, 3);
+  assert.equal(citations[2].type, 'web');
+  assert.equal(citations[2].source, 'weibo.com');
+});
+
+test('extractCitations: returns empty array for empty inputs or no matches', () => {
+  assert.deepEqual(extractCitations('', []), []);
+  assert.deepEqual(extractCitations('ข้อความทั่วไป', null), []);
+});
+
+test('formatCitationsBlock: formats citations in Thai, English, and Chinese', () => {
+  const citations = [
+    {
+      id: 1,
+      title: 'บุปผารักอลวน (花间令)',
+      category: 'ซีรีส์',
+      year: 2024,
+      source: 'catalog:works (search_works)',
+      verified: true
+    },
+    {
+      id: 2,
+      title: 'Weibo News',
+      url: 'https://weibo.com/test',
+      category: 'เว็บข่าว',
+      verified: true
+    }
+  ];
+
+  const thBlock = formatCitationsBlock(citations, { lang: 'th' });
+  assert.match(thBlock, /แหล่งข้อมูลและหลักฐานอ้างอิง/);
+  assert.match(thBlock, /\[1\] บุปผารักอลวน/);
+  assert.match(thBlock, /\[2024\]/);
+  assert.match(thBlock, /\[2\] Weibo News/);
+  assert.match(thBlock, /https:\/\/weibo.com\/test/);
+
+  const enBlock = formatCitationsBlock(citations, { lang: 'en' });
+  assert.match(enBlock, /Sources & Evidence Citations/);
+
+  const zhBlock = formatCitationsBlock(citations, { lang: 'zh' });
+  assert.match(zhBlock, /参考来源与证据引用/);
+
+  assert.equal(formatCitationsBlock([]), '');
+});
+
+test('resolveCitationReference: resolves bracket notation, hash, number, and entity name', () => {
+  const citations = [
+    { id: 1, title: 'ตำนานหยุนซี (芸汐传)', year: 2018 },
+    { id: 2, title: 'บุปผารักอลวน (In Blossom)', year: 2024 },
+    { id: 3, title: 'เพลง Everyday', year: 2016 }
+  ];
+
+  const res1 = resolveCitationReference('เล่าเรื่องย่อของ [1] ให้ฟังหน่อย', citations);
+  assert.equal(res1?.id, 1);
+  assert.equal(res1?.year, 2018);
+
+  const res2 = resolveCitationReference('ขอรายละเอียดของ #2 เพิ่มเติม', citations);
+  assert.equal(res2?.id, 2);
+
+  const res3 = resolveCitationReference('3', citations);
+  assert.equal(res3?.id, 3);
+
+  const resTitle = resolveCitationReference('บุปผารักอลวน มีกี่ตอน', citations);
+  assert.equal(resTitle?.id, 2);
+
+  const notFound = resolveCitationReference('ไม่มีในรายการ', citations);
+  assert.equal(notFound, null);
+});
+
+test('/sources command: displays active grounded citations when available', async () => {
+  const mockAgent = {
+    lastCitations: [
+      {
+        id: 1,
+        title: 'ตำนานหยุนซี',
+        category: 'ซีรีส์',
+        year: 2018,
+        tool: 'search_works'
+      }
+    ]
+  };
+
+  const status = await routeCommand('/sources', {
+    agent: mockAgent,
+    setIsProcessing: () => {}
+  });
+
+  assert.equal(status, 'HANDLED');
+});

package/server/agent/tests/clarificationAnalytics.test.js

@@ -0,0 +1,219 @@
+import { describe, it, beforeEach } from 'node:test';
+import assert from 'node:assert/strict';
+import { ClarificationAnalytics, ClarificationConfig, formatAnalyticsForCLI, formatConfigForCLI } from '../clarificationAnalytics.js';
+import { existsSync, unlinkSync, mkdirSync } from 'node:fs';
+import { join } from 'node:path';
+
+const TEST_DIR = join(process.cwd(), '.kiku_test_analytics');
+const TEST_ANALYTICS_PATH = join(TEST_DIR, 'test_analytics.json');
+const TEST_CONFIG_PATH = join(TEST_DIR, 'test_config.json');
+
+beforeEach(() => {
+  
+  try {
+    if (existsSync(TEST_ANALYTICS_PATH)) unlinkSync(TEST_ANALYTICS_PATH);
+    if (existsSync(TEST_CONFIG_PATH)) unlinkSync(TEST_CONFIG_PATH);
+  } catch {}
+});
+
+describe('ClarificationAnalytics', () => {
+  it('initializes with default stats', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    assert.equal(analytics.stats.totalClarifications, 0);
+    assert.equal(analytics.stats.totalSkipped, 0);
+    assert.equal(analytics.stats.totalTimedOut, 0);
+  });
+
+  it('records clarification start', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    const session = analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    assert.equal(session.queryId, 'q_test_1');
+    assert.equal(session.totalQuestions, 1);
+    assert.equal(analytics.stats.totalClarifications, 1);
+  });
+
+  it('records clarification answer', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    analytics.recordClarificationAnswer('q_test_1', { timeframe: '2026' }, 1, 2500);
+    
+    const session = analytics.stats.recentSessions.find(s => s.queryId === 'q_test_1');
+    assert.equal(session.answered, true);
+    assert.equal(session.answerSummary.timeframe, '2026');
+    assert.equal(analytics.stats.categoryStats.timeframe.answered, 1);
+  });
+
+  it('records clarification skip', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    analytics.recordClarificationSkipped('q_test_1');
+    
+    assert.equal(analytics.stats.totalSkipped, 1);
+    const session = analytics.stats.recentSessions.find(s => s.queryId === 'q_test_1');
+    assert.equal(session.skipped, true);
+  });
+
+  it('records clarification timeout', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    analytics.recordClarificationTimeout('q_test_1');
+    
+    assert.equal(analytics.stats.totalTimedOut, 1);
+    const session = analytics.stats.recentSessions.find(s => s.queryId === 'q_test_1');
+    assert.equal(session.timedOut, true);
+  });
+
+  it('gets analytics summary', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    analytics.recordClarificationAnswer('q_test_1', { timeframe: '2026' }, 1, 2500);
+    
+    const summary = analytics.getAnalytics({ days: 7 });
+    assert.ok(summary.summary);
+    assert.equal(summary.summary.totalClarifications, 1);
+    assert.ok(summary.period);
+    assert.ok(summary.categories);
+  });
+
+  it('gets category effectiveness', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    
+    analytics.recordClarificationStart('q_test_1', questions, 0.45);
+    analytics.recordClarificationAnswer('q_test_1', { timeframe: '2026' }, 1, 2000);
+    
+    const effectiveness = analytics.getCategoryEffectiveness('timeframe');
+    assert.ok(effectiveness >= 0 && effectiveness <= 100);
+  });
+
+  it('gets top categories', () => {
+    const analytics = new ClarificationAnalytics({ storagePath: TEST_ANALYTICS_PATH });
+    
+    analytics.recordClarificationStart('q_1', [{ category: 'timeframe', question: 'When?', options: [] }], 0.5);
+    analytics.recordClarificationStart('q_2', [{ category: 'scope', question: 'How much?', options: [] }], 0.5);
+    
+    const top = analytics.getTopCategories(5);
+    assert.ok(Array.isArray(top));
+    assert.ok(top.length <= 5);
+  });
+});
+
+describe('ClarificationConfig', () => {
+  it('initializes with default config', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    const cfg = config.getConfig();
+    assert.equal(cfg.enabled, true);
+    assert.equal(cfg.confidenceThreshold, 0.65);
+    assert.equal(cfg.maxRounds, 2);
+    assert.equal(cfg.timeoutMs, 30000);
+  });
+
+  it('updates config', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    const newConfig = config.updateConfig({ confidenceThreshold: 0.8 });
+    assert.equal(newConfig.confidenceThreshold, 0.8);
+  });
+
+  it('validates confidence threshold', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    assert.throws(() => {
+      config.updateConfig({ confidenceThreshold: 1.5 });
+    });
+    assert.throws(() => {
+      config.updateConfig({ confidenceThreshold: -0.1 });
+    });
+  });
+
+  it('validates maxRounds', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    assert.throws(() => {
+      config.updateConfig({ maxRounds: 10 });
+    });
+    assert.throws(() => {
+      config.updateConfig({ maxRounds: 0 });
+    });
+  });
+
+  it('resets to defaults', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    config.updateConfig({ confidenceThreshold: 0.9 });
+    const resetConfig = config.reset();
+    assert.equal(resetConfig.confidenceThreshold, 0.65);
+  });
+
+  it('gets and sets individual values', () => {
+    const config = new ClarificationConfig({ storagePath: TEST_CONFIG_PATH });
+    config.set('enabled', false);
+    assert.equal(config.get('enabled'), false);
+  });
+});
+
+describe('formatAnalyticsForCLI', () => {
+  it('formats analytics for display', () => {
+    const analytics = {
+      summary: {
+        totalClarifications: 10,
+        totalAnswered: 8,
+        totalSkipped: 2,
+        totalTimedOut: 0,
+        overallSkipRate: '20%',
+        avgRoundsPerSession: 1.2,
+      },
+      period: {
+        days: 7,
+        asked: 5,
+        answered: 4,
+        skipped: 1,
+      },
+      categories: {
+        timeframe: { asked: 5, answered: 4, skipRate: '20%' },
+      },
+    };
+    
+    const result = formatAnalyticsForCLI(analytics, { gold: '', reset: '', bold: '', white: '', dim: '', green: '', yellow: '', red: '' });
+    assert.ok(result.includes('Clarification Analytics'));
+    assert.ok(result.includes('10'));
+    assert.ok(result.includes('timeframe'));
+  });
+});
+
+describe('formatConfigForCLI', () => {
+  it('formats config for display', () => {
+    const config = {
+      enabled: true,
+      confidenceThreshold: 0.65,
+      maxRounds: 2,
+      timeoutMs: 30000,
+      preferLLMQuestions: true,
+    };
+    
+    const result = formatConfigForCLI(config, { gold: '', reset: '', bold: '', white: '', dim: '', green: '', yellow: '' });
+    assert.ok(result.includes('Clarification Settings'));
+    assert.ok(result.includes('65%'));
+    assert.ok(result.includes('2'));
+  });
+});
+
+console.log('✅ All clarification analytics tests passed');