kiku-agent 1.3.1 → 1.3.2

package/server/agent/tests/clarifyingQuestions.test.js

@@ -0,0 +1,594 @@
+import { describe, it } from 'node:test';
+import assert from 'node:assert/strict';
+import {
+  detectAmbiguities,
+  isQueryTooVague,
+  formatQuestionsForCLI,
+  formatQuestionsForSSE,
+  parseClarifyingAnswers,
+  emitClarifyingQuestions,
+  calculateConfidence,
+  buildClarificationContext,
+  getAmbiguityPatterns,
+  generateClarifyingQuestions,
+  stripSystemDirectives,
+  cleanThinkingBlocks,
+} from '../clarifyingQuestions.js';
+
+describe('detectAmbiguities', () => {
+  it('returns empty array for null/undefined input', () => {
+    assert.deepEqual(detectAmbiguities(null), []);
+    assert.deepEqual(detectAmbiguities(undefined), []);
+    assert.deepEqual(detectAmbiguities(''), []);
+  });
+
+  it('detects timeframe ambiguity', () => {
+    const result = detectAmbiguities('What are her recent works?', 'en');
+    assert.ok(result.length > 0);
+    assert.equal(result[0].category, 'timeframe');
+    assert.ok(result[0].question.includes('timeframe'));
+    assert.ok(result[0].options.length > 0);
+  });
+
+  it('detects scope ambiguity', () => {
+    const result = detectAmbiguities('Tell me about all her dramas', 'en');
+    assert.ok(result.length > 0);
+    assert.equal(result[0].category, 'scope');
+  });
+
+  it('detects depth ambiguity', () => {
+    const result = detectAmbiguities('Give me a detailed overview of her career', 'en');
+    assert.ok(result.length > 0);
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('depth'));
+  });
+
+  it('detects comparison ambiguity', () => {
+    const result = detectAmbiguities('Compare her dramas vs her music', 'en');
+    assert.ok(result.length > 0);
+    assert.equal(result[0].category, 'comparison');
+  });
+
+  it('detects media_type ambiguity', () => {
+    const result = detectAmbiguities('Show me her songs', 'en');
+    assert.ok(result.length > 0);
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('media_type'));
+  });
+
+  it('detects language ambiguity', () => {
+    const result = detectAmbiguities('Tell me about her Chinese dramas', 'en');
+    assert.ok(result.length > 0);
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('language'));
+  });
+
+  it('detects multiple ambiguities', () => {
+    const result = detectAmbiguities('Show me all her recent songs in Chinese', 'en');
+    assert.ok(result.length >= 2);
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('timeframe'));
+    assert.ok(categories.includes('media_type'));
+  });
+
+  it('returns Thai questions when detectedLang is th', () => {
+    const result = detectAmbiguities('recent works', 'th');
+    assert.ok(result.length > 0);
+    const timeframeQ = result.find(r => r.category === 'timeframe');
+    assert.ok(timeframeQ);
+    assert.ok(timeframeQ.question.includes('กรุณา') || timeframeQ.question.includes('ช่วงเวลา'));
+  });
+
+  it('returns Chinese questions when detectedLang is zh', () => {
+    const result = detectAmbiguities('recent works', 'zh');
+    assert.ok(result.length > 0);
+    const timeframeQ = result.find(r => r.category === 'timeframe');
+    assert.ok(timeframeQ);
+    assert.ok(timeframeQ.question.includes('您') || timeframeQ.question.includes('吗'));
+  });
+
+  it('returns English questions as fallback', () => {
+    const result = detectAmbiguities('recent works', 'unknown');
+    assert.ok(result.length > 0);
+    assert.ok(result[0].question.includes('timeframe') || result[0].question.includes('Could you'));
+  });
+
+  it('does not duplicate categories', () => {
+    const result = detectAmbiguities('Tell me about all her recent detailed songs in Chinese', 'en');
+    const categories = result.map(r => r.category);
+    const uniqueCategories = [...new Set(categories)];
+    assert.equal(categories.length, uniqueCategories.length);
+  });
+});
+
+describe('isQueryTooVague', () => {
+  it('returns true for null/undefined', () => {
+    assert.equal(isQueryTooVague(null), true);
+    assert.equal(isQueryTooVague(undefined), true);
+    assert.equal(isQueryTooVague(''), true);
+  });
+
+  it('returns true for very short queries', () => {
+    assert.equal(isQueryTooVague('a'), true);
+    assert.equal(isQueryTooVague('hi'), true);
+    assert.equal(isQueryTooVague('??'), true);
+  });
+
+  it('returns true for punctuation-only queries', () => {
+    assert.equal(isQueryTooVague('???'), true);
+    assert.equal(isQueryTooVague('...'), true);
+    assert.equal(isQueryTooVague('!!!'), true);
+  });
+
+  it('returns true for single short word', () => {
+    assert.equal(isQueryTooVague('hey'), true);
+    assert.equal(isQueryTooVague('hi'), true);
+  });
+
+  it('returns false for meaningful queries', () => {
+    assert.equal(isQueryTooVague('What are her latest dramas?'), false);
+    assert.equal(isQueryTooVague('Tell me about Ju Jingyi'), false);
+    assert.equal(isQueryTooVague('ผลงานล่าสุดของเธอ'), false);
+    assert.equal(isQueryTooVague('她的最新作品'), false);
+  });
+});
+
+describe('formatQuestionsForCLI', () => {
+  it('returns empty string for empty input', () => {
+    assert.equal(formatQuestionsForCLI([]), '');
+    assert.equal(formatQuestionsForCLI(null), '');
+    assert.equal(formatQuestionsForCLI(undefined), '');
+  });
+
+  it('formats questions with options', () => {
+    const questions = [
+      {
+        category: 'timeframe',
+        question: 'What timeframe?',
+        options: ['2026', '2025', 'All time'],
+      },
+    ];
+    const result = formatQuestionsForCLI(questions, { gold: '\x1b[33m', reset: '\x1b[0m', bold: '\x1b[1m', roseGlow: '\x1b[38;2;255;117;140m', dim: '\x1b[2m', slate: '\x1b[90m', white: '\x1b[37m' });
+    assert.ok(result.includes('TIMEFRAME'));
+    assert.ok(result.includes('What timeframe?'));
+    assert.ok(result.includes('a) 2026'));
+    assert.ok(result.includes('b) 2025'));
+    assert.ok(result.includes('c) All time'));
+  });
+
+  it('includes skip instruction', () => {
+    const questions = [{ category: 'scope', question: 'Scope?', options: ['A'] }];
+    const result = formatQuestionsForCLI(questions, {});
+    assert.ok(result.includes('skip'));
+  });
+});
+
+describe('formatQuestionsForSSE', () => {
+  it('returns null for empty input', () => {
+    assert.equal(formatQuestionsForSSE([]), null);
+    assert.equal(formatQuestionsForSSE(null), null);
+  });
+
+  it('returns structured object', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['Now', 'Later'] },
+    ];
+    const result = formatQuestionsForSSE(questions);
+    assert.equal(result.type, 'clarifying_questions');
+    assert.ok(result.questions.length === 1);
+    assert.equal(result.questions[0].category, 'timeframe');
+    assert.ok(result.instruction.includes('skip'));
+  });
+});
+
+describe('parseClarifyingAnswers', () => {
+  it('returns empty for skip', () => {
+    const result = parseClarifyingAnswers('skip', [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ]);
+    assert.equal(Object.keys(result.answers).length, 0);
+    assert.ok(result.summary.includes('skip'));
+  });
+
+  it('parses structured format "1a 2c"', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025', 'All'] },
+      { category: 'scope', question: 'How much?', options: ['Full', 'Brief'] },
+    ];
+    const result = parseClarifyingAnswers('1a 2b', questions);
+    assert.equal(result.answers.timeframe, '2026');
+    assert.equal(result.answers.scope, 'Brief');
+  });
+
+  it('parses single option format "a"', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    const result = parseClarifyingAnswers('a', questions);
+    assert.equal(result.answers.timeframe, '2026');
+  });
+
+  it('handles free text as first question answer', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    const result = parseClarifyingAnswers('the past few years', questions);
+    assert.equal(result.answers.timeframe, 'the past few years');
+  });
+
+  it('returns empty for null/undefined input', () => {
+    const result = parseClarifyingAnswers(null, []);
+    assert.equal(Object.keys(result.answers).length, 0);
+  });
+});
+
+describe('emitClarifyingQuestions', () => {
+  it('returns default when no handler provided', async () => {
+    const result = await emitClarifyingQuestions(
+      [{ category: 'test', question: 'Test?', options: ['A'] }],
+      'q_test'
+    );
+    assert.equal(Object.keys(result.answers).length, 0);
+    assert.ok(result.summary.includes('No response handler'));
+  });
+
+  it('returns default when questions are empty', async () => {
+    const result = await emitClarifyingQuestions([], 'q_test');
+    assert.equal(Object.keys(result.answers).length, 0);
+  });
+});
+
+describe('calculateConfidence', () => {
+  it('returns very_low confidence for null/undefined input', () => {
+    const result = calculateConfidence(null);
+    assert.equal(result.level, 'very_low');
+    assert.equal(result.shouldAsk, true);
+    assert.ok(result.score < 0.5);
+  });
+
+  it('returns low confidence for short queries', () => {
+    const result = calculateConfidence('drama', []);
+    assert.ok(result.score < 0.8);
+  });
+
+  it('returns higher confidence for specific queries with year', () => {
+    const result = calculateConfidence('What dramas did Ju Jingyi star in 2024?', []);
+    assert.ok(result.score > 0.8);
+    assert.equal(result.level, 'high');
+    assert.equal(result.shouldAsk, false);
+  });
+
+  it('returns medium confidence for moderate queries', () => {
+    
+    const ambiguities = [
+      { category: 'scope', weight: 0.6 },
+      { category: 'depth', weight: 0.5 },
+    ];
+    const result = calculateConfidence('Show me something', ambiguities);
+    assert.ok(result.score >= 0.4 && result.score <= 0.9, `Expected medium confidence, got ${result.score}`);
+  });
+
+  it('deducts score for detected ambiguities', () => {
+    const ambiguities = [{ category: 'timeframe', weight: 0.7 }];
+    const withoutAmbiguity = calculateConfidence('Show me her songs', []);
+    const withAmbiguity = calculateConfidence('Show me her songs', ambiguities);
+    assert.ok(withAmbiguity.score < withoutAmbiguity.score);
+  });
+
+  it('boosts confidence for specific keywords', () => {
+    const result = calculateConfidence('Tell me specifically about In Blossom drama', []);
+    assert.ok(result.score > 0.8);
+  });
+
+  it('includes reasoning in result', () => {
+    const result = calculateConfidence('test query', []);
+    assert.ok(typeof result.reasoning === 'string');
+    assert.ok(result.reasoning.includes('Confidence'));
+  });
+});
+
+describe('buildClarificationContext', () => {
+  it('returns empty string for null result', () => {
+    assert.equal(buildClarificationContext(null, 'test'), '');
+  });
+
+  it('returns empty string for empty answers', () => {
+    assert.equal(buildClarificationContext({ answers: {}, summary: '' }, 'test'), '');
+  });
+
+  it('builds context with answers', () => {
+    const result = {
+      answers: { timeframe: '2026', scope: 'Comprehensive' },
+      summary: 'User clarified: timeframe: 2026'
+    };
+    const context = buildClarificationContext(result, 'Show me her works');
+    assert.ok(context.includes('[SYSTEM CLARIFICATION]'));
+    assert.ok(context.includes('Original query: Show me her works'));
+    assert.ok(context.includes('timeframe: 2026'));
+    assert.ok(context.includes('scope: Comprehensive'));
+  });
+});
+
+describe('getAmbiguityPatterns', () => {
+  it('returns array of patterns', () => {
+    const patterns = getAmbiguityPatterns();
+    assert.ok(Array.isArray(patterns));
+    assert.ok(patterns.length >= 6);
+  });
+
+  it('each pattern has required fields', () => {
+    const patterns = getAmbiguityPatterns();
+    for (const p of patterns) {
+      assert.ok(p.category, 'Pattern should have category');
+      assert.ok(p.weight !== undefined, 'Pattern should have weight');
+      assert.ok(p.detection, 'Pattern should have detection regex');
+      assert.ok(p.questions, 'Pattern should have questions');
+      assert.ok(p.questions.en, 'Pattern should have English questions');
+      assert.ok(p.options, 'Pattern should have options');
+    }
+  });
+});
+
+describe('parseClarifyingAnswers (enhanced)', () => {
+  it('interprets shorthand "detailed" for depth questions', () => {
+    const questions = [
+      { category: 'depth', question: 'How detailed?', options: ['Very detailed (full analysis)', 'Moderate', 'Brief (quick summary)'] },
+    ];
+    const result = parseClarifyingAnswers('detailed', questions);
+    assert.equal(result.answers.depth, 'Very detailed (full analysis)');
+  });
+
+  it('interprets shorthand "brief" for depth questions', () => {
+    const questions = [
+      { category: 'depth', question: 'How detailed?', options: ['Very detailed (full analysis)', 'Moderate', 'Brief (quick summary)'] },
+    ];
+    const result = parseClarifyingAnswers('brief', questions);
+    assert.equal(result.answers.depth, 'Brief (quick summary)');
+  });
+
+  it('interprets "2026" for timeframe questions', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026 (current year)', '2025', 'All time'] },
+    ];
+    const result = parseClarifyingAnswers('2026', questions);
+    assert.equal(result.answers.timeframe, '2026 (current year)');
+  });
+
+  it('skips on "no" answer', () => {
+    const questions = [
+      { category: 'timeframe', question: 'When?', options: ['2026', '2025'] },
+    ];
+    const result = parseClarifyingAnswers('no', questions);
+    assert.equal(Object.keys(result.answers).length, 0);
+    assert.ok(result.summary.includes('skip'));
+  });
+});
+
+describe('stripSystemDirectives', () => {
+  it('strips SYSTEM DIRECTIVE and returns clean user question', () => {
+    const raw = '我需要有關鞠靜怡的資訊。\n\n[SYSTEM DIRECTIVE (Fact Grounding & Music Playback):\n1. Do not hallucinate]';
+    const cleaned = stripSystemDirectives(raw);
+    assert.equal(cleaned, '我需要有關鞠靜怡的資訊。');
+  });
+
+  it('handles text without system directives', () => {
+    assert.equal(stripSystemDirectives('ขอเพลงหน่อย'), 'ขอเพลงหน่อย');
+  });
+});
+
+describe('generateClarifyingQuestions (model-driven)', () => {
+  it('uses model client to generate dynamic questions when available', async () => {
+    const mockClient = {
+      timeout: 5000,
+      async chat({ messages }) {
+        return {
+          content: JSON.stringify([
+            {
+              category: 'subject_focus',
+              question: 'สนใจเรื่องใดเกี่ยวกับจวีจิ้งอีเป็นพิเศษคะ?',
+              options: ['ผลงานซีรีส์', 'ผลงานเพลง', 'ประวัติส่วนตัว']
+            },
+            {
+              category: 'timeframe',
+              question: 'ต้องการดูข้อมูลช่วงปีใดคะ?',
+              options: ['2024-2026', '2020-2023', 'ทั้งหมด']
+            }
+          ])
+        };
+      }
+    };
+
+    const questions = await generateClarifyingQuestions('ขอข้อมูลจวีจิ้งอี', 'th', { client: mockClient });
+    assert.ok(Array.isArray(questions));
+    assert.equal(questions.length, 2);
+    assert.equal(questions[0].category, 'subject_focus');
+    assert.equal(questions[0].question, 'สนใจเรื่องใดเกี่ยวกับจวีจิ้งอีเป็นพิเศษคะ?');
+    assert.deepEqual(questions[0].options, ['ผลงานซีรีส์', 'ผลงานเพลง', 'ประวัติส่วนตัว']);
+  });
+
+  it('parses markdown code block JSON from model correctly', async () => {
+    const mockClient = {
+      timeout: 5000,
+      async chat() {
+        return {
+          content: '```json\n[\n  {\n    "category": "career_phase",\n    "question": "สนใจช่วงใดคะ?",\n    "options": ["Solo", "SNH48"]\n  }\n,  {\n    "category": "depth",\n    "question": "ต้องการคำตอบละเอียดแค่ไหนคะ?",\n    "options": ["สรุปกระชับ", "เจาะลึก"]\n  }\n]\n```'
+        };
+      }
+    };
+
+    const questions = await generateClarifyingQuestions('เล่าเรื่องจวีจิ้งอี', 'th', { client: mockClient });
+    assert.equal(questions.length, 2);
+    assert.equal(questions[0].category, 'career_phase');
+    assert.equal(questions[1].category, 'depth');
+  });
+
+  it('falls back cleanly to synthesizeDynamicQuestions when client fails', async () => {
+    const mockClient = {
+      timeout: 5000,
+      async chat() {
+        throw new Error('Model offline');
+      }
+    };
+
+    const questions = await generateClarifyingQuestions('เพลงล่าสุด', 'th', { client: mockClient });
+    assert.ok(Array.isArray(questions));
+    assert.ok(questions.length > 0);
+  });
+});
+
+console.log('✅ All clarifying questions tests passed');
+
+describe('multilingual support (ja/ko)', () => {
+  it('returns Japanese questions when detectedLang is ja', () => {
+    const result = detectAmbiguities('recent works', 'ja');
+    const timeframeQ = result.find(r => r.category === 'timeframe');
+    assert.ok(timeframeQ);
+    assert.ok(/期間/.test(timeframeQ.question));
+    assert.ok(timeframeQ.options.every(opt => !/[\u0E00-\u0E7F]/.test(opt)));
+  });
+
+  it('returns Korean questions when detectedLang is ko', () => {
+    const result = detectAmbiguities('recent works', 'ko');
+    const timeframeQ = result.find(r => r.category === 'timeframe');
+    assert.ok(timeframeQ);
+    assert.ok(/기간/.test(timeframeQ.question));
+    assert.ok(timeframeQ.options.every(opt => !/[\u0E00-\u0E7F]/.test(opt)));
+  });
+
+  it('normalizes language aliases (jp -> ja, kr -> ko, zh-TW -> zh)', () => {
+    const ja = detectAmbiguities('recent works', 'jp');
+    assert.ok(ja.length > 0 && /[\u3040-\u30FF]/.test(ja[0].question));
+    const ko = detectAmbiguities('recent works', 'kr');
+    assert.ok(ko.length > 0 && /[\uAC00-\uD7AF]/.test(ko[0].question));
+    const zh = detectAmbiguities('recent works', 'zh-TW');
+    assert.ok(zh.length > 0 && /[\u4E00-\u9FFF]/.test(zh[0].question));
+  });
+
+  it('falls back to English for unknown language tags', () => {
+    const result = detectAmbiguities('recent works', 'xx');
+    assert.ok(result.length > 0);
+    assert.ok(result[0].question.includes('timeframe') || result[0].question.includes('Could you'));
+  });
+
+  it('detects Japanese keywords in queries', () => {
+    const result = detectAmbiguities('彼女のドラマと曲を教えて', 'ja');
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('media_type'));
+  });
+
+  it('detects Korean keywords in queries', () => {
+    const result = detectAmbiguities('그녀의 노래를 보여줘', 'ko');
+    const categories = result.map(r => r.category);
+    assert.ok(categories.includes('media_type'));
+  });
+
+  it('isQueryTooVague handles Japanese and Korean', () => {
+    assert.equal(isQueryTooVague('はい'), true);
+    assert.equal(isQueryTooVague('花間令について詳しく教えて'), false);
+    assert.equal(isQueryTooVague('그녀의 최신 드라마를 알려줘'), false);
+    assert.equal(isQueryTooVague('？？？'), true);
+  });
+
+  it('calculateConfidence is not over-penalized for CJK queries', () => {
+    const result = calculateConfidence('彼女の最新のドラマ作品について詳しく教えてください', []);
+    assert.ok(result.score > 0.3, `Expected score > 0.3, got ${result.score}`);
+  });
+
+  it('generates Japanese fallback questions without a client', async () => {
+    const questions = await generateClarifyingQuestions('彼女の作品について教えて', 'ja', {});
+    assert.ok(questions.length > 0);
+    assert.ok(questions.every(q => /[\u3040-\u30FF]/.test(q.question)));
+  });
+
+  it('generates Korean fallback questions without a client', async () => {
+    const questions = await generateClarifyingQuestions('그녀의 작품에 대해 알려줘', 'ko', {});
+    assert.ok(questions.length > 0);
+    assert.ok(questions.every(q => /[\uAC00-\uD7AF]/.test(q.question)));
+  });
+
+  it('parses localized skip answers', () => {
+    for (const word of ['ข้าม', '跳过', 'スキップ', '건너뛰기', 'pass']) {
+      const result = parseClarifyingAnswers(word, [
+        { category: 'timeframe', question: 'When?', options: ['2026'] },
+      ]);
+      assert.equal(Object.keys(result.answers).length, 0);
+      assert.ok(result.summary.includes('skip'));
+    }
+  });
+});
+
+describe('fan-centric dynamic clarification & thinking block cleanup', () => {
+  it('cleanThinkingBlocks strips <think>, <thought>, and markdown thought blocks', () => {
+    const withThink = '<think>User wants info on In Blossom. Brackets [1, 2] here.</think>Hello world!';
+    assert.equal(cleanThinkingBlocks(withThink), 'Hello world!');
+
+    const withThought = '<thought>Analyzing query...</thought>[{"category": "test", "question": "Q?"}]';
+    assert.equal(cleanThinkingBlocks(withThought), '[{"category": "test", "question": "Q?"}]');
+
+    const withMarkdown = '```thought\nSome internal deliberations\n```\n[{"category": "music_style"}]';
+    assert.equal(cleanThinkingBlocks(withMarkdown), '[{"category": "music_style"}]');
+
+    assert.equal(cleanThinkingBlocks(null), '');
+    assert.equal(cleanThinkingBlocks(''), '');
+  });
+
+  it('generateClarifyingQuestions parses LLM responses wrapped with reasoning thought blocks', async () => {
+    const mockClient = {
+      timeout: 5000,
+      async chat() {
+        return {
+          content: '<thought>\n' +
+            'The fan is asking about the drama In Blossom (花间令).\n' +
+            'They want to know more about the character Yang Caiwei.\n' +
+            'I should propose questions about character arc and signature scenes.\n' +
+            '[internal note: brackets should not confuse the parser]\n' +
+            '</thought>\n' +
+            '[\n' +
+            '  {\n' +
+            '    "category": "character_arc",\n' +
+            '    "question": "เกี่ยวกับหยางไฉ่เวย สนใจเจาะลึกมิติตัวละครหรือเคมีคู่กับพานเยว่คะ?",\n' +
+            '    "options": ["มิติตัวละครหยางไฉ่เวย", "เคมีคู่พานเยว่", "เบื้องหลังการถ่ายทำ"]\n' +
+            '  },\n' +
+            '  {\n' +
+            '    "category": "scene_highlight",\n' +
+            '    "question": "อยากดูการวิเคราะห์ฉากไฮไลต์ซีนไหนเป็นพิเศษไหมคะ?",\n' +
+            '    "options": ["ฉากแต่งงานสลับตัว", "ฉากไขคดีแรก", "ฉากจบสุดประทับใจ"]\n' +
+            '  }\n' +
+            ']'
+        };
+      }
+    };
+
+    const questions = await generateClarifyingQuestions('เล่าเรื่องฮวาเจียนลิ่งหน่อย', 'th', { client: mockClient });
+    assert.ok(Array.isArray(questions));
+    assert.equal(questions.length, 2);
+    assert.equal(questions[0].category, 'character_arc');
+    assert.equal(questions[0].question, 'เกี่ยวกับหยางไฉ่เวย สนใจเจาะลึกมิติตัวละครหรือเคมีคู่กับพานเยว่คะ?');
+    assert.deepEqual(questions[0].options, ['มิติตัวละครหยางไฉ่เวย', 'เคมีคู่พานเยว่', 'เบื้องหลังการถ่ายทำ']);
+    assert.equal(questions[1].category, 'scene_highlight');
+  });
+
+  it('synthesizes music-specific dynamic questions without redundant drama vs song asking', async () => {
+    const questions = await generateClarifyingQuestions('อยากฟังเพลงของเสี่ยวจวี แนะนำหน่อย', 'th', {});
+    assert.ok(questions.length > 0);
+    const categories = questions.map(q => q.category);
+    assert.ok(categories.includes('music_aspect') || categories.includes('stage_vibe') || categories.includes('subject_focus'));
+    assert.ok(!categories.includes('media_type'), 'Should not ask if user wants drama or music when they asked for songs');
+  });
+
+  it('synthesizes drama-specific dynamic questions without redundant drama vs song asking', async () => {
+    const questions = await generateClarifyingQuestions('แนะนำซีรีส์น่าดูของจวีจิ้งอีหน่อย', 'th', {});
+    assert.ok(questions.length > 0);
+    const categories = questions.map(q => q.category);
+    assert.ok(categories.includes('drama_genre') || categories.includes('drama_aspect') || categories.includes('subject_focus'));
+    assert.ok(!categories.includes('media_type'), 'Should not ask if user wants drama or music when they asked for dramas');
+  });
+
+  it('synthesizes fashion-specific dynamic questions for brand queries', async () => {
+    const questions = await generateClarifyingQuestions('จวีจิ้งอีกับเครื่องประดับ FRED Paris เป็นยังไงบ้าง', 'th', {});
+    assert.ok(questions.length > 0);
+    const categories = questions.map(q => q.category);
+    assert.ok(categories.includes('fashion_aspect') || categories.includes('subject_focus'));
+    assert.ok(!categories.includes('media_type'));
+  });
+});