kiku-agent 1.0.11 → 1.2.0

package/server/agent/memory.js

@@ -1,23 +1,27 @@
 import { promises as fs } from 'node:fs';
 import path from 'node:path';
-import { EXPORT_DIR, KIKU_DATA_DIR, SESSION_DIR } from './appPaths.js';
+import { EXPORT_DIR, KIKU_DATA_DIR, SESSION_DIR } from './appPaths.js';
+import { redactSensitiveValue } from './session.js';
 
 const MEMORY_DIR = KIKU_DATA_DIR;
 const MEMORY_FILE = path.join(MEMORY_DIR, 'long_term_memory.json');
 const SESSIONS_DIR = SESSION_DIR;
 
 
-export class AgentMemory {
-  constructor() {
+export class AgentMemory {
+  constructor(options = {}) {
+    this.persistenceEnabled = options.persistence !== false;
+    this.storageFile = options.storageFile ? path.resolve(String(options.storageFile)) : MEMORY_FILE;
     this.facts = [];
     this.preferences = {
       language: null,          
       topicsOfInterest: [],    
-      responseStyle: 'default', 
-      userSkills: [],
-      skillsEnabled: true,
-      favorites: [],
-    };
+      responseStyle: 'default', 
+      userSkills: [],
+      skillsEnabled: true,
+      favorites: [],
+      learnedStyles: [],
+    };
     this.sessions = [];         
     this.summaries = [];       
     this.stats = {
@@ -31,215 +35,229 @@ export class AgentMemory {
     this._storageWarningShown = false;
     this._storageError = null;
   }
-
-
-  async init() {
-    try {
-      await fs.mkdir(MEMORY_DIR, { recursive: true, mode: 0o700 });
-      await fs.mkdir(SESSIONS_DIR, { recursive: true, mode: 0o700 });
-      this._storageError = null;
-      return true;
-    } catch (error) {
-      this._storageError = error;
-      this._warnStorage(error);
-      return false;
-    }
-  }
-
-  _warnStorage(error) {
-    if (this._storageWarningShown) return;
-    this._storageWarningShown = true;
-    console.error(`Kiku memory is running without persistence (${error?.code || 'unknown'}) in ${MEMORY_DIR}. Set KIKU_DATA_DIR to a writable user folder; Administrator privileges are not required.`);
-  }
-
-  
-  async load() {
-    try {
-      await this.init();
-      const data = await fs.readFile(MEMORY_FILE, 'utf-8');
-      const parsed = JSON.parse(data);
-      
-     
-      this.facts = (parsed.facts || []).map(f => ({
-        ...f,
-        createdAt: f.createdAt ? new Date(f.createdAt) : new Date(),
-        lastAccessedAt: f.lastAccessedAt ? new Date(f.lastAccessedAt) : new Date()
-      }));
-      
+
+
+  async init() {
+    if (!this.persistenceEnabled) {
+      this._loaded = true;
+      return true;
+    }
+    try {
+      await fs.mkdir(MEMORY_DIR, { recursive: true, mode: 0o700 });
+      await fs.mkdir(SESSIONS_DIR, { recursive: true, mode: 0o700 });
+      this._storageError = null;
+      return true;
+    } catch (error) {
+      this._storageError = error;
+      this._warnStorage(error);
+      return false;
+    }
+  }
+
+  _warnStorage(error) {
+    if (this._storageWarningShown) return;
+    this._storageWarningShown = true;
+    console.error(`Kiku memory is running without persistence (${error?.code || 'unknown'}) in ${MEMORY_DIR}. Set KIKU_DATA_DIR to a writable user folder; Administrator privileges are not required.`);
+  }
+
+  async load() {
+    if (!this.persistenceEnabled) {
+      this._loaded = true;
+      return false;
+    }
+    try {
+      await this.init();
+      const data = await fs.readFile(this.storageFile, 'utf-8');
+      const parsed = JSON.parse(data);
+      
+     
+      this.facts = (parsed.facts || []).map(f => ({
+        ...f,
+        createdAt: f.createdAt ? new Date(f.createdAt) : new Date(),
+        lastAccessedAt: f.lastAccessedAt ? new Date(f.lastAccessedAt) : new Date()
+      }));
+      
       const loadedPrefs = parsed.preferences || {};
       this.preferences = {
         ...this.preferences,
-        ...loadedPrefs,
-        userSkills: Array.isArray(loadedPrefs.userSkills) ? loadedPrefs.userSkills : [],
+        ...loadedPrefs,
+        userSkills: Array.isArray(loadedPrefs.userSkills) ? loadedPrefs.userSkills : [],
+        learnedStyles: Array.isArray(loadedPrefs.learnedStyles) ? loadedPrefs.learnedStyles : [],
         favorites: Array.isArray(loadedPrefs.favorites) ? loadedPrefs.favorites : [],
         topicsOfInterest: (loadedPrefs.topicsOfInterest || []).map(t => ({
-          ...t,
-          lastSeen: t.lastSeen ? new Date(t.lastSeen) : new Date()
-        }))
-      };
-      
-      this.sessions = parsed.sessions || [];
-      this.summaries = parsed.summaries || [];
-      this.stats = { ...this.stats, ...(parsed.stats || {}) };
-      this._loaded = true;
-      return true;
-    } catch {
-      this._loaded = true;
-      return false;
-    }
-  }
-
-
-  async save() {
-    try {
-      if (!await this.init()) return false;
-      
-      const serializablePrefs = {
-        ...this.preferences,
-        topicsOfInterest: (this.preferences.topicsOfInterest || []).map(t => ({
-          ...t,
-          lastSeen: t.lastSeen ? t.lastSeen.toISOString() : null
-        }))
-      };
-      const data = {
-        facts: this.facts.map(f => ({
-          ...f,
-          createdAt: f.createdAt ? f.createdAt.toISOString() : f.createdAt,
-          lastAccessedAt: f.lastAccessedAt ? f.lastAccessedAt.toISOString() : f.lastAccessedAt
-        })),
-        preferences: serializablePrefs,
-        sessions: this.sessions,
-        summaries: this.summaries,
-        stats: this.stats,
-        lastSavedAt: new Date().toISOString()
-      };
-      await fs.writeFile(MEMORY_FILE, JSON.stringify(data, null, 2), 'utf-8');
-      return true;
-    } catch (error) {
-      this._warnStorage(error);
-      return false;
-    }
-  }
-
-  addFact(fact, meta = {}) {
-    const entry = {
-      id: `fact_${Date.now()}_${Math.random().toString(36).slice(2, 6)}`,
-      content: fact,
-      category: meta.category || 'general',
-      source: meta.source || 'conversation',
-      confidence: meta.confidence || 'high',
-      createdAt: new Date(),
-      lastAccessedAt: new Date(),
-      accessCount: 0,
-      tags: meta.tags || []
-    };
-    this.facts.push(entry);
-    this.stats.totalFacts = this.facts.length;
-    this.save().catch(() => {});
-    return entry;
-  }
-
- 
-  scoreFactRelevance(fact, queryTerms = [], now = Date.now()) {
-    if (!fact) return 0;
-    const content = (fact.content || '').toLowerCase();
-    const tags = (fact.tags || []).map(t => String(t).toLowerCase());
-
-    let matchScore = 0;
-    if (queryTerms.length > 0) {
-      for (const term of queryTerms) {
-        if (!term || term.length < 2) continue;
-        if (tags.some(t => t.includes(term))) matchScore += 3.0;
-        if (content.includes(term)) matchScore += 2.0;
-      }
-    } else {
-      matchScore = 1.0;
-    }
-
-    const createdTime = fact.createdAt ? new Date(fact.createdAt).getTime() : now;
-    const ageInDays = Math.max(0, (now - createdTime) / (1000 * 60 * 60 * 24));
-    const recencyDecay = Math.exp(-ageInDays / 45);
-
-    const accessBoost = Math.log10(1 + (fact.accessCount || 0) * 2);
-
-    return (matchScore * (0.6 + 0.4 * recencyDecay)) + accessBoost;
-  }
-
-  getRelevantFacts(query = '', limit = 8) {
-    if (!this.facts || this.facts.length === 0) return [];
-    const q = String(query || '').toLowerCase().trim();
-    const terms = q ? q.split(/\s+/).filter(t => t.length >= 2) : [];
-    const now = Date.now();
-
-    const scored = this.facts.map(fact => ({
-      fact,
-      score: this.scoreFactRelevance(fact, terms, now)
-    }));
-
-    scored.sort((a, b) => b.score - a.score);
-    const top = scored.slice(0, limit).map(s => s.fact);
-
-    for (const f of top) {
-      f.lastAccessedAt = new Date();
-      f.accessCount = (f.accessCount || 0) + 1;
-    }
-    return top;
-  }
-
-  searchFacts(query, options = {}) {
-    const { category, limit = 10 } = options;
-    const q = (query || '').toLowerCase().trim();
-    
-    let results = this.facts;
-    
-    if (category) {
-      results = results.filter(f => f.category === category);
-    }
-    
-    if (q) {
-      results = results.filter(f => 
-        f.content.toLowerCase().includes(q) ||
-        f.tags.some(t => t.toLowerCase().includes(q))
-      );
-    }
-
-    const terms = q ? q.split(/\s+/).filter(t => t.length >= 2) : [];
-    const now = Date.now();
-
-    results.sort((a, b) => {
-      const scoreA = this.scoreFactRelevance(a, terms, now);
-      const scoreB = this.scoreFactRelevance(b, terms, now);
-      return scoreB - scoreA;
-    });
-
-    for (const fact of results.slice(0, limit)) {
-      fact.lastAccessedAt = new Date();
-      fact.accessCount = (fact.accessCount || 0) + 1;
-    }
-
-    return results.slice(0, limit);
-  }
-
-  removeFact(factId) {
-    const idx = this.facts.findIndex(f => f.id === factId);
-    if (idx === -1) return false;
-    this.facts.splice(idx, 1);
-    this.stats.totalFacts = this.facts.length;
-    this.save().catch(() => {});
-    return true;
-  }
-
-  
-  getFactsByCategory() {
-    const grouped = {};
-    for (const fact of this.facts) {
-      const cat = fact.category || 'general';
-      if (!grouped[cat]) grouped[cat] = [];
-      grouped[cat].push(fact);
-    }
-    return grouped;
-  }
-
+          ...t,
+          lastSeen: t.lastSeen ? new Date(t.lastSeen) : new Date()
+        }))
+      };
+      
+      this.sessions = parsed.sessions || [];
+      this.summaries = parsed.summaries || [];
+      this.stats = { ...this.stats, ...(parsed.stats || {}) };
+      this._loaded = true;
+      return true;
+    } catch {
+      this._loaded = true;
+      return false;
+    }
+  }
+
+  async save() {
+    if (!this.persistenceEnabled) return false;
+    try {
+      if (!await this.init()) return false;
+      
+      const serializablePrefs = {
+        ...this.preferences,
+        topicsOfInterest: (this.preferences.topicsOfInterest || []).map(t => ({
+          ...t,
+          lastSeen: t.lastSeen ? t.lastSeen.toISOString() : null
+        }))
+      };
+      const data = {
+        facts: this.facts.map(f => ({
+          ...f,
+          createdAt: f.createdAt ? f.createdAt.toISOString() : f.createdAt,
+          lastAccessedAt: f.lastAccessedAt ? f.lastAccessedAt.toISOString() : f.lastAccessedAt
+        })),
+        preferences: serializablePrefs,
+        sessions: this.sessions,
+        summaries: this.summaries,
+        stats: this.stats,
+        lastSavedAt: new Date().toISOString()
+      };
+      await fs.writeFile(this.storageFile, JSON.stringify(data, null, 2), { encoding: 'utf-8', mode: 0o600 });
+      return true;
+    } catch (error) {
+      this._warnStorage(error);
+      return false;
+    }
+  }
+
+  addFact(fact, meta = {}) {
+    const entry = {
+      id: `fact_${Date.now()}_${Math.random().toString(36).slice(2, 6)}`,
+      content: fact,
+      category: meta.category || 'general',
+      source: meta.source || 'conversation',
+      confidence: meta.confidence || 'high',
+      createdAt: new Date(),
+      lastAccessedAt: new Date(),
+      accessCount: 0,
+      tags: meta.tags || []
+    };
+    this.facts.push(entry);
+    this.stats.totalFacts = this.facts.length;
+    this.save().catch(() => {});
+    return entry;
+  }
+
+  scoreFactRelevance(fact, queryTerms = [], now = Date.now()) {
+    if (!fact) return 0;
+    const content = (fact.content || '').toLowerCase();
+    const tags = (fact.tags || []).map(t => String(t).toLowerCase());
+    const category = (fact.category || '').toLowerCase();
+
+    let matchScore = 0;
+    if (queryTerms.length > 0) {
+      for (const term of queryTerms) {
+        if (!term || term.length < 2) continue;
+        const termLenBonus = Math.min(2.0, term.length / 4);
+
+        if (tags.includes(term)) {
+          matchScore += 5.0 * termLenBonus;
+        } else if (tags.some(t => t.includes(term))) {
+          matchScore += 3.0 * termLenBonus;
+        }
+
+        if (category === term || category.includes(term)) {
+          matchScore += 2.5;
+        }
+
+        const wordRegex = new RegExp(`\\b${term.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`, 'i');
+        if (wordRegex.test(content)) {
+          matchScore += 3.5 * termLenBonus;
+        } else if (content.includes(term)) {
+          matchScore += 1.8 * termLenBonus;
+        }
+      }
+    } else {
+      matchScore = 1.0;
+    }
+
+    const createdTime = fact.createdAt ? new Date(fact.createdAt).getTime() : now;
+    const ageInDays = Math.max(0, (now - createdTime) / (1000 * 60 * 60 * 24));
+    const recencyDecay = Math.exp(-ageInDays / 45);
+
+    const accessBoost = Math.log10(1 + (fact.accessCount || 0) * 2);
+    const confidenceWeight = typeof fact.confidence === 'number' ? Math.max(0.5, Math.min(1.5, fact.confidence)) : 1.0;
+
+    return ((matchScore * confidenceWeight) * (0.6 + 0.4 * recencyDecay)) + accessBoost;
+  }
+
+  getRelevantFacts(query = '', limit = 8) {
+    if (!this.facts || this.facts.length === 0) return [];
+    const q = String(query || '').toLowerCase().trim();
+    const terms = q ? q.split(/\s+/).filter(t => t.length >= 2) : [];
+    const now = Date.now();
+
+    const scored = this.facts.map(fact => ({
+      fact,
+      score: this.scoreFactRelevance(fact, terms, now)
+    }));
+
+    scored.sort((a, b) => b.score - a.score);
+    const top = scored.slice(0, limit).map(s => s.fact);
+
+    for (const f of top) {
+      f.lastAccessedAt = new Date();
+      f.accessCount = (f.accessCount || 0) + 1;
+    }
+    return top;
+  }
+
+  searchFacts(query, options = {}) {
+    const { category, limit = 10 } = options;
+    const q = (query || '').toLowerCase().trim();
+    
+    let results = this.facts;
+    
+    if (category) {
+      results = results.filter(f => f.category === category);
+    }
+    
+    if (q) {
+      results = results.filter(f => 
+        f.content.toLowerCase().includes(q) ||
+        f.tags.some(t => t.toLowerCase().includes(q))
+      );
+    }
+
+    const terms = q ? q.split(/\s+/).filter(t => t.length >= 2) : [];
+    const now = Date.now();
+
+    results.sort((a, b) => {
+      const scoreA = this.scoreFactRelevance(a, terms, now);
+      const scoreB = this.scoreFactRelevance(b, terms, now);
+      return scoreB - scoreA;
+    });
+
+    for (const fact of results.slice(0, limit)) {
+      fact.lastAccessedAt = new Date();
+      fact.accessCount = (fact.accessCount || 0) + 1;
+    }
+
+    return results.slice(0, limit);
+  }
+
+  removeFact(factId) {
+    const idx = this.facts.findIndex(f => f.id === factId);
+    if (idx === -1) return false;
+    this.facts.splice(idx, 1);
+    this.stats.totalFacts = this.facts.length;
+    this.save().catch(() => {});
+    return true;
+  }
+
   setPreference(key, value) {
     this.preferences[key] = value;
     this.save().catch(() => {});
@@ -344,6 +362,28 @@ export class AgentMemory {
     return this.preferences.userSkills.map((skill, index) => `${index + 1}. ${skill.instruction}`).join('\n');
   }
 
+  applyFeedbackDirectives(directives = []) {
+    const clean = (Array.isArray(directives) ? directives : [])
+      .filter(d => d && typeof d.text === 'string' && d.text.trim())
+      .slice(0, 6)
+      .map(d => ({
+        id: String(d.id || '').slice(0, 60),
+        kind: d.kind === 'avoid' ? 'avoid' : 'prefer',
+        text: String(d.text).replace(/\s+/g, ' ').trim().slice(0, 200),
+        support: Number.isFinite(Number(d.support)) ? Number(d.support) : 0,
+        updatedAt: d.updatedAt || new Date().toISOString(),
+      }));
+    this.preferences.learnedStyles = clean;
+    this.save().catch(() => {});
+    return clean;
+  }
+
+  buildFeedbackStyleContext() {
+    const styles = Array.isArray(this.preferences.learnedStyles) ? this.preferences.learnedStyles : [];
+    if (styles.length === 0) return '';
+    return styles.map(s => `- ${s.text}`).join('\n');
+  }
+
   
   async savePreferences() {
     await this.save();
@@ -376,7 +416,8 @@ export class AgentMemory {
   }
 
   
-  async archiveSession(sessionData) {
+  async archiveSession(sessionData) {
+    if (!this.persistenceEnabled) return null;
     const archive = {
       id: sessionData.id,
       createdAt: sessionData.createdAt,
@@ -391,8 +432,10 @@ export class AgentMemory {
     let archivedToDisk = false;
     try {
       if (!await this.init()) return null;
-      const sessionFile = path.join(SESSIONS_DIR, `${sessionData.id}.json`);
-      await fs.writeFile(sessionFile, JSON.stringify(sessionData, null, 2), 'utf-8');
+      const safeId = String(sessionData.id || '').replace(/[^a-zA-Z0-9_-]/g, '').slice(0, 100);
+      if (!safeId) return null;
+      const sessionFile = path.join(SESSIONS_DIR, `${safeId}.json`);
+      await fs.writeFile(sessionFile, JSON.stringify(redactSensitiveValue(sessionData), null, 2), { encoding: 'utf-8', mode: 0o600 });
       archivedToDisk = true;
     } catch (err) {
       this._warnStorage(err);
@@ -412,9 +455,12 @@ export class AgentMemory {
       .slice(0, limit);
   }
 
-  async loadArchivedSession(sessionId) {
-    try {
-      const sessionFile = path.join(SESSIONS_DIR, `${sessionId}.json`);
+  async loadArchivedSession(sessionId) {
+    if (!this.persistenceEnabled) return null;
+    try {
+      const safeId = String(sessionId || '').replace(/[^a-zA-Z0-9_-]/g, '').slice(0, 100);
+      if (!safeId) return null;
+      const sessionFile = path.join(SESSIONS_DIR, `${safeId}.json`);
       const data = await fs.readFile(sessionFile, 'utf-8');
       return JSON.parse(data);
     } catch {
@@ -507,7 +553,7 @@ export class AgentMemory {
   }
 
 
-  buildMemoryContext(currentQuery = '') {
+  buildMemoryContext(currentQuery = '') {
     const parts = [];
 
     if (this.preferences.language) {
@@ -519,6 +565,11 @@ export class AgentMemory {
       parts.push(`User-taught response skills (follow these preferences unless they conflict with safety or verified facts):\n${userSkillContext}`);
     }
 
+    const feedbackStyleContext = this.buildFeedbackStyleContext();
+    if (feedbackStyleContext) {
+      parts.push(`Learned answer-style preferences (distilled from this user's like/dislike feedback — answer this way unless it conflicts with safety or verified facts):\n${feedbackStyleContext}`);
+    }
+
     const topTopics = this.getTopTopics(5);
     if (topTopics.length > 0) {
       const topicList = topTopics.map(t => `${t.topic} (${t.count}x)`).join(', ');
@@ -545,10 +596,18 @@ export class AgentMemory {
 
     if (parts.length === 0) return '';
 
-    return `\n\n=== LONG-TERM MEMORY CONTEXT ===\n${parts.join('\n\n')}\n=== END MEMORY CONTEXT ===`;
-  }
-
-  getStatus() {
+    return `\n\n=== LONG-TERM MEMORY CONTEXT ===\n${parts.join('\n\n')}\n=== END MEMORY CONTEXT ===`;
+  }
+
+  getFactsByCategory() {
+    return this.facts.reduce((counts, fact) => {
+      const category = String(fact?.category || 'general');
+      counts[category] = (counts[category] || 0) + 1;
+      return counts;
+    }, {});
+  }
+
+  getStatus() {
     return {
       factsCount: this.facts.length,
       factsByCategory: this.getFactsByCategory(),
@@ -726,7 +785,7 @@ export class AgentMemory {
 
   async getStorageSize() {
     try {
-      const stat = await fs.stat(MEMORY_FILE);
+      const stat = await fs.stat(this.storageFile);
       return stat.size;
     } catch {
       return 0;