kibi-cursor 2.8.2 → 2.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.cursor-plugin/plugin.json +1 -1
- package/CHANGELOG.md +40 -0
- package/README.md +3 -3
- package/agent-plugin/plugin.json +1 -1
- package/agent-plugin/skills/kibi-commit-review/SKILL.md +125 -0
- package/agent-plugin/skills/kibi-commit-review/resources/staged-gate.md +98 -0
- package/agent-plugin/skills/kibi-decisions/SKILL.md +130 -0
- package/agent-plugin/skills/kibi-decisions/resources/decision-records.md +142 -0
- package/agent-plugin/skills/kibi-decisions/resources/signoff-views.md +66 -0
- package/agent-plugin/skills/kibi-freshness/SKILL.md +2 -0
- package/agent-plugin/skills/kibi-traceability/SKILL.md +4 -0
- package/agent-plugin/skills/kibi-usage/SKILL.md +20 -15
- package/commands/kibi-signoff.md +26 -0
- package/dist/.cursor-plugin/plugin.json +1 -1
- package/dist/commands/kibi-signoff.md +26 -0
- package/dist/hook-runner.js +14 -7
- package/dist/skills/.canon-hash.json +8 -3
- package/dist/skills/kibi-commit-review/SKILL.md +125 -0
- package/dist/skills/kibi-commit-review/resources/staged-gate.md +98 -0
- package/dist/skills/kibi-decisions/SKILL.md +130 -0
- package/dist/skills/kibi-decisions/resources/decision-records.md +142 -0
- package/dist/skills/kibi-decisions/resources/signoff-views.md +66 -0
- package/dist/skills/kibi-freshness/SKILL.md +2 -0
- package/dist/skills/kibi-traceability/SKILL.md +4 -0
- package/dist/skills/kibi-usage/SKILL.md +20 -15
- package/package.json +2 -2
- package/skills/.canon-hash.json +8 -3
- package/skills/kibi-commit-review/SKILL.md +125 -0
- package/skills/kibi-commit-review/resources/staged-gate.md +98 -0
- package/skills/kibi-decisions/SKILL.md +130 -0
- package/skills/kibi-decisions/resources/decision-records.md +142 -0
- package/skills/kibi-decisions/resources/signoff-views.md +66 -0
- package/skills/kibi-freshness/SKILL.md +2 -0
- package/skills/kibi-traceability/SKILL.md +4 -0
- package/skills/kibi-usage/SKILL.md +20 -15
|
@@ -0,0 +1,66 @@
|
|
|
1
|
+
# Signoff views
|
|
2
|
+
|
|
3
|
+
`kibi signoff` renders what a person signs off, so the agent never retypes
|
|
4
|
+
requirement text from memory. It is a CLI command, not an MCP tool.
|
|
5
|
+
|
|
6
|
+
| View | Command | When |
|
|
7
|
+
| --- | --- | --- |
|
|
8
|
+
| Decisions to confirm | `kibi signoff --questions <file or ->` | Mid-work: rules to record as firm, a change to a recorded rule, a conflict |
|
|
9
|
+
| Requirements signoff | `kibi signoff` (`--staged` for the index) | End of work: before asking to commit |
|
|
10
|
+
|
|
11
|
+
Both print plain Markdown by default (`--format chat`): headings, quoted
|
|
12
|
+
statements and lists that render in any chat or messaging surface. Put it in
|
|
13
|
+
your reply unchanged: never wrap it in a code block, summarize it or retell a
|
|
14
|
+
requirement in your own words. Every run also writes
|
|
15
|
+
`.kb/briefs/signoff/latest.json`, `latest.md` and `latest.html` (git-ignored);
|
|
16
|
+
`latest.html` is a self-contained page with the full view.
|
|
17
|
+
|
|
18
|
+
## Showing it on your host
|
|
19
|
+
|
|
20
|
+
| Host | Best view |
|
|
21
|
+
| --- | --- |
|
|
22
|
+
| Claude Code, Codex, Cursor, ZCode, VS Code chat | Paste the default output; `/kibi-signoff` (Claude Code, Cursor, ZCode) runs it. Offer `kibi signoff --format html --open` for the page |
|
|
23
|
+
| OpenCode terminal | `kibi signoff --format md` and paste the fenced block unchanged: kibi-opencode draws it as a card, and `/kibi-signoff` reopens it |
|
|
24
|
+
| Replies sent through a messaging tool (cloud or project threads, chat bots) | Pass the default output as the message text, and attach or publish `.kb/briefs/signoff/latest.html` next to it when the tool can carry a file or a page |
|
|
25
|
+
| VS Code or Cursor with the kibi-vscode extension | The **Kibi: Show Requirements Signoff** panel follows every run |
|
|
26
|
+
| Remote machine, no browser | Give the person the path of `latest.html` |
|
|
27
|
+
|
|
28
|
+
`--format md` wraps the same Markdown in a ```` ```kibi-signoff ```` or
|
|
29
|
+
```` ```kibi-questions ```` fence for host renderers; use it only where one
|
|
30
|
+
draws it, because everywhere else a fence shows as raw code.
|
|
31
|
+
`KIBI_SIGNOFF_FORMAT` sets the default for a host. `--format html --open`
|
|
32
|
+
writes and opens the page; `--format json` prints the view.
|
|
33
|
+
|
|
34
|
+
## Questions input
|
|
35
|
+
|
|
36
|
+
`{"questions":[...]}` or a bare array. Each question:
|
|
37
|
+
|
|
38
|
+
| Field | Required | Meaning |
|
|
39
|
+
| --- | --- | --- |
|
|
40
|
+
| `statement` | yes | The rule as it would be recorded |
|
|
41
|
+
| `title` | no | A short name for the card |
|
|
42
|
+
| `id` | no | The recorded requirement the question would change; the view quotes its current statement and firmness |
|
|
43
|
+
| `quote` | no | The person's words that would go in `origin.ref` |
|
|
44
|
+
| `firmness` | no | `firm`, `default` or `exploratory`, as it would be recorded |
|
|
45
|
+
| `governs` | no | Files or symbols the rule governs |
|
|
46
|
+
| `conflictsWith` | no | Recorded requirement ids it conflicts with; the view quotes them |
|
|
47
|
+
| `question` | no | What you ask, when it is more than "record this?" |
|
|
48
|
+
| `answer` | no | The person's answer; answered questions are struck out |
|
|
49
|
+
|
|
50
|
+
The person answers by number ("1 yes, 2 exploratory, 3 reword: ..."). Copy
|
|
51
|
+
each answer into `answer`, render again, and record the rules only once every
|
|
52
|
+
question is answered. An answer is the person's words: quote it in
|
|
53
|
+
`origin.ref`; a view itself is never an approval.
|
|
54
|
+
|
|
55
|
+
## Summary contents
|
|
56
|
+
|
|
57
|
+
| Section | Meaning |
|
|
58
|
+
| --- | --- |
|
|
59
|
+
| New | Requirement documents the change adds |
|
|
60
|
+
| Changed | Rewritten requirements; a changed statement shows before and after |
|
|
61
|
+
| Affected by the code change | Unchanged requirements whose implementing code changed (the `requirement_statement_unverified` set) |
|
|
62
|
+
| Superseded or retired | Requirements the change retires, supersedes or deletes |
|
|
63
|
+
|
|
64
|
+
Each requirement shows its firmness, origin, superseded rules, changed code
|
|
65
|
+
symbols, scenarios and proof state (the earliest unmet proof gate). Parts
|
|
66
|
+
Kibi could not compute are named in a `Note:` line instead of failing.
|
|
@@ -53,6 +53,8 @@ echo '{}' | npx --no-install kibi status --input -
|
|
|
53
53
|
`committed_with_repairs`, follow required typed `nextActions`; never retry the
|
|
54
54
|
original operation.
|
|
55
55
|
|
|
56
|
+
For every freshness, branch, or completion question, call `kb_status` first, then `kb_query` the entities and source files that status names, then `kb_check` as the last Kibi call before answering. Never skip the query step, even when status alone seems to answer the question. If another query or write follows a check, run `kb_check` again before answering. When asked whether requirements are consistent or proven, run `kb_query`, then `kb_check` with the domain-contradictions rule, then `kb_coverage`, and read whether the analysis was complete. Report any unmodeled or unknown clause as incomplete analysis, not as consistent. Only when every clause is fully modeled and compatible, state plainly that no conflict was found. For authorized knowledge changes, keep the exact supplied target and intended relationship edges, and discover and query those targets first. Validate the payload with `kb_upsert` and `dryRun: true`, then perform the authorized `kb_upsert` with that same payload and read the result back exactly before the final checks. A passing dry run is validation, not completion. Distinct authorized payloads may need several sequential writes, each validated and read back, but never retry a mutation that already committed. If a mutation returns `committed_with_repairs`, follow its typed `nextActions` instead of repeating the original operation.
|
|
57
|
+
|
|
56
58
|
## Guidance
|
|
57
59
|
|
|
58
60
|
- Treat MCP and the trusted project-local CLI as equal peer surfaces.
|
|
@@ -29,6 +29,8 @@ interfaces. Select the surface by capability; neither is semantically preferred.
|
|
|
29
29
|
For CLI JSON, use a dedicated route such as
|
|
30
30
|
`printf '%s\n' '{}' | kibi status --input -`.
|
|
31
31
|
|
|
32
|
+
For every traceability answer, begin with `kb_search` even when an identifier is already named, then exact-filter with `kb_query`, inspect relationships with `kb_graph`, and make `kb_status` the final Kibi call, including after `kb_graph` or `kb_coverage`; report no conclusions until that closing `kb_status` returns. When judging scenario feasibility, ground each step in the queried requirements, scenarios, tests, and symbols, and state missing links, ambiguity, or stale evidence explicitly rather than inferring them. For authorized coverage or link work, keep the exact supplied target and intended edges, discover and query those targets, then validate the payload with `kb_upsert` and `dryRun: true`. A passing dry run is only validation, not completion: next perform the real `kb_upsert` with the same payload, exact-read the result back with `kb_query`, run `kb_check` and `kb_coverage`, report the resulting proof state, and finish with `kb_status`. Distinct authorized payloads may each need their own sequential dry run and write, so there is no single-write limit, but never retry a mutation that already committed; on `committed_with_repairs`, execute the typed repair action instead.
|
|
33
|
+
|
|
32
34
|
## Workflow
|
|
33
35
|
|
|
34
36
|
Use the visible approved MCP tools or trusted project-local CLI as equal peer
|
|
@@ -50,6 +52,8 @@ plan_returned` with a hash-bound plan whose `nextActions[0].input` is the exact
|
|
|
50
52
|
through a new requirement linked with `supersedes`. Relationship deletes patch
|
|
51
53
|
shards while preserving unrelated records.
|
|
52
54
|
|
|
55
|
+
For executable coverage work, keep the production symbol's implements link to its requirement and link that same production symbol to its qualifying test with covered_by; reserve executable_for for a symbol that stands for the executable test itself, and never put executable_for on a symbol that also carries production ownership or coverage. Preserve the exact supplied target and intended edges, discover and query those targets, validate the payload with `kb_upsert` and `dryRun: true`, then perform the authorized real `kb_upsert` with the same payload and exact-read the result with `kb_query` before final checks, because validation alone is not completion. A passing dry run does not guarantee the commit: if the real `kb_upsert` returns an error, read its message and correct only the conflicting relationship on the same target rather than working around it with a new entity, then validate again with `dryRun: true`, write again, and exact-read it back. Distinct authorized payloads may each need their own sequential validation and write, so there is no single write limit, but never retry a mutation that already committed; on `committed_with_repairs`, execute the typed repair action instead. Then run `kb_check` and `kb_coverage`, report the proof and verification state they return, treating a dirty verification snapshot after a write as expected rather than as a failure, and finish with `kb_status`.
|
|
56
|
+
|
|
53
57
|
## Typed recovery and proof
|
|
54
58
|
|
|
55
59
|
Parse `kibiProtocol`, `resultVersion`, `status`, `effects`, diagnostics, and
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
id: kibi-usage
|
|
3
3
|
name: Kibi Usage
|
|
4
4
|
description: Use Kibi's source-first, exact-Git, migration-aware, proof-aware operations safely across MCP or the trusted local CLI, including partial completion repair.
|
|
5
|
-
version: 2.
|
|
5
|
+
version: 2.22.0
|
|
6
6
|
kibiCompatibility: ">=1.0.0"
|
|
7
7
|
tags:
|
|
8
8
|
- kibi
|
|
@@ -121,6 +121,10 @@ component that renders it) with `implements` through `kb_upsert`. Without a read
|
|
|
121
121
|
still answers and `kibi sync` regenerates the manifest. The search tip and the
|
|
122
122
|
`.kb/` note appear once per session and need no action.
|
|
123
123
|
|
|
124
|
+
Before you edit a source file that Kibi tracks, run `kb_search` with that file in `sourceLocations`, and treat both its ranked results and its `data.answer` layer as discovery only, not as the governing text. Then call `kb_query` by `id` on each current governing requirement that the search names, read what each one requires, and make the edit only after those exact reads. A `kb_check`, `kb_status` or `kb_coverage` result does not replace that `kb_query` read. This rule only adds an exact read before the edit and does not change the order of any other step in this workflow. It adds nothing to a modeling or write task: that task still ends with the real `kb_upsert` of every planned fact and requirement and the closing `kb_check`.
|
|
125
|
+
|
|
126
|
+
For an edit that keeps the governing rule, limit the consultation before the edit to exactly two Kibi calls: `kb_search` with the file in `sourceLocations`, then one `kb_query` (by the governing requirement's `id`, or by `sourceFile` when several requirements govern the file). Do not start with `kb_status`, and do not repeat the search or the query before editing; run `kb_status`, `kb_check` and `kb_coverage` after the edit. This limit applies only to source edits. A task that models a claim keeps its full order, one step after the other: `kb_search`, then the exact `kb_query` of the supplied target, then `kb_model` with `mode: "analyze"` on the complete claim, then `mode: "predicates"` for each relational clause, then `kb_model` with `mode: "requirement"` for a strict or typed-rule clause, and only then the real `kb_upsert` of every planned fact and requirement and the closing `kb_check`. Never call `kb_model` before that exact `kb_query`, and never stop at a dry run.
|
|
127
|
+
|
|
124
128
|
## Safe workflow
|
|
125
129
|
|
|
126
130
|
1. Always discover before you mutate: start with `kb_search`, then exact-filter with `kb_query`. Use
|
|
@@ -356,7 +360,9 @@ authored. Each one is the order the write path accepts.
|
|
|
356
360
|
|
|
357
361
|
Entities record `origin` (`kind`: `human`, `agent`, `migration`, or `import`,
|
|
358
362
|
plus optional `ref` and `approved_by`). `kb_upsert` records `kind: agent` on
|
|
359
|
-
entities you create; leave `origin.approved_by` to the person who reviews them
|
|
363
|
+
entities you create; leave `origin.approved_by` to the person who reviews them,
|
|
364
|
+
and ask for that review with `kibi signoff` (see `kibi-decisions`), never with
|
|
365
|
+
a summary in your own words.
|
|
360
366
|
An exception (a requirement that `exempts` another) exempts nothing until a
|
|
361
367
|
human sets `approved_by`; `kb_check` flags approvals an agent recorded without
|
|
362
368
|
corroboration. Never fill in an approval yourself. Record why a requirement
|
|
@@ -365,6 +371,8 @@ exists in `rationale`, or link the ADR that explains it.
|
|
|
365
371
|
## Decision firmness
|
|
366
372
|
|
|
367
373
|
Requirements and ADRs carry `firmness`, which says what you may do with them.
|
|
374
|
+
Load `kibi-decisions` when a person states a rule, a hook asks before an edit
|
|
375
|
+
of firm code, or a request conflicts with a recorded rule.
|
|
368
376
|
Search answers, `kb_query` rows and hook snippets show it (snippets label only
|
|
369
377
|
`[firm: ask before changing]` and `[exploratory]`; an unlabeled decision is
|
|
370
378
|
`default`).
|
|
@@ -394,17 +402,12 @@ task or in reply: then supersede it with `firmness: firm` and `origin.ref` to
|
|
|
394
402
|
their words (or, for a correction they asked for in place, update it with
|
|
395
403
|
`origin.ref` to those words), and say in the final answer which rule changed.
|
|
396
404
|
|
|
397
|
-
Set `firmness` from what a human actually said: only their stated
|
|
398
|
-
`firm` (with `origin.ref`
|
|
399
|
-
guess is `exploratory`.
|
|
400
|
-
|
|
401
|
-
|
|
402
|
-
|
|
403
|
-
words): name the evidence (a failing test, a measured cost, a constraint the
|
|
404
|
-
old decision missed, a new requirement, the person's instruction) and answer
|
|
405
|
-
the old decision's reasoning; `kb_check` blocks it otherwise. A preference is
|
|
406
|
-
not evidence: propose it instead of superseding. Kibi checks only that a firm
|
|
407
|
-
decision has a reference; never cite words nobody said.
|
|
405
|
+
Set `firmness` explicitly from what a human actually said: only their stated
|
|
406
|
+
rule is `firm` (with `origin.ref` to their words); your own pick is `default`;
|
|
407
|
+
a guess is `exploratory`. A supersede needs a `## Why this changed` section of
|
|
408
|
+
at least 12 words naming the evidence; a preference is not evidence. Never
|
|
409
|
+
cite words nobody said. `kibi-decisions` has the recording and supersede
|
|
410
|
+
payloads.
|
|
408
411
|
|
|
409
412
|
Conditional clauses ("only when", "only if", "must not ... unless") compile
|
|
410
413
|
into typed `forbid` rules linked by `requires_rule`, not property facts; one
|
|
@@ -418,7 +421,8 @@ read `unresolved` as consistent. Compare the intent with each candidate's
|
|
|
418
421
|
`statement`, then compile again with `conflictReviews`
|
|
419
422
|
(`{requirementId, verdict: "conflict" | "no_conflict", note}`). On a conflict
|
|
420
423
|
the plan is `blocked`: ask the human which rule holds (a firm requirement is
|
|
421
|
-
theirs), then supersede or change it, or change the intent
|
|
424
|
+
theirs), then supersede or change it, or change the intent (see
|
|
425
|
+
`kibi-decisions`).
|
|
422
426
|
|
|
423
427
|
## Semantic and proof guardrails
|
|
424
428
|
|
|
@@ -558,4 +562,5 @@ retrying the same payload; inspect the typed error and `nextActions`.
|
|
|
558
562
|
Kibi may now author tracked Markdown/YAML evidence transactionally. The former
|
|
559
563
|
statement “Kibi operation writes do not automatically stage markdown evidence”
|
|
560
564
|
means Kibi writes do not Git-stage it: review and commit remain ordinary Git
|
|
561
|
-
workflows.
|
|
565
|
+
workflows. When `kibi check --staged` or the pre-commit hook blocks a commit,
|
|
566
|
+
load `kibi-commit-review`.
|
|
@@ -0,0 +1,26 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: kibi-signoff
|
|
3
|
+
description: Show the Kibi requirements signoff view for the current change, or the decisions waiting for the person
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Kibi signoff
|
|
7
|
+
|
|
8
|
+
Show the person what they sign off, quoted from the knowledge base rather than
|
|
9
|
+
retold from memory.
|
|
10
|
+
|
|
11
|
+
1. If decisions are waiting for the person (rules to record as firm, a change
|
|
12
|
+
to a recorded rule, a conflict), build the questions view as the
|
|
13
|
+
`kibi-decisions` skill describes (`resources/signoff-views.md`) and run
|
|
14
|
+
`npx --no-install kibi signoff --questions -` with the questions on stdin.
|
|
15
|
+
2. Otherwise run `npx --no-install kibi signoff` (add `--staged` for the
|
|
16
|
+
staged changes only).
|
|
17
|
+
3. Put the command's output in your reply unchanged. It is plain Markdown that
|
|
18
|
+
renders as headings, quotes and lists; do not wrap it in a code block or
|
|
19
|
+
summarize it.
|
|
20
|
+
4. Offer the full page too: `npx --no-install kibi signoff --format html --open`
|
|
21
|
+
opens it in the browser on this machine, and
|
|
22
|
+
`.kb/briefs/signoff/latest.html` is the same self-contained page to attach
|
|
23
|
+
when the person is not on this machine.
|
|
24
|
+
|
|
25
|
+
A view is never an approval: record a rule as approved only from the person's
|
|
26
|
+
answer, quoted in `origin.ref`.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "kibi-cursor",
|
|
3
3
|
"displayName": "Kibi",
|
|
4
|
-
"version": "2.
|
|
4
|
+
"version": "2.9.0",
|
|
5
5
|
"description": "Optional Cursor adapter for Kibi. Requires project-local kibi-cli, kibi-mcp, and kibi-core (SWI-Prolog is bundled on Linux and macOS) before the bundled MCP server can start.",
|
|
6
6
|
"license": "AGPL-3.0-or-later",
|
|
7
7
|
"author": {
|
|
@@ -0,0 +1,26 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: kibi-signoff
|
|
3
|
+
description: Show the Kibi requirements signoff view for the current change, or the decisions waiting for the person
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Kibi signoff
|
|
7
|
+
|
|
8
|
+
Show the person what they sign off, quoted from the knowledge base rather than
|
|
9
|
+
retold from memory.
|
|
10
|
+
|
|
11
|
+
1. If decisions are waiting for the person (rules to record as firm, a change
|
|
12
|
+
to a recorded rule, a conflict), build the questions view as the
|
|
13
|
+
`kibi-decisions` skill describes (`resources/signoff-views.md`) and run
|
|
14
|
+
`npx --no-install kibi signoff --questions -` with the questions on stdin.
|
|
15
|
+
2. Otherwise run `npx --no-install kibi signoff` (add `--staged` for the
|
|
16
|
+
staged changes only).
|
|
17
|
+
3. Put the command's output in your reply unchanged. It is plain Markdown that
|
|
18
|
+
renders as headings, quotes and lists; do not wrap it in a code block or
|
|
19
|
+
summarize it.
|
|
20
|
+
4. Offer the full page too: `npx --no-install kibi signoff --format html --open`
|
|
21
|
+
opens it in the browser on this machine, and
|
|
22
|
+
`.kb/briefs/signoff/latest.html` is the same self-contained page to attach
|
|
23
|
+
when the person is not on this machine.
|
|
24
|
+
|
|
25
|
+
A view is never an approval: record a rule as approved only from the person's
|
|
26
|
+
answer, quoted in `origin.ref`.
|
package/dist/hook-runner.js
CHANGED
|
@@ -3,7 +3,7 @@
|
|
|
3
3
|
import fs from "node:fs";
|
|
4
4
|
import path from "node:path";
|
|
5
5
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
6
|
-
import { captureReminder, claimCaptureReminder, confirmFirmEdits, firmEditNotice, firmRequirementsTouched, hasDecisionFlag, holdRuleNote, markDecisionFlag, recordRequest, settleFirmRequirements, settledFirmRequirements, takeRuleNote, } from "kibi-agent-core/decision-guard";
|
|
6
|
+
import { captureReminder, claimCaptureReminder, claimSignoffReminder, confirmFirmEdits, firmEditNotice, firmRequirementsTouched, hasDecisionFlag, holdRuleNote, isRequirementUpsert, markDecisionFlag, recordRequest, settleFirmRequirements, settledFirmRequirements, signoffReminder, takeRuleNote, } from "kibi-agent-core/decision-guard";
|
|
7
7
|
import { appendHookUsageRows, editTraces, hookTelemetryEnabled, kbUsageTrace, readPackageVersion, } from "kibi-agent-core/hook-usage-log";
|
|
8
8
|
import { stampKibiWorkspace } from "kibi-agent-core/kb-mcp-tools";
|
|
9
9
|
import { createEntitySummarizer, editFocus, fileKnowledgeSnippet, implementedRequirementIds, } from "kibi-agent-core/snippets";
|
|
@@ -299,6 +299,10 @@ export async function runHook(rawInput, environment = {}) {
|
|
|
299
299
|
kbUsageTrace(input.toolName, input.toolInput)?.kbOperation ===
|
|
300
300
|
"kb_upsert") {
|
|
301
301
|
markDecisionFlag(session, "kb-recorded");
|
|
302
|
+
// implements REQ-kibi-signoff-views
|
|
303
|
+
if (isRequirementUpsert(input.toolInput)) {
|
|
304
|
+
markDecisionFlag(session, "requirement-recorded");
|
|
305
|
+
}
|
|
302
306
|
}
|
|
303
307
|
const primaryPath = resolvePrimaryPath(input);
|
|
304
308
|
if (!primaryPath || !kibiReady) {
|
|
@@ -360,12 +364,15 @@ export async function runHook(rawInput, environment = {}) {
|
|
|
360
364
|
// implements REQ-agent-hosts-decision-guard
|
|
361
365
|
// Source changed and nothing was recorded: the follow-up asks for the
|
|
362
366
|
// decision to be recorded, once per conversation.
|
|
363
|
-
const
|
|
364
|
-
|
|
365
|
-
|
|
366
|
-
|
|
367
|
-
|
|
368
|
-
|
|
367
|
+
const capture = claimCaptureReminder(session)
|
|
368
|
+
? captureReminder(hasDecisionFlag(session, "rule-prompt"))
|
|
369
|
+
: undefined;
|
|
370
|
+
// implements REQ-kibi-signoff-views
|
|
371
|
+
// Requirements were written without a signoff view since: ask once.
|
|
372
|
+
const signoff = capture === undefined && claimSignoffReminder(session, cwd)
|
|
373
|
+
? signoffReminder()
|
|
374
|
+
: undefined;
|
|
375
|
+
const followupMessage = [capture, signoff, stopFollowupMessage(state)]
|
|
369
376
|
.filter((part) => part !== undefined)
|
|
370
377
|
.join("\n");
|
|
371
378
|
if (followupMessage) {
|
|
@@ -4,16 +4,21 @@
|
|
|
4
4
|
"kibi-bootstrap/resources/branch-lifecycle.md": "c854264ce888439140883a3fc636db5e522f020dd27b30a5c1ecc4105b64ed13",
|
|
5
5
|
"kibi-bootstrap/resources/operation-access.md": "b5a6a59e72d800c376e7fad79132897623c32a0ce152a1e8d73f9628b444db51",
|
|
6
6
|
"kibi-bootstrap/resources/source-authoring.md": "bf296e62f69474e01797d6cb9469bf624551dca834dd188abb6e705bd96fa586",
|
|
7
|
-
"kibi-
|
|
7
|
+
"kibi-commit-review/SKILL.md": "d593f4f879be9aec0ddcd4003612a97fe6fa64298602ff6922f780e2a3ba4152",
|
|
8
|
+
"kibi-commit-review/resources/staged-gate.md": "993e5a08ab2be5ccd95695ec5f7600cd32ef6d75d1a9b962202183aa05fec51f",
|
|
9
|
+
"kibi-decisions/SKILL.md": "384749d6a9196c978a6df5a0d89fffe1fab7bad9554bc77e6bc45282567c4184",
|
|
10
|
+
"kibi-decisions/resources/decision-records.md": "1244ab963f78cfd47fc88dc9700bbfdbe2fad8a0d84da1fb7c40d718ccca710a",
|
|
11
|
+
"kibi-decisions/resources/signoff-views.md": "f5de0c378de9094949b372485d6e1f06398eb1c60cd234077a89af312f3c9d07",
|
|
12
|
+
"kibi-freshness/SKILL.md": "f1ccfa35dae113d7b3b2a61c455c1791dbc79732972d4604fbb82e002ff3c836",
|
|
8
13
|
"kibi-freshness/resources/branch-lifecycle.md": "ebc01b19fe3dca8df5fc0175978963f6f1204f71f7c805cb2a5fb1b277ac78e4",
|
|
9
14
|
"kibi-freshness/resources/operation-access.md": "4e1db9294ee540cd29b8b3a2532a81e7894d5b4228b39e99ba48b37212f489f3",
|
|
10
15
|
"kibi-freshness/resources/source-authoring.md": "41a0547ce4d2a112a0f3671d36720f07c447864db3b473e94eb88a8ce2d371ff",
|
|
11
|
-
"kibi-traceability/SKILL.md": "
|
|
16
|
+
"kibi-traceability/SKILL.md": "f4ebc9a57dae6fcbc8fa467209b31a6c2fc9358ece4aa96189f6fa5e2c20ee21",
|
|
12
17
|
"kibi-traceability/resources/branch-lifecycle.md": "50f1a6355aa9185d412b2474db1a64e112944625d2465be0adbf93ada3273c1f",
|
|
13
18
|
"kibi-traceability/resources/operation-access.md": "39f7972ab7f4ae7479e78f7072bb50e8e6c4cdf4f857425f69d2522d37db437c",
|
|
14
19
|
"kibi-traceability/resources/source-authoring.md": "408c6ee2bef1b84e0194c0538ef929c26a0a617e631b2234247388140dbbdd08",
|
|
15
20
|
"kibi-traceability/resources/traceability.md": "38c290a0bc71bd1692e115f22694743946e2f69630e134acfd43cee5f613fb88",
|
|
16
|
-
"kibi-usage/SKILL.md": "
|
|
21
|
+
"kibi-usage/SKILL.md": "c95fc81dfed557a46353df0ec3e9ab3cdf7fda8f3cf0a0062aec57d839873d4f",
|
|
17
22
|
"kibi-usage/resources/branch-lifecycle.md": "f1bf359e9826e83c548f3cd0287f8175a62456527b0132b06b3f9f74aa59b7d6",
|
|
18
23
|
"kibi-usage/resources/fact-lanes.md": "899218f90396aa469b6e34aeb5f7ea1f38bf11bb326102319f376c213859fb33",
|
|
19
24
|
"kibi-usage/resources/kb-improvement.md": "a8408fce27342bdce6415a6718599e53fe00bb33aa1fd3dc42353ec6f61adcd7",
|
|
@@ -0,0 +1,125 @@
|
|
|
1
|
+
---
|
|
2
|
+
id: kibi-commit-review
|
|
3
|
+
name: kibi-commit-review
|
|
4
|
+
description: "Use when kibi check --staged or the Kibi pre-commit hook blocks a commit (kibi_impact_evidence_missing, symbols_manifest_stale, symbol_granularity_violation, symbol-coverage, kibi check-generated drift, Staged impact review failed), or when preparing a commit or pull-request impact review. Covers reading the per-file Detail lines, authoring .kb/symbols.yaml symbol entries through kb_upsert, kibi sync --refresh-symbol-coordinates, staging the tracked Kibi evidence with git add, kb_prepare_impact_review for a staged or diff scope, the kibi signoff requirements summary to show before a commit, and how merge commits and migration renames are judged."
|
|
5
|
+
version: 1.2.0
|
|
6
|
+
kibiCompatibility: ">=1.0.0"
|
|
7
|
+
tags:
|
|
8
|
+
- kibi
|
|
9
|
+
- commit
|
|
10
|
+
- staged-check
|
|
11
|
+
- traceability
|
|
12
|
+
- agent-guidance
|
|
13
|
+
resources:
|
|
14
|
+
- resources/staged-gate.md
|
|
15
|
+
---
|
|
16
|
+
## Goal
|
|
17
|
+
|
|
18
|
+
Get a commit through Kibi's staged gate by fixing the cause: the commit
|
|
19
|
+
carries the knowledge its behavior change needs, with current symbol
|
|
20
|
+
coordinates, so the gate passes for the same reason a reviewer would accept it.
|
|
21
|
+
|
|
22
|
+
## Interface Selection
|
|
23
|
+
|
|
24
|
+
Use the visible approved MCP tools or the trusted project-local CLI as equal
|
|
25
|
+
peer interfaces (CLI JSON: `printf '%s\n' '{}' | npx --no-install kibi status
|
|
26
|
+
--input -`). The gate itself is CLI: `npx --no-install kibi check --staged`
|
|
27
|
+
(add `--format json` for the full evidence). If neither surface is available,
|
|
28
|
+
stop and name the missing capability. Never read or edit `.kb/` files directly.
|
|
29
|
+
|
|
30
|
+
## When this applies
|
|
31
|
+
|
|
32
|
+
- `kibi check --staged` fails, or the pre-commit hook (`kibi check-generated
|
|
33
|
+
--staged --changed-only`, then `kibi check --staged`) blocks a commit.
|
|
34
|
+
- You are about to commit or open a pull request and want the impact review
|
|
35
|
+
ready first.
|
|
36
|
+
|
|
37
|
+
Never read or open any file under `.kb`, not even read-only with a file tool to look at symbols or coordinates; doing so fails the session even when nothing is written. What you need is already shown elsewhere: the gate's `Detail:` lines, `kb_query` by `sourceFile` or `id`, and `kb_check` with `staged: true` show which symbols and coordinates are covered and which are missing. Before deciding what the change is, always run `kb_search` with `sourceLocations` for each named file and `kb_query` the requirement that governs it, even when the edit looks coordinate-only or seems to contradict a firm rule. When a write is authorized, keep the supplied target and its intended edges, query those targets first, validate the exact payload with `kb_upsert` and `dryRun: true`, then send that same payload with `kb_upsert` and exact-read the result back with `kb_query` before the final checks. Distinct authorized payloads may need several sequential writes, but never resend a write that is already committed, and let typed `nextActions` drive recovery. A passing dry run is validation only, not completion.
|
|
38
|
+
|
|
39
|
+
## Steps
|
|
40
|
+
|
|
41
|
+
1. **Read the whole failure.** Each finding names an id, the files, `Detail:`
|
|
42
|
+
lines and a `Suggestion:`. Detail lines are complete per file: how many
|
|
43
|
+
symbols extraction finds in the staged content, how many the staged
|
|
44
|
+
evidence covers, and every symbol missing from `.kb/symbols.yaml` with its
|
|
45
|
+
line. The common ids and their fixes are in `resources/staged-gate.md`.
|
|
46
|
+
2. **Find the owning knowledge.** `kb_search` with `sourceLocations` for each
|
|
47
|
+
named file (or `kb_query({sourceFile})`), then `kb_query` the requirements,
|
|
48
|
+
scenarios and tests it returns. Run `kb_check` with `sourceFiles`,
|
|
49
|
+
`includeImpactDiagnostics: true` and `staged: true` to see the impact
|
|
50
|
+
findings, including `requirement_statement_unverified` quotes.
|
|
51
|
+
3. **Decide what the change is.**
|
|
52
|
+
- Behavior changed: update or record the knowledge (a requirement with a
|
|
53
|
+
scenario, or a new clause) through `kb_upsert`. If the change contradicts
|
|
54
|
+
a recorded rule, stop and ask; load `kibi-decisions`.
|
|
55
|
+
- New or uncovered symbols: author a `symbol` entity per listed symbol
|
|
56
|
+
through `kb_upsert` (`title` = the member the extractor names,
|
|
57
|
+
`sourceFile`, `status: active`, `symbol_role: behavioral`, `implements`
|
|
58
|
+
to the requirement, `covered_by` to the test). Then run
|
|
59
|
+
`kibi sync --refresh-symbol-coordinates`.
|
|
60
|
+
- Only coordinates moved: `kibi sync --refresh-symbol-coordinates`.
|
|
61
|
+
- No behavior change (a genuine false positive): see the audited
|
|
62
|
+
no-impact note in `resources/staged-gate.md`; it never covers a real
|
|
63
|
+
behavior change.
|
|
64
|
+
4. **Stage the evidence.** Kibi authors tracked files but never Git-stages or
|
|
65
|
+
commits them. `git status --short .kb` lists what it wrote; `git add` the
|
|
66
|
+
entity Markdown, `.kb/relationships/` shards, `.kb/symbols.yaml` and
|
|
67
|
+
`.kb/symbol-coordinates.yaml` that belong to this change (use `git add -p`
|
|
68
|
+
when the files hold unrelated edits).
|
|
69
|
+
5. **Re-run** `kibi check --staged` (and `kibi check-generated --staged` when it
|
|
70
|
+
failed) until it passes. Never bypass the hook (`--no-verify`) unless the
|
|
71
|
+
person says so.
|
|
72
|
+
|
|
73
|
+
## Requirements signoff
|
|
74
|
+
|
|
75
|
+
Before you ask the person to approve a commit that adds, rewrites or retires
|
|
76
|
+
requirements, or changes code that implements them, show them what they are
|
|
77
|
+
signing off:
|
|
78
|
+
|
|
79
|
+
```
|
|
80
|
+
npx --no-install kibi signoff # working tree; --staged for the index
|
|
81
|
+
```
|
|
82
|
+
|
|
83
|
+
It prints Markdown listing each new, changed, affected and retired
|
|
84
|
+
requirement with its statement (before and after for a rewrite), firmness,
|
|
85
|
+
origin, scenarios and proof state. Put it in your reply unchanged (in the
|
|
86
|
+
messaging tool's message when replies go through one), then add one or two
|
|
87
|
+
sentences on why the requirements changed. Offer the full page with
|
|
88
|
+
`kibi signoff --format html --open`, or attach or publish
|
|
89
|
+
`.kb/briefs/signoff/latest.html` when your host can carry a file or a page;
|
|
90
|
+
past 15 requirements the Markdown stops and only the page lists them all.
|
|
91
|
+
Host details: `kibi-decisions`, `resources/signoff-views.md`. `--no-proof` skips the proof lookup, which reads coverage and is slow
|
|
92
|
+
on a large knowledge base. The summary is not an approval: never set
|
|
93
|
+
`approved_by` or `origin.ref` from it.
|
|
94
|
+
|
|
95
|
+
## Impact reviews
|
|
96
|
+
|
|
97
|
+
When the repository's base commit carries `.kibi/impact-policy.json`, the gate
|
|
98
|
+
also demands a content-bound review record at `.kibi/impact-review.json`
|
|
99
|
+
(`Staged impact review failed: impact_review_invalid ...`). Prepare it with
|
|
100
|
+
`kb_prepare_impact_review` (`scope: {"kind":"staged"}`, or `{"kind":"diff",
|
|
101
|
+
"baseCommit":"<40-hex sha>","headCommit":"<40-hex sha>"}` for a pull
|
|
102
|
+
request). It is read-only: it returns per-file evidence, requirement scopes,
|
|
103
|
+
residual review obligations and an unauthored record template. Draft each
|
|
104
|
+
file's `decision` from what you verified, leave `reviewer.id` for the person
|
|
105
|
+
who reviews, and never present the record as their approval. Field details are
|
|
106
|
+
in `resources/staged-gate.md`.
|
|
107
|
+
|
|
108
|
+
## Merge commits and migrations
|
|
109
|
+
|
|
110
|
+
During a merge (`MERGE_HEAD` exists), files staged unchanged from a merged
|
|
111
|
+
parent are skipped (`Merge commit: N staged file(s) are taken unchanged ...`);
|
|
112
|
+
only what the merge resolved or edited is judged. A commit that moves
|
|
113
|
+
knowledge into `.kb/` after `kibi migrate` is compared with the old paths
|
|
114
|
+
(`Baseline: HEAD with N staged knowledge rename(s) ...`), and symbol records
|
|
115
|
+
changed only by the migration are not judged as changed. Debt reported there
|
|
116
|
+
came from the branch or the old layout; the full `kibi check` still shows it.
|
|
117
|
+
|
|
118
|
+
## Typed results and report
|
|
119
|
+
|
|
120
|
+
Parse `kibiProtocol`, `status`, diagnostics and typed `nextActions` on every
|
|
121
|
+
Kibi write. On `committed_with_repairs`, run the repair actions and never
|
|
122
|
+
resend the original write. Report the findings you fixed (id, file, what
|
|
123
|
+
changed), the knowledge you recorded or confirmed still current, the files
|
|
124
|
+
you staged, the final `kibi check --staged` result, and anything left for the
|
|
125
|
+
person (an open rule conflict, an unauthored review decision).
|
|
@@ -0,0 +1,98 @@
|
|
|
1
|
+
# The staged gate
|
|
2
|
+
|
|
3
|
+
Reference for `kibi-commit-review`: what `kibi check --staged` and
|
|
4
|
+
`kibi check-generated --staged` report, how to fix each finding, and the
|
|
5
|
+
impact-review record. The staged check reads blob content from the Git index,
|
|
6
|
+
not the working tree, so a fix counts only once it is staged.
|
|
7
|
+
|
|
8
|
+
## Reading a finding
|
|
9
|
+
|
|
10
|
+
```text
|
|
11
|
+
symbols_manifest_stale: .kb/symbol-coordinates.yaml is stale or missing for staged source files: src/billing/refund.ts
|
|
12
|
+
Detail: src/billing/refund.ts — extraction finds 4 symbol(s), evidence covers 3.
|
|
13
|
+
Not in .kb/symbols.yaml: approveRefund (line 42)
|
|
14
|
+
Suggestion: Author .kb/symbols.yaml entries for the uncovered symbols (kibi upsert, with implements/covered_by links), then run kibi sync --refresh-symbol-coordinates && git add .kb/symbol-coordinates.yaml .kb/symbols.yaml, then re-run kibi check --staged.
|
|
15
|
+
```
|
|
16
|
+
|
|
17
|
+
- Detail lines name every symbol, never a shortened list. `Evidence without a
|
|
18
|
+
matching symbol:` lists manifest entries whose declaration is gone or
|
|
19
|
+
renamed: rename the symbol's `title`, or retire the entry.
|
|
20
|
+
- `--format json` carries the same lists in the diagnostic `evidence`
|
|
21
|
+
(`symbolsManifest[].missing` / `extra`, `uncoveredSymbols[].titles`).
|
|
22
|
+
|
|
23
|
+
## Blocking findings
|
|
24
|
+
|
|
25
|
+
| Id or message | Cause | Fix |
|
|
26
|
+
| --- | --- | --- |
|
|
27
|
+
| `kibi_impact_evidence_missing` | A staged behavior edit (changed lines in exported or behavior-bearing code, not comments or formatting) has no staged Kibi evidence. Test-only edits do not need it unless they add executable test symbols. | Query the owning knowledge; update it when behavior changed; stage entity Markdown under `.kb/`, authored `.kb/symbols.yaml` entries for the listed symbols, or refreshed `.kb/symbol-coordinates.yaml`. |
|
|
28
|
+
| `symbols_manifest_stale` | Extraction output changed and the staged coordinates (or manifest) do not match it. | Author entries for the listed symbols first, then `kibi sync --refresh-symbol-coordinates`, then stage both manifests. |
|
|
29
|
+
| `symbol_granularity_violation` | A changed behavioral member is owned only by a coarse class or module symbol while a narrower declaration exists. | Add a symbol for the member itself (`title` = `Class.method` or the exported function) with its own links; use `granularity_reason` (`config-artifact`, `module-level-behavior`, `extractor-miss`, `legacy-link`, `test-suite`) only when it is true. |
|
|
30
|
+
| `symbol-coverage` | A changed symbol, or a symbol whose staged manifest entry changed, fails the full-check rule on the staged knowledge. | The symbol `implements` the requirement and is `covered_by` a test that verifies it: through the requirement's scenario (`verified_by` scenario -> test) when it has one, else `verified_by` requirement -> test. A direct requirement -> test link does not count while a scenario exists. The finding's suggestion names the missing link (see `kibi-traceability`). |
|
|
31
|
+
| `kibi_impact_override_missing_rationale` | A `Kibi-Impact: none` declaration has no `Rationale:` line. | Add the rationale, or drop the declaration and stage real evidence. |
|
|
32
|
+
| `entity-context-missing` (staged entity) | A staged requirement, scenario, test, ADR or observation fact has fewer than 12 words of context. | Upsert a sectioned `document.body` (see `kibi-usage`, Entity body contract). |
|
|
33
|
+
| `domain-contradictions`, `scenario-feasibility`, `exception-claim-keys` (staged `.kb/` change) | The staged knowledge introduces a violation the last commit did not have. | Fix the knowledge; a contradiction with a recorded rule goes to the person (`kibi-decisions`). |
|
|
34
|
+
| Proposition-complete ingestion | A staged requirement's semantic inventory is missing or no longer matches its prose. | Re-derive it (`kb_model` analyze with the complete prose) or run `kibi migrate` for drift. |
|
|
35
|
+
| `kibi check-generated --staged` drift | The staged `.kb/symbols.yaml` or `.kb/symbol-coordinates.yaml` differs from a refresh computed from the index. | `kibi sync --refresh-symbol-coordinates`, review the diff, stage only the intended hunks (`git add -p`). |
|
|
36
|
+
| `Staged impact review failed: impact_review_invalid: ...` | The base commit has `.kibi/impact-policy.json` and the staged `.kibi/impact-review.json` is missing, stale or incomplete. The message names the cause (missing review path, stale fingerprint, ...). | Prepare a fresh record (below). Any later staged change makes the fingerprints stale again, so prepare it last. |
|
|
37
|
+
|
|
38
|
+
## Advisory findings
|
|
39
|
+
|
|
40
|
+
These warn but do not block. Read them; they are often the real review.
|
|
41
|
+
|
|
42
|
+
- `requirement_statement_unverified`: quotes each current requirement the
|
|
43
|
+
changed code implements, with its firmness. Compare the code with the
|
|
44
|
+
statement yourself.
|
|
45
|
+
- `symbol_semantic_review_needed`: the links exist, but check that the linked
|
|
46
|
+
requirement, scenario and test still describe the changed behavior. In a
|
|
47
|
+
file with no linked symbol it says no recorded intent covers the change.
|
|
48
|
+
- `staged_file_ownership_missing` / `staged_file_impact_review_needed`: a
|
|
49
|
+
staged text file (not TypeScript or JavaScript) has no owning requirement,
|
|
50
|
+
or has one and no matching evidence changed.
|
|
51
|
+
|
|
52
|
+
## Audited no-impact declaration
|
|
53
|
+
|
|
54
|
+
For a false positive or an edit that changes no behavior, Kibi accepts a
|
|
55
|
+
staged Markdown note in a knowledge lane under `.kb/` with the two lines
|
|
56
|
+
|
|
57
|
+
```text
|
|
58
|
+
Kibi-Impact: none
|
|
59
|
+
Rationale: <why the staged source edits change no behavior>
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
It never satisfies a genuine behavior change, and it is visible in review.
|
|
63
|
+
Prefer real evidence; use the note only when the person agrees the edit has
|
|
64
|
+
no behavior impact.
|
|
65
|
+
|
|
66
|
+
## Impact-review record
|
|
67
|
+
|
|
68
|
+
`kb_prepare_impact_review` (CLI `prepare-impact-review --input`) takes only
|
|
69
|
+
`scope`: `{"kind":"staged"}`, or
|
|
70
|
+
`{"kind":"diff","baseCommit":"<sha>","headCommit":"<sha>"}` with full
|
|
71
|
+
lowercase 40- or 64-hex commit ids. It returns `status: ready_for_authoring`,
|
|
72
|
+
the `snapshot` identity, `recordHeaders` (policy, evaluator and scope
|
|
73
|
+
fingerprints), complete per-file evidence in `files`, `requirementScopes`,
|
|
74
|
+
`residualReviewObligations`, and `authorship` with the record schemas and an
|
|
75
|
+
unauthored `recordTemplate`.
|
|
76
|
+
|
|
77
|
+
Fill only the authored fields (`files[].decision`, `files[].analysisReviews`,
|
|
78
|
+
`reviewer.id`, `reviewedAt`) and write the record to `.kibi/impact-review.json`,
|
|
79
|
+
then stage it. A file `decision` is one of:
|
|
80
|
+
|
|
81
|
+
- `{"kind":"impact","requirementIds":[...],"knowledge":{"state":"still_current","rationale":"..."}}`
|
|
82
|
+
- `{"kind":"impact","requirementIds":[...],"knowledge":{"state":"updated","entities":[{"entityId":"...","artifactPath":"...","beforeFingerprint":"<sha256 or null>","afterFingerprint":"<sha256>"}]}}`
|
|
83
|
+
- `{"kind":"no_impact","reason":"...","rationale":"..."}`
|
|
84
|
+
- `{"kind":"not_applicable","policyReason":"...","rationale":"..."}` (only
|
|
85
|
+
where the policy lists the path as not applicable)
|
|
86
|
+
|
|
87
|
+
`reviewer.source` is `self-claimed-local`: the record says who reviewed, it
|
|
88
|
+
does not prove it. Put the person's id there only when they reviewed it.
|
|
89
|
+
|
|
90
|
+
## Commands
|
|
91
|
+
|
|
92
|
+
```bash
|
|
93
|
+
npx --no-install kibi check --staged # the gate
|
|
94
|
+
npx --no-install kibi check --staged --format json # with full evidence
|
|
95
|
+
npx --no-install kibi check-generated --staged # manifest drift
|
|
96
|
+
npx --no-install kibi sync --refresh-symbol-coordinates # refresh coordinates
|
|
97
|
+
git status --short .kb # what Kibi wrote
|
|
98
|
+
```
|