kibi-core 0.9.1 → 0.11.0

package/package.json

@@ -1,15 +1,17 @@
 {
   "name": "kibi-core",
-  "version": "0.9.1",
+  "version": "0.11.0",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",
   "engines": {
-    "node": ">=18",
-    "bun": ">=1.0"
+    "node": ">=18"
   },
   "main": "./src/kb.pl",
-  "files": ["src/**/*.pl", "schema/**/*.pl"],
+  "files": [
+    "src/**/*.pl",
+    "schema/**/*.pl"
+  ],
   "license": "AGPL-3.0-or-later",
   "author": "Piotr Franczyk",
   "repository": {

package/schema/entities.pl

@@ -3,6 +3,7 @@
 :- module(kibi_entities, [entity_type/1, entity_property/3, required_property/2, optional_property/2]).
 
 % Entity types
+% implements REQ-004
 entity_type(req).
 entity_type(scenario).
 entity_type(test).
@@ -87,6 +88,7 @@ entity_property(symbol, sourceEndColumn, integer).
 % Typed test verification fields - only valid for test entities
 entity_property(test, verification_scope, atom).
 entity_property(test, verification_perspective, atom).
+entity_property(test, verification_contract, list_or_json).
 entity_property(test, verification_receipts, string).
 
 % Required properties for all entity types
@@ -113,6 +115,7 @@ optional_property(req, semantic_source_hash).
 optional_property(req, semantic_inventory).
 optional_property(test, verification_scope).
 optional_property(test, verification_perspective).
+optional_property(test, verification_contract).
 optional_property(test, verification_receipts).
 
 % Documentation helpers

package/schema/relationships.pl

@@ -3,6 +3,7 @@
 :- module(kibi_relationships, [relationship_type/1, valid_relationship/3, relationship_metadata/1]).
 
 % Relationship types
+% implements REQ-005
 relationship_type(depends_on).
 relationship_type(executable_for).
 relationship_type(specified_by).

package/schema/validation.pl

@@ -119,6 +119,7 @@ is_fact_only_field(claim_span_end).
 % is_test_only_field(+Key) - true if Key is a test-specific field
 is_test_only_field(verification_scope).
 is_test_only_field(verification_perspective).
+is_test_only_field(verification_contract).
 is_test_only_field(verification_receipts).
 
 % validate_fact_shape(+Kind, +Props)

package/src/checks.pl

@@ -6,6 +6,7 @@
 :- module(checks, [
     check_all/1,                    % Returns all violations as a dict
     check_all_json/1,               % Returns all violations as JSON string
+    check_selected_json/2,           % Returns only selected rule violations as JSON
     check_must_priority_coverage/1, % Returns list of must-priority violations
     check_symbol_coverage/1,        % Returns list of uncovered symbols
     check_symbol_traceability/2,    % Returns list of symbols lacking requirement traceability (ReqAdr option)
@@ -14,6 +15,7 @@
     check_required_fields/1,        % Returns list of missing required field violations
     check_deprecated_adrs/1,        % Returns list of deprecated ADR violations
     check_domain_contradictions/1,  % Returns list of contradiction violations
+    check_domain_contradictions_and_witnesses/2,
     check_domain_contradiction_witnesses/1,
     check_strict_fact_shape/1,      % Returns list of malformed strict fact violations
     check_strict_req_fact_pairing/1,% Returns list of malformed strict req/fact pairing violations
@@ -591,6 +593,15 @@ check_domain_contradictions(Violations) :-
     check_domain_contradiction_witnesses(Witnesses),
     maplist(contradiction_witness_violation, Witnesses, Violations).
 
+%% check_domain_contradictions_and_witnesses(-Violations, -Witnesses)
+% Compute the contradiction witness graph once when a caller needs both the
+% report violations and their exact evidence. The existing one-result
+% predicates remain unchanged; this paired form avoids duplicate work in
+% proof contexts without weakening any contradiction checks.
+check_domain_contradictions_and_witnesses(Violations, Witnesses) :-
+    check_domain_contradiction_witnesses(Witnesses),
+    maplist(contradiction_witness_violation, Witnesses, Violations).
+
 %% check_domain_contradiction_witnesses(-Witnesses)
 % Exact, JSON-safe evidence for every strict-property, ground-predicate, and
 % safe-rule contradiction result.  Rule overlap that cannot be proven or
@@ -989,9 +1000,11 @@ predicate_verifiability_kind_label(Kind, Label) :-
 
 %% check_logic_coverage(-Violations)
 % Validates explicitly declared atomic requirement claim manifests. Legacy
-% requirements without logic_claims remain eligible for gradual backfill; once
-% a manifest exists, every key must be grounded by a linked strict-property or
-% predicate fact carrying the same claim_key.
+% requirements without logic_claims remain eligible for gradual backfill. A
+% modeled proposition must be grounded exactly once; ambiguous, ontology-gap,
+% and missing propositions remain explicit unresolved inventory states and are
+% not required to have a ground fact (missing is reported by semantic
+% completeness).
 check_logic_coverage(Violations) :-
     findall(Violation, logic_coverage_violation(Violation), Violations0),
     sort(Violations0, Violations).
@@ -1006,6 +1019,7 @@ logic_coverage_violation(violation(
     kb:current_req(ReqId),
     requirement_logic_claims(ReqId, ClaimKeys),
     member(ClaimKey, ClaimKeys),
+    claim_requires_grounding(ReqId, ClaimKey),
     \+ grounded_requirement_claim(ReqId, ClaimKey),
     format(
         string(Description),
@@ -1014,6 +1028,24 @@ logic_coverage_violation(violation(
     ),
     violation_source(ReqId, req, Source).
 
+logic_coverage_violation(violation(
+    'logic-coverage',
+    ReqId,
+    Description,
+    "Keep ontology gaps, ambiguities, and missing interpretations unresolved; only modeled propositions may have logical ground facts",
+    Source
+)) :-
+    kb:current_req(ReqId),
+    requirement_inventory_status(ReqId, ClaimKey, Status),
+    memberchk(Status, [ambiguous, ontology_gap, missing]),
+    grounded_requirement_claim(ReqId, ClaimKey),
+    format(
+        string(Description),
+        "Requirement grounds unresolved ~w proposition ~w",
+        [Status, ClaimKey]
+    ),
+    violation_source(ReqId, req, Source).
+
 logic_coverage_violation(violation(
     'logic-coverage',
     ReqId,
@@ -1076,6 +1108,28 @@ requirement_logic_claims(ReqId, ClaimKeys) :-
     memberchk(logic_claims=RawClaimKeys, Props),
     kb:normalize_term_atom_list(RawClaimKeys, ClaimKeys).
 
+claim_requires_grounding(ReqId, ClaimKey) :-
+    requirement_inventory_status(ReqId, ClaimKey, modeled),
+    !.
+claim_requires_grounding(ReqId, ClaimKey) :-
+    \+ requirement_inventory_status(ReqId, ClaimKey, _).
+
+requirement_inventory_status(ReqId, ClaimKey, Status) :-
+    kb_entity(ReqId, req, Props),
+    memberchk(semantic_inventory=RawInventory, Props),
+    inventory_entries(RawInventory, Entries),
+    member(Entry, Entries),
+    checks_inventory_entry_field(Entry, claim_key, RawClaimKey),
+    kb:normalize_term_atom(RawClaimKey, ClaimKey),
+    inventory_entry_status(Entry, Status).
+
+checks_inventory_entry_field(Entry, Key, Value) :-
+    is_dict(Entry),
+    get_dict(Key, Entry, Value).
+checks_inventory_entry_field(Entry, Key, Value) :-
+    is_list(Entry),
+    memberchk(Key=Value, Entry).
+
 grounded_requirement_claim(ReqId, ClaimKey) :-
     grounded_requirement_claim_fact(ReqId, ClaimKey, _FactId).
 
@@ -1222,13 +1276,15 @@ rule_verifiability_description(Props, FactId, Description) :-
 rule_verifiability_description(Props, FactId, Description) :-
     memberchk(fact_kind=RawKind, Props),
     normalize_term_atom(RawKind, rule),
-    memberchk(rule_schema_id=SchemaId, Props),
+    memberchk(rule_schema_id=RawSchemaId, Props),
+    normalize_term_atom(RawSchemaId, SchemaId),
     \+ kb_entity(SchemaId, fact, _),
     format(string(Description), "Rule fact ~w references missing rule schema ~w", [FactId, SchemaId]).
 rule_verifiability_description(Props, FactId, Description) :-
     memberchk(fact_kind=RawKind, Props),
     normalize_term_atom(RawKind, rule),
-    memberchk(rule_schema_id=SchemaId, Props),
+    memberchk(rule_schema_id=RawSchemaId, Props),
+    normalize_term_atom(RawSchemaId, SchemaId),
     kb_entity(SchemaId, fact, SchemaProps),
     \+ valid_rule_schema_props(SchemaProps),
     format(string(Description), "Rule fact ~w references ~w, which is not a rule_schema fact", [FactId, SchemaId]).
@@ -1286,6 +1342,10 @@ inventory_entries(Raw, Entries) :-
         catch(atom_json_dict(Raw, JsonEntries, [value_string_as(string)]), _, fail),
         is_list(JsonEntries)
     ->  Entries = JsonEntries
+    ;   (atom(Raw) ; string(Raw)),
+        catch(term_string(PrologEntries, Raw), _, fail),
+        is_list(PrologEntries)
+    ->  Entries = PrologEntries
     ;   Entries = []
     ).
 
@@ -1341,6 +1401,64 @@ check_all_json(JsonString) :-
         JsonString
     ).
 
+%% check_selected_json(+Rules, -JsonString)
+% Run only the named aggregated checks. This is intentionally separate from
+% check_all/1 so focused diagnostics cannot evaluate unrelated rule queries.
+check_selected_json(Rules, JsonString) :-
+    check_selected(Rules, ViolationsDict),
+    violations_dict_to_json(ViolationsDict, JsonDict),
+    with_output_to_string(
+        json_write_dict(current_output, JsonDict, [width(0)]),
+        JsonString
+    ).
+
+check_selected(Rules, _{
+    must_priority_coverage: MustPriority,
+    symbol_coverage: SymbolCoverage,
+    symbol_traceability: SymbolTraceability,
+    no_dangling_refs: DanglingRefs,
+    no_cycles: Cycles,
+    required_fields: RequiredFields,
+    deprecated_adr_no_successor: DeprecatedADRs,
+    domain_contradictions: Contradictions,
+    strict_fact_shape: StrictFactShape,
+    strict_req_fact_pairing: StrictReqFactPairing,
+    strict_readiness: StrictReadiness,
+    predicate_verifiability: PredicateVerifiability,
+    logic_coverage: LogicCoverage,
+    rule_safety: RuleSafety,
+    rule_verifiability: RuleVerifiability,
+    semantic_completeness: SemanticCompleteness
+}) :-
+    selected_rule(Rules, 'must-priority-coverage', check_must_priority_coverage, MustPriority),
+    selected_rule(Rules, 'symbol-coverage', check_symbol_coverage, SymbolCoverage),
+    selected_rule_with_options(Rules, 'symbol-traceability', check_symbol_traceability, SymbolTraceability),
+    selected_rule(Rules, 'no-dangling-refs', check_no_dangling_refs, DanglingRefs),
+    selected_rule(Rules, 'no-cycles', check_no_cycles, Cycles),
+    selected_rule(Rules, 'required-fields', check_required_fields, RequiredFields),
+    selected_rule(Rules, 'deprecated-adr-no-successor', check_deprecated_adrs, DeprecatedADRs),
+    selected_rule(Rules, 'domain-contradictions', check_domain_contradictions, Contradictions),
+    selected_rule(Rules, 'strict-fact-shape', check_strict_fact_shape, StrictFactShape),
+    selected_rule(Rules, 'strict-req-fact-pairing', check_strict_req_fact_pairing, StrictReqFactPairing),
+    selected_rule(Rules, 'strict-readiness', check_strict_readiness, StrictReadiness),
+    selected_rule(Rules, 'predicate-verifiability', check_predicate_verifiability, PredicateVerifiability),
+    selected_rule(Rules, 'logic-coverage', check_logic_coverage, LogicCoverage),
+    selected_rule(Rules, 'rule-safety', check_rule_safety, RuleSafety),
+    selected_rule(Rules, 'rule-verifiability', check_rule_verifiability, RuleVerifiability),
+    selected_rule(Rules, 'semantic-completeness', check_semantic_completeness, SemanticCompleteness).
+
+selected_rule(Rules, Name, Goal, Violations) :-
+    (   memberchk(Name, Rules)
+    ->  call(Goal, Violations)
+    ;   Violations = []
+    ).
+
+selected_rule_with_options(Rules, Name, Goal, Violations) :-
+    (   memberchk(Name, Rules)
+    ->  call(Goal, false, Violations)
+    ;   Violations = []
+    ).
+
 %% check_all_json_with_options(-JsonString, +RequireAdr)
 % Returns all violations as JSON string with options.
 % RequireAdr: if true, symbol-traceability also requires ADR constraints.

package/src/discovery.pl

@@ -143,7 +143,7 @@ coverage_rows(type, _Tags, _IncludePassing, _IncludeTransitive, _VerificationSna
 requirement_coverage_row(Tags, IncludeTransitive, ProofContext, Row) :-
     kb_entity(Id, req, Props),
     matches_tags(Tags, Props),
-    entity_title_status_source(Props, Title, Status, _Source),
+    entity_title_status_source(Props, Title, Status, Source),
     entity_priority(Props, Priority),
     count_distinct_targets(specified_by, Id, source, ScenarioCount),
     requirement_test_count(Id, TestCount),
@@ -156,6 +156,7 @@ requirement_coverage_row(Tags, IncludeTransitive, ProofContext, Row) :-
         type: req,
         title: Title,
         status: Status,
+        source: Source,
         priority: Priority,
         scenarioCount: ScenarioCount,
         testCount: TestCount,