kibi-core 0.6.3 → 0.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.6.3",
+  "version": "0.7.0",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",
@@ -9,10 +9,7 @@
     "bun": ">=1.0"
   },
   "main": "./src/kb.pl",
-  "files": [
-    "src/**/*.pl",
-    "schema/**/*.pl"
-  ],
+  "files": ["src/**/*.pl", "schema/**/*.pl"],
   "license": "AGPL-3.0-or-later",
   "author": "Piotr Franczyk",
   "repository": {

package/schema/entities.pl

@@ -57,6 +57,10 @@ entity_property(fact, aliases, list).
 entity_property(fact, examples, list).
 entity_property(fact, predicate_args, list).
 
+% Typed symbol metadata fields - only valid for symbol entities
+entity_property(symbol, symbol_role, atom).
+entity_property(symbol, granularity_reason, atom).
+
 % Typed test verification fields - only valid for test entities
 entity_property(test, verification_scope, atom).
 entity_property(test, verification_perspective, atom).

package/src/checks.pl

@@ -17,6 +17,7 @@
     check_strict_fact_shape/1,      % Returns list of malformed strict fact violations
     check_strict_req_fact_pairing/1,% Returns list of malformed strict req/fact pairing violations
     check_strict_readiness/1,       % Returns list of strict readiness audit violations
+    check_predicate_verifiability/1,% Returns list of unverifiable predicate-lane requirement links
     run_checks_json/0,              % Entry point for JSON output
     violation_id_text/2             % Extract text from entity ID term (exported for testing)
 ]).
@@ -52,6 +53,7 @@ check_all(ViolationsDict) :-
     check_strict_fact_shape(StrictFactShape),
     check_strict_req_fact_pairing(StrictReqFactPairing),
     check_strict_readiness(StrictReadiness),
+    check_predicate_verifiability(PredicateVerifiability),
     ViolationsDict = _{
         must_priority_coverage: MustPriority,
         symbol_coverage: SymbolCoverage,
@@ -63,7 +65,8 @@ check_all(ViolationsDict) :-
         domain_contradictions: Contradictions,
         strict_fact_shape: StrictFactShape,
         strict_req_fact_pairing: StrictReqFactPairing,
-        strict_readiness: StrictReadiness
+        strict_readiness: StrictReadiness,
+        predicate_verifiability: PredicateVerifiability
     }.
 
 %% check_must_priority_coverage(-Violations)
@@ -132,7 +135,6 @@ symbol_traceability_violation(RequireAdr, violation(
     Source
 )) :-
     kb_entity(SymbolId, symbol, _),
-    \+ executable_test_symbol(SymbolId),
     % Check if symbol has direct requirement ownership
     (   symbol_owns_requirement(SymbolId, ReqId),
         kb_entity(ReqId, req, _)
@@ -148,6 +150,7 @@ symbol_traceability_violation(RequireAdr, violation(
         )
     ;   HasAdr = true  % Not required, so pass this check
     ),
+    \+ executable_test_symbol(SymbolId),
     % Determine what is missing
     (   HasReq = false, HasAdr = false, RequireAdr = true ->
         Description = "Symbol has no direct requirement ownership and no ADR constraint.",
@@ -307,15 +310,14 @@ missing_required_field(Required, violation(
 )) :-
     kb_entity(EntityId, _Type, Props),
     member(Field, Required),
-    \+ memberchk(Field=_, Props),
-    
-    format(string(Description), "Missing required field: ~w", [Field]),
-    format(string(Suggestion), "Add ~w to entity definition", [Field]),
-    
     (   memberchk(source=Source, Props)
     ->  true
     ;   Source = ""
-    ).
+    ),
+    \+ memberchk(Field=_, Props),
+
+    format(string(Description), "Missing required field: ~w", [Field]),
+    format(string(Suggestion), "Add ~w to entity definition", [Field]).
 
 %% check_deprecated_adrs(-Violations)
 % Finds all deprecated ADRs without successors.
@@ -428,8 +430,7 @@ property_value_shape_error(Props, "Property value fact missing required field: v
     \+ memberchk(value_type=_, Props).
 property_value_shape_error(Props, "Property value fact missing value field (value_string, value_int, value_number, or value_bool)") :-
     memberchk(value_type=_, Props),
-    \+ (memberchk(value_string=_, Props); memberchk(value_int=_, Props); 
-        memberchk(value_number=_, Props); memberchk(value_bool=_, Props)).
+    \+ has_value_field(Props).
 property_value_shape_error(Props, "Property value fact has multiple value fields (should have exactly one)") :-
     findall(F, (member(F=_, Props), is_value_field(F)), Fields),
     length(Fields, Count),
@@ -445,6 +446,11 @@ is_value_field(value_int).
 is_value_field(value_number).
 is_value_field(value_bool).
 
+has_value_field(Props) :- memberchk(value_string=_, Props), !.
+has_value_field(Props) :- memberchk(value_int=_, Props), !.
+has_value_field(Props) :- memberchk(value_number=_, Props), !.
+has_value_field(Props) :- memberchk(value_bool=_, Props), !.
+
 % value_type_matches_field(+ValueType, +Props)
 value_type_matches_field(string, Props) :- memberchk(value_string=_, Props), !.
 value_type_matches_field(int, Props) :- memberchk(value_int=_, Props), !.
@@ -752,6 +758,48 @@ strict_readiness_level(ReqId, traceable) :-
     !.
 strict_readiness_level(_ReqId, prose_only).
 
+%% check_predicate_verifiability(-Violations)
+% Finds requirements whose requires_predicate links do not target ground
+% predicate facts. This keeps ontology-lane prose from looking modeled when the
+% target is still a legacy, observation, meta, schema, or strict-property fact.
+check_predicate_verifiability(Violations) :-
+    findall(
+        Violation,
+        predicate_verifiability_violation(Violation),
+        Violations0
+    ),
+    sort(Violations0, Violations).
+
+predicate_verifiability_violation(violation(
+    'predicate-verifiability',
+    ReqId,
+    Description,
+    "Apply kb_suggest_predicates and link requires_predicate to a fact_kind: predicate fact, or record a review:ontology-gap observation when no predicate fits",
+    Source
+)) :-
+    kb:current_req(ReqId),
+    kb_relationship(requires_predicate, ReqId, FactId),
+    kb_entity(FactId, fact, Props),
+    predicate_verifiability_fact_kind(Props, Kind),
+    Kind \= predicate,
+    predicate_verifiability_kind_label(Kind, KindLabel),
+    format(
+        string(Description),
+        "Requirement uses requires_predicate ~w but target is ~w, not fact_kind=predicate",
+        [FactId, KindLabel]
+    ),
+    violation_source(ReqId, req, Source).
+
+predicate_verifiability_fact_kind(Props, Kind) :-
+    (   memberchk(fact_kind=RawKind, Props)
+    ->  normalize_term_atom(RawKind, Kind)
+    ;   Kind = legacy
+    ).
+
+predicate_verifiability_kind_label(legacy, "a legacy fact without fact_kind").
+predicate_verifiability_kind_label(Kind, Label) :-
+    format(string(Label), "fact_kind=~w", [Kind]).
+
 strict_readiness_has_fact_link(ReqId) :-
     kb_relationship(constrains, ReqId, FactId),
     kb_entity(FactId, fact, _),
@@ -824,6 +872,7 @@ check_all_with_options(ViolationsDict, RequireAdr) :-
     check_strict_fact_shape(StrictFactShape),
     check_strict_req_fact_pairing(StrictReqFactPairing),
     check_strict_readiness(StrictReadiness),
+    check_predicate_verifiability(PredicateVerifiability),
     ViolationsDict = _{
         must_priority_coverage: MustPriority,
         symbol_coverage: SymbolCoverage,
@@ -835,7 +884,8 @@ check_all_with_options(ViolationsDict, RequireAdr) :-
         domain_contradictions: Contradictions,
         strict_fact_shape: StrictFactShape,
         strict_req_fact_pairing: StrictReqFactPairing,
-        strict_readiness: StrictReadiness
+        strict_readiness: StrictReadiness,
+        predicate_verifiability: PredicateVerifiability
     }.
 
 %% violations_dict_to_json(+ViolationsDict, -JsonDict)

package/src/discovery.pl

@@ -131,6 +131,7 @@ requirement_coverage_row(Tags, IncludeTransitive, Row) :-
     count_direct_symbols(Id, DirectSymbolCount),
     count_transitive_symbols(Id, IncludeTransitive, TransitiveSymbolCount),
     requirement_coverage_state(Id, Props, Gaps, Evaluated, CoverageStatus),
+    requirement_coverage_depth(Id, ScenarioCount, CoverageDepth, CoverageEvidence),
     Row = _{
         id: Id,
         type: req,
@@ -143,7 +144,13 @@ requirement_coverage_row(Tags, IncludeTransitive, Row) :-
         transitiveSymbolCount: TransitiveSymbolCount,
         gaps: Gaps,
         evaluated: Evaluated,
-        coverageStatus: CoverageStatus
+        coverageStatus: CoverageStatus,
+        coverageDepth: CoverageDepth,
+        coverage_depth: CoverageDepth,
+        directTests: CoverageEvidence.directTests,
+        scenarioTests: CoverageEvidence.scenarioTests,
+        testStatuses: CoverageEvidence.testStatuses,
+        verificationScopes: CoverageEvidence.verificationScopes
     }.
 
 symbol_coverage_row(Tags, Row) :-
@@ -232,6 +239,125 @@ requirement_test_count(Id, Count) :-
     sort(Combined0, Combined),
     length(Combined, Count).
 
+requirement_coverage_depth(Id, ScenarioCount, CoverageDepth, Evidence) :-
+    requirement_direct_tests(Id, DirectTests),
+    requirement_scenario_tests(Id, ScenarioTests),
+    append(DirectTests, ScenarioTests, AllTests0),
+    sort(AllTests0, AllTests),
+    passing_tests(DirectTests, PassingDirectTests),
+    passing_tests(ScenarioTests, PassingScenarioTests),
+    passing_tests(AllTests, PassingTests),
+    test_statuses(AllTests, TestStatuses),
+    test_scopes(AllTests, VerificationScopes),
+    Evidence = _{
+        directTests: DirectTests,
+        scenarioTests: ScenarioTests,
+        testStatuses: TestStatuses,
+        verificationScopes: VerificationScopes
+    },
+    classify_coverage_depth(
+        ScenarioCount,
+        AllTests,
+        PassingTests,
+        PassingDirectTests,
+        PassingScenarioTests,
+        CoverageDepth
+    ).
+
+requirement_direct_tests(Id, Tests) :-
+    findall(TestId, direct_requirement_test(Id, TestId), Tests0),
+    sort(Tests0, Tests).
+
+direct_requirement_test(Id, TestId) :-
+    kb_relationship(verified_by, Id, TestId),
+    kb_entity(TestId, test, _).
+direct_requirement_test(Id, TestId) :-
+    kb_relationship(validates, TestId, Id),
+    kb_entity(TestId, test, _).
+direct_requirement_test(Id, TestId) :-
+    kb_relationship(covered_by, Id, TestId),
+    kb_entity(TestId, test, _).
+
+requirement_scenario_tests(Id, Tests) :-
+    findall(TestId, scenario_requirement_test(Id, TestId), Tests0),
+    sort(Tests0, Tests).
+
+scenario_requirement_test(Id, TestId) :-
+    kb_relationship(specified_by, Id, ScenarioId),
+    scenario_test(ScenarioId, TestId).
+
+scenario_test(ScenarioId, TestId) :-
+    kb_relationship(validates, TestId, ScenarioId),
+    kb_entity(TestId, test, _).
+scenario_test(ScenarioId, TestId) :-
+    kb_relationship(verified_by, ScenarioId, TestId),
+    kb_entity(TestId, test, _).
+
+passing_tests(Tests, PassingTests) :-
+    include(passing_test, Tests, PassingTests).
+
+passing_test(TestId) :-
+    kb_entity(TestId, test, Props),
+    memberchk(status=StatusRaw, Props),
+    source_value_atom(StatusRaw, passing).
+
+test_statuses(Tests, Statuses) :-
+    findall(Status, (member(TestId, Tests), test_status(TestId, Status)), Statuses0),
+    sort(Statuses0, Statuses).
+
+test_status(TestId, Status) :-
+    kb_entity(TestId, test, Props),
+    memberchk(status=StatusRaw, Props),
+    source_value_atom(StatusRaw, Status).
+
+test_scopes(Tests, Scopes) :-
+    findall(Scope, (member(TestId, Tests), test_scope(TestId, Scope)), Scopes0),
+    sort(Scopes0, Scopes).
+
+test_scope(TestId, Scope) :-
+    kb_entity(TestId, test, Props),
+    (   memberchk(verification_scope=ScopeRaw, Props)
+    ->  source_value_atom(ScopeRaw, Scope)
+    ;   legacy_e2e_test(Props)
+    ->  Scope = end_to_end
+    ;   Scope = unknown
+    ).
+
+legacy_e2e_test(Props) :-
+    legacy_e2e_tag(Props),
+    !.
+legacy_e2e_test(Props) :-
+    memberchk(source=SourceRaw, Props),
+    source_value_atom(SourceRaw, Source),
+    downcase_atom(Source, LowercaseSource),
+    sub_atom(LowercaseSource, _, _, _, 'e2e').
+
+legacy_e2e_tag(Props) :-
+    memberchk(tags=Tags, Props),
+    member(TagRaw, Tags),
+    source_value_atom(TagRaw, Tag),
+    downcase_atom(Tag, e2e).
+
+classify_coverage_depth(_ScenarioCount, _AllTests, _PassingTests, PassingDirectTests, _PassingScenarioTests, direct_passing_e2e) :-
+    member(TestId, PassingDirectTests),
+    test_scope(TestId, end_to_end),
+    !.
+classify_coverage_depth(_ScenarioCount, _AllTests, _PassingTests, _PassingDirectTests, PassingScenarioTests, scenario_passing_e2e) :-
+    member(TestId, PassingScenarioTests),
+    test_scope(TestId, end_to_end),
+    !.
+classify_coverage_depth(_ScenarioCount, _AllTests, PassingTests, _PassingDirectTests, _PassingScenarioTests, unit_only) :-
+    PassingTests \= [],
+    forall(member(TestId, PassingTests), test_scope(TestId, unit)),
+    !.
+classify_coverage_depth(_ScenarioCount, AllTests, _PassingTests, _PassingDirectTests, _PassingScenarioTests, open_or_nonpassing_tests_only) :-
+    AllTests \= [],
+    !.
+classify_coverage_depth(ScenarioCount, _AllTests, _PassingTests, _PassingDirectTests, _PassingScenarioTests, scenario_only_no_test) :-
+    ScenarioCount > 0,
+    !.
+classify_coverage_depth(_ScenarioCount, _AllTests, _PassingTests, _PassingDirectTests, _PassingScenarioTests, no_test_evidence).
+
 count_direct_symbols(Id, Count) :-
     findall(SymbolId, kb_relationship(implements, SymbolId, Id), Symbols0),
     sort(Symbols0, Symbols),

package/src/status.pl

@@ -117,6 +117,7 @@ documentation_markdown_untracked(WorkspaceRoot) :-
 documentation_markdown_file(Path, Path) :-
     exists_file(Path),
     file_name_extension(_, md, Path),
+    \+ ignored_documentation_file(Path),
     !.
 documentation_markdown_file(Path, FilePath) :-
     exists_directory(Path),
@@ -138,6 +139,8 @@ known_source_path(RelativePath) :-
     repo_relative_source(SourceAtom, RelativePath).
 
 directory_tree_newer(Path, SnapshotTime) :-
+    exists_file(Path),
+    \+ ignored_documentation_file(Path),
     time_file(Path, EntryTime),
     EntryTime > SnapshotTime,
     !.
@@ -212,5 +215,8 @@ source_value_atom(Val, Atom) :-
     term_string(Val, Str),
     atom_string(Atom, Str).
 
+ignored_documentation_file(Path) :-
+    file_base_name(Path, 'README.md').
+
 dict_json_string(Dict, JsonString) :-
     with_output_to(string(JsonString), json_write_dict(current_output, Dict, [])).