kibi-core 0.22.0 → 0.22.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.22.0",
+  "version": "0.22.2",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",

package/src/checks.pl

@@ -72,7 +72,7 @@
     check_subject_key_shape/1,
     check_ontology_quality/1
 ]).
-:- use_module('logic_ir.pl', [logic_rule_safety/2, logic_rule_from_props/2, logic_rule_render/2, logic_rule_conflict/3, logic_rule_conflict_witness/3, logic_rules_stratified/1, logic_rule_missing_keys/4, functional_predicate_declarations/1, logic_rule_property_form/2]).
+:- use_module('logic_ir.pl', [logic_rule_safety/2, logic_rule_from_props/2, logic_rule_render/2, logic_rule_conflict/3, logic_rule_conflict_witness/4, logic_rules_stratified/1, logic_rule_missing_keys/4, functional_predicate_declarations/1, logic_rule_property_form/2]).
 % GENERATED registry facts; single source is schema/rule-registry.json.
 :- use_module('rule_registry.pl', [known_rule/1]).
 
@@ -2433,7 +2433,8 @@ check_domain_contradictions_and_witnesses(Violations, Witnesses) :-
 % disproven remains status=unresolved rather than becoming consistency.
 check_domain_contradiction_witnesses(Witnesses) :-
     findall(Witness, req_conflict_witness(_ReqA, _ReqB, Witness), GroundWitnesses),
-    findall(Witness, rule_contradiction_witness(Witness), RuleWitnesses),
+    functional_predicate_declarations(Functional),
+    findall(Witness, rule_contradiction_witness(Functional, Witness), RuleWitnesses),
     append(GroundWitnesses, RuleWitnesses, Witnesses0),
     sort(Witnesses0, Witnesses).
 
@@ -2622,9 +2623,9 @@ opposing_rule_requirement_facts(ReqA, ReqB, FactA, FactB, RuleA, RuleB) :-
     logic_rule_from_props(PropsA, RuleA),
     logic_rule_from_props(PropsB, RuleB).
 
-rule_contradiction_witness(Witness) :-
+rule_contradiction_witness(Functional, Witness) :-
     opposing_rule_requirement_facts(ReqA, ReqB, FactA, FactB, RuleA, RuleB),
-    logic_rule_conflict_witness(RuleA, RuleB, InternalWitness),
+    logic_rule_conflict_witness(RuleA, RuleB, Functional, InternalWitness),
     InternalWitness.status \= disjoint,
     rule_conflict_side(ReqA, FactA, Left),
     rule_conflict_side(ReqB, FactB, Right),

package/src/kb.pl

@@ -2466,12 +2466,36 @@ coverage_gap(Req, missing_test) :-
     has_scenario(Req),
     \+ has_test(Req).
 
+% implements REQ-core-validation-rules
+% Only a current must-priority requirement owes scenario and test coverage.
 must_requirement(Req) :-
     kb_entity(Req, req, Props),
     memberchk(priority=Priority, Props),
     normalize_term_atom(Priority, PriorityAtom),
     atom_string(PriorityAtom, PriorityStr),
-    sub_string(PriorityStr, _, 4, 0, "must").
+    sub_string(PriorityStr, _, 4, 0, "must"),
+    coverage_current_requirement(Req, Props).
+
+%% coverage_current_requirement(+Req, +Props)
+% A requirement is still owed coverage unless it is retired: superseded by
+% another requirement (the target of `supersedes`), carrying a retired status,
+% or `closed` without the `implemented` tag (a closed requirement is retired
+% work unless it records that it was implemented, the same rule the
+% coverage-depth review applies).  A requirement without a status keeps the
+% obligation.
+coverage_current_requirement(Req, Props) :-
+    \+ kb_relationship(supersedes, _, Req),
+    (   memberchk(status=RawStatus, Props)
+    ->  normalize_term_atom(RawStatus, Status)
+    ;   Status = missing
+    ),
+    \+ memberchk(Status, [deprecated, superseded, archived, removed, deleted, rejected]),
+    (   Status == closed
+    ->  memberchk(tags=RawTags, Props),
+        normalize_term_atom_list(RawTags, Tags),
+        memberchk(implemented, Tags)
+    ;   true
+    ).
 
 has_scenario(Req) :-
     once(kb_relationship(specified_by, Req, _)).

package/src/logic_ir.pl

@@ -12,6 +12,7 @@
     logic_rule_conflict/3,
     logic_rule_conflict/4,
     logic_rule_conflict_witness/3,
+    logic_rule_conflict_witness/4,
     logic_rule_missing_keys/4,
     functional_predicate_declarations/1,
     logic_atom_signature/2,
@@ -1215,7 +1216,15 @@ dependency_path(Current, Target, Edges, Seen) :-
 % Consumers can attach requirement IDs and source spans without ever treating
 % the rendered Prolog preview as executable source.
 logic_rule_conflict_witness(RuleA, RuleB, Witness) :-
-    logic_rule_conflict(RuleA, RuleB, Status),
+    functional_predicate_declarations(Functional),
+    logic_rule_conflict_witness(RuleA, RuleB, Functional, Witness).
+
+%% logic_rule_conflict_witness(+RuleA, +RuleB, +Functional, -Witness)
+% As logic_rule_conflict_witness/3 with the functional declarations already
+% read.  Reading them scans every predicate_schema fact, so a caller walking
+% every opposing rule pair reads them once instead of once per pair.
+logic_rule_conflict_witness(RuleA, RuleB, Functional, Witness) :-
+    logic_rule_conflict(RuleA, RuleB, Functional, Status),
     RuleA = rule(_KindA, ModalityA, HeadA, BodyA, ExceptionsA, ScopeA, FromA, ToA, SchemaA, _VariablesA),
     RuleB = rule(_KindB, ModalityB, HeadB, BodyB, ExceptionsB, ScopeB, FromB, ToB, SchemaB, _VariablesB),
     Witness = witness{

package/src/rule_registry.pl

@@ -62,6 +62,7 @@ known_rule('entity-context-missing').
 known_rule('entity-context-acknowledged').
 known_rule('decision-firm-unreferenced').
 known_rule('decision-firm-superseded').
+known_rule('decision-firm-edited').
 known_rule('supersedes-reason-missing').
 known_rule('supersedes-reason-acknowledged').
 known_rule('policy-ownership').
@@ -115,6 +116,7 @@ rule_enforcement_class('entity-context-missing', canonical).
 rule_enforcement_class('entity-context-acknowledged', advisory).
 rule_enforcement_class('decision-firm-unreferenced', canonical).
 rule_enforcement_class('decision-firm-superseded', canonical).
+rule_enforcement_class('decision-firm-edited', canonical).
 rule_enforcement_class('supersedes-reason-missing', canonical).
 rule_enforcement_class('supersedes-reason-acknowledged', advisory).
 rule_enforcement_class('policy-ownership', canonical).
@@ -168,6 +170,7 @@ rule_implementation('entity-context-missing', typescript).
 rule_implementation('entity-context-acknowledged', typescript).
 rule_implementation('decision-firm-unreferenced', typescript).
 rule_implementation('decision-firm-superseded', typescript).
+rule_implementation('decision-firm-edited', typescript).
 rule_implementation('supersedes-reason-missing', typescript).
 rule_implementation('supersedes-reason-acknowledged', typescript).
 rule_implementation('policy-ownership', typescript).
@@ -243,7 +246,7 @@ rule_predicate_arity('symbol-owner-superseded', 1).
 rule_predicate_arity('adr-unlinked', 1).
 rule_predicate_arity('adr-proposed', 1).
 
-rule_description('must-priority-coverage', 'Every must-priority requirement must have a scenario and a test').
+rule_description('must-priority-coverage', 'Every current must-priority requirement (not superseded, retired, or closed without the implemented tag) must have a scenario and a test').
 rule_description('symbol-coverage', 'Production symbols need qualifying coverage via covered_by plus a canonical requirement/scenario test path').
 rule_description('symbol-traceability', 'Production symbols must directly implement requirements for ownership; covered_by is coverage only and executable_for is test identity only').
 rule_description('symbol-granularity', 'A symbol with traceability relationships must not link its source file coarsely while narrower behavioral symbols are available, unless it carries an allowed granularity_reason; the staged gate\'s symbol_granularity_violation evaluated KB-wide').
@@ -291,6 +294,7 @@ rule_description('entity-context-missing', 'A current requirement, scenario, tes
 rule_description('entity-context-acknowledged', 'Informational: how many current entities carry the review:context-missing tag, so the legacy context backlog stays visible; one summary finding per check').
 rule_description('decision-firm-unreferenced', 'A requirement or ADR marked firmness: firm must name the human words it rests on: origin.ref (or approval_ref on a requirement); Kibi checks that the reference is present, not that it is genuine').
 rule_description('decision-firm-superseded', 'A requirement or ADR that supersedes a firm decision, retired or not, must itself be firm (and so carry a ref to the human who changed the rule); a default or exploratory replacement cannot overrule a firm decision').
+rule_description('decision-firm-edited', 'A current requirement or ADR that was firm at HEAD must not have its claim (title, stated meaning, the statement its body derives, an ADR\'s body, or its firmness) changed in place unless the edit cites new human words (a changed origin.ref, or approval_ref on a requirement); supersede it with a firm decision instead').
 rule_description('supersedes-reason-missing', 'A current requirement or ADR that supersedes another must explain why under a \'Why this changed\' heading (at least 12 words of prose naming the evidence and answering the old decision\'s reasoning); supersede edges recorded before schema 9 are acknowledged in the manifest and exempt').
 rule_description('supersedes-reason-acknowledged', 'Informational: how many current superseding requirements and ADRs have only supersede edges the schema 9 migration acknowledged without a \'Why this changed\' section; one summary finding per check').
 rule_description('policy-ownership', 'When a plugin activated for kibi.check-policy.v1 declares ownership rules, every production symbol in a rule\'s file set must implement a current requirement grounded (requires_predicate) in one of the rule\'s predicates; projects without an activated check policy are unaffected').