kibi-core 0.21.1 → 0.22.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.21.1",
+  "version": "0.22.1",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",

package/src/checks.pl

@@ -9,6 +9,7 @@
     check_selected_json/2,           % Returns only selected rule violations as JSON
     check_must_priority_coverage/1, % Returns list of must-priority violations
     check_symbol_coverage/1,        % Returns list of uncovered symbols
+    check_changed_symbol_coverage/2, % symbol-coverage restricted to a staged change set
     check_symbol_traceability/2,    % Returns list of symbols lacking requirement traceability (ReqAdr option)
     check_proof_contract_symbols/1, % Returns unresolved or unexpected required_proofs symbol issues
     check_no_dangling_refs/1,       % Returns list of dangling ref violations
@@ -198,6 +199,18 @@ check_symbol_coverage(Violations) :-
     sort(SymbolIds0, SymbolIds),
     maplist(symbol_coverage_violation, SymbolIds, Violations).
 
+%% check_changed_symbol_coverage(+ExtraSymbols, -Violations)
+% The symbol-coverage rule for the staged gate: the same violations
+% check_symbol_coverage/1 reports, restricted to the changed symbols
+% (kb:changed_symbol/1 overlay facts plus ExtraSymbols).
+% implements REQ-014
+check_changed_symbol_coverage(ExtraSymbols, Violations) :-
+    findall(SymbolId,
+            changed_symbol_no_req_coverage(ExtraSymbols, SymbolId),
+            SymbolIds0),
+    sort(SymbolIds0, SymbolIds),
+    maplist(symbol_coverage_violation, SymbolIds, Violations).
+
 symbol_coverage_violation(SymbolId, violation(
     'symbol-coverage',
     SymbolId,

package/src/kb.pl

@@ -61,6 +61,7 @@
     adr_chain/2,
     deprecated_no_successor/1,
     symbol_no_req_coverage/2,
+    changed_symbol_no_req_coverage/2,
     predicate_schema/6,
     predicate_schema_keys/4,
     predicate_fact/5,
@@ -2465,12 +2466,36 @@ coverage_gap(Req, missing_test) :-
     has_scenario(Req),
     \+ has_test(Req).
 
+% implements REQ-core-validation-rules
+% Only a current must-priority requirement owes scenario and test coverage.
 must_requirement(Req) :-
     kb_entity(Req, req, Props),
     memberchk(priority=Priority, Props),
     normalize_term_atom(Priority, PriorityAtom),
     atom_string(PriorityAtom, PriorityStr),
-    sub_string(PriorityStr, _, 4, 0, "must").
+    sub_string(PriorityStr, _, 4, 0, "must"),
+    coverage_current_requirement(Req, Props).
+
+%% coverage_current_requirement(+Req, +Props)
+% A requirement is still owed coverage unless it is retired: superseded by
+% another requirement (the target of `supersedes`), carrying a retired status,
+% or `closed` without the `implemented` tag (a closed requirement is retired
+% work unless it records that it was implemented, the same rule the
+% coverage-depth review applies).  A requirement without a status keeps the
+% obligation.
+coverage_current_requirement(Req, Props) :-
+    \+ kb_relationship(supersedes, _, Req),
+    (   memberchk(status=RawStatus, Props)
+    ->  normalize_term_atom(RawStatus, Status)
+    ;   Status = missing
+    ),
+    \+ memberchk(Status, [deprecated, superseded, archived, removed, deleted, rejected]),
+    (   Status == closed
+    ->  memberchk(tags=RawTags, Props),
+        normalize_term_atom_list(RawTags, Tags),
+        memberchk(implemented, Tags)
+    ;   true
+    ).
 
 has_scenario(Req) :-
     once(kb_relationship(specified_by, Req, _)).
@@ -3327,6 +3352,23 @@ changed_symbol_missing_req(Symbol, MinLinks, Count) :-
     length(UniqueReqs, Count),
     Count < MinLinks.
 
+%% changed_symbol_no_req_coverage(+ExtraSymbols, -Symbol)
+% The full-check symbol-coverage rule restricted to a staged change set: the
+% overlay changed_symbol/1 facts plus ExtraSymbols (symbols whose staged
+% manifest entry changed). It reuses symbol_no_req_coverage/2, so the staged
+% gate and `kibi check` judge coverage identically: a direct req->test edge
+% counts only while the requirement has no scenario.
+% implements REQ-014
+changed_symbol_no_req_coverage(ExtraSymbols, Symbol) :-
+    findall(Candidate,
+            (   changed_symbol(Candidate)
+            ;   member(Candidate, ExtraSymbols)
+            ),
+            Candidates0),
+    sort(Candidates0, Candidates),
+    member(Symbol, Candidates),
+    symbol_no_req_coverage(Symbol, _).
+
 %% changed_symbol_violation(+Symbol, +MinLinks, -Count, -File, -Line, -Col, -Name)
 % Full violation record for a changed symbol missing requirements.
 changed_symbol_violation(Symbol, MinLinks, Count, File, Line, Col, Name) :-

package/src/rule_registry.pl

@@ -17,6 +17,7 @@
 known_rule('must-priority-coverage').
 known_rule('symbol-coverage').
 known_rule('symbol-traceability').
+known_rule('symbol-granularity').
 known_rule('no-dangling-refs').
 known_rule('source-relationship-parity').
 known_rule('branch-store-not-compiled').
@@ -69,6 +70,7 @@ known_rule('policy-markers').
 rule_enforcement_class('must-priority-coverage', canonical).
 rule_enforcement_class('symbol-coverage', canonical).
 rule_enforcement_class('symbol-traceability', canonical).
+rule_enforcement_class('symbol-granularity', canonical).
 rule_enforcement_class('no-dangling-refs', canonical).
 rule_enforcement_class('source-relationship-parity', canonical).
 rule_enforcement_class('branch-store-not-compiled', canonical).
@@ -121,6 +123,7 @@ rule_enforcement_class('policy-markers', canonical).
 rule_implementation('must-priority-coverage', prolog).
 rule_implementation('symbol-coverage', prolog).
 rule_implementation('symbol-traceability', prolog).
+rule_implementation('symbol-granularity', typescript).
 rule_implementation('no-dangling-refs', prolog).
 rule_implementation('source-relationship-parity', typescript).
 rule_implementation('branch-store-not-compiled', typescript).
@@ -240,9 +243,10 @@ rule_predicate_arity('symbol-owner-superseded', 1).
 rule_predicate_arity('adr-unlinked', 1).
 rule_predicate_arity('adr-proposed', 1).
 
-rule_description('must-priority-coverage', 'Every must-priority requirement must have a scenario and a test').
+rule_description('must-priority-coverage', 'Every current must-priority requirement (not superseded, retired, or closed without the implemented tag) must have a scenario and a test').
 rule_description('symbol-coverage', 'Production symbols need qualifying coverage via covered_by plus a canonical requirement/scenario test path').
 rule_description('symbol-traceability', 'Production symbols must directly implement requirements for ownership; covered_by is coverage only and executable_for is test identity only').
+rule_description('symbol-granularity', 'A symbol with traceability relationships must not link its source file coarsely while narrower behavioral symbols are available, unless it carries an allowed granularity_reason; the staged gate\'s symbol_granularity_violation evaluated KB-wide').
 rule_description('no-dangling-refs', 'All relationship targets must exist in the KB').
 rule_description('source-relationship-parity', 'Authored Markdown and relationship-shard edges must exactly match the compiled KB').
 rule_description('branch-store-not-compiled', 'The current branch\'s KB store must be compiled from the authored .kb/ sources; a missing or empty store is reported once, naming kibi sync, instead of every store-backed rule reading an empty KB').