kibi-core 0.21.0 → 0.21.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",

package/schema/entities.pl

@@ -51,6 +51,10 @@ entity_property(req, approval_ref, string).
 entity_property(req, rationale, string).
 % Claim keys of the exempted requirement an exception waives (all when absent).
 entity_property(req, exempts_claims, list).
+% How firmly a requirement or ADR was decided: firm, default or exploratory.
+% Absent reads as default.
+entity_property(req, firmness, atom).
+entity_property(adr, firmness, atom).
 % Intended outcome of a scenario: success, rejection or error.
 entity_property(scenario, expects, atom).
 
@@ -143,6 +147,8 @@ optional_property(req, approved_by).
 optional_property(req, approval_ref).
 optional_property(req, rationale).
 optional_property(req, exempts_claims).
+optional_property(req, firmness).
+optional_property(adr, firmness).
 optional_property(test, verification_scope).
 optional_property(test, verification_perspective).
 optional_property(test, proof_contract).

package/src/discovery.pl

@@ -708,14 +708,18 @@ ask_schema_dict(Namespace, Name, SchemaDict, ArgumentNames) :-
     ArgumentNames = SchemaDict.argumentNames.
 ask_schema_dict(_Namespace, _Name, null, none).
 
+% A built-in row carries the catalog id that kb_model accepts as schemaId;
+% `stored: false` says no entity with that id exists, so it is not a
+% kb_query id.
 ask_builtin_schema_row(Namespace, Name, Arity, KeyPositions, DecisionPosition, Row) :-
-    builtin_argument_names(Name, Names),
+    kb:builtin_predicate_signature(Name, SchemaId, Names),
     findall(Key, (member(P, KeyPositions), nth1(P, Names, Key)), KeyArguments),
     nth1(DecisionPosition, Names, DecisionArgument),
     aggregate_all(count, kb:predicate_fact(_, Namespace, Name, _, _), FactCount),
     Row = _{
-        id: null,
+        id: SchemaId,
         builtin: true,
+        stored: false,
         namespace: Namespace,
         name: Name,
         arity: Arity,
@@ -728,9 +732,6 @@ ask_builtin_schema_row(Namespace, Name, Arity, KeyPositions, DecisionPosition, R
         factCount: FactCount
     }.
 
-% Keep in step with builtin_decision_predicate/5 in kb.pl.
-builtin_argument_names(permission_rule, [actor, action, resource, decision]).
-
 ask_schema_row(SchemaId, Namespace, Name, Arity, ArgumentNames, ArgumentTypes, Row) :-
     kb_entity(SchemaId, fact, Props),
     (   memberchk(key_arguments=KeysRaw, Props)
@@ -755,6 +756,7 @@ ask_schema_row(SchemaId, Namespace, Name, Arity, ArgumentNames, ArgumentTypes, R
     Row = _{
         id: SchemaId,
         builtin: false,
+        stored: true,
         namespace: Namespace,
         name: Name,
         arity: Arity,

package/src/kb.pl

@@ -2845,6 +2845,15 @@ bind_key_arguments([Position|Positions], ArgsA, ArgsB) :-
 % predicate-catalog-4.ts (permission_rule: actor, action, resource).
 builtin_decision_predicate(default, permission_rule, 4, [1, 2, 3], 4).
 
+%% builtin_predicate_signature(?Name, ?SchemaId, ?ArgumentNames)
+% implements REQ-kibi-query-fact-filters
+% The catalog id and argument names of a built-in decision predicate.  The
+% id is the one kb_model accepts as schemaId; no entity with that id is
+% stored, so a kb_query by id finds nothing.  Keep in step with
+% builtin_decision_predicate/5 and the catalog entry in
+% packages/cli/src/operations/modeling/predicate-catalog-4.ts.
+builtin_predicate_signature(permission_rule, 'FACT-SCHEMA-PERMISSION-RULE', [actor, action, resource, decision]).
+
 %% effective_decision(+Decision, +Polarity, -Effect)
 effective_decision(allow, assert, allow).
 effective_decision(allow, deny, deny).

package/src/rule_registry.pl

@@ -59,6 +59,10 @@ known_rule('adr-proposed').
 known_rule('predicate-schema-conformance').
 known_rule('entity-context-missing').
 known_rule('entity-context-acknowledged').
+known_rule('decision-firm-unreferenced').
+known_rule('decision-firm-superseded').
+known_rule('supersedes-reason-missing').
+known_rule('supersedes-reason-acknowledged').
 known_rule('policy-ownership').
 known_rule('policy-markers').
 
@@ -107,6 +111,10 @@ rule_enforcement_class('adr-proposed', advisory).
 rule_enforcement_class('predicate-schema-conformance', advisory).
 rule_enforcement_class('entity-context-missing', canonical).
 rule_enforcement_class('entity-context-acknowledged', advisory).
+rule_enforcement_class('decision-firm-unreferenced', canonical).
+rule_enforcement_class('decision-firm-superseded', canonical).
+rule_enforcement_class('supersedes-reason-missing', canonical).
+rule_enforcement_class('supersedes-reason-acknowledged', advisory).
 rule_enforcement_class('policy-ownership', canonical).
 rule_enforcement_class('policy-markers', canonical).
 
@@ -155,6 +163,10 @@ rule_implementation('adr-proposed', prolog).
 rule_implementation('predicate-schema-conformance', typescript).
 rule_implementation('entity-context-missing', typescript).
 rule_implementation('entity-context-acknowledged', typescript).
+rule_implementation('decision-firm-unreferenced', typescript).
+rule_implementation('decision-firm-superseded', typescript).
+rule_implementation('supersedes-reason-missing', typescript).
+rule_implementation('supersedes-reason-acknowledged', typescript).
 rule_implementation('policy-ownership', typescript).
 rule_implementation('policy-markers', typescript).
 
@@ -273,5 +285,9 @@ rule_description('adr-proposed', 'Informational: an ADR that is still proposed a
 rule_description('predicate-schema-conformance', 'Predicate facts match a predicate_schema (project-local, or the built-in catalog in the default namespace) and use its declared argument constants').
 rule_description('entity-context-missing', 'A current requirement, scenario, test, ADR or observation/meta fact must carry body context: at least 12 words of prose (requirements: under a Context, Rationale, Why, Background, Source, Notes or Evidence heading) that do not restate the title or semantic_text; entities tagged review:context-missing are acknowledged legacy and exempt').
 rule_description('entity-context-acknowledged', 'Informational: how many current entities carry the review:context-missing tag, so the legacy context backlog stays visible; one summary finding per check').
+rule_description('decision-firm-unreferenced', 'A requirement or ADR marked firmness: firm must name the human words it rests on: origin.ref (or approval_ref on a requirement); Kibi checks that the reference is present, not that it is genuine').
+rule_description('decision-firm-superseded', 'A requirement or ADR that supersedes a firm decision, retired or not, must itself be firm (and so carry a ref to the human who changed the rule); a default or exploratory replacement cannot overrule a firm decision').
+rule_description('supersedes-reason-missing', 'A current requirement or ADR that supersedes another must explain why under a \'Why this changed\' heading (at least 12 words of prose naming the evidence and answering the old decision\'s reasoning); supersede edges recorded before schema 9 are acknowledged in the manifest and exempt').
+rule_description('supersedes-reason-acknowledged', 'Informational: how many current superseding requirements and ADRs have only supersede edges the schema 9 migration acknowledged without a \'Why this changed\' section; one summary finding per check').
 rule_description('policy-ownership', 'When a plugin activated for kibi.check-policy.v1 declares ownership rules, every production symbol in a rule\'s file set must implement a current requirement grounded (requires_predicate) in one of the rule\'s predicates; projects without an activated check policy are unaffected').
 rule_description('policy-markers', 'When a plugin activated for kibi.check-policy.v1 declares marker rules, every file implementing a requirement grounded in the rule\'s pattern predicate (with its declared sibling files) must contain each marker the KB declares for that pattern').