kibi-core 0.1.9 → 0.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.1.9",
+  "version": "0.2.0",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",

package/src/checks.pl

@@ -324,7 +324,7 @@ deprecated_adr_violation(violation(
 )) :-
     deprecated_no_successor(AdrId),
     
-    Description = "Archived/deprecated ADR has no successor — add a supersedes link from the replacement ADR",
+    Description = "Superseded/deprecated ADR has no successor — add a supersedes link from the replacement ADR",
     
     format(string(Suggestion), "Create a new ADR and add: links: [{type: supersedes, target: ~w}]", [AdrId]),
     

package/src/discovery.pl

@@ -0,0 +1,461 @@
+% Module: discovery
+% Curated discovery, reporting, and bounded graph traversal predicates.
+
+:- module(discovery, [
+    find_gaps_json/8,
+    coverage_report_json/7,
+    graph_expand_json/8
+]).
+
+:- use_module(library(http/json)).
+:- use_module('kb.pl').
+:- use_module('status.pl', [status_meta_dict/1]).
+:- use_module('../schema/relationships.pl', [relationship_type/1]).
+
+find_gaps_json(TypeFilter, MissingRelationships, PresentRelationships, Tags, SourceFilter, Limit, Offset, JsonString) :-
+    findall(
+        Row,
+        matching_gap_row(TypeFilter, MissingRelationships, PresentRelationships, Tags, SourceFilter, Row),
+        Rows0
+    ),
+    sort_dict_rows(Rows0, SortedRows),
+    paginate_rows(SortedRows, Offset, Limit, Rows),
+    length(SortedRows, Count),
+    status_meta_dict(Meta),
+    Response = _{rows: Rows, count: Count, meta: Meta},
+    dict_json_string(Response, JsonString).
+
+coverage_report_json(By, Tags, IncludePassing, IncludeTransitive, Limit, Offset, JsonString) :-
+    coverage_rows(By, Tags, IncludePassing, IncludeTransitive, Rows0, Summary),
+    sort_dict_rows(Rows0, SortedRows),
+    paginate_rows(SortedRows, Offset, Limit, Rows),
+    status_meta_dict(Meta),
+    Response = _{summary: Summary, rows: Rows, meta: Meta},
+    dict_json_string(Response, JsonString).
+
+graph_expand_json(SeedIds, Relationships, Direction, Depth, EntityTypes, MaxNodes, MaxEdges, JsonString) :-
+    sort(SeedIds, SeedSet),
+    bfs_layers(SeedSet, SeedSet, [], Relationships, Direction, Depth, MaxNodes, MaxEdges, SeenNodes0, SeenEdges0, Truncated0),
+    append(SeedSet, SeenNodes0, SeededNodes0),
+    sort(SeededNodes0, SeenNodes),
+    include(keep_entity_type(EntityTypes), SeenNodes, FilteredNodes0),
+    sort(FilteredNodes0, FilteredNodes),
+    include(edge_kept(FilteredNodes), SeenEdges0, FilteredEdges0),
+    sort(FilteredEdges0, FilteredEdges),
+    maplist(node_dict, FilteredNodes, Nodes),
+    maplist(edge_dict, FilteredEdges, Edges),
+    (   Truncated0
+    ->  Truncated = true
+    ;   Truncated = false
+    ),
+    status_meta_dict(Meta),
+    Response = _{nodes: Nodes, edges: Edges, truncated: Truncated, meta: Meta},
+    dict_json_string(Response, JsonString).
+
+matching_gap_row(TypeFilter, MissingRelationships, PresentRelationships, Tags, SourceFilter, Row) :-
+    kb_entity(Id, Type, Props),
+    matches_type(TypeFilter, Type),
+    matches_tags(Tags, Props),
+    matches_source(SourceFilter, Props),
+    relationships_missing(Id, MissingRelationships),
+    relationships_present(Id, PresentRelationships),
+    entity_title_status_source(Props, Title, Status, Source),
+    relationship_counts(Id, Counts),
+    Row = _{
+        id: Id,
+        type: Type,
+        title: Title,
+        status: Status,
+        missingRelationships: MissingRelationships,
+        presentRelationships: PresentRelationships,
+        relationshipCounts: Counts,
+        source: Source
+    }.
+
+relationships_missing(_Id, []).
+relationships_missing(Id, [Relationship|Rest]) :-
+    relationship_count(Id, Relationship, 0),
+    relationships_missing(Id, Rest).
+
+relationships_present(_Id, []).
+relationships_present(Id, [Relationship|Rest]) :-
+    relationship_count(Id, Relationship, Count),
+    Count > 0,
+    relationships_present(Id, Rest).
+
+relationship_counts(Id, CountsDict) :-
+    findall(Relationship-Count,
+        (relationship_type(Relationship), relationship_count(Id, Relationship, Count)),
+        Pairs),
+    dict_pairs(CountsDict, relationship_counts, Pairs).
+
+relationship_count(Id, Relationship, Count) :-
+    findall(1,
+        (kb_relationship(Relationship, Id, _); kb_relationship(Relationship, _, Id)),
+        Matches),
+    length(Matches, Count).
+
+coverage_rows(req, Tags, IncludePassing, IncludeTransitive, Rows, Summary) :-
+    !,
+    findall(Row,
+        requirement_coverage_row(Tags, IncludeTransitive, Row),
+        AllRows),
+    filter_req_coverage_rows(IncludePassing, AllRows, Rows),
+    coverage_summary(AllRows, Summary).
+coverage_rows(symbol, Tags, IncludePassing, _IncludeTransitive, Rows, Summary) :-
+    !,
+    findall(Row,
+        symbol_coverage_row(Tags, Row),
+        AllRows),
+    filter_symbol_coverage_rows(IncludePassing, AllRows, Rows),
+    length(AllRows, Total),
+    include(symbol_row_fully_covered, AllRows, CoveredRows),
+    length(CoveredRows, Covered),
+    Uncovered is Total - Covered,
+    Summary = _{total: Total, fullyCovered: Covered, uncovered: Uncovered}.
+coverage_rows(type, _Tags, _IncludePassing, _IncludeTransitive, Rows, Summary) :-
+    findall(Type-Count,
+        type_entity_count(Type, Count),
+        Pairs),
+    maplist(type_pair_row, Pairs, Rows),
+    length(Rows, Total),
+    Summary = _{total: Total}.
+
+requirement_coverage_row(Tags, IncludeTransitive, Row) :-
+    kb_entity(Id, req, Props),
+    matches_tags(Tags, Props),
+    entity_title_status_source(Props, Title, Status, _Source),
+    entity_priority(Props, Priority),
+    count_distinct_targets(specified_by, Id, source, ScenarioCount),
+    requirement_test_count(Id, TestCount),
+    count_direct_symbols(Id, DirectSymbolCount),
+    count_transitive_symbols(Id, IncludeTransitive, TransitiveSymbolCount),
+    requirement_coverage_state(Id, Props, Gaps, Evaluated, CoverageStatus),
+    Row = _{
+        id: Id,
+        type: req,
+        title: Title,
+        status: Status,
+        priority: Priority,
+        scenarioCount: ScenarioCount,
+        testCount: TestCount,
+        directSymbolCount: DirectSymbolCount,
+        transitiveSymbolCount: TransitiveSymbolCount,
+        gaps: Gaps,
+        evaluated: Evaluated,
+        coverageStatus: CoverageStatus
+    }.
+
+symbol_coverage_row(Tags, Row) :-
+    kb_entity(Id, symbol, Props),
+    matches_tags(Tags, Props),
+    entity_title_status_source(Props, Title, Status, _Source),
+    count_direct_requirements(Id, DirectRequirementCount),
+    count_direct_tests(Id, TestCount),
+    (   symbol_no_req_coverage(Id, _)
+    ->  Gaps = [missing_requirement],
+        CoverageStatus = uncovered
+    ;   Gaps = [],
+        CoverageStatus = fully_covered
+    ),
+    Row = _{
+        id: Id,
+        type: symbol,
+        title: Title,
+        status: Status,
+        directRequirementCount: DirectRequirementCount,
+        testCount: TestCount,
+        gaps: Gaps,
+        coverageStatus: CoverageStatus
+    }.
+
+coverage_summary(Rows, Summary) :-
+    length(Rows, Total),
+    include(req_row_evaluated, Rows, EvaluatedRows),
+    include(req_row_fully_covered, Rows, FullyCoveredRows),
+    include(req_row_uncovered, Rows, UncoveredRows),
+    include(req_row_not_applicable, Rows, NotApplicableRows),
+    include(req_row_missing_scenario, Rows, MissingScenarioRows),
+    include(req_row_missing_test, Rows, MissingTestRows),
+    include(req_row_missing_both, Rows, MissingBothRows),
+    length(EvaluatedRows, Evaluated),
+    length(FullyCoveredRows, FullyCovered),
+    length(UncoveredRows, Uncovered),
+    length(NotApplicableRows, NotApplicable),
+    length(MissingScenarioRows, MissingScenario),
+    length(MissingTestRows, MissingTest),
+    length(MissingBothRows, MissingScenarioAndTest),
+    Summary = _{
+        total: Total,
+        evaluated: Evaluated,
+        fullyCovered: FullyCovered,
+        uncovered: Uncovered,
+        notApplicable: NotApplicable,
+        missingScenario: MissingScenario,
+        missingTest: MissingTest,
+        missingScenarioAndTest: MissingScenarioAndTest
+    }.
+
+req_row_fully_covered(Row) :-
+    CoverageStatus = Row.get(coverageStatus),
+    CoverageStatus = fully_covered.
+req_row_evaluated(Row) :-
+    Evaluated = Row.get(evaluated),
+    Evaluated = true.
+req_row_uncovered(Row) :-
+    CoverageStatus = Row.get(coverageStatus),
+    CoverageStatus = uncovered.
+req_row_not_applicable(Row) :-
+    CoverageStatus = Row.get(coverageStatus),
+    CoverageStatus = not_applicable.
+req_row_missing_scenario(Row) :-
+    Row.gaps = [missing_scenario].
+req_row_missing_test(Row) :-
+    Row.gaps = [missing_test].
+req_row_missing_both(Row) :-
+    Row.gaps = [missing_scenario_and_test].
+
+symbol_row_fully_covered(Row) :-
+    CoverageStatus = Row.get(coverageStatus),
+    CoverageStatus = fully_covered.
+
+count_distinct_targets(Relationship, Id, source, Count) :-
+    !,
+    findall(Target, kb_relationship(Relationship, Id, Target), Targets0),
+    sort(Targets0, Targets),
+    length(Targets, Count).
+
+requirement_test_count(Id, Count) :-
+    findall(TestId, kb_relationship(verified_by, Id, TestId), Verified0),
+    findall(TestId, kb_relationship(validates, TestId, Id), Validates0),
+    append(Verified0, Validates0, Combined0),
+    sort(Combined0, Combined),
+    length(Combined, Count).
+
+count_direct_symbols(Id, Count) :-
+    findall(SymbolId, kb_relationship(implements, SymbolId, Id), Symbols0),
+    sort(Symbols0, Symbols),
+    length(Symbols, Count).
+
+count_transitive_symbols(Id, true, Count) :-
+    !,
+    findall(SymbolId, transitively_implements(SymbolId, Id), Symbols0),
+    sort(Symbols0, Symbols),
+    length(Symbols, Count).
+count_transitive_symbols(Id, false, Count) :-
+    count_direct_symbols(Id, Count).
+
+count_direct_requirements(Id, Count) :-
+    findall(ReqId, kb_relationship(implements, Id, ReqId), ReqIds0),
+    sort(ReqIds0, ReqIds),
+    length(ReqIds, Count).
+
+count_direct_tests(Id, Count) :-
+    findall(TestId, kb_relationship(covered_by, Id, TestId), TestIds0),
+    sort(TestIds0, TestIds),
+    length(TestIds, Count).
+
+requirement_gap_list(Id, [Reason]) :-
+    coverage_gap(Id, Reason),
+    !.
+requirement_gap_list(_, []).
+
+requirement_coverage_state(Id, Props, Gaps, true, CoverageStatus) :-
+    entity_priority(Props, Priority),
+    must_priority(Priority),
+    !,
+    requirement_gap_list(Id, Gaps),
+    (   Gaps = []
+    ->  CoverageStatus = fully_covered
+    ;   CoverageStatus = uncovered
+    ).
+requirement_coverage_state(_Id, _Props, [], false, not_applicable).
+
+filter_req_coverage_rows(true, Rows, Rows).
+filter_req_coverage_rows(false, Rows, Filtered) :-
+    exclude(req_row_fully_covered, Rows, Filtered).
+
+filter_symbol_coverage_rows(true, Rows, Rows).
+filter_symbol_coverage_rows(false, Rows, Filtered) :-
+    exclude(symbol_row_fully_covered, Rows, Filtered).
+
+entity_priority(Props, Priority) :-
+    (   memberchk(priority=PriorityValue, Props)
+    ->  source_value_atom(PriorityValue, Priority)
+    ;   Priority = ''
+    ).
+
+must_priority(Priority) :-
+    atom(Priority),
+    downcase_atom(Priority, Lowercase),
+    sub_atom(Lowercase, _, 4, 0, must).
+
+type_entity_count(Type, Count) :-
+    setof(Id, Props^kb_entity(Id, Type, Props), Ids),
+    length(Ids, Count).
+
+type_pair_row(Type-Count, _{id: Type, type: Type, count: Count}).
+
+bfs_layers(_Frontier, SeenNodes, SeenEdges, _Relationships, _Direction, 0, _MaxNodes, _MaxEdges, SeenNodes, SeenEdges, false) :- !.
+bfs_layers([], SeenNodes, SeenEdges, _Relationships, _Direction, _Depth, _MaxNodes, _MaxEdges, SeenNodes, SeenEdges, false) :- !.
+bfs_layers(Frontier, SeenNodes, SeenEdges, Relationships, Direction, Depth, MaxNodes, MaxEdges, FinalNodes, FinalEdges, Truncated) :-
+    (   length(SeenNodes, NodeCount), NodeCount >= MaxNodes
+    ->  FinalNodes = SeenNodes,
+        FinalEdges = SeenEdges,
+        Truncated = true
+    ;   length(SeenEdges, EdgeCount), EdgeCount >= MaxEdges
+    ->  FinalNodes = SeenNodes,
+        FinalEdges = SeenEdges,
+        Truncated = true
+    ;   findall(Edge-Next,
+            (member(Current, Frontier), edge_step(Current, Relationships, Direction, Edge, Next)),
+            Pairs0),
+        sort(Pairs0, Pairs),
+        collect_pairs(Pairs, SeenNodes, SeenEdges, MaxNodes, MaxEdges, NextFrontier, NextNodes, NextEdges, HitLimit),
+        Depth1 is Depth - 1,
+        bfs_layers(NextFrontier, NextNodes, NextEdges, Relationships, Direction, Depth1, MaxNodes, MaxEdges, FinalNodes, FinalEdges, Truncated1),
+        (   HitLimit
+        ->  Truncated = true
+        ;   Truncated = Truncated1
+        )
+    ).
+
+collect_pairs([], SeenNodes, SeenEdges, _MaxNodes, _MaxEdges, [], SeenNodes, SeenEdges, false).
+collect_pairs([Edge-Next|Rest], SeenNodes, SeenEdges, MaxNodes, MaxEdges, Frontier, FinalNodes, FinalEdges, HitLimit) :-
+    (   memberchk(Edge, SeenEdges)
+    ->  true,
+        collect_pairs(Rest, SeenNodes, SeenEdges, MaxNodes, MaxEdges, Frontier, FinalNodes, FinalEdges, HitLimit)
+    ;   collect_new_pair(Edge, Next, Rest, SeenNodes, SeenEdges, MaxNodes, MaxEdges, Frontier, FinalNodes, FinalEdges, HitLimit)
+    ).
+
+collect_new_pair(Edge, Next, _Rest, SeenNodes, SeenEdges, MaxNodes, MaxEdges, Frontier, FinalNodes, FinalEdges, HitLimit) :-
+    prepare_new_pair(Edge, Next, SeenNodes, SeenEdges, SeenNodes1, SeenEdges1, NewFrontier),
+    length(SeenNodes1, NodeCount),
+    length(SeenEdges1, EdgeCount),
+    (   NodeCount >= MaxNodes
+    ;   EdgeCount >= MaxEdges
+    ),
+    !,
+    Frontier = NewFrontier,
+    FinalNodes = SeenNodes1,
+    FinalEdges = SeenEdges1,
+    HitLimit = true.
+collect_new_pair(Edge, Next, Rest, SeenNodes, SeenEdges, MaxNodes, MaxEdges, Frontier, FinalNodes, FinalEdges, HitLimit) :-
+    prepare_new_pair(Edge, Next, SeenNodes, SeenEdges, SeenNodes1, SeenEdges1, NewFrontier),
+    collect_pairs(Rest, SeenNodes1, SeenEdges1, MaxNodes, MaxEdges, FrontierRest, FinalNodes, FinalEdges, HitLimitRest),
+    append(NewFrontier, FrontierRest, Frontier),
+    HitLimit = HitLimitRest.
+
+prepare_new_pair(Edge, Next, SeenNodes, SeenEdges, SeenNodes1, SeenEdges1, NewFrontier) :-
+    append(SeenEdges, [Edge], SeenEdges1),
+    (   memberchk(Next, SeenNodes)
+    ->  SeenNodes1 = SeenNodes,
+        NewFrontier = []
+    ;   append(SeenNodes, [Next], SeenNodes1),
+        NewFrontier = [Next]
+    ).
+
+edge_step(Current, Relationships, outgoing, edge(Type, Current, Next), Next) :-
+    relationship_allowed(Relationships, Type),
+    kb_relationship(Type, Current, Next).
+edge_step(Current, Relationships, incoming, edge(Type, Prev, Current), Prev) :-
+    relationship_allowed(Relationships, Type),
+    kb_relationship(Type, Prev, Current).
+edge_step(Current, Relationships, both, Edge, Next) :-
+    edge_step(Current, Relationships, outgoing, Edge, Next).
+edge_step(Current, Relationships, both, Edge, Next) :-
+    edge_step(Current, Relationships, incoming, Edge, Next).
+
+relationship_allowed([], Type) :-
+    relationship_type(Type).
+relationship_allowed(Relationships, Type) :-
+    memberchk(Type, Relationships).
+
+keep_entity_type([], _Id).
+keep_entity_type(EntityTypes, Id) :-
+    kb_entity(Id, Type, _),
+    memberchk(Type, EntityTypes).
+
+edge_kept(KeptNodes, edge(_Type, From, To)) :-
+    memberchk(From, KeptNodes),
+    memberchk(To, KeptNodes).
+
+node_dict(Id, _{id: Id, type: Type, title: Title, status: Status}) :-
+    kb_entity(Id, Type, Props),
+    entity_title_status_source(Props, Title, Status, _Source).
+
+edge_dict(edge(Type, From, To), _{type: Type, from: From, to: To}).
+
+matches_type(none, _Type).
+matches_type(TypeFilter, Type) :-
+    TypeFilter \= none,
+    Type = TypeFilter.
+
+matches_tags([], _Props).
+matches_tags(Tags, Props) :-
+    memberchk(tags=EntityTags, Props),
+    member(Tag, Tags),
+    member(Tag, EntityTags),
+    !.
+
+matches_source(none, _Props).
+matches_source(SourceFilter, Props) :-
+    memberchk(source=SourceValue, Props),
+    source_value_atom(SourceValue, SourceAtom),
+    sub_atom(SourceAtom, _, _, _, SourceFilter).
+
+entity_title_status_source(Props, Title, Status, Source) :-
+    memberchk(title=TitleValue, Props),
+    memberchk(status=StatusValue, Props),
+    (   memberchk(source=SourceValue, Props)
+    ->  source_value_atom(SourceValue, Source)
+    ;   Source = ''
+    ),
+    source_value_atom(TitleValue, Title),
+    source_value_atom(StatusValue, Status).
+
+source_value_atom(Val, Atom) :-
+    nonvar(Val),
+    compound(Val),
+    Val =.. ['^^', Inner, _Type],
+    !,
+    source_value_atom(Inner, Atom).
+source_value_atom(literal(type(_, Val)), Atom) :-
+    !,
+    source_value_atom(Val, Atom).
+source_value_atom(Val, Atom) :-
+    string(Val),
+    !,
+    atom_string(Atom, Val).
+source_value_atom(Val, Atom) :-
+    atom(Val),
+    !,
+    Atom = Val.
+source_value_atom(Val, Atom) :-
+    term_string(Val, Str),
+    atom_string(Atom, Str).
+
+sort_dict_rows(Rows, SortedRows) :-
+    map_list_to_pairs(dict_row_sort_key, Rows, Pairs),
+    keysort(Pairs, SortedPairs),
+    pairs_values(SortedPairs, SortedRows).
+
+dict_row_sort_key(Row, Key) :-
+    Id = Row.get(id),
+    Type = Row.get(type),
+    format(atom(Key), '~w::~w', [Type, Id]).
+
+paginate_rows(Rows, Offset, Limit, PaginatedRows) :-
+    length(Prefix, Offset),
+    append(Prefix, Rest, Rows),
+    length(PaginatedRows, Limit),
+    append(PaginatedRows, _Tail, Rest),
+    !.
+paginate_rows(Rows, Offset, _Limit, PaginatedRows) :-
+    length(Prefix, Offset),
+    append(Prefix, PaginatedRows, Rows),
+    !.
+paginate_rows(_, _, _, []).
+
+dict_json_string(Dict, JsonString) :-
+    with_output_to(string(JsonString), json_write_dict(current_output, Dict, [])).

package/src/kb.pl

@@ -59,16 +59,15 @@ kb_uri('urn-kibi:').
 :- dynamic kb_attached/1.
 :- dynamic kb_audit_db/1.
 :- dynamic kb_graph/1.
+:- dynamic kb_attached_snapshot/1.
 :- dynamic entity/4.  % Support legacy .pl file format (Type, Id, Title, Props)
 
 %% kb_attach(+Directory)
 % Attach to a KB directory with RDF persistence and file locking.
 % Creates directory if it doesn't exist.
 kb_attach(Directory) :-
-    % If we were already attached in this process, detach first.
-    % This prevents accidentally loading the same RDF snapshot multiple times.
     (   kb_attached(_)
-    ->  kb_detach
+    ->  throw(error(permission_error(attach, kb, Directory), kb_attach/1))
     ;   true
     ),
     % Ensure directory exists
@@ -89,6 +88,7 @@ kb_attach(Directory) :-
     ->  rdf_load(DataFile, [graph(GraphURI), silent(true)])
     ;   true
     ),
+    current_data_stamp(DataFile, SnapshotStamp),
     % Set up audit log - only attach if not already attached
     atom_concat(Directory, '/audit.log', AuditLog),
     (   db_attached(AuditLog)
@@ -99,55 +99,114 @@ kb_attach(Directory) :-
     assert(kb_attached(Directory)),
     assert(kb_audit_db(AuditLog)),
     assert(kb_graph(GraphURI)),
+    assert(kb_attached_snapshot(SnapshotStamp)),
 
     % Load legacy .pl entity files if present
     load_kb_pl_files(Directory).
 
 
 %% kb_detach
-% Safely detach from KB, flushing journals and closing audit log.
+% Safely detach from KB without persisting pending changes.
+% Call kb_save/0 explicitly before kb_detach/0 when durability is required.
+% implements REQ-009
 kb_detach :-
     (   kb_attached(_Directory)
     ->  (
-            kb_save,
             % Unload RDF graph from memory to prevent duplication on reattach
             (   kb_graph(GraphURI)
             ->  rdf_unload_graph(GraphURI)
             ;   true
             ),
-            % Sync and close audit log
-            (   kb_audit_db(AuditLog)
-            ->  db_sync(AuditLog)
+            (   db_attached(_)
+            ->  catch(db_detach, _, true)
             ;   true
             ),
             % Clear state
             retractall(kb_attached(_)),
             retractall(kb_audit_db(_)),
-            retractall(kb_graph(_))
+            retractall(kb_graph(_)),
+            retractall(kb_attached_snapshot(_))
         )
     ;   true
     ).
 
 %% kb_save
 % Save RDF graph and sync audit log to disk
+% implements REQ-009
 kb_save :-
     (   kb_attached(Directory)
-    ->  (
-            % Save RDF graph to file with namespace declarations
-            atom_concat(Directory, '/kb.rdf', DataFile),
-            % Get current graph URI
-            kb_graph(GraphURI),
-            % If we have a graph URI, save that graph. Otherwise save all data
-            % (fallback) so a kb.rdf is always produced. Report errors if save fails.
-            (   kb_graph(GraphURI)
-            ->  catch(rdf_save(DataFile, [graph(GraphURI), base_uri('urn-kibi:'), namespaces([kb, xsd])]), E, print_message(error, E))
-            ;   catch(rdf_save(DataFile, [base_uri('urn-kibi:'), namespaces([kb, xsd])]), E2, print_message(error, E2))
-            ),
-            % Sync audit log
-            (   kb_audit_db(AuditLog)
-            ->  db_sync(AuditLog)
-            ;   true
-            )
+    ->  with_kb_mutex(with_kb_file_lock(Directory, kb_save_locked(Directory)))
+    ;   true
+    ).
+
+with_kb_file_lock(Directory, Goal) :-
+    atom_concat(Directory, '/kb.lock', LockFile),
+    setup_call_cleanup(
+        open(LockFile, append, LockStream, [lock(write)]),
+        call(Goal),
+        close(LockStream)
+    ).
+
+kb_save_locked(Directory) :-
+    atom_concat(Directory, '/kb.rdf', DataFile),
+    temp_rdf_file(Directory, TempFile),
+    catch(
+        (
+            ensure_snapshot_current(DataFile),
+            save_rdf_snapshot(TempFile),
+            rename_file(TempFile, DataFile),
+            current_data_stamp(DataFile, UpdatedStamp),
+            retractall(kb_attached_snapshot(_)),
+            assert(kb_attached_snapshot(UpdatedStamp)),
+            sync_audit_log
+        ),
+        Error,
+        (
+            cleanup_temp_file(TempFile),
+            throw(Error)
+        )
+    ).
+
+temp_rdf_file(Directory, TempFile) :-
+    get_time(Timestamp),
+    Millis is floor(Timestamp * 1000),
+    (   current_prolog_flag(pid, Pid)
+    ->  true
+    ;   Pid = 0
+    ),
+    format(atom(TempFile), '~w/kb.rdf.tmp.~w.~w', [Directory, Pid, Millis]).
+
+save_rdf_snapshot(TargetFile) :-
+    (   kb_graph(GraphURI)
+    ->  rdf_save(TargetFile, [graph(GraphURI), base_uri('urn-kibi:'), namespaces([kb, xsd])])
+    ;   rdf_save(TargetFile, [base_uri('urn-kibi:'), namespaces([kb, xsd])])
+    ).
+
+sync_audit_log :-
+    (   kb_audit_db(AuditLog)
+    ->  db_sync(AuditLog)
+    ;   true
+    ).
+
+cleanup_temp_file(TempFile) :-
+    (   exists_file(TempFile)
+    ->  catch(delete_file(TempFile), _, true)
+    ;   true
+    ).
+
+current_data_stamp(DataFile, missing) :-
+    \+ exists_file(DataFile),
+    !.
+current_data_stamp(DataFile, stamp(MTime, Size)) :-
+    time_file(DataFile, MTime),
+    size_file(DataFile, Size).
+
+ensure_snapshot_current(DataFile) :-
+    (   kb_attached_snapshot(ExpectedStamp)
+    ->  current_data_stamp(DataFile, CurrentStamp),
+        (   ExpectedStamp == CurrentStamp
+        ->  true
+        ;   throw(error(permission_error(save, kb, stale_snapshot), kb_save/0))
         )
     ;   true
     ).
@@ -554,12 +613,12 @@ conflicting(Adr1, Adr2) :-
     Adr1 @< Adr2.
 
 %% deprecated_still_used(+Adr, -Symbols)
-% Deprecated/archived/rejected ADRs that still constrain symbols.
+% Deprecated/superseded ADRs that still constrain symbols.
 deprecated_still_used(Adr, Symbols) :-
     kb_entity(Adr, adr, Props),
     memberchk(status=Status, Props),
     normalize_term_atom(Status, StatusAtom),
-    memberchk(StatusAtom, [deprecated, archived, rejected]),
+    memberchk(StatusAtom, [deprecated, superseded]),
     setof(Symbol, kb_relationship(constrained_by, Symbol, Adr), Symbols),
     !.
 deprecated_still_used(_, []).
@@ -569,9 +628,11 @@ deprecated_still_used(_, []).
 %% ------------------------------------------------------------------
 
 %% current_adr(+Id)
-% True when Id is an ADR not superseded by any other ADR.
+% True when Id is an accepted ADR not superseded by any other ADR.
 current_adr(Id) :-
-    kb_entity(Id, adr, _),
+    kb_entity(Id, adr, Props),
+    memberchk(status=Status, Props),
+    normalize_term_atom(Status, accepted),
     \+ kb_relationship(supersedes, _, Id).
 
 %% superseded_by(+OldId, -NewId)
@@ -593,20 +654,23 @@ adr_chain_acc(Id, Visited, [Id|Rest]) :-
     adr_chain_acc(Newer, [Id|Visited], Rest).
 
 %% deprecated_no_successor(+OldId)
-% Lint rule: ADR is archived/deprecated but has no supersedes relationship pointing to it.
+% Lint rule: ADR is superseded/deprecated but has no supersedes relationship pointing to it.
 deprecated_no_successor(Id) :-
     kb_entity(Id, adr, Props),
     memberchk(status=Status, Props),
     normalize_term_atom(Status, StatusAtom),
-    memberchk(StatusAtom, [archived, deprecated]),
+    memberchk(StatusAtom, [superseded, deprecated]),
     \+ kb_relationship(supersedes, _, Id).
 
 %% current_req(+Id)
-% Requirement is current when active and not superseded by another requirement.
+% Requirement is current when not deprecated and not superseded by another requirement.
+% Canonical statuses: open, in_progress, closed.
+% Legacy statuses accepted for backwards compatibility: active, approved.
 current_req(Id) :-
     kb_entity(Id, req, Props),
     memberchk(status=Status, Props),
-    normalize_term_atom(Status, active),
+    normalize_term_atom(Status, StatusAtom),
+    memberchk(StatusAtom, [open, in_progress, closed, active, approved]),
     \+ kb_relationship(supersedes, _, Id).
 
 %% contradicting_reqs(-ReqA, -ReqB, -Reason)

package/src/status.pl

@@ -0,0 +1,202 @@
+% Module: status
+% Curated KB status and freshness reporting for MCP and CLI surfaces.
+
+:- module(status, [
+    kb_status_json/1,
+    status_meta_dict/1
+]).
+
+:- use_module(library(http/json)).
+:- use_module('kb.pl').
+
+kb_status_json(JsonString) :-
+    status_meta_dict(StatusDict),
+    dict_json_string(StatusDict, JsonString).
+
+status_meta_dict(StatusDict) :-
+    attached_kb_info(Branch, KbPath, DataFile),
+    snapshot_id(SnapshotId),
+    synced_at(DataFile, SyncedAt),
+    freshness_state(DataFile, Dirty, SyncState),
+    StatusDict = _{
+        branch: Branch,
+        snapshotId: SnapshotId,
+        syncedAt: SyncedAt,
+        dirty: Dirty,
+        syncState: SyncState,
+        kbPath: KbPath,
+        lastSyncSource: persisted
+    }.
+
+attached_kb_info(Branch, KbPath, DataFile) :-
+    kb:kb_attached(KbPath),
+    branch_workspace_from_kb_path(KbPath, Branch, _WorkspaceRoot),
+    directory_file_path(KbPath, 'kb.rdf', DataFile).
+
+snapshot_id(SnapshotId) :-
+    kb:kb_attached_snapshot(stamp(MTime, Size)),
+    !,
+    format(atom(SnapshotId), 'stamp:~16f:~w', [MTime, Size]).
+snapshot_id(SnapshotId) :-
+    kb:kb_attached_snapshot(missing),
+    !,
+    SnapshotId = missing.
+snapshot_id(unknown).
+
+synced_at(DataFile, SyncedAt) :-
+    exists_file(DataFile),
+    !,
+    time_file(DataFile, Timestamp),
+    format_time(atom(SyncedAt), '%FT%TZ', Timestamp).
+synced_at(_, @(null)).
+
+freshness_state(DataFile, true, stale) :-
+    exists_file(DataFile),
+    time_file(DataFile, SnapshotTime),
+    workspace_state_changed(SnapshotTime),
+    !.
+freshness_state(DataFile, false, fresh) :-
+    exists_file(DataFile),
+    !.
+freshness_state(_, true, unknown).
+
+workspace_state_changed(SnapshotTime) :-
+    workspace_source_changed(SnapshotTime),
+    !.
+workspace_state_changed(SnapshotTime) :-
+    documentation_tree_changed(SnapshotTime),
+    !.
+
+workspace_source_changed(SnapshotTime) :-
+    attached_workspace_root(WorkspaceRoot),
+    kb_entity(_, _, Props),
+    memberchk(source=SourceValue, Props),
+    source_value_atom(SourceValue, SourceAtom),
+    repo_relative_source(SourceAtom, RelativeSource),
+    directory_file_path(WorkspaceRoot, RelativeSource, SourcePath),
+    (   exists_file(SourcePath)
+    ->  time_file(SourcePath, FileTime),
+        FileTime > SnapshotTime
+    ;   true
+    ),
+    !.
+
+documentation_tree_changed(SnapshotTime) :-
+    attached_workspace_root(WorkspaceRoot),
+    documentation_markdown_untracked(WorkspaceRoot),
+    !.
+documentation_tree_changed(SnapshotTime) :-
+    attached_workspace_root(WorkspaceRoot),
+    directory_file_path(WorkspaceRoot, 'documentation', DocumentationRoot),
+    exists_directory(DocumentationRoot),
+    directory_tree_newer(DocumentationRoot, SnapshotTime),
+    !.
+
+documentation_markdown_untracked(WorkspaceRoot) :-
+    directory_file_path(WorkspaceRoot, 'documentation', DocumentationRoot),
+    exists_directory(DocumentationRoot),
+    documentation_markdown_file(DocumentationRoot, FilePath),
+    path_relative_to_workspace(WorkspaceRoot, FilePath, RelativePath),
+    \+ known_source_path(RelativePath),
+    !.
+
+documentation_markdown_file(Path, Path) :-
+    exists_file(Path),
+    file_name_extension(_, md, Path),
+    !.
+documentation_markdown_file(Path, FilePath) :-
+    exists_directory(Path),
+    directory_files(Path, Entries),
+    member(Entry, Entries),
+    Entry \= '.',
+    Entry \= '..',
+    directory_file_path(Path, Entry, ChildPath),
+    documentation_markdown_file(ChildPath, FilePath).
+
+path_relative_to_workspace(WorkspaceRoot, FilePath, RelativePath) :-
+    atom_concat(WorkspaceRoot, '/', Prefix),
+    atom_concat(Prefix, RelativePath, FilePath).
+
+known_source_path(RelativePath) :-
+    kb_entity(_, _, Props),
+    memberchk(source=SourceValue, Props),
+    source_value_atom(SourceValue, SourceAtom),
+    repo_relative_source(SourceAtom, RelativePath).
+
+directory_tree_newer(Path, SnapshotTime) :-
+    time_file(Path, EntryTime),
+    EntryTime > SnapshotTime,
+    !.
+directory_tree_newer(Path, SnapshotTime) :-
+    exists_directory(Path),
+    directory_files(Path, Entries),
+    member(Entry, Entries),
+    Entry \= '.',
+    Entry \= '..',
+    directory_file_path(Path, Entry, ChildPath),
+    directory_tree_newer(ChildPath, SnapshotTime),
+    !.
+
+attached_workspace_root(WorkspaceRoot) :-
+    kb:kb_attached(KbPath),
+    branch_workspace_from_kb_path(KbPath, _Branch, WorkspaceRoot).
+
+branch_workspace_from_kb_path(KbPath, Branch, WorkspaceRoot) :-
+    branch_path_segments(KbPath, BranchesDir, Segments),
+    file_directory_name(BranchesDir, KbRoot),
+    file_directory_name(KbRoot, WorkspaceRoot),
+    atomic_list_concat(Segments, '/', Branch).
+
+branch_path_segments(KbPath, BranchesDir, [Base]) :-
+    file_directory_name(KbPath, BranchesDir),
+    file_base_name(BranchesDir, branches),
+    file_base_name(KbPath, Base).
+branch_path_segments(KbPath, BranchesDir, Segments) :-
+    file_directory_name(KbPath, Parent),
+    Parent \= KbPath,
+    branch_path_segments(Parent, BranchesDir, ParentSegments),
+    file_base_name(KbPath, Base),
+    append(ParentSegments, [Base], Segments).
+
+repo_relative_source(SourceAtom, RelativeSource) :-
+    strip_fragment(SourceAtom, NoFragment),
+    \+ sub_atom(NoFragment, _, _, _, '://'),
+    (   attached_workspace_root(WorkspaceRoot),
+        workspace_relative_path(WorkspaceRoot, NoFragment, RelativePath)
+    ->  RelativeSource = RelativePath
+    ;   RelativeSource = NoFragment
+    ).
+
+workspace_relative_path(WorkspaceRoot, SourcePath, RelativePath) :-
+    atom_concat(WorkspaceRoot, '/', Prefix),
+    atom_concat(Prefix, RelativePath, SourcePath).
+
+strip_fragment(SourceAtom, NoFragment) :-
+    (   sub_atom(SourceAtom, Before, _, _, '#')
+    ->  sub_atom(SourceAtom, 0, Before, _, NoFragment)
+    ;   NoFragment = SourceAtom
+    ).
+
+source_value_atom(Val, Atom) :-
+    nonvar(Val),
+    compound(Val),
+    Val =.. ['^^', Inner, _Type],
+    !,
+    source_value_atom(Inner, Atom).
+source_value_atom(literal(type(_, Val)), Atom) :-
+    !,
+    source_value_atom(Val, Atom).
+source_value_atom(Val, Atom) :-
+    string(Val),
+    !,
+    atom_string(Atom, Val).
+source_value_atom(Val, Atom) :-
+    atom(Val),
+    !,
+    Atom = Val.
+source_value_atom(Val, Atom) :-
+    term_string(Val, Str),
+    atom_string(Atom, Str).
+
+dict_json_string(Dict, JsonString) :-
+    with_output_to(string(JsonString), json_write_dict(current_output, Dict, [])).