kibi-core 0.1.8 → 0.1.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kibi-core",
-  "version": "0.1.8",
+  "version": "0.1.10",
   "private": false,
   "description": "Core Prolog modules and RDF graph logic for Kibi",
   "type": "module",

package/src/checks.pl

@@ -8,6 +8,7 @@
     check_all_json/1,               % Returns all violations as JSON string
     check_must_priority_coverage/1, % Returns list of must-priority violations
     check_symbol_coverage/1,        % Returns list of uncovered symbols
+    check_symbol_traceability/2,    % Returns list of symbols lacking direct traceability (ReqAdr option)
     check_no_dangling_refs/1,       % Returns list of dangling ref violations
     check_no_cycles/1,              % Returns list of cycle violations
     check_required_fields/1,        % Returns list of missing required field violations
@@ -34,9 +35,11 @@ all_relationship_types([
 %% check_all(-ViolationsDict)
 % Returns a dict with all violations grouped by rule type.
 % Each value is a list of violation terms: violation(Rule, EntityId, Description, Suggestion, Source)
+% For symbol-traceability, uses RequireAdr=false as default.
 check_all(ViolationsDict) :-
     check_must_priority_coverage(MustPriority),
     check_symbol_coverage(SymbolCoverage),
+    check_symbol_traceability(false, SymbolTraceability),
     check_no_dangling_refs(DanglingRefs),
     check_no_cycles(Cycles),
     check_required_fields(RequiredFields),
@@ -45,6 +48,7 @@ check_all(ViolationsDict) :-
     ViolationsDict = _{
         must_priority_coverage: MustPriority,
         symbol_coverage: SymbolCoverage,
+        symbol_traceability: SymbolTraceability,
         no_dangling_refs: DanglingRefs,
         no_cycles: Cycles,
         required_fields: RequiredFields,
@@ -98,6 +102,55 @@ symbol_coverage_violation(SymbolId, violation(
 )) :-
     violation_source(SymbolId, symbol, Source).
 
+%% check_symbol_traceability(+RequireAdr, -Violations)
+% Finds all symbols lacking direct traceability:
+% - Every symbol must have at least one direct 'implements' relationship to a requirement
+% - If RequireAdr=true, the symbol must also have at least one 'constrained_by' relationship to an ADR
+check_symbol_traceability(RequireAdr, Violations) :-
+    findall(
+        Violation,
+        symbol_traceability_violation(RequireAdr, Violation),
+        Violations0
+    ),
+    sort(Violations0, Violations).
+
+symbol_traceability_violation(RequireAdr, violation(
+    'symbol-traceability',
+    SymbolId,
+    Description,
+    Suggestion,
+    Source
+)) :-
+    kb_entity(SymbolId, symbol, _),
+    % Check if symbol has direct implements to a requirement
+    (   kb_relationship(implements, SymbolId, ReqId),
+        kb_entity(ReqId, req, _)
+    ->  HasReq = true
+    ;   HasReq = false
+    ),
+    % Check if symbol has constrained_by to ADR (only if required)
+    (   RequireAdr = true ->
+        (   kb_relationship(constrained_by, SymbolId, AdrId),
+            kb_entity(AdrId, adr, _)
+        ->  HasAdr = true
+        ;   HasAdr = false
+        )
+    ;   HasAdr = true  % Not required, so pass this check
+    ),
+    % Determine what is missing
+    (   HasReq = false, HasAdr = false, RequireAdr = true ->
+        Description = "Symbol has no direct requirement link and no ADR constraint.",
+        Suggestion = "Add 'implements: REQ-xxx' and 'constrained_by: ADR-xxx' in symbols.yaml."
+    ;   HasReq = false ->
+        Description = "Symbol has no direct requirement link.",
+        Suggestion = "Add 'implements: REQ-xxx' in symbols.yaml."
+    ;   HasAdr = false ->
+        Description = "Symbol has no ADR constraint.",
+        Suggestion = "Add 'constrained_by: ADR-xxx' in symbols.yaml."
+    ;   fail  % No violation
+    ),
+    violation_source(SymbolId, symbol, Source).
+
 %% check_no_dangling_refs(-Violations)
 % Finds all relationships referencing non-existent entities.
 check_no_dangling_refs(Violations) :-
@@ -271,7 +324,7 @@ deprecated_adr_violation(violation(
 )) :-
     deprecated_no_successor(AdrId),
     
-    Description = "Archived/deprecated ADR has no successor — add a supersedes link from the replacement ADR",
+    Description = "Superseded/deprecated ADR has no successor — add a supersedes link from the replacement ADR",
     
     format(string(Suggestion), "Create a new ADR and add: links: [{type: supersedes, target: ~w}]", [AdrId]),
     
@@ -323,6 +376,39 @@ check_all_json(JsonString) :-
         JsonString
     ).
 
+%% check_all_json_with_options(-JsonString, +RequireAdr)
+% Returns all violations as JSON string with options.
+% RequireAdr: if true, symbol-traceability also requires ADR constraints.
+check_all_json_with_options(JsonString, RequireAdr) :-
+    check_all_with_options(ViolationsDict, RequireAdr),
+    violations_dict_to_json(ViolationsDict, JsonDict),
+    with_output_to_string(
+        json_write_dict(current_output, JsonDict, [width(0)]),
+        JsonString
+    ).
+
+%% check_all_with_options(-ViolationsDict, +RequireAdr)
+% Returns a dict with all violations, respecting options.
+check_all_with_options(ViolationsDict, RequireAdr) :-
+    check_must_priority_coverage(MustPriority),
+    check_symbol_coverage(SymbolCoverage),
+    check_symbol_traceability(RequireAdr, SymbolTraceability),
+    check_no_dangling_refs(DanglingRefs),
+    check_no_cycles(Cycles),
+    check_required_fields(RequiredFields),
+    check_deprecated_adrs(DeprecatedADRs),
+    check_domain_contradictions(Contradictions),
+    ViolationsDict = _{
+        must_priority_coverage: MustPriority,
+        symbol_coverage: SymbolCoverage,
+        symbol_traceability: SymbolTraceability,
+        no_dangling_refs: DanglingRefs,
+        no_cycles: Cycles,
+        required_fields: RequiredFields,
+        deprecated_adr_no_successor: DeprecatedADRs,
+        domain_contradictions: Contradictions
+    }.
+
 %% violations_dict_to_json(+ViolationsDict, -JsonDict)
 % Converts a dict of violation/5 term lists to a dict of JSON-compatible dicts.
 violations_dict_to_json(Dict, JsonDict) :-

package/src/kb.pl

@@ -554,12 +554,12 @@ conflicting(Adr1, Adr2) :-
     Adr1 @< Adr2.
 
 %% deprecated_still_used(+Adr, -Symbols)
-% Deprecated/archived/rejected ADRs that still constrain symbols.
+% Deprecated/superseded ADRs that still constrain symbols.
 deprecated_still_used(Adr, Symbols) :-
     kb_entity(Adr, adr, Props),
     memberchk(status=Status, Props),
     normalize_term_atom(Status, StatusAtom),
-    memberchk(StatusAtom, [deprecated, archived, rejected]),
+    memberchk(StatusAtom, [deprecated, superseded]),
     setof(Symbol, kb_relationship(constrained_by, Symbol, Adr), Symbols),
     !.
 deprecated_still_used(_, []).
@@ -569,9 +569,11 @@ deprecated_still_used(_, []).
 %% ------------------------------------------------------------------
 
 %% current_adr(+Id)
-% True when Id is an ADR not superseded by any other ADR.
+% True when Id is an accepted ADR not superseded by any other ADR.
 current_adr(Id) :-
-    kb_entity(Id, adr, _),
+    kb_entity(Id, adr, Props),
+    memberchk(status=Status, Props),
+    normalize_term_atom(Status, accepted),
     \+ kb_relationship(supersedes, _, Id).
 
 %% superseded_by(+OldId, -NewId)
@@ -593,20 +595,23 @@ adr_chain_acc(Id, Visited, [Id|Rest]) :-
     adr_chain_acc(Newer, [Id|Visited], Rest).
 
 %% deprecated_no_successor(+OldId)
-% Lint rule: ADR is archived/deprecated but has no supersedes relationship pointing to it.
+% Lint rule: ADR is superseded/deprecated but has no supersedes relationship pointing to it.
 deprecated_no_successor(Id) :-
     kb_entity(Id, adr, Props),
     memberchk(status=Status, Props),
     normalize_term_atom(Status, StatusAtom),
-    memberchk(StatusAtom, [archived, deprecated]),
+    memberchk(StatusAtom, [superseded, deprecated]),
     \+ kb_relationship(supersedes, _, Id).
 
 %% current_req(+Id)
-% Requirement is current when active and not superseded by another requirement.
+% Requirement is current when not deprecated and not superseded by another requirement.
+% Canonical statuses: open, in_progress, closed.
+% Legacy statuses accepted for backwards compatibility: active, approved.
 current_req(Id) :-
     kb_entity(Id, req, Props),
     memberchk(status=Status, Props),
-    normalize_term_atom(Status, active),
+    normalize_term_atom(Status, StatusAtom),
+    memberchk(StatusAtom, [open, in_progress, closed, active, approved]),
     \+ kb_relationship(supersedes, _, Id).
 
 %% contradicting_reqs(-ReqA, -ReqB, -Reason)